)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e04b4f4041502d0bee90bf1b0576349685a0c5c2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: Cleanup test_create_configdrive"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This test made a tortured trip into _create_image_helper without using"},{"line_number":10,"context_line":"much of its functionality. We pull this out and have it call"},{"line_number":11,"context_line":"_create_configdrive directly."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3ac371cc_796e84ca","line":9,"updated":"2016-08-15 15:44:03.000000000","message":"heh, that\u0027s a good way of describing it :)","commit_id":"4af338246c26dd9f16882304f053614ed9e68d70"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e04b4f4041502d0bee90bf1b0576349685a0c5c2","unresolved":false,"context_lines":[{"line_number":10629,"context_line":""},{"line_number":10630,"context_line":"    @mock.patch("},{"line_number":10631,"context_line":"        \u0027nova.virt.libvirt.driver.LibvirtDriver._build_device_metadata\u0027,"},{"line_number":10632,"context_line":"        mock.Mock(return_value\u003dNone))"},{"line_number":10633,"context_line":"    @mock.patch(\u0027nova.api.metadata.base.InstanceMetadata\u0027, mock.MagicMock())"},{"line_number":10634,"context_line":"    @mock.patch(\u0027nova.virt.configdrive.ConfigDriveBuilder.make_drive\u0027)"},{"line_number":10635,"context_line":"    def test_create_configdrive(self, mock_make_drive):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_d948585e","line":10632,"updated":"2016-08-15 15:44:03.000000000","message":"Not sure I understand why this was changed.","commit_id":"4af338246c26dd9f16882304f053614ed9e68d70"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e04b4f4041502d0bee90bf1b0576349685a0c5c2","unresolved":false,"context_lines":[{"line_number":10630,"context_line":"    @mock.patch("},{"line_number":10631,"context_line":"        \u0027nova.virt.libvirt.driver.LibvirtDriver._build_device_metadata\u0027,"},{"line_number":10632,"context_line":"        mock.Mock(return_value\u003dNone))"},{"line_number":10633,"context_line":"    @mock.patch(\u0027nova.api.metadata.base.InstanceMetadata\u0027, mock.MagicMock())"},{"line_number":10634,"context_line":"    @mock.patch(\u0027nova.virt.configdrive.ConfigDriveBuilder.make_drive\u0027)"},{"line_number":10635,"context_line":"    def test_create_configdrive(self, mock_make_drive):"},{"line_number":10636,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_39740c9b","line":10633,"updated":"2016-08-15 15:44:03.000000000","message":"the \", mock.MagicMock()\" part of the above call should be removed. The default value of the \"new\" parameter to patch() is already mock.MagicMock().","commit_id":"4af338246c26dd9f16882304f053614ed9e68d70"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"e3749a1e64f122435359ed829bf41aed5d31015b","unresolved":false,"context_lines":[{"line_number":10630,"context_line":"    @mock.patch("},{"line_number":10631,"context_line":"        \u0027nova.virt.libvirt.driver.LibvirtDriver._build_device_metadata\u0027,"},{"line_number":10632,"context_line":"        mock.Mock(return_value\u003dNone))"},{"line_number":10633,"context_line":"    @mock.patch(\u0027nova.api.metadata.base.InstanceMetadata\u0027, mock.MagicMock())"},{"line_number":10634,"context_line":"    @mock.patch(\u0027nova.virt.configdrive.ConfigDriveBuilder.make_drive\u0027)"},{"line_number":10635,"context_line":"    def test_create_configdrive(self, mock_make_drive):"},{"line_number":10636,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_7235d6d8","line":10633,"in_reply_to":"3ac371cc_39740c9b","updated":"2016-08-16 09:15:21.000000000","message":"I don\u0027t know if anybody else does this, but I\u0027ve used it in a few places. Frankly, I wish mock provided a better interface for this.\n\nThe purpose of adding a \u0027redundant\u0027 mock.MagicMock() when using mock.patch() as a decorator is that when used this way, the decorator doesn\u0027t add the resulting mock as an argument to the test. It would be much nicer if you could just do add_arg\u003dFalse or something, but I\u0027ve done this instead.\n\nI guess it\u0027s a toss-up as to which you prefer: you can either have an ugly call, or you can have an unused method argument.\n\nI have no problems changing this because there\u0027s not much in it, but personally I feel it\u0027s slightly less worse to explicitly not generate an argument you don\u0027t intend to use. Let me know.","commit_id":"4af338246c26dd9f16882304f053614ed9e68d70"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e04b4f4041502d0bee90bf1b0576349685a0c5c2","unresolved":false,"context_lines":[{"line_number":10642,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":10643,"context_line":"        drvr._create_configdrive(self.context, instance)"},{"line_number":10644,"context_line":""},{"line_number":10645,"context_line":"        mock_make_drive.assert_called_once()"},{"line_number":10646,"context_line":"        backend.disks[\u0027disk.config\u0027].import_file.assert_called_once_with("},{"line_number":10647,"context_line":"            instance, mock.ANY, \u0027disk.config\u0027)"},{"line_number":10648,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_19795094","line":10645,"updated":"2016-08-15 15:44:03.000000000","message":"assert_called_once_with() needed here.","commit_id":"4af338246c26dd9f16882304f053614ed9e68d70"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"e3749a1e64f122435359ed829bf41aed5d31015b","unresolved":false,"context_lines":[{"line_number":10642,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":10643,"context_line":"        drvr._create_configdrive(self.context, instance)"},{"line_number":10644,"context_line":""},{"line_number":10645,"context_line":"        mock_make_drive.assert_called_once()"},{"line_number":10646,"context_line":"        backend.disks[\u0027disk.config\u0027].import_file.assert_called_once_with("},{"line_number":10647,"context_line":"            instance, mock.ANY, \u0027disk.config\u0027)"},{"line_number":10648,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_52b53a2f","line":10645,"in_reply_to":"3ac371cc_19795094","updated":"2016-08-16 09:15:21.000000000","message":"See previous.","commit_id":"4af338246c26dd9f16882304f053614ed9e68d70"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"c641862ee52c0dcbccc79ad084c9e0533d6a76fb","unresolved":false,"context_lines":[{"line_number":10542,"context_line":"            drvr._create_image(self.context, instance, disk_info[\u0027mapping\u0027],"},{"line_number":10543,"context_line":"                               suffix\u003dsuffix)"},{"line_number":10544,"context_line":"        drvr._get_guest_xml(self.context, instance, None,"},{"line_number":10545,"context_line":"                            disk_info, image_meta)"},{"line_number":10546,"context_line":""},{"line_number":10547,"context_line":"        return gotFiles, imported_files"},{"line_number":10548,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_4b43d46c","side":"PARENT","line":10545,"updated":"2016-11-21 15:52:44.000000000","message":"Incidentally, since this is stubbed to fake_none above and no assertion is made about its arguments, afaict it serves literally no purpose. The new test doesn\u0027t do this.","commit_id":"125ab522c9fb21741f6c2e5a3c12602808dccee8"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"b4916be91c04432506032135fa783e32c06d3fe0","unresolved":false,"context_lines":[{"line_number":10501,"context_line":"        self.assertEqual(wantFiles, gotFiles)"},{"line_number":10502,"context_line":""},{"line_number":10503,"context_line":"    def test_create_image_with_swap(self):"},{"line_number":10504,"context_line":"        def fake_none(*args, **kwargs):"},{"line_number":10505,"context_line":"            return"},{"line_number":10506,"context_line":""},{"line_number":10507,"context_line":"        def fake_get_info(instance):"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_0462b4ad","line":10504,"range":{"start_line":10504,"start_character":12,"end_line":10504,"end_character":21},"updated":"2016-11-21 13:10:50.000000000","message":"I think we no longer need this one either","commit_id":"f5776451f6c75431e9164d3e505d1e29a3383b02"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"2cb08516c7adcad4f8afef60645c06880f78f1b1","unresolved":false,"context_lines":[{"line_number":10511,"context_line":"        instance.flavor.swap \u003d 500"},{"line_number":10512,"context_line":""},{"line_number":10513,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":10514,"context_line":"        self.stubs.Set(drvr, \u0027_get_guest_xml\u0027, fake_none)"},{"line_number":10515,"context_line":"        self.stubs.Set(drvr, \u0027_create_domain_and_network\u0027, fake_none)"},{"line_number":10516,"context_line":"        self.stubs.Set(drvr, \u0027get_info\u0027, fake_get_info)"},{"line_number":10517,"context_line":"        self.stubs.Set(instance_metadata, \u0027InstanceMetadata\u0027, fake_none)"},{"line_number":10518,"context_line":"        self.stubs.Set(nova.virt.configdrive.ConfigDriveBuilder,"},{"line_number":10519,"context_line":"                       \u0027make_drive\u0027, fake_none)"},{"line_number":10520,"context_line":""},{"line_number":10521,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":10522,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a629dbe_ba504d0c","line":10519,"range":{"start_line":10514,"start_character":0,"end_line":10519,"end_character":47},"updated":"2016-11-13 06:51:47.000000000","message":"I guess some of this stubs is no more required.","commit_id":"f5776451f6c75431e9164d3e505d1e29a3383b02"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"c641862ee52c0dcbccc79ad084c9e0533d6a76fb","unresolved":false,"context_lines":[{"line_number":10511,"context_line":"        instance.flavor.swap \u003d 500"},{"line_number":10512,"context_line":""},{"line_number":10513,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":10514,"context_line":"        self.stubs.Set(drvr, \u0027_get_guest_xml\u0027, fake_none)"},{"line_number":10515,"context_line":"        self.stubs.Set(drvr, \u0027_create_domain_and_network\u0027, fake_none)"},{"line_number":10516,"context_line":"        self.stubs.Set(drvr, \u0027get_info\u0027, fake_get_info)"},{"line_number":10517,"context_line":"        self.stubs.Set(instance_metadata, \u0027InstanceMetadata\u0027, fake_none)"},{"line_number":10518,"context_line":"        self.stubs.Set(nova.virt.configdrive.ConfigDriveBuilder,"},{"line_number":10519,"context_line":"                       \u0027make_drive\u0027, fake_none)"},{"line_number":10520,"context_line":""},{"line_number":10521,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":10522,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_6ba33050","line":10519,"range":{"start_line":10514,"start_character":0,"end_line":10519,"end_character":47},"in_reply_to":"7a77a97e_87e7a93f","updated":"2016-11-21 15:52:44.000000000","message":"Some much better-written tests which are very similar in purpose have merged since I wrote this. I\u0027ve refactored this code to use the new tests, so all this is now gone.","commit_id":"f5776451f6c75431e9164d3e505d1e29a3383b02"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6cbcbd12024b5f2701264aee46db5b77eea2c36e","unresolved":false,"context_lines":[{"line_number":10511,"context_line":"        instance.flavor.swap \u003d 500"},{"line_number":10512,"context_line":""},{"line_number":10513,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":10514,"context_line":"        self.stubs.Set(drvr, \u0027_get_guest_xml\u0027, fake_none)"},{"line_number":10515,"context_line":"        self.stubs.Set(drvr, \u0027_create_domain_and_network\u0027, fake_none)"},{"line_number":10516,"context_line":"        self.stubs.Set(drvr, \u0027get_info\u0027, fake_get_info)"},{"line_number":10517,"context_line":"        self.stubs.Set(instance_metadata, \u0027InstanceMetadata\u0027, fake_none)"},{"line_number":10518,"context_line":"        self.stubs.Set(nova.virt.configdrive.ConfigDriveBuilder,"},{"line_number":10519,"context_line":"                       \u0027make_drive\u0027, fake_none)"},{"line_number":10520,"context_line":""},{"line_number":10521,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":10522,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_87e7a93f","line":10519,"range":{"start_line":10514,"start_character":0,"end_line":10519,"end_character":47},"in_reply_to":"9a629dbe_ba504d0c","updated":"2016-11-15 01:10:52.000000000","message":"agreed with Feodor, these are no longer required and should be removed along with the fake_none method.","commit_id":"f5776451f6c75431e9164d3e505d1e29a3383b02"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"2cb08516c7adcad4f8afef60645c06880f78f1b1","unresolved":false,"context_lines":[{"line_number":10560,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":10561,"context_line":"        drvr._create_configdrive(self.context, instance)"},{"line_number":10562,"context_line":""},{"line_number":10563,"context_line":"        self.assertTrue(mock_make_drive.called)"},{"line_number":10564,"context_line":"        backend.disks[\u0027disk.config\u0027].import_file.assert_called_once_with("},{"line_number":10565,"context_line":"            instance, mock.ANY, \u0027disk.config\u0027)"},{"line_number":10566,"context_line":""},{"line_number":10567,"context_line":"    @mock.patch.object(nova.virt.libvirt.imagebackend.Image, \u0027cache\u0027,"},{"line_number":10568,"context_line":"                       side_effect\u003dexception.ImageNotFound(image_id\u003d\u0027fake-id\u0027))"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a629dbe_5a33b1f6","line":10565,"range":{"start_line":10563,"start_character":0,"end_line":10565,"end_character":46},"updated":"2016-11-13 06:51:47.000000000","message":"Previously the test didn\u0027t check arguments of InstanceMetadata initialization, ConfigDriveBuilder.make_driver. Now it does not check where config drive file is created, and even if that file is passed into import_image. It looks suspicious for me.","commit_id":"f5776451f6c75431e9164d3e505d1e29a3383b02"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"c641862ee52c0dcbccc79ad084c9e0533d6a76fb","unresolved":false,"context_lines":[{"line_number":10560,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":10561,"context_line":"        drvr._create_configdrive(self.context, instance)"},{"line_number":10562,"context_line":""},{"line_number":10563,"context_line":"        self.assertTrue(mock_make_drive.called)"},{"line_number":10564,"context_line":"        backend.disks[\u0027disk.config\u0027].import_file.assert_called_once_with("},{"line_number":10565,"context_line":"            instance, mock.ANY, \u0027disk.config\u0027)"},{"line_number":10566,"context_line":""},{"line_number":10567,"context_line":"    @mock.patch.object(nova.virt.libvirt.imagebackend.Image, \u0027cache\u0027,"},{"line_number":10568,"context_line":"                       side_effect\u003dexception.ImageNotFound(image_id\u003d\u0027fake-id\u0027))"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_2b1698a7","line":10565,"range":{"start_line":10563,"start_character":0,"end_line":10565,"end_character":46},"in_reply_to":"7a77a97e_07b479f0","updated":"2016-11-21 15:52:44.000000000","message":"Done","commit_id":"f5776451f6c75431e9164d3e505d1e29a3383b02"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"6cbcbd12024b5f2701264aee46db5b77eea2c36e","unresolved":false,"context_lines":[{"line_number":10560,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":10561,"context_line":"        drvr._create_configdrive(self.context, instance)"},{"line_number":10562,"context_line":""},{"line_number":10563,"context_line":"        self.assertTrue(mock_make_drive.called)"},{"line_number":10564,"context_line":"        backend.disks[\u0027disk.config\u0027].import_file.assert_called_once_with("},{"line_number":10565,"context_line":"            instance, mock.ANY, \u0027disk.config\u0027)"},{"line_number":10566,"context_line":""},{"line_number":10567,"context_line":"    @mock.patch.object(nova.virt.libvirt.imagebackend.Image, \u0027cache\u0027,"},{"line_number":10568,"context_line":"                       side_effect\u003dexception.ImageNotFound(image_id\u003d\u0027fake-id\u0027))"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_07b479f0","line":10565,"range":{"start_line":10563,"start_character":0,"end_line":10565,"end_character":46},"in_reply_to":"9a629dbe_5a33b1f6","updated":"2016-11-15 01:10:52.000000000","message":"I think what Feodor is trying to say is that he expected to see:\n\n mock_make_drive.assert_called_once_with(...)\n mock_instance_metadata.assert_called_once_with(...)\n\nbeing called somewhere here.","commit_id":"f5776451f6c75431e9164d3e505d1e29a3383b02"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"18cccaa70b5221ec47df8be79bed43d1fcf00415","unresolved":false,"context_lines":[{"line_number":10534,"context_line":"            extra_md\u003d{\u0027admin_pass\u0027: mock.sentinel.admin_pass})"},{"line_number":10535,"context_line":""},{"line_number":10536,"context_line":"        backend.disks[\u0027disk.config\u0027].import_file.assert_called_once_with("},{"line_number":10537,"context_line":"            instance, mock.ANY, \u0027disk.config\u0027)"},{"line_number":10538,"context_line":""},{"line_number":10539,"context_line":"    @ddt.unpack"},{"line_number":10540,"context_line":"    @ddt.data({\u0027expected\u0027: 200, \u0027flavor_size\u0027: 200},"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a77a97e_41349349","line":10537,"range":{"start_line":10537,"start_character":22,"end_line":10537,"end_character":30},"updated":"2016-11-21 16:51:29.000000000","message":"Is it possible to have expected_config_drive_path here instead?","commit_id":"d36d6119d77618b8f0c5a5f4f198fb527eee399b"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"27b014ff19493d9f82b5e93e0d11bcf648c00359","unresolved":false,"context_lines":[{"line_number":10534,"context_line":"            extra_md\u003d{\u0027admin_pass\u0027: mock.sentinel.admin_pass})"},{"line_number":10535,"context_line":""},{"line_number":10536,"context_line":"        backend.disks[\u0027disk.config\u0027].import_file.assert_called_once_with("},{"line_number":10537,"context_line":"            instance, mock.ANY, \u0027disk.config\u0027)"},{"line_number":10538,"context_line":""},{"line_number":10539,"context_line":"    @ddt.unpack"},{"line_number":10540,"context_line":"    @ddt.data({\u0027expected\u0027: 200, \u0027flavor_size\u0027: 200},"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a77a97e_e4c4cd60","line":10537,"range":{"start_line":10537,"start_character":22,"end_line":10537,"end_character":30},"in_reply_to":"7a77a97e_41349349","updated":"2016-11-21 16:55:01.000000000","message":"I\u0027ll add this if I update.","commit_id":"d36d6119d77618b8f0c5a5f4f198fb527eee399b"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"57555b08801e842e57d3597835fe13bd6f350fd4","unresolved":false,"context_lines":[{"line_number":10540,"context_line":"    @ddt.data({\u0027expected\u0027: 200, \u0027flavor_size\u0027: 200},"},{"line_number":10541,"context_line":"              {\u0027expected\u0027: 100, \u0027flavor_size\u0027: 200, \u0027bdi_size\u0027: 100},"},{"line_number":10542,"context_line":"              {\u0027expected\u0027: 200, \u0027flavor_size\u0027: 200, \u0027bdi_size\u0027: 100,"},{"line_number":10543,"context_line":"               \u0027legacy\u0027: True})"},{"line_number":10544,"context_line":"    def test_create_image_with_swap(self, expected,"},{"line_number":10545,"context_line":"                                    flavor_size\u003dNone, bdi_size\u003dNone,"},{"line_number":10546,"context_line":"                                    legacy\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_417c9372","line":10543,"updated":"2016-12-01 15:53:38.000000000","message":"opinion: I don\u0027t love ddt in the way it does test name munging, but others seem to like it.","commit_id":"d36d6119d77618b8f0c5a5f4f198fb527eee399b"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"18cccaa70b5221ec47df8be79bed43d1fcf00415","unresolved":false,"context_lines":[{"line_number":10551,"context_line":"        instance_ref[\u0027image_ref\u0027] \u003d \u0027\u0027"},{"line_number":10552,"context_line":"        instance \u003d objects.Instance(**instance_ref)"},{"line_number":10553,"context_line":""},{"line_number":10554,"context_line":"        if flavor_size is not None:"},{"line_number":10555,"context_line":"            instance.flavor.swap \u003d flavor_size"},{"line_number":10556,"context_line":""},{"line_number":10557,"context_line":"        bdi \u003d {\u0027block_device_mapping\u0027: [{\u0027boot_index\u0027: 0}]}"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a77a97e_044c6975","line":10554,"updated":"2016-11-21 16:51:29.000000000","message":"Probably this check is unnecessary?","commit_id":"d36d6119d77618b8f0c5a5f4f198fb527eee399b"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"27b014ff19493d9f82b5e93e0d11bcf648c00359","unresolved":false,"context_lines":[{"line_number":10551,"context_line":"        instance_ref[\u0027image_ref\u0027] \u003d \u0027\u0027"},{"line_number":10552,"context_line":"        instance \u003d objects.Instance(**instance_ref)"},{"line_number":10553,"context_line":""},{"line_number":10554,"context_line":"        if flavor_size is not None:"},{"line_number":10555,"context_line":"            instance.flavor.swap \u003d flavor_size"},{"line_number":10556,"context_line":""},{"line_number":10557,"context_line":"        bdi \u003d {\u0027block_device_mapping\u0027: [{\u0027boot_index\u0027: 0}]}"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a77a97e_a4cad56c","line":10554,"in_reply_to":"7a77a97e_044c6975","updated":"2016-11-21 16:55:01.000000000","message":"It\u0027s unnecessary with this data set, but I like it for the sake of completeness.","commit_id":"d36d6119d77618b8f0c5a5f4f198fb527eee399b"}]}