)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"50cac16b02465321b95fca1e9e9981927c05a7bb","unresolved":false,"context_lines":[{"line_number":1431,"context_line":""},{"line_number":1432,"context_line":"        macs \u003d self.driver.macs_for_instance(instance)"},{"line_number":1433,"context_line":"        dhcp_options \u003d self.driver.dhcp_options_for_instance(instance)"},{"line_number":1434,"context_line":"        vnic_type \u003d self.driver.get_vnic_type_for_instance(instance)"},{"line_number":1435,"context_line":"        if vnic_type:"},{"line_number":1436,"context_line":"            for net in requested_networks:"},{"line_number":1437,"context_line":"                net.vnic_type \u003d vnic_type"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_c6053a15","line":1434,"updated":"2016-07-08 08:22:12.000000000","message":"Hmm, does not vnic_type also depend on the port specifics (i.e. not only a particular hypervisor driver in Nova)?\n\nE.g. NFV\u0027ish things here https://github.com/openstack/neutron/blob/4148a347b365ec2ff9b8f5255b100208e23efbc8/neutron/extensions/portbindings.py#L92-L102","commit_id":"bfac5ba5a95a7799cd7829560f217079b9858e3c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8dbe83c4373fff1e68441e0263789012f0c6733d","unresolved":false,"context_lines":[{"line_number":1435,"context_line":"        if vnic_type:"},{"line_number":1436,"context_line":"            for net in requested_networks:"},{"line_number":1437,"context_line":"                net.vnic_type \u003d vnic_type"},{"line_number":1438,"context_line":"        network_info \u003d self._allocate_network(context, instance,"},{"line_number":1439,"context_line":"                requested_networks, macs, security_groups, dhcp_options)"},{"line_number":1440,"context_line":""},{"line_number":1441,"context_line":"        return network_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_895a1e4f","line":1438,"updated":"2016-07-08 10:03:56.000000000","message":"So I think this needs to follow the same pattern as the dhcp_options, hence my patch https://review.openstack.org/#/c/339143/","commit_id":"bfac5ba5a95a7799cd7829560f217079b9858e3c"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"276aabb8599c1ffb6d8705931900ceb3900f2d97","unresolved":false,"context_lines":[{"line_number":1435,"context_line":"        if vnic_type:"},{"line_number":1436,"context_line":"            for net in requested_networks:"},{"line_number":1437,"context_line":"                net.vnic_type \u003d vnic_type"},{"line_number":1438,"context_line":"        network_info \u003d self._allocate_network(context, instance,"},{"line_number":1439,"context_line":"                requested_networks, macs, security_groups, dhcp_options)"},{"line_number":1440,"context_line":""},{"line_number":1441,"context_line":"        return network_info"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_0bed7e8e","line":1438,"in_reply_to":"1aa78d24_895a1e4f","updated":"2016-07-08 11:59:21.000000000","message":"John that for fast review. I see that your patch is almost done, and it uses the same approach as I\u0027m proposing. Would you not mind to add me to Co-Authors? I will abandon this one than.","commit_id":"bfac5ba5a95a7799cd7829560f217079b9858e3c"}],"nova/objects/network_request.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"50cac16b02465321b95fca1e9e9981927c05a7bb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \u0027port_id\u0027: fields.UUIDField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027pci_request_id\u0027: fields.UUIDField(nullable\u003dTrue),"},{"line_number":41,"context_line":"        \u0027tag\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":42,"context_line":"        \u0027vnic_type\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def obj_make_compatible(self, primitive, target_version):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_f172aeaf","line":42,"updated":"2016-07-08 08:22:12.000000000","message":"this requires a version bump ^","commit_id":"bfac5ba5a95a7799cd7829560f217079b9858e3c"}],"nova/virt/driver.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"50cac16b02465321b95fca1e9e9981927c05a7bb","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"        \"\"\""},{"line_number":1597,"context_line":"        return instance.get(\u0027host\u0027)"},{"line_number":1598,"context_line":""},{"line_number":1599,"context_line":"    def get_vnic_type_for_instance(self, instanace):"},{"line_number":1600,"context_line":"        \"\"\"Get NIC type for Instance."},{"line_number":1601,"context_line":""},{"line_number":1602,"context_line":"        Get VNIC type for instance to determine which mechanism driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_f1246eb3","line":1599,"updated":"2016-07-08 08:22:12.000000000","message":"typo: instance\n\nThis probably needs a spec :P","commit_id":"bfac5ba5a95a7799cd7829560f217079b9858e3c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"50cac16b02465321b95fca1e9e9981927c05a7bb","unresolved":false,"context_lines":[{"line_number":1604,"context_line":""},{"line_number":1605,"context_line":"        :param instance: nova.objects.instance.Instance that the network"},{"line_number":1606,"context_line":"                         ports will be associated with"},{"line_number":1607,"context_line":"        returns: a string with VNIC type"},{"line_number":1608,"context_line":"        \"\"\""},{"line_number":1609,"context_line":""},{"line_number":1610,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_b16146d6","line":1607,"updated":"2016-07-08 08:22:12.000000000","message":"nit: you should probably document that by default None is returned which effectively tells Neutron to use its default value","commit_id":"bfac5ba5a95a7799cd7829560f217079b9858e3c"}]}