)]}'
{"nova/api/openstack/compute/plugins/v3/multinic.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d72f0009243f54b5dca56da175172c9e05badf66","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        except exception.InstanceNotFound:"},{"line_number":42,"context_line":"            msg \u003d _(\"Server not found\")"},{"line_number":43,"context_line":"            raise exc.HTTPNotFound(msg)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @wsgi.action(\u0027addFixedIp\u0027)"},{"line_number":46,"context_line":"    def _add_fixed_ip(self, req, id, body):"},{"line_number":47,"context_line":"        \"\"\"Adds an IP on a given network to an instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FefQ%3D","line":44,"updated":"2013-07-01 04:51:46.000000000","message":"This should be \u0027add_fixed_ip\u0027","commit_id":"fd01f6995d1c691c03e143e912b8c53c148bf3bb"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d72f0009243f54b5dca56da175172c9e05badf66","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":49,"context_line":"        authorize(context)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # Validate the input entity"},{"line_number":52,"context_line":"        if \u0027networkId\u0027 not in body[\u0027addFixedIp\u0027]:"},{"line_number":53,"context_line":"            msg \u003d _(\"Missing \u0027networkId\u0027 argument for addFixedIp\")"},{"line_number":54,"context_line":"            raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FefM%3D","line":51,"updated":"2013-07-01 04:51:46.000000000","message":"ditto","commit_id":"fd01f6995d1c691c03e143e912b8c53c148bf3bb"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"64cede0460a5b33be6e837aa9e8db9cc08fe3034","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            msg \u003d _(\"Missing \u0027networkId\u0027 argument for addFixedIp\")"},{"line_number":54,"context_line":"            raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        instance \u003d self._get_instance(context, id)"},{"line_number":57,"context_line":"        network_id \u003d body[\u0027addFixedIp\u0027][\u0027networkId\u0027]"},{"line_number":58,"context_line":"        self.compute_api.add_fixed_ip(context, instance, network_id)"},{"line_number":59,"context_line":"        return webob.Response(status_int\u003d202)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FefA%3D","line":56,"updated":"2013-07-01 04:55:22.000000000","message":"InstanceNotFound should be catched explicitly","commit_id":"fd01f6995d1c691c03e143e912b8c53c148bf3bb"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"53136e9922b61b19fc48a825096577cdebda7542","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            msg \u003d _(\"Missing \u0027networkId\u0027 argument for addFixedIp\")"},{"line_number":54,"context_line":"            raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        instance \u003d self._get_instance(context, id)"},{"line_number":57,"context_line":"        network_id \u003d body[\u0027addFixedIp\u0027][\u0027networkId\u0027]"},{"line_number":58,"context_line":"        self.compute_api.add_fixed_ip(context, instance, network_id)"},{"line_number":59,"context_line":"        return webob.Response(status_int\u003d202)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FX40%3D","line":56,"in_reply_to":"AAAAPn%2F%2FefA%3D","updated":"2013-07-03 04:13:58.000000000","message":"InstanceNotFound is caught in _get_instance and converted to HTTPNotFound","commit_id":"fd01f6995d1c691c03e143e912b8c53c148bf3bb"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"64cede0460a5b33be6e837aa9e8db9cc08fe3034","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        if \u0027address\u0027 not in body[\u0027removeFixedIp\u0027]:"},{"line_number":69,"context_line":"            msg \u003d _(\"Missing \u0027address\u0027 argument for removeFixedIp\")"},{"line_number":70,"context_line":"            raise exc.HTTPUnprocessableEntity(explanation\u003dmsg)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        instance \u003d self._get_instance(context, id)"},{"line_number":73,"context_line":"        address \u003d body[\u0027removeFixedIp\u0027][\u0027address\u0027]"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fee8%3D","line":71,"updated":"2013-07-01 04:55:22.000000000","message":"ditto","commit_id":"fd01f6995d1c691c03e143e912b8c53c148bf3bb"}]}
