)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"460bd8bf68ee1096d2741bc8c84e900cfa269dc1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"been created outside the class because of issues in the oslo db"},{"line_number":12,"context_line":"library. Those issue have since been fixed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note that the methods that are associated with _update, _add and"},{"line_number":15,"context_line":"_set_inventory have _not_ been moved because the changes involved"},{"line_number":16,"context_line":"would have been more than a simple copy and paste."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_10b56130","line":14,"updated":"2016-07-11 10:12:40.000000000","message":"Can you add some TODO notes to these methods so that we know this change does not address all methods and actions are still required.","commit_id":"f11753ab5973fe02467203bbe460786bfd39044d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"25249b78400d8ed7498a13f4aa6645d3d8c6814a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"been created outside the class because of issues in the oslo db"},{"line_number":12,"context_line":"library. Those issue have since been fixed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note that the methods that are associated with _update, _add and"},{"line_number":15,"context_line":"_set_inventory have _not_ been moved because the changes involved"},{"line_number":16,"context_line":"would have been more than a simple copy and paste."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_36ffa302","line":14,"in_reply_to":"1aa78d24_10b56130","updated":"2016-07-11 15:45:24.000000000","message":"At this time there\u0027s no intention of changing the methods related to _set_inventory and the related methods so putting a TODO would be a bit disingenuous. I could leave a NOTE describing why they are there, but that too would be confusing because the way they are currently written they have to remain module level unless we want to change them rather a lot to make them a combination of object, class and static methods. I\u0027d be inclined just to leave it as it is. What do others think?","commit_id":"f11753ab5973fe02467203bbe460786bfd39044d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e61fd40211444a286da3291c4581295b6de883dd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"been created outside the class because of issues in the oslo db"},{"line_number":12,"context_line":"library. Those issue have since been fixed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note that the methods that are associated with _update, _add and"},{"line_number":15,"context_line":"_set_inventory have _not_ been moved because the changes involved"},{"line_number":16,"context_line":"would have been more than a simple copy and paste."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_2cd0f452","line":14,"in_reply_to":"1aa78d24_36ffa302","updated":"2016-07-11 16:20:02.000000000","message":"In the way I have read it an action was require, I do not have a strong opinion on this and having put -1 on this was probably excessive. It was more a suggestion.","commit_id":"f11753ab5973fe02467203bbe460786bfd39044d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"45aceca271fc668f04e790960265b0cd12fae765","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change moves several of the module level methods that perform"},{"line_number":10,"context_line":"database interaction back into the ResourceProvider class. They had"},{"line_number":11,"context_line":"been created outside the class because of issues in the oslo db"},{"line_number":12,"context_line":"library. Those issue have since been fixed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note that the methods that are associated with _update, _add and"},{"line_number":15,"context_line":"_set_inventory have _not_ been moved because the changes involved"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aa78d24_e8a32541","line":12,"range":{"start_line":12,"start_character":9,"end_line":12,"end_character":43},"updated":"2016-07-13 00:38:35.000000000","message":"What was the fix? Can you link to the change? More specifically, I want to make sure that the minimum version of oslo.db that we require in global-requirements has the fix for this.","commit_id":"d1952b2b56f59fa3cd50dfa91522263c04d8ae75"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8a9c231c5d0e6e582295a6a91ac2940ff38215a0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change moves several of the module level methods that perform"},{"line_number":10,"context_line":"database interaction back into the ResourceProvider class. They had"},{"line_number":11,"context_line":"been created outside the class because of issues in the oslo db"},{"line_number":12,"context_line":"library. Those issue have since been fixed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note that the methods that are associated with _update, _add and"},{"line_number":15,"context_line":"_set_inventory have _not_ been moved because the changes involved"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aa78d24_cb7e2318","line":12,"range":{"start_line":12,"start_character":9,"end_line":12,"end_character":43},"in_reply_to":"1aa78d24_e8a32541","updated":"2016-07-13 01:01:02.000000000","message":"Was it 8a5fbb723f234c89630360bca24aa91160edd8e0 because that\u0027s not released so I\u0027m not sure how this would work?","commit_id":"d1952b2b56f59fa3cd50dfa91522263c04d8ae75"}],"nova/objects/resource_provider.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e6c789de0b564fad735e74fb3f6c9be23a990a30","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    @staticmethod"},{"line_number":310,"context_line":"    @db_api.api_context_manager.writer"},{"line_number":311,"context_line":"    def _delete(context, _id):"},{"line_number":312,"context_line":"        # Don\u0027t delete the resource provider if it has allocations."},{"line_number":313,"context_line":"        rp_allocations \u003d context.session.query(models.Allocation).\\"},{"line_number":314,"context_line":"                         filter(models.Allocation.resource_provider_id \u003d\u003d _id).\\"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_08d4bbe9","line":311,"updated":"2016-07-12 19:54:52.000000000","message":"This should have been _delete_from_db, but that\u0027s outside the scope of this patch.","commit_id":"d1952b2b56f59fa3cd50dfa91522263c04d8ae75"}]}