)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"45e7a120f10eba1bf676ca3643034eef6e4b4f7a","unresolved":false,"context_lines":[{"line_number":1649,"context_line":""},{"line_number":1650,"context_line":"                    cb(context, instance, bdms,"},{"line_number":1651,"context_line":"                       reservations\u003dquotas.reservations)"},{"line_number":1652,"context_line":"            except exception.ComputeHostNotFound:"},{"line_number":1653,"context_line":"                pass"},{"line_number":1654,"context_line":""},{"line_number":1655,"context_line":"            if is_local_delete:"},{"line_number":1656,"context_line":"                # If instance is in shelved_offloaded state or compute node"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_d0e66ce7","line":1653,"range":{"start_line":1652,"start_character":12,"end_line":1653,"end_character":20},"updated":"2016-07-08 18:54:11.000000000","message":"Do we even need this anymore? This was here because we didn\u0027t check instance.host before in this try/except, we checked a status value:\n\nhttps://review.openstack.org/#/c/335697/2/nova/compute/api.py@1626\n\nBut that\u0027s no longer the case.","commit_id":"aefda3f94be1a1d8868b09e8a15e38ae668c1804"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"21f29a39ade87e822b98a3b7ccdff534fed2ce74","unresolved":false,"context_lines":[{"line_number":1650,"context_line":"                    cb(context, instance, bdms,"},{"line_number":1651,"context_line":"                       reservations\u003dquotas.reservations)"},{"line_number":1652,"context_line":"            except exception.ComputeHostNotFound:"},{"line_number":1653,"context_line":"                pass"},{"line_number":1654,"context_line":""},{"line_number":1655,"context_line":"            if is_local_delete:"},{"line_number":1656,"context_line":"                # If instance is in shelved_offloaded state or compute node"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_f9c9cc5b","line":1653,"in_reply_to":"1aa78d24_d0e66ce7","updated":"2016-07-08 20:49:24.000000000","message":"I thought about that but wasn\u0027t sure if it might be needed in case of a compute host record not existing anymore (deleted?) or otherwise being old/bogus, so the code falls through to do a local delete with volume detach etc cleanup. What do you think?","commit_id":"aefda3f94be1a1d8868b09e8a15e38ae668c1804"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b7b442a1ceafee6dc7419fc598012a1e3b1ecc81","unresolved":false,"context_lines":[{"line_number":1650,"context_line":"                    cb(context, instance, bdms,"},{"line_number":1651,"context_line":"                       reservations\u003dquotas.reservations)"},{"line_number":1652,"context_line":"            except exception.ComputeHostNotFound:"},{"line_number":1653,"context_line":"                pass"},{"line_number":1654,"context_line":""},{"line_number":1655,"context_line":"            if is_local_delete:"},{"line_number":1656,"context_line":"                # If instance is in shelved_offloaded state or compute node"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_6a6cc59c","line":1653,"in_reply_to":"1aa78d24_f9c9cc5b","updated":"2016-07-10 17:21:39.000000000","message":"Yeah I guess we could have an instance in ERROR state, the compute host for that instance was down, the admin deleted it w/o evacuate, and this is just doing cleanup. It might be good to debug log this but that could be a separate change.","commit_id":"aefda3f94be1a1d8868b09e8a15e38ae668c1804"}]}