)]}'
{"nova/conf/scheduler.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"468c72f8347e2bc50fe8dd377e8e9e03ce7a4565","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"host_subset_size_opt \u003d cfg.IntOpt(\"scheduler_host_subset_size\","},{"line_number":29,"context_line":"        default\u003d1,"},{"line_number":30,"context_line":"        help\u003d\"\"\""},{"line_number":31,"context_line":"New instances will be scheduled on a host chosen randomly from a subset of the"},{"line_number":32,"context_line":"N best hosts, where N is the value set by this option. Valid values are 1 or"},{"line_number":33,"context_line":"greater. Any value less than one will be treated as 1."}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_6a6205da","line":30,"updated":"2016-07-10 17:06:01.000000000","message":"Add min\u003d1 here","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"468c72f8347e2bc50fe8dd377e8e9e03ce7a4565","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Possible values:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* Any integer, although any value less than 1 will be treated as 1"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Related options:"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_0a6381de","line":47,"updated":"2016-07-10 17:06:01.000000000","message":"Why not just use min\u003d1 on the IntOpt instead","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Possible values:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* Any integer, although any value less than 1 will be treated as 1"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Related options:"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_01923a9f","line":47,"in_reply_to":"1aa78d24_0a6381de","updated":"2016-07-11 09:57:04.000000000","message":"I agree, but I\u0027ll add that, if you do this, you\u0027re going to break config files for the odd person who used a negative number. I don\u0027t imagine this will be an issue, but you\u0027d do well to include a reno note for safety.\n\nIf you do this, reword to something like so:\n\n    * Any positive integer, where value indicates size of \"best host\" pool","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"187021c50a21ca9877dd3bba2443de925b932910","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* Any integer, although any value less than 1 will be treated as 1"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Related options:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* None"},{"line_number":52,"context_line":"\"\"\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"bm_default_filter_opt \u003d cfg.ListOpt(\"baremetal_scheduler_default_filters\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_7bbf9960","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":6},"updated":"2016-07-14 15:42:30.000000000","message":"You can remove this.","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* Any integer, although any value less than 1 will be treated as 1"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Related options:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* None"},{"line_number":52,"context_line":"\"\"\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"bm_default_filter_opt \u003d cfg.ListOpt(\"baremetal_scheduler_default_filters\","}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_854cd277","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":6},"in_reply_to":"1aa78d24_7bbf9960","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"187021c50a21ca9877dd3bba2443de925b932910","unresolved":false,"context_lines":[{"line_number":181,"context_line":"* Any list of zero or more strings, with each string being the name of a"},{"line_number":182,"context_line":"  weigher that will be used for selecting a host."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Related options:"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"* None"},{"line_number":187,"context_line":"\"\"\")"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"host_mgr_tracks_inst_chg_opt \u003d cfg.BoolOpt(\"scheduler_tracks_instance_changes\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_3ba6b153","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":6},"updated":"2016-07-14 15:42:30.000000000","message":"You can remove this.","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":181,"context_line":"* Any list of zero or more strings, with each string being the name of a"},{"line_number":182,"context_line":"  weigher that will be used for selecting a host."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Related options:"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"* None"},{"line_number":187,"context_line":"\"\"\")"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"host_mgr_tracks_inst_chg_opt \u003d cfg.BoolOpt(\"scheduler_tracks_instance_changes\","}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_e524b6b0","line":186,"range":{"start_line":184,"start_character":0,"end_line":186,"end_character":6},"in_reply_to":"1aa78d24_3ba6b153","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"187021c50a21ca9877dd3bba2443de925b932910","unresolved":false,"context_lines":[{"line_number":202,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":203,"context_line":"a different scheduler, this option has no effect."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Related options:"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"* None"},{"line_number":208,"context_line":"\"\"\")"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"rpc_sched_topic_opt \u003d cfg.StrOpt(\"scheduler_topic\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_fb7269e2","line":207,"range":{"start_line":205,"start_character":0,"end_line":207,"end_character":6},"updated":"2016-07-14 15:42:30.000000000","message":"You can remove this.","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":202,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":203,"context_line":"a different scheduler, this option has no effect."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Related options:"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"* None"},{"line_number":208,"context_line":"\"\"\")"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"rpc_sched_topic_opt \u003d cfg.StrOpt(\"scheduler_topic\","}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_c51fba59","line":207,"range":{"start_line":205,"start_character":0,"end_line":207,"end_character":6},"in_reply_to":"1aa78d24_fb7269e2","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"468c72f8347e2bc50fe8dd377e8e9e03ce7a4565","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Possible values:"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"*"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Related options:"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_caa7b909","line":220,"updated":"2016-07-10 17:06:01.000000000","message":"Something to add here?","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Possible values:"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"*"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Related options:"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_a52aae7c","line":220,"in_reply_to":"1aa78d24_caa7b909","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"187021c50a21ca9877dd3bba2443de925b932910","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"*"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Related options:"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"* None"},{"line_number":225,"context_line":"\"\"\")"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"scheduler_json_config_location_opt \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_bb474176","line":224,"range":{"start_line":222,"start_character":0,"end_line":224,"end_character":6},"updated":"2016-07-14 15:42:30.000000000","message":"You can remove this.","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"*"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Related options:"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"* None"},{"line_number":225,"context_line":"\"\"\")"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"scheduler_json_config_location_opt \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_0513625d","line":224,"range":{"start_line":222,"start_character":0,"end_line":224,"end_character":6},"in_reply_to":"1aa78d24_bb474176","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"187021c50a21ca9877dd3bba2443de925b932910","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"* Any valid file path, or an empty string"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"Related options:"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"* None"},{"line_number":244,"context_line":"\"\"\")"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"sched_driver_host_mgr_opt \u003d cfg.StrOpt(\"scheduler_host_manager\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_7b1b1981","line":243,"range":{"start_line":241,"start_character":0,"end_line":243,"end_character":6},"updated":"2016-07-14 15:42:30.000000000","message":"You can remove this, and all occurrences of related options with `none` below.","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"* Any valid file path, or an empty string"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"Related options:"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"* None"},{"line_number":244,"context_line":"\"\"\")"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"sched_driver_host_mgr_opt \u003d cfg.StrOpt(\"scheduler_host_manager\","}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_e50d9638","line":243,"range":{"start_line":241,"start_character":0,"end_line":243,"end_character":6},"in_reply_to":"1aa78d24_7b1b1981","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":256,"context_line":"option as of the Mitaka release is \u0027ironic_host_manager\u0027, which should be used"},{"line_number":257,"context_line":"if you\u0027re using Ironic to provision bare-metal instances."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Possible values:"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"* Either \u0027host_manager\u0027 (default), or \"ironic_hos"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Related options:"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_61f21ed4","line":261,"range":{"start_line":259,"start_character":0,"end_line":261,"end_character":49},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this whole thing - we can extract this from the \"choice\" field, and they\u0027re liable to get out of date","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"468c72f8347e2bc50fe8dd377e8e9e03ce7a4565","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Possible values:"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"* Either \u0027host_manager\u0027 (default), or \"ironic_hos"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Related options:"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_2aaf5de4","line":261,"range":{"start_line":261,"start_character":38,"end_line":261,"end_character":39},"updated":"2016-07-10 17:06:01.000000000","message":"Unmatched quote","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":256,"context_line":"option as of the Mitaka release is \u0027ironic_host_manager\u0027, which should be used"},{"line_number":257,"context_line":"if you\u0027re using Ironic to provision bare-metal instances."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Possible values:"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"* Either \u0027host_manager\u0027 (default), or \"ironic_hos"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Related options:"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_a5038e0c","line":261,"range":{"start_line":259,"start_character":0,"end_line":261,"end_character":49},"in_reply_to":"1aa78d24_61f21ed4","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":273,"context_line":"\u0027setup.cfg\u0027. If nothing is specified in this option, the \u0027filter_scheduler\u0027 is"},{"line_number":274,"context_line":"used."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"Other options are:"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    * \u0027caching_scheduler\u0027 which aggressively caches the system state for better"},{"line_number":279,"context_line":"    individual scheduler performance at the risk of more retries when running"},{"line_number":280,"context_line":"    multiple schedulers."},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    * \u0027chance_scheduler\u0027 which simply picks a host at random."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    * \u0027fake_scheduler\u0027 which is used for testing."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Possible values:"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_a1eec688","line":284,"range":{"start_line":276,"start_character":0,"end_line":284,"end_character":49},"updated":"2016-07-11 09:57:04.000000000","message":"Get rid of this, or merge with the \"Possible values\" section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":273,"context_line":"\u0027setup.cfg\u0027. If nothing is specified in this option, the \u0027filter_scheduler\u0027 is"},{"line_number":274,"context_line":"used."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"Other options are:"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    * \u0027caching_scheduler\u0027 which aggressively caches the system state for better"},{"line_number":279,"context_line":"    individual scheduler performance at the risk of more retries when running"},{"line_number":280,"context_line":"    multiple schedulers."},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    * \u0027chance_scheduler\u0027 which simply picks a host at random."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    * \u0027fake_scheduler\u0027 which is used for testing."},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Possible values:"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_4a065921","line":284,"range":{"start_line":276,"start_character":0,"end_line":284,"end_character":49},"in_reply_to":"1aa78d24_a1eec688","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"468c72f8347e2bc50fe8dd377e8e9e03ce7a4565","unresolved":false,"context_lines":[{"line_number":291,"context_line":"** chance_scheduler"},{"line_number":292,"context_line":"** fake_scheduler"},{"line_number":293,"context_line":"* You may also set this to the class name of a custom scheduler driver, but you"},{"line_number":294,"context_line":"  will be responsible for creating and maintaining the entrypoint in your"},{"line_number":295,"context_line":"  setup.cfg file."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_6ab9652e","line":294,"range":{"start_line":294,"start_character":55,"end_line":294,"end_character":65},"updated":"2016-07-10 17:06:01.000000000","message":"entry point","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":291,"context_line":"** chance_scheduler"},{"line_number":292,"context_line":"** fake_scheduler"},{"line_number":293,"context_line":"* You may also set this to the class name of a custom scheduler driver, but you"},{"line_number":294,"context_line":"  will be responsible for creating and maintaining the entrypoint in your"},{"line_number":295,"context_line":"  setup.cfg file."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_0a0c5141","line":294,"range":{"start_line":294,"start_character":55,"end_line":294,"end_character":65},"in_reply_to":"1aa78d24_6ab9652e","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Possible values:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"* Any positive integer"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"Related options:"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_01ca3a6e","line":317,"updated":"2016-07-11 09:57:04.000000000","message":", where the integer corresponds to...","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Possible values:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"* Any positive integer"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"Related options:"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_ea164554","line":317,"in_reply_to":"1aa78d24_01ca3a6e","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"Possible values:"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"* A list of stings, where each is the name of a host"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"Related options:"},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_c1ae7297","line":356,"range":{"start_line":356,"start_character":12,"end_line":356,"end_character":18},"updated":"2016-07-11 09:57:04.000000000","message":"s/stings/strings","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":353,"context_line":""},{"line_number":354,"context_line":"Possible values:"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"* A list of stings, where each is the name of a host"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"Related options:"},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_25acdeec","line":356,"range":{"start_line":356,"start_character":12,"end_line":356,"end_character":18},"in_reply_to":"1aa78d24_c1ae7297","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":395,"context_line":"request that their VMs only be placed on nodes that have been verified by the"},{"line_number":396,"context_line":"attestation server specified in this option."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"The value is a string, and can be either an IP address or FQDN."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":401,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_c1a2f24a","line":398,"range":{"start_line":398,"start_character":0,"end_line":398,"end_character":63},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":395,"context_line":"request that their VMs only be placed on nodes that have been verified by the"},{"line_number":396,"context_line":"attestation server specified in this option."},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"The value is a string, and can be either an IP address or FQDN."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":401,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_05dd2270","line":398,"range":{"start_line":398,"start_character":0,"end_line":398,"end_character":63},"in_reply_to":"1aa78d24_c1a2f24a","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":421,"context_line":"to the attestation server. See the `attestation_server` help text for more"},{"line_number":422,"context_line":"information about host verification."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"The value is a string, and must point to a file that is readable by the"},{"line_number":425,"context_line":"scheduler."},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":428,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_81bf4a5f","line":425,"range":{"start_line":424,"start_character":0,"end_line":425,"end_character":10},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":421,"context_line":"to the attestation server. See the `attestation_server` help text for more"},{"line_number":422,"context_line":"information about host verification."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"The value is a string, and must point to a file that is readable by the"},{"line_number":425,"context_line":"scheduler."},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":428,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_45e72a40","line":425,"range":{"start_line":424,"start_character":0,"end_line":425,"end_character":10},"in_reply_to":"1aa78d24_81bf4a5f","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":448,"context_line":"The port to use when connecting to the attestation server. See the"},{"line_number":449,"context_line":"`attestation_server` help text for more information about host verification."},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"Valid values are strings, not integers, but must be digits only."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":454,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_21b13690","line":451,"range":{"start_line":451,"start_character":0,"end_line":451,"end_character":63},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":448,"context_line":"The port to use when connecting to the attestation server. See the"},{"line_number":449,"context_line":"`attestation_server` help text for more information about host verification."},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"Valid values are strings, not integers, but must be digits only."},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":454,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_45556ac4","line":451,"range":{"start_line":451,"start_character":0,"end_line":451,"end_character":63},"in_reply_to":"1aa78d24_21b13690","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":474,"context_line":"The URL on the attestation server to use. See the `attestation_server` help"},{"line_number":475,"context_line":"text for more information about host verification."},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"This value must be just that path portion of the full URL, as it will be joined"},{"line_number":478,"context_line":"to the host specified in the attestation_server option."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":481,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_81662a27","line":478,"range":{"start_line":477,"start_character":0,"end_line":478,"end_character":55},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":474,"context_line":"The URL on the attestation server to use. See the `attestation_server` help"},{"line_number":475,"context_line":"text for more information about host verification."},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"This value must be just that path portion of the full URL, as it will be joined"},{"line_number":478,"context_line":"to the host specified in the attestation_server option."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":481,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_e5459617","line":478,"range":{"start_line":477,"start_character":0,"end_line":478,"end_character":55},"in_reply_to":"1aa78d24_81662a27","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":481,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":482,"context_line":"only affects scheduling if the \u0027TrustedFilter\u0027 filter is enabled."},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"ossible values:"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"* A valid URL string of the attestation server, or an empty string."},{"line_number":487,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_e1828eff","line":484,"range":{"start_line":484,"start_character":0,"end_line":484,"end_character":7},"updated":"2016-07-11 09:57:04.000000000","message":"Possible","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":481,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":482,"context_line":"only affects scheduling if the \u0027TrustedFilter\u0027 filter is enabled."},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"ossible values:"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"* A valid URL string of the attestation server, or an empty string."},{"line_number":487,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_855db2ee","line":484,"range":{"start_line":484,"start_character":0,"end_line":484,"end_character":7},"in_reply_to":"1aa78d24_e1828eff","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":521,"context_line":"* attestation_insecure_ssl"},{"line_number":522,"context_line":"\"\"\"),"},{"line_number":523,"context_line":"    cfg.IntOpt(\"attestation_auth_timeout\","},{"line_number":524,"context_line":"            default\u003d60,"},{"line_number":525,"context_line":"            help\u003d\"\"\""},{"line_number":526,"context_line":"This value controls how long a successful attestation is cached. Once this"},{"line_number":527,"context_line":"period has elapsed, a new attestation request will be made. See the"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_41c0c22a","line":524,"updated":"2016-07-11 09:57:04.000000000","message":"It might be helpful to set \u0027min\u0027 on this, seeing as a any minimum value has the same effect as 0 and doesn\u0027t really make sense. However: reno notes.","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":527,"context_line":"period has elapsed, a new attestation request will be made. See the"},{"line_number":528,"context_line":"`attestation_server` help text for more information about host verification."},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"The value is in seconds. Valid values must be positive integers for any"},{"line_number":531,"context_line":"caching; setting this to zero or a negative value will result in calls to the"},{"line_number":532,"context_line":"attestation_server for every request, which may impact performance."},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":535,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_01735ae8","line":532,"range":{"start_line":530,"start_character":0,"end_line":532,"end_character":67},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":527,"context_line":"period has elapsed, a new attestation request will be made. See the"},{"line_number":528,"context_line":"`attestation_server` help text for more information about host verification."},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"The value is in seconds. Valid values must be positive integers for any"},{"line_number":531,"context_line":"caching; setting this to zero or a negative value will result in calls to the"},{"line_number":532,"context_line":"attestation_server for every request, which may impact performance."},{"line_number":533,"context_line":""},{"line_number":534,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":535,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_253cde2e","line":532,"range":{"start_line":530,"start_character":0,"end_line":532,"end_character":67},"in_reply_to":"1aa78d24_01735ae8","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"Possible values:"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"* Any integer is valid, although setting this to zero or negative values can"},{"line_number":541,"context_line":"  greatly impact performance when using an attestation service."},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"Related options:"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_e1356e46","line":541,"range":{"start_line":540,"start_character":0,"end_line":541,"end_character":63},"updated":"2016-07-11 09:57:04.000000000","message":"Any positive integer or 0, where the integer corresponds to ... and 0 corresponds to ...","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":537,"context_line":""},{"line_number":538,"context_line":"Possible values:"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"* Any integer is valid, although setting this to zero or negative values can"},{"line_number":541,"context_line":"  greatly impact performance when using an attestation service."},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"Related options:"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_376c159c","line":541,"range":{"start_line":540,"start_character":0,"end_line":541,"end_character":63},"in_reply_to":"1aa78d24_e1356e46","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":555,"context_line":"When set to True, the SSL certificate verification is skipped for the"},{"line_number":556,"context_line":"attestation service. See the `attestation_server` help text for more"},{"line_number":557,"context_line":"information about host verification."},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"Valid values are True or False. The default is False."},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":562,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_614a1ec7","line":559,"range":{"start_line":558,"start_character":0,"end_line":559,"end_character":53},"updated":"2016-07-11 09:57:04.000000000","message":"Drop this - we can infer from the fact that this is a bool","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":555,"context_line":"When set to True, the SSL certificate verification is skipped for the"},{"line_number":556,"context_line":"attestation service. See the `attestation_server` help text for more"},{"line_number":557,"context_line":"information about host verification."},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"Valid values are True or False. The default is False."},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":562,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_f7f8edc6","line":559,"range":{"start_line":558,"start_character":0,"end_line":559,"end_character":53},"in_reply_to":"1aa78d24_614a1ec7","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":580,"context_line":"performing IO (in a build, resize, snapshot, migrate, rescue, or unshelve task"},{"line_number":581,"context_line":"state) before that host becomes ineligible to build new instances."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"Valid values are positive integers: 1 or greater."},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":586,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_81158a9c","line":583,"range":{"start_line":583,"start_character":0,"end_line":583,"end_character":49},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":580,"context_line":"performing IO (in a build, resize, snapshot, migrate, rescue, or unshelve task"},{"line_number":581,"context_line":"state) before that host becomes ineligible to build new instances."},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"Valid values are positive integers: 1 or greater."},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":586,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_5717e1ec","line":583,"range":{"start_line":583,"start_character":0,"end_line":583,"end_character":49},"in_reply_to":"1aa78d24_81158a9c","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":606,"context_line":"in the request spec must have the value of that metadata in its properties in"},{"line_number":607,"context_line":"order for the scheduler to consider the host as acceptable."},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"Valid values are strings."},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":612,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_61597e5a","line":609,"range":{"start_line":609,"start_character":0,"end_line":609,"end_character":25},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":606,"context_line":"in the request spec must have the value of that metadata in its properties in"},{"line_number":607,"context_line":"order for the scheduler to consider the host as acceptable."},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"Valid values are strings."},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":612,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_173c792e","line":609,"range":{"start_line":609,"start_character":0,"end_line":609,"end_character":25},"in_reply_to":"1aa78d24_61597e5a","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":615,"context_line":""},{"line_number":616,"context_line":"Possible values:"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"* Any string"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"Related options:"},{"line_number":621,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_61217efb","line":618,"updated":"2016-07-11 09:57:04.000000000","message":"...corresponding to?","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":615,"context_line":""},{"line_number":616,"context_line":"Possible values:"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"* Any string"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"Related options:"},{"line_number":621,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_b734a54a","line":618,"in_reply_to":"1aa78d24_61217efb","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":629,"context_line":"When using the aggregate_image_properties_isolation filter, the relevant"},{"line_number":630,"context_line":"metadata keys are prefixed with the namespace defined in the"},{"line_number":631,"context_line":"aggregate_image_properties_isolation_namespace configuration option plus a"},{"line_number":632,"context_line":"separator. This option defines the separator to be used. It defaults to a"},{"line_number":633,"context_line":"period (\u0027.\u0027)."},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"Valid values are strings."},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_61305e02","line":633,"range":{"start_line":632,"start_character":56,"end_line":633,"end_character":13},"updated":"2016-07-11 09:57:04.000000000","message":"Drop this - we can infer from the \u0027default\u0027 argument","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":629,"context_line":"When using the aggregate_image_properties_isolation filter, the relevant"},{"line_number":630,"context_line":"metadata keys are prefixed with the namespace defined in the"},{"line_number":631,"context_line":"aggregate_image_properties_isolation_namespace configuration option plus a"},{"line_number":632,"context_line":"separator. This option defines the separator to be used. It defaults to a"},{"line_number":633,"context_line":"period (\u0027.\u0027)."},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"Valid values are strings."},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_3a55dcc5","line":633,"range":{"start_line":632,"start_character":56,"end_line":633,"end_character":13},"in_reply_to":"1aa78d24_61305e02","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":632,"context_line":"separator. This option defines the separator to be used. It defaults to a"},{"line_number":633,"context_line":"period (\u0027.\u0027)."},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"Valid values are strings."},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":638,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_a131a60d","line":635,"range":{"start_line":635,"start_character":0,"end_line":635,"end_character":25},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":632,"context_line":"separator. This option defines the separator to be used. It defaults to a"},{"line_number":633,"context_line":"period (\u0027.\u0027)."},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"Valid values are strings."},{"line_number":636,"context_line":""},{"line_number":637,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":638,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_5a52a8de","line":635,"range":{"start_line":635,"start_character":0,"end_line":635,"end_character":25},"in_reply_to":"1aa78d24_a131a60d","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":656,"context_line":"will reject any host that has at least as many instances as this option\u0027s"},{"line_number":657,"context_line":"value."},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"Valid values are positive integers; setting it to zero or less will cause all"},{"line_number":660,"context_line":"hosts to be rejected if the num_instances_filter is active."},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":663,"context_line":"a different scheduler, this option has no effect. Also note that this setting"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_412ba294","line":660,"range":{"start_line":659,"start_character":0,"end_line":660,"end_character":59},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":689,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":690,"context_line":"only affects scheduling if the \u0027ram\u0027 weigher is enabled."},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"Valid values are numeric, either integer or float."},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"Possible values:"},{"line_number":695,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_811bca7f","line":692,"range":{"start_line":692,"start_character":0,"end_line":692,"end_character":50},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":689,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":690,"context_line":"only affects scheduling if the \u0027ram\u0027 weigher is enabled."},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"Valid values are numeric, either integer or float."},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"Possible values:"},{"line_number":695,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_ba0e4ce3","line":692,"range":{"start_line":692,"start_character":0,"end_line":692,"end_character":50},"in_reply_to":"1aa78d24_811bca7f","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"187021c50a21ca9877dd3bba2443de925b932910","unresolved":false,"context_lines":[{"line_number":691,"context_line":""},{"line_number":692,"context_line":"Valid values are numeric, either integer or float."},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"Possible values:"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"* Any numeric value"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"Related options:"},{"line_number":699,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_d6c824ab","line":696,"range":{"start_line":694,"start_character":0,"end_line":696,"end_character":19},"updated":"2016-07-14 15:42:30.000000000","message":"This can be dropped. It is quite obvious.","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":691,"context_line":""},{"line_number":692,"context_line":"Valid values are numeric, either integer or float."},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"Possible values:"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"* Any numeric value"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"Related options:"},{"line_number":699,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_5a00e8aa","line":696,"range":{"start_line":694,"start_character":0,"end_line":696,"end_character":19},"in_reply_to":"1aa78d24_d6c824ab","updated":"2016-09-20 10:05:15.000000000","message":"Took a different tack","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":721,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":722,"context_line":"only affects scheduling if the \u0027io_ops\u0027 weigher is enabled."},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"Valid values are numeric, either integer or float."},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"Possible values:"},{"line_number":727,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_210db63e","line":724,"range":{"start_line":724,"start_character":0,"end_line":724,"end_character":50},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":721,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":722,"context_line":"only affects scheduling if the \u0027io_ops\u0027 weigher is enabled."},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"Valid values are numeric, either integer or float."},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"Possible values:"},{"line_number":727,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_fa1ff406","line":724,"range":{"start_line":724,"start_character":0,"end_line":724,"end_character":50},"in_reply_to":"1aa78d24_210db63e","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":741,"context_line":"to change how the calculated weight influences the weight assigned to a host as"},{"line_number":742,"context_line":"follows:"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"    * Greater than 1.0: increases the effect of the metric on overall weight."},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"    * Equal to 1.0: No change to the calculated weight."},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    * Less than 1.0, greater than 0: reduces the effect of the metric on"},{"line_number":749,"context_line":"    overall weight."},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    * 0: The metric value is ignored, and the value of the"},{"line_number":752,"context_line":"    \u0027weight_of_unavailable\u0027 option is returned instead."},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    * Greater than -1.0, less than 0: the effect is reduced and reversed."},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    * -1.0: the effect is reversed"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    * Less than -1.0: the effect is increased proportionally and reversed."},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"Valid values are numeric, either integer or float."},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":763,"context_line":"a different scheduler, this option has no effect."}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_3c19597a","line":760,"range":{"start_line":744,"start_character":0,"end_line":760,"end_character":50},"updated":"2016-07-11 09:57:04.000000000","message":"Should this move into the \u0027Possible values\u0027 section?","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":741,"context_line":"to change how the calculated weight influences the weight assigned to a host as"},{"line_number":742,"context_line":"follows:"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"    * Greater than 1.0: increases the effect of the metric on overall weight."},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"    * Equal to 1.0: No change to the calculated weight."},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    * Less than 1.0, greater than 0: reduces the effect of the metric on"},{"line_number":749,"context_line":"    overall weight."},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"    * 0: The metric value is ignored, and the value of the"},{"line_number":752,"context_line":"    \u0027weight_of_unavailable\u0027 option is returned instead."},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    * Greater than -1.0, less than 0: the effect is reduced and reversed."},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    * -1.0: the effect is reversed"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    * Less than -1.0: the effect is increased proportionally and reversed."},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"Valid values are numeric, either integer or float."},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":763,"context_line":"a different scheduler, this option has no effect."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_3a1a3c18","line":760,"range":{"start_line":744,"start_character":0,"end_line":760,"end_character":50},"in_reply_to":"1aa78d24_3c19597a","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":779,"context_line":"of the metric to be weighed, and \u0027ratio\u0027 is the relative weight for that"},{"line_number":780,"context_line":"metric."},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"Note that if the ratio is set to 0, the metric value is ignored, and instead"},{"line_number":783,"context_line":"the weight will be set to the value of the \u0027weight_of_unavailable\u0027 option."},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"As an example, let\u0027s consider the case where this option is set to:"},{"line_number":786,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_1c3bbdd2","line":783,"range":{"start_line":782,"start_character":0,"end_line":783,"end_character":74},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":779,"context_line":"of the metric to be weighed, and \u0027ratio\u0027 is the relative weight for that"},{"line_number":780,"context_line":"metric."},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"Note that if the ratio is set to 0, the metric value is ignored, and instead"},{"line_number":783,"context_line":"the weight will be set to the value of the \u0027weight_of_unavailable\u0027 option."},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"As an example, let\u0027s consider the case where this option is set to:"},{"line_number":786,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_7ad20436","line":783,"range":{"start_line":782,"start_character":0,"end_line":783,"end_character":74},"in_reply_to":"1aa78d24_1c3bbdd2","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f77343209fb45d2e6da7fc442392aea1af4c0043","unresolved":false,"context_lines":[{"line_number":811,"context_line":"exception, so it is recommended to also use the MetricFilter to filter out"},{"line_number":812,"context_line":"those hosts before weighing."},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"When this option is False, any metric being unavailable for a host will set the"},{"line_number":815,"context_line":"host weight to \u0027weight_of_unavailable\u0027."},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":818,"context_line":"a different scheduler, this option has no effect."}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_5c3545d8","line":815,"range":{"start_line":814,"start_character":0,"end_line":815,"end_character":39},"updated":"2016-07-11 09:57:04.000000000","message":"Remove this, or merge into the possible values section","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":811,"context_line":"exception, so it is recommended to also use the MetricFilter to filter out"},{"line_number":812,"context_line":"those hosts before weighing."},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"When this option is False, any metric being unavailable for a host will set the"},{"line_number":815,"context_line":"host weight to \u0027weight_of_unavailable\u0027."},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":818,"context_line":"a different scheduler, this option has no effect."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_3a207cf7","line":815,"range":{"start_line":814,"start_character":0,"end_line":815,"end_character":39},"in_reply_to":"1aa78d24_5c3545d8","updated":"2016-09-20 10:05:15.000000000","message":"Done","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"187021c50a21ca9877dd3bba2443de925b932910","unresolved":false,"context_lines":[{"line_number":860,"context_line":""},{"line_number":861,"context_line":"Possible values:"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"* Any positive integer"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"Related options:"},{"line_number":866,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_3651a8d9","line":863,"range":{"start_line":863,"start_character":0,"end_line":863,"end_character":22},"updated":"2016-07-14 15:42:30.000000000","message":"Add min\u003d0 param to IntOpt and drop this section, it\u0027s quite obvious.","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"67f4daf452b886c384e470f62eeca5defd9d2176","unresolved":false,"context_lines":[{"line_number":860,"context_line":""},{"line_number":861,"context_line":"Possible values:"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"* Any positive integer"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"Related options:"},{"line_number":866,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_6d5deceb","line":863,"range":{"start_line":863,"start_character":0,"end_line":863,"end_character":22},"in_reply_to":"1aa78d24_3651a8d9","updated":"2016-09-20 10:05:15.000000000","message":"We\u0027ll do this in another patch","commit_id":"c171485a854b2dc729874bdcaa65bf1c80be1649"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"80306ec72271ce1f6ec02f860a052de63d8b4234","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Possible values:"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"*"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Related options:"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_aed8ea53","line":220,"updated":"2016-08-02 10:37:00.000000000","message":"Missing the description for possible values.\nAny string?","commit_id":"b1c89b498968a6e0e8a6057bd76cc13e30c79d56"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"cee942e0d602b54cdba1b899c50c14d4e40b8447","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Possible values:"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"*"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Related options:"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_238d6cd3","line":220,"in_reply_to":"bacf61ea_aed8ea53","updated":"2016-08-05 14:13:54.000000000","message":"Done","commit_id":"b1c89b498968a6e0e8a6057bd76cc13e30c79d56"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* Any integer, although any value less than 1 will be treated as 1"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Related options:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* None"},{"line_number":52,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_cffc7174","line":49,"updated":"2016-08-05 15:24:03.000000000","message":"This section should be dropped, if its empty.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"* Any integer, although any value less than 1 will be treated as 1"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Related options:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* None"},{"line_number":52,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_ade614e6","line":49,"in_reply_to":"bacf61ea_cffc7174","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Related options:"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"* None"},{"line_number":208,"context_line":"\"\"\")"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"rpc_sched_topic_opt \u003d cfg.StrOpt(\"scheduler_topic\","}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_4f1fe1b6","line":207,"updated":"2016-08-05 15:24:03.000000000","message":"This should be dropped.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"Related options:"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"* None"},{"line_number":208,"context_line":"\"\"\")"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"rpc_sched_topic_opt \u003d cfg.StrOpt(\"scheduler_topic\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_0dce285a","line":207,"in_reply_to":"bacf61ea_4f1fe1b6","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Possible values:"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"* Any non-empty string"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Related options:"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_6f658543","line":220,"updated":"2016-08-05 15:24:03.000000000","message":"Thats not true, it has to be a valid AMQP topic name.\n\nWe really should be deprecating and removing this option, there is little point in changing this option.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Possible values:"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"* Any non-empty string"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Related options:"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_6d032c77","line":220,"in_reply_to":"bacf61ea_6f658543","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Related options:"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"* None"},{"line_number":225,"context_line":"\"\"\")"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"scheduler_json_config_location_opt \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2f1a6dc6","line":224,"updated":"2016-08-05 15:24:03.000000000","message":"This should be dropped.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Related options:"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"* None"},{"line_number":225,"context_line":"\"\"\")"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"scheduler_json_config_location_opt \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_edf73c8a","line":224,"in_reply_to":"bacf61ea_2f1a6dc6","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"Related options:"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"* None"},{"line_number":244,"context_line":"\"\"\")"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"sched_driver_host_mgr_opt \u003d cfg.StrOpt(\"scheduler_host_manager\","}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_ef517563","line":243,"updated":"2016-08-05 15:24:03.000000000","message":"As above, we should drop this section.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"Related options:"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"* None"},{"line_number":244,"context_line":"\"\"\")"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"sched_driver_host_mgr_opt \u003d cfg.StrOpt(\"scheduler_host_manager\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_2df2049b","line":243,"in_reply_to":"bacf61ea_ef517563","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":256,"context_line":"option as of the Mitaka release is \u0027ironic_host_manager\u0027, which should be used"},{"line_number":257,"context_line":"if you\u0027re using Ironic to provision bare-metal instances."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Possible values:"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"* Either \u0027host_manager\u0027 (default), or \"ironic_host_manager\""},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Related options:"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_4fe401ab","line":261,"range":{"start_line":259,"start_character":0,"end_line":261,"end_character":59},"updated":"2016-08-05 15:24:03.000000000","message":"We already have this in the choices, I would drop this as it just duplicates info we already have.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":256,"context_line":"option as of the Mitaka release is \u0027ironic_host_manager\u0027, which should be used"},{"line_number":257,"context_line":"if you\u0027re using Ironic to provision bare-metal instances."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"Possible values:"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"* Either \u0027host_manager\u0027 (default), or \"ironic_host_manager\""},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Related options:"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_ad34544a","line":261,"range":{"start_line":259,"start_character":0,"end_line":261,"end_character":59},"in_reply_to":"bacf61ea_4fe401ab","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Related options:"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"* None"},{"line_number":266,"context_line":"\"\"\")"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"driver_opt \u003d cfg.StrOpt(\"scheduler_driver\","}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2f48adb2","line":265,"updated":"2016-08-05 15:24:03.000000000","message":"as above.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"Related options:"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"* None"},{"line_number":266,"context_line":"\"\"\")"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"driver_opt \u003d cfg.StrOpt(\"scheduler_driver\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_cd39a043","line":265,"in_reply_to":"bacf61ea_2f48adb2","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Possible values:"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"* Any of the drivers included in Nova:"},{"line_number":289,"context_line":"** filter_scheduler"},{"line_number":290,"context_line":"** caching_scheduler"},{"line_number":291,"context_line":"** chance_scheduler"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_cfe631af","line":288,"updated":"2016-08-05 15:24:03.000000000","message":"I would rather we added a choices\u003d() param, and put this great detail in there.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Possible values:"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"* Any of the drivers included in Nova:"},{"line_number":289,"context_line":"** filter_scheduler"},{"line_number":290,"context_line":"** caching_scheduler"},{"line_number":291,"context_line":"** chance_scheduler"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_0d51c862","line":288,"in_reply_to":"bacf61ea_cfe631af","updated":"2016-09-20 10:18:18.000000000","message":"I don\u0027t know if we can do that, seeing as it\u0027s possible to provide our own scheduler","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Related options:"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"* None"},{"line_number":300,"context_line":"\"\"\")"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"driver_period_opt \u003d cfg.IntOpt(\"scheduler_driver_task_period\","}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_afe93d81","line":299,"updated":"2016-08-05 15:24:03.000000000","message":"as above.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"Related options:"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"* None"},{"line_number":300,"context_line":"\"\"\")"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"driver_period_opt \u003d cfg.IntOpt(\"scheduler_driver_task_period\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_4d4bd0b0","line":299,"in_reply_to":"bacf61ea_afe93d81","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":312,"context_line":"option allows. As each scheduler can work a little differently than the others,"},{"line_number":313,"context_line":"be sure to test this with your selected scheduler."},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Possible values:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"* Any positive integer"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"Related options:"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2f8d4dd3","line":317,"range":{"start_line":315,"start_character":0,"end_line":317,"end_character":22},"updated":"2016-08-05 15:24:03.000000000","message":"Thats not true, I added some details notes on what is correct here on this patch:\nhttps://review.openstack.org/#/c/349666/4/nova/conf/scheduler.py@278","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":312,"context_line":"option allows. As each scheduler can work a little differently than the others,"},{"line_number":313,"context_line":"be sure to test this with your selected scheduler."},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Possible values:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"* Any positive integer"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"Related options:"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_30625bd9","line":317,"range":{"start_line":315,"start_character":0,"end_line":317,"end_character":22},"in_reply_to":"bacf61ea_2f8d4dd3","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":481,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":482,"context_line":"only affects scheduling if the \u0027TrustedFilter\u0027 filter is enabled."},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"ossible values:"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"* A valid URL string of the attestation server, or an empty string."},{"line_number":487,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_8f65591f","line":484,"range":{"start_line":484,"start_character":0,"end_line":484,"end_character":15},"updated":"2016-08-05 15:24:03.000000000","message":"Possible values:","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":481,"context_line":"a different scheduler, this option has no effect. Also note that this setting"},{"line_number":482,"context_line":"only affects scheduling if the \u0027TrustedFilter\u0027 filter is enabled."},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"ossible values:"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"* A valid URL string of the attestation server, or an empty string."},{"line_number":487,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_505fe70d","line":484,"range":{"start_line":484,"start_character":0,"end_line":484,"end_character":15},"in_reply_to":"bacf61ea_8f65591f","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":593,"context_line":""},{"line_number":594,"context_line":"Related options:"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"* None"},{"line_number":597,"context_line":"\"\"\")"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"agg_img_prop_iso_namespace_opt \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_0f7a09bd","line":596,"updated":"2016-08-05 15:24:03.000000000","message":"As above, drop this bit.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":593,"context_line":""},{"line_number":594,"context_line":"Related options:"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"* None"},{"line_number":597,"context_line":"\"\"\")"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"agg_img_prop_iso_namespace_opt \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_709a23c7","line":596,"in_reply_to":"bacf61ea_0f7a09bd","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":670,"context_line":""},{"line_number":671,"context_line":"Related options:"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"* None"},{"line_number":674,"context_line":"\"\"\")"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"ram_weight_mult_opt \u003d cfg.FloatOpt(\"ram_weight_multiplier\","}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2f7b8dbf","line":673,"updated":"2016-08-05 15:24:03.000000000","message":"As above.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":670,"context_line":""},{"line_number":671,"context_line":"Related options:"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"* None"},{"line_number":674,"context_line":"\"\"\")"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"ram_weight_mult_opt \u003d cfg.FloatOpt(\"ram_weight_multiplier\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_30e7bb41","line":673,"in_reply_to":"bacf61ea_2f7b8dbf","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":691,"context_line":""},{"line_number":692,"context_line":"Valid values are numeric, either integer or float."},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"Possible values:"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"* Any numeric value"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"Related options:"},{"line_number":699,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_6f362504","line":696,"range":{"start_line":694,"start_character":0,"end_line":696,"end_character":19},"updated":"2016-08-05 15:24:03.000000000","message":"I would drop this too, this info is already given in the option definition.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":691,"context_line":""},{"line_number":692,"context_line":"Valid values are numeric, either integer or float."},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"Possible values:"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"* Any numeric value"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"Related options:"},{"line_number":699,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_50e4473a","line":696,"range":{"start_line":694,"start_character":0,"end_line":696,"end_character":19},"in_reply_to":"bacf61ea_6f362504","updated":"2016-09-20 10:18:18.000000000","message":"I fleshed out the detail a little more","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":697,"context_line":""},{"line_number":698,"context_line":"Related options:"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"* None"},{"line_number":701,"context_line":"\"\"\")"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"disk_weight_mult_opt \u003d cfg.FloatOpt(\"disk_weight_multiplier\","}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_6f4f4592","line":700,"updated":"2016-08-05 15:24:03.000000000","message":"As above.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":697,"context_line":""},{"line_number":698,"context_line":"Related options:"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"* None"},{"line_number":701,"context_line":"\"\"\")"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"disk_weight_mult_opt \u003d cfg.FloatOpt(\"disk_weight_multiplier\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_10c1df80","line":700,"in_reply_to":"bacf61ea_6f4f4592","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":723,"context_line":""},{"line_number":724,"context_line":"Valid values are numeric, either integer or float."},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"Possible values:"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"* Any numeric value"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"Related options:"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"* None"},{"line_number":733,"context_line":"\"\"\")"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"# These opts are registered as a separate OptGroup"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_4f2ec1a5","line":732,"range":{"start_line":726,"start_character":0,"end_line":732,"end_character":6},"updated":"2016-08-05 15:24:03.000000000","message":"As above, I would delete these bits.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":723,"context_line":""},{"line_number":724,"context_line":"Valid values are numeric, either integer or float."},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"Possible values:"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"* Any numeric value"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"Related options:"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"* None"},{"line_number":733,"context_line":"\"\"\")"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"# These opts are registered as a separate OptGroup"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_f04ab326","line":732,"range":{"start_line":726,"start_character":0,"end_line":732,"end_character":6},"in_reply_to":"bacf61ea_4f2ec1a5","updated":"2016-09-20 10:18:18.000000000","message":"Reworked first. Removed second.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":762,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":763,"context_line":"a different scheduler, this option has no effect."},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"Possible values:"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"* Any numeric value"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"Related options:"},{"line_number":770,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2f29cd9b","line":767,"range":{"start_line":765,"start_character":0,"end_line":767,"end_character":19},"updated":"2016-08-05 15:24:03.000000000","message":"I would delete this section, its not required.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":762,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":763,"context_line":"a different scheduler, this option has no effect."},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"Possible values:"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"* Any numeric value"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"Related options:"},{"line_number":770,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_b00e6be3","line":767,"range":{"start_line":765,"start_character":0,"end_line":767,"end_character":19},"in_reply_to":"bacf61ea_2f29cd9b","updated":"2016-09-20 10:18:18.000000000","message":"Reworked","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":837,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":838,"context_line":"a different scheduler, this option has no effect."},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"Possible values:"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"* Any numeric value"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"Related options:"},{"line_number":845,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_4f052112","line":842,"range":{"start_line":840,"start_character":0,"end_line":842,"end_character":19},"updated":"2016-08-05 15:24:03.000000000","message":"Lets drop that.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":837,"context_line":"This option is only used by the FilterScheduler and its subclasses; if you use"},{"line_number":838,"context_line":"a different scheduler, this option has no effect."},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"Possible values:"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"* Any numeric value"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"Related options:"},{"line_number":845,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_702b0334","line":842,"range":{"start_line":840,"start_character":0,"end_line":842,"end_character":19},"in_reply_to":"bacf61ea_4f052112","updated":"2016-09-20 10:18:18.000000000","message":"Reworked","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":850,"context_line":"]"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"scheduler_max_att_opt \u003d cfg.IntOpt(\"scheduler_max_attempts\","},{"line_number":853,"context_line":"        default\u003d3,"},{"line_number":854,"context_line":"        help\u003d\"\"\""},{"line_number":855,"context_line":"This is the maximum number of attempts that will be made to schedule an"},{"line_number":856,"context_line":"instance before it is assumed that the failures aren\u0027t due to normal occasional"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_3a174946","line":853,"updated":"2016-08-05 15:24:03.000000000","message":"I mentioned in the follow up patch, really just have min\u003d1 here. Below that all builds will fail, I think.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":858,"context_line":"MaxRetriesExceeded exception is raised, and the instance is set to an error"},{"line_number":859,"context_line":"state."},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"Possible values:"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"* Any positive integer"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"Related options:"},{"line_number":866,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_da070d16","line":863,"range":{"start_line":861,"start_character":0,"end_line":863,"end_character":22},"updated":"2016-08-05 15:24:03.000000000","message":"Lets drop that.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":858,"context_line":"MaxRetriesExceeded exception is raised, and the instance is set to an error"},{"line_number":859,"context_line":"state."},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"Possible values:"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"* Any positive integer"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"Related options:"},{"line_number":866,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_b0dcab47","line":863,"range":{"start_line":861,"start_character":0,"end_line":863,"end_character":22},"in_reply_to":"bacf61ea_da070d16","updated":"2016-09-20 10:18:18.000000000","message":"Reworked","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":864,"context_line":""},{"line_number":865,"context_line":"Related options:"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"* None"},{"line_number":868,"context_line":"\"\"\")"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"soft_affinity_weight_opt \u003d cfg.FloatOpt(\"soft_affinity_weight_multiplier\","}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_7a2b8182","line":867,"updated":"2016-08-05 15:24:03.000000000","message":"As above, drop it.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":864,"context_line":""},{"line_number":865,"context_line":"Related options:"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"* None"},{"line_number":868,"context_line":"\"\"\")"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"soft_affinity_weight_opt \u003d cfg.FloatOpt(\"soft_affinity_weight_multiplier\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_301a5b18","line":867,"in_reply_to":"bacf61ea_7a2b8182","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":877,"context_line":"* Any numeric, although only a positive value is meaningful, as negative values"},{"line_number":878,"context_line":"  would make this behave as a soft-anti-affinity weigher."},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"Related options:"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"* None"},{"line_number":883,"context_line":"\"\"\")"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"soft_anti_affinity_weight_opt \u003d cfg.FloatOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_1a3d25c4","line":882,"range":{"start_line":880,"start_character":0,"end_line":882,"end_character":6},"updated":"2016-08-05 15:24:03.000000000","message":"drop it.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":877,"context_line":"* Any numeric, although only a positive value is meaningful, as negative values"},{"line_number":878,"context_line":"  would make this behave as a soft-anti-affinity weigher."},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"Related options:"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"* None"},{"line_number":883,"context_line":"\"\"\")"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"soft_anti_affinity_weight_opt \u003d cfg.FloatOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_d0e13700","line":882,"range":{"start_line":880,"start_character":0,"end_line":882,"end_character":6},"in_reply_to":"bacf61ea_1a3d25c4","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"05984315ca53dddad59cb28c1b343b3c76bf4527","unresolved":false,"context_lines":[{"line_number":893,"context_line":"* Any numeric, although only a positive value is meaningful, as negative values"},{"line_number":894,"context_line":"  would make this behave as a soft-affinity weigher."},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"Related options:"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"* None"},{"line_number":899,"context_line":"\"\"\")"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_fa3771e0","line":898,"range":{"start_line":896,"start_character":0,"end_line":898,"end_character":6},"updated":"2016-08-05 15:24:03.000000000","message":"As above, please drop this section.","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1478b533085b03351b62ad25aed483614c5fc2a7","unresolved":false,"context_lines":[{"line_number":893,"context_line":"* Any numeric, although only a positive value is meaningful, as negative values"},{"line_number":894,"context_line":"  would make this behave as a soft-affinity weigher."},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"Related options:"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"* None"},{"line_number":899,"context_line":"\"\"\")"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_10e47f0b","line":898,"range":{"start_line":896,"start_character":0,"end_line":898,"end_character":6},"in_reply_to":"bacf61ea_fa3771e0","updated":"2016-09-20 10:18:18.000000000","message":"Done","commit_id":"5c976656f134c73699b65a733c36b218a4a186c3"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ad2512eda5974f53eebedc9146c9e68ba2e05644","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Possible values:"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* Any list of zero or more strings, with each string being the name of a filter"},{"line_number":77,"context_line":"  to be used for selecting a baremetal host."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_c595c040","line":76,"range":{"start_line":76,"start_character":70,"end_line":76,"end_character":79},"updated":"2016-09-12 10:48:46.000000000","message":"This is an indentation-related thing which I tried to address with hacking check, but i ultimately failed due to the way oslo.config handles configs.\n\nIn help text messages (and all other triple \") max line length is 77, not 79. Generated doc prepends every line with \"# \" and still makes a soft wrap on 79 column resulting in a single word in new line. See [0].\n\nIf you could just reformat all help texts here to include this limitation, would be great.\n\n[0] http://docs-draft.openstack.org/36/339736/4/check/gate-nova-docs-ubuntu-xenial/b521e54//doc/build/html/sample_config.html","commit_id":"a09942d276fc1a7a86f688af34377b37c9ae7de4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ba0834cc550d37bce1a6c5e44c7ede931636254","unresolved":false,"context_lines":[{"line_number":249,"context_line":"\u0027setup.cfg\u0027. If nothing is specified in this option, the \u0027filter_scheduler\u0027 is"},{"line_number":250,"context_line":"used."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"Other options are:"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"* \u0027caching_scheduler\u0027 which aggressively caches the system state for better"},{"line_number":255,"context_line":"  individual scheduler performance at the risk of more retries when running"},{"line_number":256,"context_line":"  multiple schedulers."},{"line_number":257,"context_line":"* \u0027chance_scheduler\u0027 which simply picks a host at random."},{"line_number":258,"context_line":"* \u0027fake_scheduler\u0027 which is used for testing."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Possible values:"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_14b7ccd8","line":258,"range":{"start_line":252,"start_character":0,"end_line":258,"end_character":45},"updated":"2016-09-21 10:56:42.000000000","message":"This seems to duplicate possible values, but lets sort that out in some follow up.","commit_id":"c4ce5f11040a7143926a67a316575089bf91b2b2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3ba0834cc550d37bce1a6c5e44c7ede931636254","unresolved":false,"context_lines":[{"line_number":263,"context_line":"** filter_scheduler"},{"line_number":264,"context_line":"** caching_scheduler"},{"line_number":265,"context_line":"** chance_scheduler"},{"line_number":266,"context_line":"** fake_scheduler"},{"line_number":267,"context_line":"* You may also set this to the class name of a custom scheduler driver, but you"},{"line_number":268,"context_line":"  will be responsible for creating and maintaining the entrypoint in your"},{"line_number":269,"context_line":"  setup.cfg file."}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_34e3e8da","line":266,"updated":"2016-09-21 10:56:42.000000000","message":"We should probably add choices in here, but thats a later patch.","commit_id":"c4ce5f11040a7143926a67a316575089bf91b2b2"}]}