)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df0ebb9a6a67e4eedd4c5867b5f22e211b685380","unresolved":false,"context_lines":[{"line_number":836,"context_line":"                                                  migration)"},{"line_number":837,"context_line":"            except exception.FlavorNotFound:"},{"line_number":838,"context_line":"                LOG.warning(_LW(\"Flavor could not be found, skipping \""},{"line_number":839,"context_line":"                                \"migration.\"), instance_uuid\u003dinstance.uuid)"},{"line_number":840,"context_line":"                continue"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"    def _update_usage_from_instance(self, context, instance, is_removed\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_2b09a795","line":839,"updated":"2016-07-13 01:04:56.000000000","message":"How is this any different? instance comes from:\n\ninstance \u003d instances[migration.instance_uuid]\n\nAnd that instances dict is built from:\n\nuuid \u003d migration.instance_uuid\n\n            try:\n                if uuid not in instances:\n                    instances[uuid] \u003d migration.instance","commit_id":"8911559d6bd7d529c0a0b34ce1533fa7bd7b3ee8"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"35c4e8aa54a7aa6b873a274137bbd40350965ed7","unresolved":false,"context_lines":[{"line_number":836,"context_line":"                                                  migration)"},{"line_number":837,"context_line":"            except exception.FlavorNotFound:"},{"line_number":838,"context_line":"                LOG.warning(_LW(\"Flavor could not be found, skipping \""},{"line_number":839,"context_line":"                                \"migration.\"), instance_uuid\u003dinstance.uuid)"},{"line_number":840,"context_line":"                continue"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"    def _update_usage_from_instance(self, context, instance, is_removed\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_6edf380d","line":839,"in_reply_to":"1aa78d24_2b09a795","updated":"2016-07-13 05:19:45.000000000","message":"At the point of this exception, the value of \"uuid\" is whatever was left over after the previous \"for migration in migrations\" loop.  It doesn\u0027t get set in the \"for migration in filtered.values()\" loop, while \"instance\" does.","commit_id":"8911559d6bd7d529c0a0b34ce1533fa7bd7b3ee8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dec55da9723b1f3ee17c38436751229efc4cf869","unresolved":false,"context_lines":[{"line_number":836,"context_line":"                                                  migration)"},{"line_number":837,"context_line":"            except exception.FlavorNotFound:"},{"line_number":838,"context_line":"                LOG.warning(_LW(\"Flavor could not be found, skipping \""},{"line_number":839,"context_line":"                                \"migration.\"), instance_uuid\u003dinstance.uuid)"},{"line_number":840,"context_line":"                continue"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"    def _update_usage_from_instance(self, context, instance, is_removed\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_cb8c51d9","line":839,"in_reply_to":"1aa78d24_6edf380d","updated":"2016-07-13 10:04:38.000000000","message":"Right its previous loop that defined the uuid.","commit_id":"8911559d6bd7d529c0a0b34ce1533fa7bd7b3ee8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2a90298cff63f984c2ab7bc17e9f5ba08758ce36","unresolved":false,"context_lines":[{"line_number":836,"context_line":"                                                  migration)"},{"line_number":837,"context_line":"            except exception.FlavorNotFound:"},{"line_number":838,"context_line":"                LOG.warning(_LW(\"Flavor could not be found, skipping \""},{"line_number":839,"context_line":"                                \"migration.\"), instance_uuid\u003dinstance.uuid)"},{"line_number":840,"context_line":"                continue"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"    def _update_usage_from_instance(self, context, instance, is_removed\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_08dbe84f","line":839,"in_reply_to":"1aa78d24_cb8c51d9","updated":"2016-07-13 15:48:44.000000000","message":"Ah damn, 2 loops, OK this makes sense now. :)","commit_id":"8911559d6bd7d529c0a0b34ce1533fa7bd7b3ee8"}]}