)]}'
{"nova/api/openstack/placement/handlers/allocation.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"1649e670cff559fe1bb1926adefee27aa26c6809","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    try:"},{"line_number":68,"context_line":"        data \u003d jsonutils.loads(body)"},{"line_number":69,"context_line":"    except ValueError as exc:"},{"line_number":70,"context_line":"        raise webob.exc.HTTPBadRequest("},{"line_number":71,"context_line":"            \u0027Malformed JSON: %s\u0027 % exc,"},{"line_number":72,"context_line":"            json_formatter\u003dutil.json_error_formatter)"},{"line_number":73,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":34,"id":"fa7ab95a_4e473b77","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":13},"updated":"2016-08-31 20:18:40.000000000","message":"Logging for this code will be added at some point, right?","commit_id":"66117c40ff98b83c8762b1c9884fa2c180d8025c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"01f02f876c4cfd030b47ab30ccbc36a9af1d0f5a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    try:"},{"line_number":68,"context_line":"        data \u003d jsonutils.loads(body)"},{"line_number":69,"context_line":"    except ValueError as exc:"},{"line_number":70,"context_line":"        raise webob.exc.HTTPBadRequest("},{"line_number":71,"context_line":"            \u0027Malformed JSON: %s\u0027 % exc,"},{"line_number":72,"context_line":"            json_formatter\u003dutil.json_error_formatter)"},{"line_number":73,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":34,"id":"fa7ab95a_a91a8115","line":70,"in_reply_to":"fa7ab95a_4e473b77","updated":"2016-08-31 20:23:26.000000000","message":"Yes, we need to resolve the logging situation. The presumption is that logging will be centralized at some point above that catches and logs the various exceptions, the re-raises.\n\nWe could also scatter logging throughout the handlers. In some early versions of some of the handlers I asked about logging and the lack of responses suggested it was something that could be put off until we had a unified front^wsolution.\n\nSo: yes.","commit_id":"66117c40ff98b83c8762b1c9884fa2c180d8025c"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"20b4abf43379dbcc72228699a21a48b275d06302","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        for resource_class in resources:"},{"line_number":108,"context_line":"            allocation \u003d objects.Allocation("},{"line_number":109,"context_line":"                resource_provider\u003dresource_provider,"},{"line_number":110,"context_line":"                consumer_id\u003dconsumer_uuid, resource_class\u003dresource_class,"},{"line_number":111,"context_line":"                used\u003dresources[resource_class])"},{"line_number":112,"context_line":"            allocation_objects.append(allocation)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"fa7ab95a_e0dd5771","line":110,"range":{"start_line":110,"start_character":43,"end_line":110,"end_character":72},"updated":"2016-09-01 11:18:46.000000000","message":"We should handle when resource_class didn\u0027t existed.","commit_id":"66117c40ff98b83c8762b1c9884fa2c180d8025c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"75a4b8b433b1b0073fff06abce228d4090d92c6f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        for resource_class in resources:"},{"line_number":108,"context_line":"            allocation \u003d objects.Allocation("},{"line_number":109,"context_line":"                resource_provider\u003dresource_provider,"},{"line_number":110,"context_line":"                consumer_id\u003dconsumer_uuid, resource_class\u003dresource_class,"},{"line_number":111,"context_line":"                used\u003dresources[resource_class])"},{"line_number":112,"context_line":"            allocation_objects.append(allocation)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"fa7ab95a_f390d350","line":110,"in_reply_to":"fa7ab95a_e0dd5771","updated":"2016-09-01 11:29:12.000000000","message":"Good catch, I\u0027ll put that in when the patch below this one settles out, as it is going to raise some exceptions (during the set_all below) that will probably indicate this.","commit_id":"66117c40ff98b83c8762b1c9884fa2c180d8025c"}],"nova/tests/functional/api/openstack/placement/gabbits/allocations.yaml":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"8163f7dc957aae87a6cbfcdc05302c19b15b6c50","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      max_unit: 8"},{"line_number":183,"context_line":"  status: 201"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"- name: multiple allocations "},{"line_number":186,"context_line":"  PUT: /allocations/833f0885-f78c-4788-bb2b-3607b0656be7"},{"line_number":187,"context_line":"  request_headers:"},{"line_number":188,"context_line":"      content-type: application/json"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fa7ab95a_26c81e22","line":185,"updated":"2016-09-01 17:26:57.000000000","message":"The dreaded red box appears.","commit_id":"b76ff3e1fa30b8238793e0d56033e601001de3b7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"98dad7f2219ed92115dcb13b535c2f03a9d2424f","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      max_unit: 8"},{"line_number":183,"context_line":"  status: 201"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"- name: multiple allocations "},{"line_number":186,"context_line":"  PUT: /allocations/833f0885-f78c-4788-bb2b-3607b0656be7"},{"line_number":187,"context_line":"  request_headers:"},{"line_number":188,"context_line":"      content-type: application/json"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"fa7ab95a_adb246e3","line":185,"updated":"2016-09-01 20:16:37.000000000","message":"whitespace issue","commit_id":"f441ee55c6f99a099fe1a68a6cfa486fd522554f"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3de47c7d4cbf42dccfd4e0b0554f204340882b3c","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      max_unit: 8"},{"line_number":183,"context_line":"  status: 201"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"- name: multiple allocations "},{"line_number":186,"context_line":"  PUT: /allocations/833f0885-f78c-4788-bb2b-3607b0656be7"},{"line_number":187,"context_line":"  request_headers:"},{"line_number":188,"context_line":"      content-type: application/json"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"fa7ab95a_8de582a5","line":185,"in_reply_to":"fa7ab95a_adb246e3","updated":"2016-09-01 20:25:20.000000000","message":"Does not sound a problem here http://logs.openstack.org/74/339874/38/check/gate-nova-tox-db-functional/43297d5/console.html#_2016-09-01_18_46_13_851946","commit_id":"f441ee55c6f99a099fe1a68a6cfa486fd522554f"}]}