)]}'
{"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"0fec3691a2a3cc5e49e18117e5d08368d09e30ff","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        mock_last.assert_called_once_with()"},{"line_number":659,"context_line":"        mock_get_host.assert_called_once_with(ctxt, \u0027fake-mini\u0027,"},{"line_number":660,"context_line":"                                              use_slave\u003dTrue)"},{"line_number":661,"context_line":"        mock_time.assert_has_calls([mock.call(), mock.call(), mock.call()])"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"    @mock.patch.object(objects.InstanceList, \u0027get_by_host\u0027)"},{"line_number":664,"context_line":"    @mock.patch.object(objects.BlockDeviceMappingList,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_d2e4f3ad","line":661,"updated":"2016-10-18 01:12:10.000000000","message":"Are the number of time calls relevant for this test? Does it add more confidence in the code under test?","commit_id":"9c12c8b7507bd30f98c6f916be9cc5b39afc428c"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"634cb88df86e790e242a6b81397eefe77332e728","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        mock_last.assert_called_once_with()"},{"line_number":659,"context_line":"        mock_get_host.assert_called_once_with(ctxt, \u0027fake-mini\u0027,"},{"line_number":660,"context_line":"                                              use_slave\u003dTrue)"},{"line_number":661,"context_line":"        mock_time.assert_has_calls([mock.call(), mock.call(), mock.call()])"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"    @mock.patch.object(objects.InstanceList, \u0027get_by_host\u0027)"},{"line_number":664,"context_line":"    @mock.patch.object(objects.BlockDeviceMappingList,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_ca0b417c","line":661,"in_reply_to":"fa6399be_25932751","updated":"2016-10-18 14:20:44.000000000","message":"Sure, but we don\u0027t always need to assert on each mock. The goal should be confidence in the code under test, and a clear story (in the form of a concise test).","commit_id":"9c12c8b7507bd30f98c6f916be9cc5b39afc428c"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"4d8c95fe150849a1163507347a192c82b30a8fe1","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        mock_last.assert_called_once_with()"},{"line_number":659,"context_line":"        mock_get_host.assert_called_once_with(ctxt, \u0027fake-mini\u0027,"},{"line_number":660,"context_line":"                                              use_slave\u003dTrue)"},{"line_number":661,"context_line":"        mock_time.assert_has_calls([mock.call(), mock.call(), mock.call()])"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"    @mock.patch.object(objects.InstanceList, \u0027get_by_host\u0027)"},{"line_number":664,"context_line":"    @mock.patch.object(objects.BlockDeviceMappingList,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_25932751","line":661,"in_reply_to":"fa6399be_d2e4f3ad","updated":"2016-10-18 01:45:33.000000000","message":"yes, side_effect of mock_time was called 3 times, that\u0027s why we need this check.","commit_id":"9c12c8b7507bd30f98c6f916be9cc5b39afc428c"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"aad3b0c5ea3fc3d50d01480451092c72dda84281","unresolved":false,"context_lines":[{"line_number":4054,"context_line":""},{"line_number":4055,"context_line":"        _do_test()"},{"line_number":4056,"context_line":""},{"line_number":4057,"context_line":"    @mock.patch.object(compute_manager.ComputeManager, \u0027_deallocate_network\u0027)"},{"line_number":4058,"context_line":"    @mock.patch.object(fake.FakeDriver, \u0027destroy\u0027)"},{"line_number":4059,"context_line":"    def test_delete_instance_keeps_net_on_power_off_fail(self, mock_destroy,"},{"line_number":4060,"context_line":"                                                         mock_deallocate):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_6e9ef764","line":4057,"range":{"start_line":4057,"start_character":55,"end_line":4057,"end_character":77},"updated":"2016-10-17 15:21:08.000000000","message":"Why was this mock added? Was is for symmetry with the test below it?","commit_id":"9c12c8b7507bd30f98c6f916be9cc5b39afc428c"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"be1decdb3897c0a15f01e0b56982e06b468f3abe","unresolved":false,"context_lines":[{"line_number":4054,"context_line":""},{"line_number":4055,"context_line":"        _do_test()"},{"line_number":4056,"context_line":""},{"line_number":4057,"context_line":"    @mock.patch.object(compute_manager.ComputeManager, \u0027_deallocate_network\u0027)"},{"line_number":4058,"context_line":"    @mock.patch.object(fake.FakeDriver, \u0027destroy\u0027)"},{"line_number":4059,"context_line":"    def test_delete_instance_keeps_net_on_power_off_fail(self, mock_destroy,"},{"line_number":4060,"context_line":"                                                         mock_deallocate):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_b2d93f86","line":4057,"range":{"start_line":4057,"start_character":55,"end_line":4057,"end_character":77},"in_reply_to":"fa6399be_6e9ef764","updated":"2016-10-18 00:54:15.000000000","message":"yes, it was","commit_id":"9c12c8b7507bd30f98c6f916be9cc5b39afc428c"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"4d8c95fe150849a1163507347a192c82b30a8fe1","unresolved":false,"context_lines":[{"line_number":4054,"context_line":""},{"line_number":4055,"context_line":"        _do_test()"},{"line_number":4056,"context_line":""},{"line_number":4057,"context_line":"    @mock.patch.object(compute_manager.ComputeManager, \u0027_deallocate_network\u0027)"},{"line_number":4058,"context_line":"    @mock.patch.object(fake.FakeDriver, \u0027destroy\u0027)"},{"line_number":4059,"context_line":"    def test_delete_instance_keeps_net_on_power_off_fail(self, mock_destroy,"},{"line_number":4060,"context_line":"                                                         mock_deallocate):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_a59f374f","line":4057,"range":{"start_line":4057,"start_character":55,"end_line":4057,"end_character":77},"in_reply_to":"fa6399be_92da7be8","updated":"2016-10-18 01:45:33.000000000","message":"hm, I think I need to recheck this patch again. will leave the comment here after all, thanks.","commit_id":"9c12c8b7507bd30f98c6f916be9cc5b39afc428c"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"0fec3691a2a3cc5e49e18117e5d08368d09e30ff","unresolved":false,"context_lines":[{"line_number":4054,"context_line":""},{"line_number":4055,"context_line":"        _do_test()"},{"line_number":4056,"context_line":""},{"line_number":4057,"context_line":"    @mock.patch.object(compute_manager.ComputeManager, \u0027_deallocate_network\u0027)"},{"line_number":4058,"context_line":"    @mock.patch.object(fake.FakeDriver, \u0027destroy\u0027)"},{"line_number":4059,"context_line":"    def test_delete_instance_keeps_net_on_power_off_fail(self, mock_destroy,"},{"line_number":4060,"context_line":"                                                         mock_deallocate):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_92da7be8","line":4057,"range":{"start_line":4057,"start_character":55,"end_line":4057,"end_character":77},"in_reply_to":"fa6399be_b2d93f86","updated":"2016-10-18 01:12:10.000000000","message":"As a reviewer, it\u0027s hard to guess why each of these changes was made. Perhaps add gerrit comments (not code comments) to help the reviewers?","commit_id":"9c12c8b7507bd30f98c6f916be9cc5b39afc428c"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"0fec3691a2a3cc5e49e18117e5d08368d09e30ff","unresolved":false,"context_lines":[{"line_number":5482,"context_line":"        # Confirm that no exception is raised if there is no fixed ip on"},{"line_number":5483,"context_line":"        # pre_live_migration"},{"line_number":5484,"context_line":"        self.compute.driver.pre_live_migration("},{"line_number":5485,"context_line":"            None, None, {\u0027block_device_mapping\u0027: []}, None, None, None)"},{"line_number":5486,"context_line":""},{"line_number":5487,"context_line":"    @mock.patch.object(network_api.API, \u0027setup_networks_on_host\u0027)"},{"line_number":5488,"context_line":"    @mock.patch.object(fake.FakeDriver, \u0027ensure_filtering_rules_for_instance\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_32f28f70","line":5485,"updated":"2016-10-18 01:12:10.000000000","message":"I gather from a different note that this is a case of: \"more is less\".","commit_id":"9c12c8b7507bd30f98c6f916be9cc5b39afc428c"}]}