)]}'
{"nova/compute/api.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"738bcdaddbdacc575e7d820cc526fab8a9e92e5a","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"            old_flavor \u003d instance.old_flavor"},{"line_number":1716,"context_line":"            instance_vcpus \u003d old_flavor.vcpus"},{"line_number":1717,"context_line":"            vram_mb \u003d old_flavor.extra_specs.get(\u0027hw_video:ram_max_mb\u0027, 0)"},{"line_number":1718,"context_line":"            instance_memory_mb \u003d old_flavor.memory_mb + vram_mb"},{"line_number":1719,"context_line":"        else:"},{"line_number":1720,"context_line":"            instance_vcpus \u003d instance.flavor.vcpus"},{"line_number":1721,"context_line":"            instance_memory_mb \u003d instance.flavor.memory_mb"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_eb7120e2","line":1718,"updated":"2016-07-18 05:57:12.000000000","message":"Guh. So we track this \"video ram\" stuff only during migrations? ...","commit_id":"af11fb4d6f4b22eaf6657db0803d0c76e9739901"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e75cc1e5160824b48c14bb9c059956cc192d96cb","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"            old_flavor \u003d instance.old_flavor"},{"line_number":1716,"context_line":"            instance_vcpus \u003d old_flavor.vcpus"},{"line_number":1717,"context_line":"            vram_mb \u003d old_flavor.extra_specs.get(\u0027hw_video:ram_max_mb\u0027, 0)"},{"line_number":1718,"context_line":"            instance_memory_mb \u003d old_flavor.memory_mb + vram_mb"},{"line_number":1719,"context_line":"        else:"},{"line_number":1720,"context_line":"            instance_vcpus \u003d instance.flavor.vcpus"},{"line_number":1721,"context_line":"            instance_memory_mb \u003d instance.flavor.memory_mb"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_46ac9aed","line":1718,"in_reply_to":"dada55a8_eb7120e2","updated":"2016-07-18 10:14:10.000000000","message":"that looks like total nonsense anyways :(","commit_id":"af11fb4d6f4b22eaf6657db0803d0c76e9739901"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"738bcdaddbdacc575e7d820cc526fab8a9e92e5a","unresolved":false,"context_lines":[{"line_number":980,"context_line":"        elif isinstance(object_or_dict, objects.Flavor):"},{"line_number":981,"context_line":"            usage \u003d obj_base.obj_to_primitive(object_or_dict)"},{"line_number":982,"context_line":"        else:"},{"line_number":983,"context_line":"            usage.update(object_or_dict)"},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"        for key in (\u0027numa_topology\u0027,):"},{"line_number":986,"context_line":"            if key in updates:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_0b6d9404","line":983,"updated":"2016-07-18 05:57:12.000000000","message":"Hmm, we should be able to remove this particular line at this point (after fixing all the corresponding unit test failures of course...)","commit_id":"af11fb4d6f4b22eaf6657db0803d0c76e9739901"}],"nova/tests/unit/compute/test_claims.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5b556b4c8c17c5b6419784fc740e1080d1029e2f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            \u0027ephemeral_gb\u0027: 5,"},{"line_number":105,"context_line":"            \u0027vcpus\u0027: 1,"},{"line_number":106,"context_line":"            \u0027system_metadata\u0027: {},"},{"line_number":107,"context_line":"            \u0027numa_topology\u0027: None"},{"line_number":108,"context_line":"        }"},{"line_number":109,"context_line":"        instance.update(**kwargs)"},{"line_number":110,"context_line":"        return fake_instance.fake_instance_obj(self.context, **instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_586ae3b3","line":107,"updated":"2016-07-13 14:29:28.000000000","message":"It must match these. Well, actually it doesn\u0027t need to match these, but these are what the test was testing, so the tests are expecting these values :)","commit_id":"af11fb4d6f4b22eaf6657db0803d0c76e9739901"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"27cbecd138f8552747ed321968ffe876046deac0","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        instance_type \u003d {"},{"line_number":114,"context_line":"            \u0027id\u0027: 1,"},{"line_number":115,"context_line":"            \u0027name\u0027: \u0027fakeitype\u0027,"},{"line_number":116,"context_line":"            \u0027memory_mb\u0027: 1024,"},{"line_number":117,"context_line":"            \u0027vcpus\u0027: 1,"},{"line_number":118,"context_line":"            \u0027root_gb\u0027: 10,"},{"line_number":119,"context_line":"            \u0027ephemeral_gb\u0027: 5"},{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":"        instance_type.update(**kwargs)"},{"line_number":122,"context_line":"        return objects.Flavor(**instance_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_ec9de366","line":119,"range":{"start_line":116,"start_character":0,"end_line":119,"end_character":29},"updated":"2016-07-13 10:58:41.000000000","message":"out of curiosity, that is just because the original were unrealistic?","commit_id":"af11fb4d6f4b22eaf6657db0803d0c76e9739901"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"9ed9c49ad605026b5b2f0f8b3935cfd202ce3a7f","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        instance_type \u003d {"},{"line_number":114,"context_line":"            \u0027id\u0027: 1,"},{"line_number":115,"context_line":"            \u0027name\u0027: \u0027fakeitype\u0027,"},{"line_number":116,"context_line":"            \u0027memory_mb\u0027: 1024,"},{"line_number":117,"context_line":"            \u0027vcpus\u0027: 1,"},{"line_number":118,"context_line":"            \u0027root_gb\u0027: 10,"},{"line_number":119,"context_line":"            \u0027ephemeral_gb\u0027: 5"},{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":"        instance_type.update(**kwargs)"},{"line_number":122,"context_line":"        return objects.Flavor(**instance_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_d25fcfe2","line":119,"range":{"start_line":116,"start_character":0,"end_line":119,"end_character":29},"in_reply_to":"1aa78d24_5d9815c0","updated":"2016-07-13 15:40:54.000000000","message":"gotcha, thanks for the explanation.","commit_id":"af11fb4d6f4b22eaf6657db0803d0c76e9739901"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5b556b4c8c17c5b6419784fc740e1080d1029e2f","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        instance_type \u003d {"},{"line_number":114,"context_line":"            \u0027id\u0027: 1,"},{"line_number":115,"context_line":"            \u0027name\u0027: \u0027fakeitype\u0027,"},{"line_number":116,"context_line":"            \u0027memory_mb\u0027: 1024,"},{"line_number":117,"context_line":"            \u0027vcpus\u0027: 1,"},{"line_number":118,"context_line":"            \u0027root_gb\u0027: 10,"},{"line_number":119,"context_line":"            \u0027ephemeral_gb\u0027: 5"},{"line_number":120,"context_line":"        }"},{"line_number":121,"context_line":"        instance_type.update(**kwargs)"},{"line_number":122,"context_line":"        return objects.Flavor(**instance_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_5d9815c0","line":119,"range":{"start_line":116,"start_character":0,"end_line":119,"end_character":29},"in_reply_to":"1aa78d24_ec9de366","updated":"2016-07-13 14:29:28.000000000","message":"No, because before these were different than what was on the instance, but were ignored for the test. Since they\u0027re now used by the test, I changed these to match, else the test comparison would fail. See above, L107.","commit_id":"af11fb4d6f4b22eaf6657db0803d0c76e9739901"}]}