)]}'
{"nova/tests/unit/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"375b32ab0fe2c70df7099db868dd6deee28d7bea","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"        flavor \u003d fake_flavor.fake_flavor_obj(self.context, root_gb\u003d0,"},{"line_number":1753,"context_line":"                                             ephemeral_gb\u003d0)"},{"line_number":1754,"context_line":"        instance \u003d self._create_instance(root_gb\u003d0, ephemeral_gb\u003d0)"},{"line_number":1755,"context_line":"        instance.flavor.root_gb \u003d 0"},{"line_number":1756,"context_line":"        instance.flavor.ephemeral_gb \u003d 0"},{"line_number":1757,"context_line":"        xenapi_fake.create_vm(instance[\u0027name\u0027], \u0027Running\u0027)"},{"line_number":1758,"context_line":"        conn \u003d xenapi_conn.XenAPIDriver(fake.FakeVirtAPI(), False)"},{"line_number":1759,"context_line":"        vm_ref \u003d vm_utils.lookup(conn._session, instance[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_f10f4e89","line":1756,"range":{"start_line":1755,"start_character":8,"end_line":1756,"end_character":40},"updated":"2016-07-14 01:24:54.000000000","message":"self._creat_instance() has already set root_gb and ephemeral_gb, so seems the two lines are not needed?","commit_id":"0353b43aaec4fb49a042859401d853e9835a2bad"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f6012e7dfbe4d98bbc2a6f96dbb3cc1e845dd18b","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"        flavor \u003d fake_flavor.fake_flavor_obj(self.context, root_gb\u003d0,"},{"line_number":1753,"context_line":"                                             ephemeral_gb\u003d0)"},{"line_number":1754,"context_line":"        instance \u003d self._create_instance(root_gb\u003d0, ephemeral_gb\u003d0)"},{"line_number":1755,"context_line":"        instance.flavor.root_gb \u003d 0"},{"line_number":1756,"context_line":"        instance.flavor.ephemeral_gb \u003d 0"},{"line_number":1757,"context_line":"        xenapi_fake.create_vm(instance[\u0027name\u0027], \u0027Running\u0027)"},{"line_number":1758,"context_line":"        conn \u003d xenapi_conn.XenAPIDriver(fake.FakeVirtAPI(), False)"},{"line_number":1759,"context_line":"        vm_ref \u003d vm_utils.lookup(conn._session, instance[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_2c20659b","line":1756,"range":{"start_line":1755,"start_character":8,"end_line":1756,"end_character":40},"in_reply_to":"1aa78d24_be771307","updated":"2016-07-18 10:38:34.000000000","message":"this is needed, I think, because the flavor is not passed into create_instance.","commit_id":"0353b43aaec4fb49a042859401d853e9835a2bad"},{"author":{"_account_id":17922,"name":"Huan Xie","email":"huan.xie@citrix.com","username":"huan"},"change_message_id":"ba88ed18f4856da4270f86d5438d42b8df4a9c5f","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"        flavor \u003d fake_flavor.fake_flavor_obj(self.context, root_gb\u003d0,"},{"line_number":1753,"context_line":"                                             ephemeral_gb\u003d0)"},{"line_number":1754,"context_line":"        instance \u003d self._create_instance(root_gb\u003d0, ephemeral_gb\u003d0)"},{"line_number":1755,"context_line":"        instance.flavor.root_gb \u003d 0"},{"line_number":1756,"context_line":"        instance.flavor.ephemeral_gb \u003d 0"},{"line_number":1757,"context_line":"        xenapi_fake.create_vm(instance[\u0027name\u0027], \u0027Running\u0027)"},{"line_number":1758,"context_line":"        conn \u003d xenapi_conn.XenAPIDriver(fake.FakeVirtAPI(), False)"},{"line_number":1759,"context_line":"        vm_ref \u003d vm_utils.lookup(conn._session, instance[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_be771307","line":1756,"range":{"start_line":1755,"start_character":8,"end_line":1756,"end_character":40},"in_reply_to":"1aa78d24_c307da1b","updated":"2016-07-15 05:02:35.000000000","message":"ah, I see. root_gb\u003d0 in #1754 is not used for flavor\u0027s root_gb, its default root_gb is 80. So #1755 is needed. Thanks","commit_id":"0353b43aaec4fb49a042859401d853e9835a2bad"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"09220969a6e67e266a0856fd682458bf2a6a2831","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"        flavor \u003d fake_flavor.fake_flavor_obj(self.context, root_gb\u003d0,"},{"line_number":1753,"context_line":"                                             ephemeral_gb\u003d0)"},{"line_number":1754,"context_line":"        instance \u003d self._create_instance(root_gb\u003d0, ephemeral_gb\u003d0)"},{"line_number":1755,"context_line":"        instance.flavor.root_gb \u003d 0"},{"line_number":1756,"context_line":"        instance.flavor.ephemeral_gb \u003d 0"},{"line_number":1757,"context_line":"        xenapi_fake.create_vm(instance[\u0027name\u0027], \u0027Running\u0027)"},{"line_number":1758,"context_line":"        conn \u003d xenapi_conn.XenAPIDriver(fake.FakeVirtAPI(), False)"},{"line_number":1759,"context_line":"        vm_ref \u003d vm_utils.lookup(conn._session, instance[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_c307da1b","line":1756,"range":{"start_line":1755,"start_character":8,"end_line":1756,"end_character":40},"in_reply_to":"1aa78d24_f10f4e89","updated":"2016-07-14 10:08:18.000000000","message":"you are right are created with root_gb\u003d80 and ephmeral_gb\u003d0, in this test we want to have the root_gb equals to 0, so I think that those lines are required (at least #1755) to set the values required for the test.","commit_id":"0353b43aaec4fb49a042859401d853e9835a2bad"}]}