)]}'
{"nova/conf/network.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"92b3aa86e127f7219b09976eb791ce8b0c3c819d","unresolved":false,"context_lines":[{"line_number":755,"context_line":""},{"line_number":756,"context_line":"The default Linux driver implements vlans, bridges, and iptables rules"},{"line_number":757,"context_line":"using linux utilities."},{"line_number":758,"context_line":"\"\"\")"},{"line_number":759,"context_line":"]"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"rpcapi_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_ec0c8596","line":758,"updated":"2016-09-23 11:00:12.000000000","message":"So these are all only used with nova-network, I believe.\n\nWe should say about use_neutron as a related option, which a note saying these only apply to nova-network.","commit_id":"976e29e6d9c50214afe5735aa40cca8ce93bbaac"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"e5c47b363cfa979b9baaf4782251731ad00ff1f5","unresolved":false,"context_lines":[{"line_number":755,"context_line":""},{"line_number":756,"context_line":"The default Linux driver implements vlans, bridges, and iptables rules"},{"line_number":757,"context_line":"using linux utilities."},{"line_number":758,"context_line":"\"\"\")"},{"line_number":759,"context_line":"]"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"rpcapi_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_76ff4467","line":758,"in_reply_to":"5a8bc5a2_ec0c8596","updated":"2016-09-23 22:23:19.000000000","message":"Done","commit_id":"976e29e6d9c50214afe5735aa40cca8ce93bbaac"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b35d76fc3b06e93a7497afa6f471f910cec6dda7","unresolved":false,"context_lines":[{"line_number":765,"context_line":"]"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"rpcapi_opts \u003d ["},{"line_number":768,"context_line":"    cfg.StrOpt(\u0027network_topic\u0027,"},{"line_number":769,"context_line":"               default\u003d\u0027network\u0027,"},{"line_number":770,"context_line":"               help\u003d\"\"\""},{"line_number":771,"context_line":"The topic network nodes listen on"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"This is the message queue topic that the network service \u0027listens\u0027 on. It is"},{"line_number":774,"context_line":"used when the network service is started up to configure the queue, and"},{"line_number":775,"context_line":"whenever an RPC call to the network service is made."},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"Please note that this option is only used when using nova-network instead of"},{"line_number":778,"context_line":"Neutron in your deployment."},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"Related options:"},{"line_number":781,"context_line":"    ``use_neutron``"},{"line_number":782,"context_line":"\"\"\"),"},{"line_number":783,"context_line":"    cfg.BoolOpt(\u0027multi_host\u0027,"},{"line_number":784,"context_line":"                default\u003dFalse,"},{"line_number":785,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_2dbb1274","line":782,"range":{"start_line":768,"start_character":0,"end_line":782,"end_character":5},"updated":"2016-09-28 15:54:20.000000000","message":"Shouldn\u0027t this be deprecated now? It\u0027s both (a) a configurable topic option and (b) a nova-net option. Both features are deprecated.","commit_id":"a8e1ef33cc58efcaaa3915a2c62742d5926ae1ce"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"42bb040d295815a94176dd80db6761b0b8f5c7b1","unresolved":false,"context_lines":[{"line_number":799,"context_line":"Neutron in your deployment."},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"Related options:"},{"line_number":802,"context_line":"    ``use_neutron``"},{"line_number":803,"context_line":"\"\"\")"},{"line_number":804,"context_line":"]"},{"line_number":805,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_14db0a1c","line":802,"range":{"start_line":802,"start_character":0,"end_line":802,"end_character":19},"updated":"2016-09-26 19:49:46.000000000","message":"The proper styling is (applies also to above opts):\n\nRelated options:\n\n* ``use_neutron``","commit_id":"a8e1ef33cc58efcaaa3915a2c62742d5926ae1ce"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"37082f4e22183c29c6dd77911cd3cfa0d13c5dce","unresolved":false,"context_lines":[{"line_number":799,"context_line":"Neutron in your deployment."},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"Related options:"},{"line_number":802,"context_line":"    ``use_neutron``"},{"line_number":803,"context_line":"\"\"\")"},{"line_number":804,"context_line":"]"},{"line_number":805,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_cd7984fe","line":802,"range":{"start_line":802,"start_character":0,"end_line":802,"end_character":19},"in_reply_to":"3a98d1f4_6da0ba91","updated":"2016-09-29 17:41:17.000000000","message":"ya..may be we can have a followup patch that checks for consistency. For now, tags for opt_description is not removed in this patch. Followup patch can address this and remove all the tags.","commit_id":"a8e1ef33cc58efcaaa3915a2c62742d5926ae1ce"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"d96d919f5b27ed0648ed40a6568a1006665ab486","unresolved":false,"context_lines":[{"line_number":799,"context_line":"Neutron in your deployment."},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"Related options:"},{"line_number":802,"context_line":"    ``use_neutron``"},{"line_number":803,"context_line":"\"\"\")"},{"line_number":804,"context_line":"]"},{"line_number":805,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a8bc5a2_ffe552dc","line":802,"range":{"start_line":802,"start_character":0,"end_line":802,"end_character":19},"in_reply_to":"5a8bc5a2_14db0a1c","updated":"2016-09-27 21:40:21.000000000","message":"None of the options in this file has this styling. May be for consistency, we can leave it IMO.","commit_id":"a8e1ef33cc58efcaaa3915a2c62742d5926ae1ce"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b35d76fc3b06e93a7497afa6f471f910cec6dda7","unresolved":false,"context_lines":[{"line_number":799,"context_line":"Neutron in your deployment."},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"Related options:"},{"line_number":802,"context_line":"    ``use_neutron``"},{"line_number":803,"context_line":"\"\"\")"},{"line_number":804,"context_line":"]"},{"line_number":805,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_6da0ba91","line":802,"range":{"start_line":802,"start_character":0,"end_line":802,"end_character":19},"in_reply_to":"5a8bc5a2_ffe552dc","updated":"2016-09-28 15:54:20.000000000","message":"True, but perhaps it\u0027d be good to see a follow-up patch which fixes this first?","commit_id":"a8e1ef33cc58efcaaa3915a2c62742d5926ae1ce"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4fea7fb7c9d40230fd383231ef5b81a445fe9ca7","unresolved":false,"context_lines":[{"line_number":791,"context_line":"If this options is set to true, some rpc network calls will be sent directly"},{"line_number":792,"context_line":"to host."},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"Please note that this option is only used when using nova-network instead of"},{"line_number":795,"context_line":"Neutron in your deployment."},{"line_number":796,"context_line":""},{"line_number":797,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a95cdbc_33754a63","line":794,"range":{"start_line":794,"start_character":0,"end_line":794,"end_character":6},"updated":"2016-10-10 18:12:32.000000000","message":"nit: please don\u0027t use please :) [1]\n\n[1] http://docs.openstack.org/contributor-guide/writing-style/general-writing-guidelines.html#eliminate-needless-politeness","commit_id":"6f6b72b9c1c50af3a41c3340152266bc64e512ff"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1c102efe685b91e48b6905f2ef2c29227346f582","unresolved":false,"context_lines":[{"line_number":765,"context_line":"Please note that this option is only used when using nova-network instead"},{"line_number":766,"context_line":"of Neutron in your deployment."},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"Related options:"},{"line_number":769,"context_line":"    ``use_neutron``"},{"line_number":770,"context_line":"\"\"\")"},{"line_number":771,"context_line":"]"},{"line_number":772,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a629dbe_9780db8c","line":769,"range":{"start_line":768,"start_character":0,"end_line":769,"end_character":19},"updated":"2016-11-11 17:40:39.000000000","message":"This is not a proper formatting. Add empty line between header and the list. All items on the list should have an prepending asterisk.\n\nCurrent formatting causes the item to be wrapped with the blockquote HTML tag.\n\nExample of correct formatting: https://github.com/openstack/nova/blob/master/nova/conf/api.py#L126..L135","commit_id":"702f3594a20e24f415bb5575223b5913325a384c"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"26e4ea88faf7aa070da0e28db159da33c3eecfe5","unresolved":false,"context_lines":[{"line_number":762,"context_line":"The default Linux driver implements vlans, bridges, and iptables rules"},{"line_number":763,"context_line":"using linux utilities."},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"Please note that this option is only used when using nova-network instead"},{"line_number":766,"context_line":"of Neutron in your deployment."},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"Related options:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a77a97e_bf27e910","line":765,"range":{"start_line":765,"start_character":0,"end_line":765,"end_character":11},"updated":"2016-11-16 19:55:04.000000000","message":"nit: Note","commit_id":"e9dd4b017ced6ff694bd7c51e82c63c0814d8c6f"}]}