)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7ecd01b6f260fb91fb65e2774fa01bfc85247c0a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Andreas Jaeger \u003caj@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-13 13:39:47 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move doc linting to pep8"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The docs job is not run in the gate, add the linting command from"},{"line_number":10,"context_line":"the docs environment to the pep8 so that jobs run it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_e3d63226","line":7,"updated":"2016-08-09 10:58:02.000000000","message":"Its not really proper doc linting, its just checking all the json files in tree is valid json, I think?\n\ni.e. this doesn\u0027t validate rst, AFAIK.","commit_id":"9e7e23364a357869ecdd655bee6d381a010327ff"}],"tox.ini":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"2e4031e936fa6ad27230c7e75f89d67ebd98fd85","unresolved":false,"context_lines":[{"line_number":27,"context_line":"deps \u003d hacking"},{"line_number":28,"context_line":"commands \u003d"},{"line_number":29,"context_line":"  bash tools/flake8wrap.sh {posargs}"},{"line_number":30,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"[testenv:py34]"},{"line_number":33,"context_line":"# NOTE(mriedem): If py34 fails with \"db type could not be determined\", delete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1aa78d24_d62fd1f3","line":30,"range":{"start_line":30,"start_character":18,"end_line":30,"end_character":22},"updated":"2016-07-13 12:00:46.000000000","message":"Does it make sense to use {posargs} for that?","commit_id":"9e7e23364a357869ecdd655bee6d381a010327ff"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4786f6aa2781764369469f2835251190433c3931","unresolved":false,"context_lines":[{"line_number":27,"context_line":"deps \u003d hacking"},{"line_number":28,"context_line":"commands \u003d"},{"line_number":29,"context_line":"  bash tools/flake8wrap.sh {posargs}"},{"line_number":30,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"[testenv:py34]"},{"line_number":33,"context_line":"# NOTE(mriedem): If py34 fails with \"db type could not be determined\", delete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1aa78d24_d41ea9b9","line":30,"range":{"start_line":30,"start_character":18,"end_line":30,"end_character":22},"in_reply_to":"1aa78d24_3658d589","updated":"2016-07-13 12:37:39.000000000","message":"True, in the gate I want to check all. I was thinking about a (premature?) optimization when I execute it locally.","commit_id":"9e7e23364a357869ecdd655bee6d381a010327ff"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7ecd01b6f260fb91fb65e2774fa01bfc85247c0a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"deps \u003d hacking"},{"line_number":28,"context_line":"commands \u003d"},{"line_number":29,"context_line":"  bash tools/flake8wrap.sh {posargs}"},{"line_number":30,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"[testenv:py34]"},{"line_number":33,"context_line":"# NOTE(mriedem): If py34 fails with \"db type could not be determined\", delete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9ad45d7e_e308f2db","line":30,"range":{"start_line":30,"start_character":18,"end_line":30,"end_character":22},"in_reply_to":"1aa78d24_d41ea9b9","updated":"2016-08-09 10:58:02.000000000","message":"To me this just looks like magic goop.\n\nCould we add a comment that says what this magic is doing? Even if it just says validate json files are all valid json.","commit_id":"9e7e23364a357869ecdd655bee6d381a010327ff"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"8070eb8f411a4f376204638c3ec992bacb793b2e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"deps \u003d hacking"},{"line_number":28,"context_line":"commands \u003d"},{"line_number":29,"context_line":"  bash tools/flake8wrap.sh {posargs}"},{"line_number":30,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"[testenv:py34]"},{"line_number":33,"context_line":"# NOTE(mriedem): If py34 fails with \"db type could not be determined\", delete"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1aa78d24_3658d589","line":30,"range":{"start_line":30,"start_character":18,"end_line":30,"end_character":22},"in_reply_to":"1aa78d24_d62fd1f3","updated":"2016-07-13 12:02:40.000000000","message":"It won\u0027t be expand by \"tox -e pep8\" as run in the gate, so I would leave it as is.","commit_id":"9e7e23364a357869ecdd655bee6d381a010327ff"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dfcaabf1287075bcc6f3582a911d1913ce546032","unresolved":false,"context_lines":[{"line_number":95,"context_line":"commands \u003d"},{"line_number":96,"context_line":"  rm -rf doc/source/api doc/build api-guide/build api-ref/build"},{"line_number":97,"context_line":"  python setup.py build_sphinx"},{"line_number":98,"context_line":"  bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027"},{"line_number":99,"context_line":"  oslo-config-generator --config-file\u003detc/nova/nova-config-generator.conf"},{"line_number":100,"context_line":"  oslopolicy-sample-generator --config-file\u003detc/nova/nova-policy-generator.conf"},{"line_number":101,"context_line":"  sphinx-build -W -b html api-guide/source api-guide/build/html"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9ad45d7e_c3f20ed2","line":98,"updated":"2016-08-09 10:58:36.000000000","message":"Not a massive fan of cut and paste, but probably needed here I guess :(","commit_id":"9e7e23364a357869ecdd655bee6d381a010327ff"}]}
