)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"58874c5b1cb0663b73dce5f8558a9779a500627d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mauro S. M. Rodrigues \u003cmaurosr@linux.vnet.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-06-24 10:08:59 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix to integet cast of length in console output extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fixes a small issue when you try to use console output length as a"},{"line_number":10,"context_line":"float point value (as a float point itself not as string)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAPn%2F%2FhKo%3D","line":7,"updated":"2013-06-28 17:06:47.000000000","message":"s/integet/integer/","commit_id":"70ff7d4b048a3a93fcd29537fb8daf2a524c4afa"}],"nova/api/openstack/compute/contrib/console_output.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"f46b35af9541637cfbc3610e5debd3be32e7a9c8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                # integer to avoid thing like: int(2.5) which is 2 instead of"},{"line_number":57,"context_line":"                # raise ValueError like it would when we try int(\"2.5\"). This"},{"line_number":58,"context_line":"                # can be removed once we have api validation landed."},{"line_number":59,"context_line":"                int(str(length))"},{"line_number":60,"context_line":"            except ValueError:"},{"line_number":61,"context_line":"                raise webob.exc.HTTPBadRequest(_(\u0027Length in request body must \u0027"},{"line_number":62,"context_line":"                                                 \u0027be an integer value\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fr%2FU%3D","line":59,"updated":"2013-06-25 08:46:26.000000000","message":"why not be explicit and check for isinstance(n, int)?","commit_id":"70ff7d4b048a3a93fcd29537fb8daf2a524c4afa"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d98d87c5cb55c92676684eee7564378834aab391","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                # integer to avoid thing like: int(2.5) which is 2 instead of"},{"line_number":57,"context_line":"                # raise ValueError like it would when we try int(\"2.5\"). This"},{"line_number":58,"context_line":"                # can be removed once we have api validation landed."},{"line_number":59,"context_line":"                int(str(length))"},{"line_number":60,"context_line":"            except ValueError:"},{"line_number":61,"context_line":"                raise webob.exc.HTTPBadRequest(_(\u0027Length in request body must \u0027"},{"line_number":62,"context_line":"                                                 \u0027be an integer value\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fr9U%3D","line":59,"in_reply_to":"AAAAPn%2F%2Fr%2FU%3D","updated":"2013-06-25 09:04:16.000000000","message":"IIUC, the above code can check not only integer but also string integer(e.g. \"10\") by single line.\nisinstance(n, int) cannot do it.","commit_id":"70ff7d4b048a3a93fcd29537fb8daf2a524c4afa"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"8b70f14bcec5d66dface48a5f874282f1890b092","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                # integer to avoid thing like: int(2.5) which is 2 instead of"},{"line_number":57,"context_line":"                # raise ValueError like it would when we try int(\"2.5\"). This"},{"line_number":58,"context_line":"                # can be removed once we have api validation landed."},{"line_number":59,"context_line":"                int(str(length))"},{"line_number":60,"context_line":"            except ValueError:"},{"line_number":61,"context_line":"                raise webob.exc.HTTPBadRequest(_(\u0027Length in request body must \u0027"},{"line_number":62,"context_line":"                                                 \u0027be an integer value\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fr8Q%3D","line":59,"in_reply_to":"AAAAPn%2F%2Fr9U%3D","updated":"2013-06-25 09:13:28.000000000","message":"So it will ensure it\u0027s a string before casting - which will fail for non-integers... aaaaah I guess it\u0027s OK - I\u0027d prefer to be sure what we get from the de-serializer, but as the comment said - there is bp in porgress for that...","commit_id":"70ff7d4b048a3a93fcd29537fb8daf2a524c4afa"}],"nova/tests/api/openstack/compute/contrib/test_console_output.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"fca6df975b39c87d543c2e55310c384e09161418","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":150,"context_line":"        self.assertEqual(res.status_int, 409)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def test_get_console_output_with_lenght_as_float(self):"},{"line_number":153,"context_line":"        body \u003d {\u0027os-getConsoleOutput\u0027: {\u0027length\u0027: 2.5}}"},{"line_number":154,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/servers/1/action\u0027)"},{"line_number":155,"context_line":"        req.method \u003d \"POST\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FbIQ%3D","line":152,"updated":"2013-07-02 09:21:47.000000000","message":"lenght -\u003e length","commit_id":"94a396acd1920f68bca5ffcc3523fdcd2cd55324"}]}