)]}'
{"nova/conf/network.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"5bbb07a3ee8033bff3633db8f38911529b376c5c","unresolved":false,"context_lines":[{"line_number":682,"context_line":""},{"line_number":683,"context_line":"* Any valid string representing DN base."},{"line_number":684,"context_line":"\"\"\"),"},{"line_number":685,"context_line":"    cfg.StrOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":686,"context_line":"                default\u003d\u00271800\u0027,"},{"line_number":687,"context_line":"                help\u003d\"\"\""},{"line_number":688,"context_line":"Refresh interval (in seconds) for LDAP DNS driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_151f460a","line":685,"range":{"start_line":685,"start_character":8,"end_line":685,"end_character":14},"updated":"2016-07-14 15:01:29.000000000","message":"If expected value is an integer, this should be IntOpt instead of StrOpt. Please change it in other places as well.","commit_id":"ba7b8a0460968f73a8a6b3c310a22f0b178c99e2"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"4058eb3470a2312280695310bf1d2a9f365ad0ed","unresolved":false,"context_lines":[{"line_number":682,"context_line":""},{"line_number":683,"context_line":"* Any valid string representing DN base."},{"line_number":684,"context_line":"\"\"\"),"},{"line_number":685,"context_line":"    cfg.StrOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":686,"context_line":"                default\u003d\u00271800\u0027,"},{"line_number":687,"context_line":"                help\u003d\"\"\""},{"line_number":688,"context_line":"Refresh interval (in seconds) for LDAP DNS driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_35e16ed1","line":685,"range":{"start_line":685,"start_character":8,"end_line":685,"end_character":14},"in_reply_to":"1aa78d24_151f460a","updated":"2016-07-19 21:46:07.000000000","message":"Thanks for pointing it out. Since this change doesn\u0027t come under scope of this patch, not planning to do any changes as of now. Will put an follow up patch later (if required) to fix this one.","commit_id":"ba7b8a0460968f73a8a6b3c310a22f0b178c99e2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b53da61ba1f371f56c86793feb59903e7bb6534b","unresolved":false,"context_lines":[{"line_number":627,"context_line":""},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"ldap_dns_opts \u003d ["},{"line_number":630,"context_line":"    cfg.StrOpt(\u0027ldap_dns_url\u0027,"},{"line_number":631,"context_line":"                default\u003d\u0027ldap://ldap.example.com:389\u0027,"},{"line_number":632,"context_line":"                help\u003d\"\"\""},{"line_number":633,"context_line":"URL for LDAP server which will store DNS entries"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_8068f588","line":630,"updated":"2016-08-09 16:47:17.000000000","message":"Nit: URI opt would be good here.","commit_id":"df1a17165449dc5ebf4ab4d0ce4b42554a88f254"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b53da61ba1f371f56c86793feb59903e7bb6534b","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                help\u003d\"\"\""},{"line_number":670,"context_line":"DNS Servers for LDAP DNS driver"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"Possible values:"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"* Any valid string representing LDAP DNS server."},{"line_number":675,"context_line":"\"\"\"),"},{"line_number":676,"context_line":"    cfg.StrOpt(\u0027ldap_dns_base_dn\u0027,"},{"line_number":677,"context_line":"                default\u003d\u0027ou\u003dhosts,dc\u003dexample,dc\u003dorg\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_00e1a5fe","line":674,"range":{"start_line":672,"start_character":0,"end_line":674,"end_character":48},"updated":"2016-08-09 16:47:17.000000000","message":"I am not sure all these possible values entries add much. This one seems a bit confusing, giving its a multistringopt, so allows multiple entries.","commit_id":"df1a17165449dc5ebf4ab4d0ce4b42554a88f254"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b53da61ba1f371f56c86793feb59903e7bb6534b","unresolved":false,"context_lines":[{"line_number":680,"context_line":""},{"line_number":681,"context_line":"Possible values:"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"* Any valid string representing DN base."},{"line_number":684,"context_line":"\"\"\"),"},{"line_number":685,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":686,"context_line":"                min\u003d0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_c092ed4a","line":683,"range":{"start_line":683,"start_character":32,"end_line":683,"end_character":40},"updated":"2016-08-09 16:47:17.000000000","message":"Nit: I think we should probably say what the base_dn is used for. I think this helps describe where to search for when looking up the host in LDAP.","commit_id":"df1a17165449dc5ebf4ab4d0ce4b42554a88f254"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b53da61ba1f371f56c86793feb59903e7bb6534b","unresolved":false,"context_lines":[{"line_number":683,"context_line":"* Any valid string representing DN base."},{"line_number":684,"context_line":"\"\"\"),"},{"line_number":685,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":686,"context_line":"                min\u003d0,"},{"line_number":687,"context_line":"                default\u003d1800,"},{"line_number":688,"context_line":"                help\u003d\"\"\""},{"line_number":689,"context_line":"Refresh interval (in seconds) for LDAP DNS driver"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_a021b9fd","line":686,"updated":"2016-08-09 16:47:17.000000000","message":"Lets drop the min value here, till we understand what this really is.","commit_id":"df1a17165449dc5ebf4ab4d0ce4b42554a88f254"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"be4de6792786d036241afcf23fb90f85825b3d30","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                default\u003d3600,"},{"line_number":695,"context_line":"                help\u003d\"\"\""},{"line_number":696,"context_line":"Retry interval (in seconds) for LDAP DNS driver"},{"line_number":697,"context_line":"Statement of Authority"},{"line_number":698,"context_line":"\"\"\"),"},{"line_number":699,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_expiry\u0027,"},{"line_number":700,"context_line":"                min\u003d0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_340c2e94","line":697,"updated":"2016-07-27 21:14:52.000000000","message":"What happens if set to 0, infinite retry or no retry? Worth mentioning that here.","commit_id":"df1a17165449dc5ebf4ab4d0ce4b42554a88f254"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"16b7f41be0f2f0d4e7802b6d1442190a43afb74f","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                default\u003d3600,"},{"line_number":695,"context_line":"                help\u003d\"\"\""},{"line_number":696,"context_line":"Retry interval (in seconds) for LDAP DNS driver"},{"line_number":697,"context_line":"Statement of Authority"},{"line_number":698,"context_line":"\"\"\"),"},{"line_number":699,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_expiry\u0027,"},{"line_number":700,"context_line":"                min\u003d0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_d1e9abb8","line":697,"in_reply_to":"bacf61ea_340c2e94","updated":"2016-08-01 15:34:15.000000000","message":"It\u0027s an interval, not a number of retries. So 0 means no delay between retries.","commit_id":"df1a17165449dc5ebf4ab4d0ce4b42554a88f254"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b53da61ba1f371f56c86793feb59903e7bb6534b","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                default\u003d3600,"},{"line_number":695,"context_line":"                help\u003d\"\"\""},{"line_number":696,"context_line":"Retry interval (in seconds) for LDAP DNS driver"},{"line_number":697,"context_line":"Statement of Authority"},{"line_number":698,"context_line":"\"\"\"),"},{"line_number":699,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_expiry\u0027,"},{"line_number":700,"context_line":"                min\u003d0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_6027c112","line":697,"in_reply_to":"bacf61ea_86e7f4aa","updated":"2016-08-09 16:47:17.000000000","message":"I would simply omit the min value for now.","commit_id":"df1a17165449dc5ebf4ab4d0ce4b42554a88f254"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"5547d76b1183b8772fb8df2d041ae93ff4c580ff","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                default\u003d3600,"},{"line_number":695,"context_line":"                help\u003d\"\"\""},{"line_number":696,"context_line":"Retry interval (in seconds) for LDAP DNS driver"},{"line_number":697,"context_line":"Statement of Authority"},{"line_number":698,"context_line":"\"\"\"),"},{"line_number":699,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_expiry\u0027,"},{"line_number":700,"context_line":"                min\u003d0,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_86e7f4aa","line":697,"in_reply_to":"bacf61ea_d1e9abb8","updated":"2016-08-01 16:36:03.000000000","message":"Hi Maciej,\nThis seems to be interrelated with ldap_dns_soa_refresh interval. I think Raj\u0027s question is a valid one. I read in internet even if no value is set, default value will be assigned by the driver.","commit_id":"df1a17165449dc5ebf4ab4d0ce4b42554a88f254"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8be2eb3899f09afb7d2943f9a3f0e3279f144f47","unresolved":false,"context_lines":[{"line_number":671,"context_line":""},{"line_number":672,"context_line":"Possible values:"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"* A list of strings, where each string represents LDAP DNS server."},{"line_number":675,"context_line":"\"\"\"),"},{"line_number":676,"context_line":"    cfg.StrOpt(\u0027ldap_dns_base_dn\u0027,"},{"line_number":677,"context_line":"                default\u003d\u0027ou\u003dhosts,dc\u003dexample,dc\u003dorg\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_8c7639a2","line":674,"range":{"start_line":674,"start_character":2,"end_line":674,"end_character":20},"updated":"2016-08-10 14:30:55.000000000","message":"That ListOpt, this is MultiStrOpt, i.e. the same key is used multiple times, and all the values are added into a list.\n\nYou can see that detail here:\nhttp://docs.openstack.org/developer/oslo.config/api/oslo.config.cfg.html#oslo.config.cfg.MultiStrOpt","commit_id":"c5b2763112f81c8803f7f45c422c3d2cf1db01e4"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"5d79d6acd27ffee94f7f92b016382a155b760fca","unresolved":false,"context_lines":[{"line_number":671,"context_line":""},{"line_number":672,"context_line":"Possible values:"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"* A list of strings, where each string represents LDAP DNS server."},{"line_number":675,"context_line":"\"\"\"),"},{"line_number":676,"context_line":"    cfg.StrOpt(\u0027ldap_dns_base_dn\u0027,"},{"line_number":677,"context_line":"                default\u003d\u0027ou\u003dhosts,dc\u003dexample,dc\u003dorg\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_fca82c8e","line":674,"range":{"start_line":674,"start_character":2,"end_line":674,"end_character":20},"in_reply_to":"9ad45d7e_8c7639a2","updated":"2016-08-10 22:30:42.000000000","message":"Please let me know if it looks fine now else I can remove this section completely. I just found in few places in conf section, MultiStrOpt is defined as list of strings.\n 1)https://github.com/openstack/nova/blob/2395cc70ff9aff1c34a7d8ba02f5569f20baa386/nova/conf/network.py#L417\n\n 2)https://github.com/openstack/nova/blob/282c257aff6b53a1b6bb4b4b034a670c450d19d8/nova/conf/scheduler.py#L103","commit_id":"c5b2763112f81c8803f7f45c422c3d2cf1db01e4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"786ecccd39439388c9843aa69911b68a11b48282","unresolved":false,"context_lines":[{"line_number":671,"context_line":""},{"line_number":672,"context_line":"Possible values:"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"* A list of strings, where each string represents LDAP DNS server."},{"line_number":675,"context_line":"\"\"\"),"},{"line_number":676,"context_line":"    cfg.StrOpt(\u0027ldap_dns_base_dn\u0027,"},{"line_number":677,"context_line":"                default\u003d\u0027ou\u003dhosts,dc\u003dexample,dc\u003dorg\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_89b3390a","line":674,"range":{"start_line":674,"start_character":2,"end_line":674,"end_character":20},"in_reply_to":"9ad45d7e_fca82c8e","updated":"2016-08-12 17:42:27.000000000","message":"Yeah, we should fix those up in a follow up patch. Good catch.","commit_id":"c5b2763112f81c8803f7f45c422c3d2cf1db01e4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8be2eb3899f09afb7d2943f9a3f0e3279f144f47","unresolved":false,"context_lines":[{"line_number":680,"context_line":""},{"line_number":681,"context_line":"Possible values:"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"* Any valid string representing base DN."},{"line_number":684,"context_line":"\"\"\"),"},{"line_number":685,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":686,"context_line":"                default\u003d1800,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_4cb8c12a","line":683,"updated":"2016-08-10 14:30:55.000000000","message":"I still think we should describe what this is used for.\n\nIt is used to help decide where to search in LDAP for the instance.","commit_id":"c5b2763112f81c8803f7f45c422c3d2cf1db01e4"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"5d79d6acd27ffee94f7f92b016382a155b760fca","unresolved":false,"context_lines":[{"line_number":680,"context_line":""},{"line_number":681,"context_line":"Possible values:"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"* Any valid string representing base DN."},{"line_number":684,"context_line":"\"\"\"),"},{"line_number":685,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":686,"context_line":"                default\u003d1800,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_9c95b034","line":683,"in_reply_to":"9ad45d7e_4cb8c12a","updated":"2016-08-10 22:30:42.000000000","message":"Not sure how I missed to incorporate these changes last time. Apologies for it.","commit_id":"c5b2763112f81c8803f7f45c422c3d2cf1db01e4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"786ecccd39439388c9843aa69911b68a11b48282","unresolved":false,"context_lines":[{"line_number":680,"context_line":""},{"line_number":681,"context_line":"Possible values:"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"* Any valid string representing base DN."},{"line_number":684,"context_line":"\"\"\"),"},{"line_number":685,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":686,"context_line":"                default\u003d1800,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_09c8e973","line":683,"in_reply_to":"9ad45d7e_9c95b034","updated":"2016-08-12 17:42:27.000000000","message":"It happens, no worries.","commit_id":"c5b2763112f81c8803f7f45c422c3d2cf1db01e4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fbd25afed92b6131723a285b0b6c5579670aa331","unresolved":false,"context_lines":[{"line_number":621,"context_line":""},{"line_number":622,"context_line":"ldap_dns_opts \u003d ["},{"line_number":623,"context_line":"    cfg.URIOpt(\u0027ldap_dns_url\u0027,"},{"line_number":624,"context_line":"                default\u003d\u0027ldap://ldap.example.com:389\u0027,"},{"line_number":625,"context_line":"                help\u003d\"\"\""},{"line_number":626,"context_line":"URL for LDAP server which will store DNS entries"},{"line_number":627,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_4d28a586","line":624,"range":{"start_line":624,"start_character":25,"end_line":624,"end_character":33},"updated":"2016-09-13 13:57:55.000000000","message":"nit: will these always start with this scheme? If so, maybe we should figure out some way to check this. I\u0027ll work on this in oslo_config, but maybe add a TODO here?","commit_id":"56694bd041efcf1fa5bdd11f3f4b9a9738b82a00"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"48ebd81d0e0cd30cecc412b0e193a579b4e8d046","unresolved":false,"context_lines":[{"line_number":621,"context_line":""},{"line_number":622,"context_line":"ldap_dns_opts \u003d ["},{"line_number":623,"context_line":"    cfg.URIOpt(\u0027ldap_dns_url\u0027,"},{"line_number":624,"context_line":"                default\u003d\u0027ldap://ldap.example.com:389\u0027,"},{"line_number":625,"context_line":"                help\u003d\"\"\""},{"line_number":626,"context_line":"URL for LDAP server which will store DNS entries"},{"line_number":627,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_5a292c9a","line":624,"range":{"start_line":624,"start_character":25,"end_line":624,"end_character":33},"in_reply_to":"9a89bdaa_4d28a586","updated":"2016-09-13 16:46:24.000000000","message":"Good catch Stephen! It always starts with ldap \u0027https://ldapwiki.willeke.com/wiki/LDAP%20URL\u0027. The current oslo_config requires scheme but it doesn\u0027t validate if it is a valid one. Will add a TODO here.","commit_id":"56694bd041efcf1fa5bdd11f3f4b9a9738b82a00"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"913f0bed214dc77591ed68c3e68f9b9904520879","unresolved":false,"context_lines":[{"line_number":681,"context_line":""},{"line_number":682,"context_line":"* Any valid string representing base DN."},{"line_number":683,"context_line":"\"\"\"),"},{"line_number":684,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":685,"context_line":"                default\u003d1800,"},{"line_number":686,"context_line":"                help\u003d\"\"\""},{"line_number":687,"context_line":"Refresh interval (in seconds) for LDAP DNS driver Start of Authority"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_498e6128","line":684,"range":{"start_line":684,"start_character":8,"end_line":684,"end_character":14},"updated":"2016-08-12 17:44:10.000000000","message":"Sorry, after recent issues we have hit here, can we switch these all back to StrOpt, with a TODO to convert them to an IntOpt?","commit_id":"56694bd041efcf1fa5bdd11f3f4b9a9738b82a00"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"42510be1f98aefb6139d453d6c5662d2cb65ca01","unresolved":false,"context_lines":[{"line_number":681,"context_line":""},{"line_number":682,"context_line":"* Any valid string representing base DN."},{"line_number":683,"context_line":"\"\"\"),"},{"line_number":684,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":685,"context_line":"                default\u003d1800,"},{"line_number":686,"context_line":"                help\u003d\"\"\""},{"line_number":687,"context_line":"Refresh interval (in seconds) for LDAP DNS driver Start of Authority"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_0b111e5e","line":684,"range":{"start_line":684,"start_character":8,"end_line":684,"end_character":14},"in_reply_to":"3ac371cc_41e9d113","updated":"2016-08-18 19:21:57.000000000","message":"After reading this descriprion, Intopt seems like a better fit here.","commit_id":"56694bd041efcf1fa5bdd11f3f4b9a9738b82a00"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"2c07e1ce12d6907ff2e827e17ed190ad4326f3ae","unresolved":false,"context_lines":[{"line_number":681,"context_line":""},{"line_number":682,"context_line":"* Any valid string representing base DN."},{"line_number":683,"context_line":"\"\"\"),"},{"line_number":684,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":685,"context_line":"                default\u003d1800,"},{"line_number":686,"context_line":"                help\u003d\"\"\""},{"line_number":687,"context_line":"Refresh interval (in seconds) for LDAP DNS driver Start of Authority"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_41e9d113","line":684,"range":{"start_line":684,"start_character":8,"end_line":684,"end_character":14},"in_reply_to":"9ad45d7e_498e6128","updated":"2016-08-16 16:11:15.000000000","message":"Hi John!\n[0]http://bind-dlz.sourceforge.net/ldap_driver.html\nIn the above link[0], found the below comments regarding the data type of the above config options. I see they have recommended to store it as numbers.\n\n\"Notice the data type column. Some attributes are labeled as \"string (num)\". LDAP only really returns strings from a query. The values of the attributes may be held as integers, floats, whatever by the database, but the return from the OpenLDAP functions is only a string. Eventually, however, the attributess marked with \"string (num)\" are turned into numbers by BIND or the LDAP driver. Your database can hold these attributess as strings or numbers, but they MUST be able to be properly parsed into a number without any extra characters. If they cannot, BIND will error and fail to answer the DNS query. I recommend the attributess labeled as \"string (num)\" be held as numbers in your LDAP schema.\"\n\nCan you please let me know your thoughts on this.\n\nRegards,\nSiva.\nS","commit_id":"56694bd041efcf1fa5bdd11f3f4b9a9738b82a00"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad61f45f04d1236d56bdb9b4c02e3430161964cb","unresolved":false,"context_lines":[{"line_number":710,"context_line":""},{"line_number":711,"context_line":"Possible values:"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"* Any valid URL representing LDAP server."},{"line_number":714,"context_line":"\"\"\"),"},{"line_number":715,"context_line":"    cfg.StrOpt(\u0027ldap_dns_user\u0027,"},{"line_number":716,"context_line":"                default\u003d\u0027uid\u003dadmin,ou\u003dpeople,dc\u003dexample,dc\u003dorg\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_ce3c8195","line":713,"range":{"start_line":713,"start_character":2,"end_line":713,"end_character":40},"updated":"2016-10-04 07:08:40.000000000","message":"Think this should be reworded. \"A valid LDAP URL representing the server\".  Not any URL with the LDAP server address will work.  Must be an ldap scheme","commit_id":"cd4bca4b25e7ca53dff4a9d987a7138d7a3acd2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad61f45f04d1236d56bdb9b4c02e3430161964cb","unresolved":false,"context_lines":[{"line_number":715,"context_line":"    cfg.StrOpt(\u0027ldap_dns_user\u0027,"},{"line_number":716,"context_line":"                default\u003d\u0027uid\u003dadmin,ou\u003dpeople,dc\u003dexample,dc\u003dorg\u0027,"},{"line_number":717,"context_line":"                help\u003d\"\"\""},{"line_number":718,"context_line":"User for LDAP DNS"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"Possible values:"},{"line_number":721,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_0e5ae9f1","line":718,"range":{"start_line":718,"start_character":0,"end_line":718,"end_character":17},"updated":"2016-10-04 07:08:40.000000000","message":"This sounds strange.","commit_id":"cd4bca4b25e7ca53dff4a9d987a7138d7a3acd2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad61f45f04d1236d56bdb9b4c02e3430161964cb","unresolved":false,"context_lines":[{"line_number":719,"context_line":""},{"line_number":720,"context_line":"Possible values:"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"* Any valid string representing LDAP DNS user."},{"line_number":723,"context_line":"\"\"\"),"},{"line_number":724,"context_line":"    cfg.StrOpt(\u0027ldap_dns_password\u0027,"},{"line_number":725,"context_line":"                default\u003d\u0027password\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_ae6015a6","line":722,"range":{"start_line":722,"start_character":2,"end_line":722,"end_character":46},"updated":"2016-10-04 07:08:40.000000000","message":"Sounds strange also. This is the bind user to the LDAP server. Nothing more.","commit_id":"cd4bca4b25e7ca53dff4a9d987a7138d7a3acd2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad61f45f04d1236d56bdb9b4c02e3430161964cb","unresolved":false,"context_lines":[{"line_number":725,"context_line":"                default\u003d\u0027password\u0027,"},{"line_number":726,"context_line":"                secret\u003dTrue,"},{"line_number":727,"context_line":"                help\u003d\"\"\""},{"line_number":728,"context_line":"Password for LDAP DNS"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"Possible values:"},{"line_number":731,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_4e707172","line":728,"range":{"start_line":728,"start_character":0,"end_line":728,"end_character":21},"updated":"2016-10-04 07:08:40.000000000","message":"I would fix this also.","commit_id":"cd4bca4b25e7ca53dff4a9d987a7138d7a3acd2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad61f45f04d1236d56bdb9b4c02e3430161964cb","unresolved":false,"context_lines":[{"line_number":729,"context_line":""},{"line_number":730,"context_line":"Possible values:"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"* Any valid string representing LDAP DNS password."},{"line_number":733,"context_line":"\"\"\"),"},{"line_number":734,"context_line":"    cfg.StrOpt(\u0027ldap_dns_soa_hostmaster\u0027,"},{"line_number":735,"context_line":"                default\u003d\u0027hostmaster@example.org\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_ae0735c8","line":732,"range":{"start_line":732,"start_character":2,"end_line":732,"end_character":50},"updated":"2016-10-04 07:08:40.000000000","message":"This is the bind user\u0027s password to the LDAP server.","commit_id":"cd4bca4b25e7ca53dff4a9d987a7138d7a3acd2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad61f45f04d1236d56bdb9b4c02e3430161964cb","unresolved":false,"context_lines":[{"line_number":749,"context_line":""},{"line_number":750,"context_line":"* Any valid string representing LDAP DNS server"},{"line_number":751,"context_line":"  Being MultiStrOpt, it allows multiple entries for this option"},{"line_number":752,"context_line":"  e.g: The command line --ldap_dns_servers\u003d\u0027example.org\u0027"},{"line_number":753,"context_line":"  --ldap_dns_servers\u003d\u0027example1.org\u0027 would result in ldap_dns_servers"},{"line_number":754,"context_line":"  containing [\u0027example.org\u0027,\u0027example1.org\u0027]"},{"line_number":755,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_ae2e5540","line":752,"updated":"2016-10-04 07:08:40.000000000","message":"But command line isn\u0027t being used here. This is for nova.conf file.","commit_id":"cd4bca4b25e7ca53dff4a9d987a7138d7a3acd2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad61f45f04d1236d56bdb9b4c02e3430161964cb","unresolved":false,"context_lines":[{"line_number":762,"context_line":""},{"line_number":763,"context_line":"Possible values:"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"* Any valid string representing base DN."},{"line_number":766,"context_line":"\"\"\"),"},{"line_number":767,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":768,"context_line":"                default\u003d1800,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_4e1eb10c","line":765,"updated":"2016-10-04 07:08:40.000000000","message":"This is the base distinguished name for the LDAP search query.","commit_id":"cd4bca4b25e7ca53dff4a9d987a7138d7a3acd2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad61f45f04d1236d56bdb9b4c02e3430161964cb","unresolved":false,"context_lines":[{"line_number":767,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":768,"context_line":"                default\u003d1800,"},{"line_number":769,"context_line":"                help\u003d\"\"\""},{"line_number":770,"context_line":"Refresh interval (in seconds) for LDAP DNS driver Start of Authority"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"Time interval, a secondary/slave DNS server waits before requesting for"},{"line_number":773,"context_line":"primary DNS server\u0027s current SOA record. If the records are different,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_4ee5d106","line":770,"updated":"2016-10-04 07:08:40.000000000","message":"Add a minimum if this is a time value. Also what is a value of zero do?","commit_id":"cd4bca4b25e7ca53dff4a9d987a7138d7a3acd2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad61f45f04d1236d56bdb9b4c02e3430161964cb","unresolved":false,"context_lines":[{"line_number":777,"context_line":"\"\"\"),"},{"line_number":778,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_retry\u0027,"},{"line_number":779,"context_line":"                default\u003d3600,"},{"line_number":780,"context_line":"                help\u003d\"\"\""},{"line_number":781,"context_line":"Retry interval (in seconds) for LDAP DNS driver Start of Authority"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"Time interval, a secondary/slave DNS server should wait, if an"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_cebf21ce","line":780,"updated":"2016-10-04 07:08:40.000000000","message":"Add minimum. What if zero?","commit_id":"cd4bca4b25e7ca53dff4a9d987a7138d7a3acd2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad61f45f04d1236d56bdb9b4c02e3430161964cb","unresolved":false,"context_lines":[{"line_number":784,"context_line":"attempt to transfer zone failed during the previous refresh interval."},{"line_number":785,"context_line":"\"\"\"),"},{"line_number":786,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_expiry\u0027,"},{"line_number":787,"context_line":"                default\u003d86400,"},{"line_number":788,"context_line":"                help\u003d\"\"\""},{"line_number":789,"context_line":"Expiry interval (in seconds) for LDAP DNS driver Start of Authority"},{"line_number":790,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_eeb21d05","line":787,"updated":"2016-10-04 07:08:40.000000000","message":"Add minimum. What if zero?","commit_id":"cd4bca4b25e7ca53dff4a9d987a7138d7a3acd2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad61f45f04d1236d56bdb9b4c02e3430161964cb","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                default\u003d7200,"},{"line_number":796,"context_line":"                help\u003d\"\"\""},{"line_number":797,"context_line":"Minimum interval (in seconds) for LDAP DNS driver Start of Authority"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"It is Minimum time-to-live applies for all resource records in the"},{"line_number":800,"context_line":"zone file. This value is supplied to other servers how long they"},{"line_number":801,"context_line":"should keep the data in cache."}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_2ed16523","line":798,"updated":"2016-10-04 07:08:40.000000000","message":"Add minimum. What if zero?","commit_id":"cd4bca4b25e7ca53dff4a9d987a7138d7a3acd2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ad61f45f04d1236d56bdb9b4c02e3430161964cb","unresolved":false,"context_lines":[{"line_number":764,"context_line":""},{"line_number":765,"context_line":"* Any valid string representing base DN."},{"line_number":766,"context_line":"\"\"\"),"},{"line_number":767,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_refresh\u0027,"},{"line_number":768,"context_line":"                default\u003d1800,"},{"line_number":769,"context_line":"                help\u003d\"\"\""},{"line_number":770,"context_line":"Refresh interval (in seconds) for LDAP DNS driver Start of Authority"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"Time interval, a secondary/slave DNS server waits before requesting for"},{"line_number":773,"context_line":"primary DNS server\u0027s current SOA record. If the records are different,"},{"line_number":774,"context_line":"secondary DNS server will request a zone transfer from primary."},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"NOTE: Lower values would cause more traffic."},{"line_number":777,"context_line":"\"\"\"),"},{"line_number":778,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_retry\u0027,"},{"line_number":779,"context_line":"                default\u003d3600,"},{"line_number":780,"context_line":"                help\u003d\"\"\""},{"line_number":781,"context_line":"Retry interval (in seconds) for LDAP DNS driver Start of Authority"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"Time interval, a secondary/slave DNS server should wait, if an"},{"line_number":784,"context_line":"attempt to transfer zone failed during the previous refresh interval."},{"line_number":785,"context_line":"\"\"\"),"},{"line_number":786,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_expiry\u0027,"},{"line_number":787,"context_line":"                default\u003d86400,"},{"line_number":788,"context_line":"                help\u003d\"\"\""},{"line_number":789,"context_line":"Expiry interval (in seconds) for LDAP DNS driver Start of Authority"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"Time interval, a secondary/slave DNS server holds the information"},{"line_number":792,"context_line":"before it is no longer considered authoritative."},{"line_number":793,"context_line":"\"\"\"),"},{"line_number":794,"context_line":"    cfg.IntOpt(\u0027ldap_dns_soa_minimum\u0027,"},{"line_number":795,"context_line":"                default\u003d7200,"},{"line_number":796,"context_line":"                help\u003d\"\"\""},{"line_number":797,"context_line":"Minimum interval (in seconds) for LDAP DNS driver Start of Authority"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"It is Minimum time-to-live applies for all resource records in the"},{"line_number":800,"context_line":"zone file. This value is supplied to other servers how long they"},{"line_number":801,"context_line":"should keep the data in cache."},{"line_number":802,"context_line":"\"\"\"),"},{"line_number":803,"context_line":"]"},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"driver_opts \u003d ["},{"line_number":806,"context_line":"    cfg.StrOpt(\u0027network_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a98d1f4_0edf493a","line":803,"range":{"start_line":767,"start_character":0,"end_line":803,"end_character":1},"updated":"2016-10-04 07:08:40.000000000","message":"Rebase on https://review.openstack.org/#/c/168481 if you\u0027re going to change the conf option type. That patch covers the change and the other related changes.","commit_id":"cd4bca4b25e7ca53dff4a9d987a7138d7a3acd2d"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"e66180cc39bbc5a556842453605e00b9610ccccc","unresolved":false,"context_lines":[{"line_number":792,"context_line":"]"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"rpcapi_opts \u003d ["},{"line_number":795,"context_line":"    cfg.StrOpt(\u0027network_topic\u0027,"},{"line_number":796,"context_line":"        default\u003d\u0027network\u0027,"},{"line_number":797,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":798,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":799,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":800,"context_line":"There is no need to let users choose the RPC topic for all services - there"},{"line_number":801,"context_line":"is little gain from this. Furthermore, it makes it really easy to break Nova"},{"line_number":802,"context_line":"by using this option."},{"line_number":803,"context_line":"\"\"\","},{"line_number":804,"context_line":"        help\u003d\u0027The topic network nodes listen on\u0027),"},{"line_number":805,"context_line":"    cfg.BoolOpt(\u0027multi_host\u0027,"},{"line_number":806,"context_line":"        default\u003dFalse,"},{"line_number":807,"context_line":"        help\u003d\u0027Default value for multi_host in networks. Also, if set, \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_4f15f599","line":804,"range":{"start_line":795,"start_character":0,"end_line":804,"end_character":50},"updated":"2016-11-10 18:43:40.000000000","message":"Nit: can you move it down? It is nice to have deprecated stuff grouped at the bottom of each list.","commit_id":"e759a07460372e624beb1c196405cd7647881a61"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fd305bb5b1482097de57d6b9e907c435bb6dbdaf","unresolved":false,"context_lines":[{"line_number":792,"context_line":"]"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"rpcapi_opts \u003d ["},{"line_number":795,"context_line":"    cfg.StrOpt(\u0027network_topic\u0027,"},{"line_number":796,"context_line":"        default\u003d\u0027network\u0027,"},{"line_number":797,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":798,"context_line":"        deprecated_since\u003d\u002715.0.0\u0027,"},{"line_number":799,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":800,"context_line":"There is no need to let users choose the RPC topic for all services - there"},{"line_number":801,"context_line":"is little gain from this. Furthermore, it makes it really easy to break Nova"},{"line_number":802,"context_line":"by using this option."},{"line_number":803,"context_line":"\"\"\","},{"line_number":804,"context_line":"        help\u003d\u0027The topic network nodes listen on\u0027),"},{"line_number":805,"context_line":"    cfg.BoolOpt(\u0027multi_host\u0027,"},{"line_number":806,"context_line":"        default\u003dFalse,"},{"line_number":807,"context_line":"        help\u003d\u0027Default value for multi_host in networks. Also, if set, \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_05c96226","line":804,"range":{"start_line":795,"start_character":0,"end_line":804,"end_character":50},"in_reply_to":"9a629dbe_4f15f599","updated":"2016-11-25 13:52:44.000000000","message":"I think the next patch changes the need for that move, lets leave it.","commit_id":"e759a07460372e624beb1c196405cd7647881a61"}]}