)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd99e47c24bf1fcc1dd5eff380b5ef66735954e8","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            resource \u003d overs[0]"},{"line_number":313,"context_line":"            used \u003d quotas[resource] - headroom[resource]"},{"line_number":314,"context_line":"            total_allowed \u003d used + headroom[resource]"},{"line_number":315,"context_line":"            overs \u003d \u0027,\u0027.join(overs)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"            pid \u003d context.project_id"},{"line_number":318,"context_line":"            LOG.warn(_(\"%(overs)s quota exceeded for %(pid)s,\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FrUY%3D","line":315,"updated":"2013-06-25 13:52:38.000000000","message":"nit: overs and pid could be removed as they are used only for formatting log message.","commit_id":"627d15bddb603c34d96e42f9b0cb13ad6e5f5fc3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5191df1e90a2c053b58232056d69d211313f4083","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            resource \u003d overs[0]"},{"line_number":313,"context_line":"            used \u003d quotas[resource] - headroom[resource]"},{"line_number":314,"context_line":"            total_allowed \u003d used + headroom[resource]"},{"line_number":315,"context_line":"            overs \u003d \u0027,\u0027.join(overs)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"            pid \u003d context.project_id"},{"line_number":318,"context_line":"            LOG.warn(_(\"%(overs)s quota exceeded for %(pid)s,\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FkMQ%3D","line":315,"in_reply_to":"AAAAPn%2F%2FrUY%3D","updated":"2013-06-27 17:29:36.000000000","message":"The overs is used in the exception. The pid has bee addressed as requested.","commit_id":"627d15bddb603c34d96e42f9b0cb13ad6e5f5fc3"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd99e47c24bf1fcc1dd5eff380b5ef66735954e8","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        try:"},{"line_number":336,"context_line":"            QUOTAS.limit_check(context, metadata_items\u003dnum_metadata)"},{"line_number":337,"context_line":"        except exception.OverQuota as exc:"},{"line_number":338,"context_line":"            pid \u003d context.project_id"},{"line_number":339,"context_line":"            LOG.warn(_(\"Quota exceeded for %(pid)s, tried to set \""},{"line_number":340,"context_line":"                       \"%(num_metadata)s metadata properties\"),"},{"line_number":341,"context_line":"                     {\u0027pid\u0027: pid, \u0027num_metadata\u0027: num_metadata})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FrUQ%3D","line":338,"updated":"2013-06-25 13:52:38.000000000","message":"same here","commit_id":"627d15bddb603c34d96e42f9b0cb13ad6e5f5fc3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5191df1e90a2c053b58232056d69d211313f4083","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        try:"},{"line_number":336,"context_line":"            QUOTAS.limit_check(context, metadata_items\u003dnum_metadata)"},{"line_number":337,"context_line":"        except exception.OverQuota as exc:"},{"line_number":338,"context_line":"            pid \u003d context.project_id"},{"line_number":339,"context_line":"            LOG.warn(_(\"Quota exceeded for %(pid)s, tried to set \""},{"line_number":340,"context_line":"                       \"%(num_metadata)s metadata properties\"),"},{"line_number":341,"context_line":"                     {\u0027pid\u0027: pid, \u0027num_metadata\u0027: num_metadata})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FkL8%3D","line":338,"in_reply_to":"AAAAPn%2F%2FrUQ%3D","updated":"2013-06-27 17:29:36.000000000","message":"Done","commit_id":"627d15bddb603c34d96e42f9b0cb13ad6e5f5fc3"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd99e47c24bf1fcc1dd5eff380b5ef66735954e8","unresolved":false,"context_lines":[{"line_number":2117,"context_line":"            total_allowed \u003d used + headroom[resource]"},{"line_number":2118,"context_line":"            overs \u003d \u0027,\u0027.join(overs)"},{"line_number":2119,"context_line":""},{"line_number":2120,"context_line":"            pid \u003d context.project_id"},{"line_number":2121,"context_line":"            LOG.warn(_(\"%(overs)s quota exceeded for %(pid)s,\""},{"line_number":2122,"context_line":"                       \" tried to resize instance.\"),"},{"line_number":2123,"context_line":"                     {\u0027overs\u0027: overs, \u0027pid\u0027: pid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FrTY%3D","line":2120,"updated":"2013-06-25 13:52:38.000000000","message":"ditto","commit_id":"627d15bddb603c34d96e42f9b0cb13ad6e5f5fc3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5191df1e90a2c053b58232056d69d211313f4083","unresolved":false,"context_lines":[{"line_number":2117,"context_line":"            total_allowed \u003d used + headroom[resource]"},{"line_number":2118,"context_line":"            overs \u003d \u0027,\u0027.join(overs)"},{"line_number":2119,"context_line":""},{"line_number":2120,"context_line":"            pid \u003d context.project_id"},{"line_number":2121,"context_line":"            LOG.warn(_(\"%(overs)s quota exceeded for %(pid)s,\""},{"line_number":2122,"context_line":"                       \" tried to resize instance.\"),"},{"line_number":2123,"context_line":"                     {\u0027overs\u0027: overs, \u0027pid\u0027: pid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FkLs%3D","line":2120,"in_reply_to":"AAAAPn%2F%2FrTY%3D","updated":"2013-06-27 17:29:36.000000000","message":"Done","commit_id":"627d15bddb603c34d96e42f9b0cb13ad6e5f5fc3"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"ae1ba1c06a1159bf0986fcc8ef2c037ac8a6094b","unresolved":false,"context_lines":[{"line_number":539,"context_line":"            uuid \u003d orphan[\u0027uuid\u0027]"},{"line_number":540,"context_line":"            memory_mb \u003d orphan[\u0027memory_mb\u0027]"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"            LOG.warn(_(\"Detected running orphan instance: %(uuid)s (consuming \""},{"line_number":543,"context_line":"                       \"%(memory_mb)s MB memory\"),"},{"line_number":544,"context_line":"                     {\u0027uuid\u0027: uuid, \u0027memory_mb\u0027: memory_mb})"},{"line_number":545,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FuSI%3D","line":542,"updated":"2013-06-24 13:23:13.000000000","message":"Your work here looks fine.\n\nIt does look like this warning messages may have had an extra ( in it already. Perhaps we should fix it? Either here or in a separate commit?","commit_id":"e63512a3fb6d91bf8d31d6b53c84b94ad284e0c6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"22597e0c294b87360ca824bbeb22dce1664e20b6","unresolved":false,"context_lines":[{"line_number":539,"context_line":"            uuid \u003d orphan[\u0027uuid\u0027]"},{"line_number":540,"context_line":"            memory_mb \u003d orphan[\u0027memory_mb\u0027]"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"            LOG.warn(_(\"Detected running orphan instance: %(uuid)s (consuming \""},{"line_number":543,"context_line":"                       \"%(memory_mb)s MB memory\"),"},{"line_number":544,"context_line":"                     {\u0027uuid\u0027: uuid, \u0027memory_mb\u0027: memory_mb})"},{"line_number":545,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FuMo%3D","line":542,"in_reply_to":"AAAAPn%2F%2FuSI%3D","updated":"2013-06-24 13:53:29.000000000","message":"Yeah, you are correct. I\u0027ll update.","commit_id":"e63512a3fb6d91bf8d31d6b53c84b94ad284e0c6"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd99e47c24bf1fcc1dd5eff380b5ef66735954e8","unresolved":false,"context_lines":[{"line_number":536,"context_line":"    def _update_usage_from_orphans(self, resources, orphans):"},{"line_number":537,"context_line":"        \"\"\"Include orphaned instances in usage.\"\"\""},{"line_number":538,"context_line":"        for orphan in orphans:"},{"line_number":539,"context_line":"            uuid \u003d orphan[\u0027uuid\u0027]"},{"line_number":540,"context_line":"            memory_mb \u003d orphan[\u0027memory_mb\u0027]"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"            LOG.warn(_(\"Detected running orphan instance: %(uuid)s (consuming \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FrTM%3D","line":539,"updated":"2013-06-25 13:52:38.000000000","message":"uuid is only used in Log.warn so it could be removed","commit_id":"627d15bddb603c34d96e42f9b0cb13ad6e5f5fc3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5191df1e90a2c053b58232056d69d211313f4083","unresolved":false,"context_lines":[{"line_number":536,"context_line":"    def _update_usage_from_orphans(self, resources, orphans):"},{"line_number":537,"context_line":"        \"\"\"Include orphaned instances in usage.\"\"\""},{"line_number":538,"context_line":"        for orphan in orphans:"},{"line_number":539,"context_line":"            uuid \u003d orphan[\u0027uuid\u0027]"},{"line_number":540,"context_line":"            memory_mb \u003d orphan[\u0027memory_mb\u0027]"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"            LOG.warn(_(\"Detected running orphan instance: %(uuid)s (consuming \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FkLc%3D","line":539,"in_reply_to":"AAAAPn%2F%2FrTM%3D","updated":"2013-06-27 17:29:36.000000000","message":"Done","commit_id":"627d15bddb603c34d96e42f9b0cb13ad6e5f5fc3"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cd99e47c24bf1fcc1dd5eff380b5ef66735954e8","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        \"\"\"Include orphaned instances in usage.\"\"\""},{"line_number":538,"context_line":"        for orphan in orphans:"},{"line_number":539,"context_line":"            uuid \u003d orphan[\u0027uuid\u0027]"},{"line_number":540,"context_line":"            memory_mb \u003d orphan[\u0027memory_mb\u0027]"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"            LOG.warn(_(\"Detected running orphan instance: %(uuid)s (consuming \""},{"line_number":543,"context_line":"                       \"%(memory_mb)s MB memory)\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FrTI%3D","line":540,"updated":"2013-06-25 13:52:38.000000000","message":"memory_mb could be used in in usage at 547 line","commit_id":"627d15bddb603c34d96e42f9b0cb13ad6e5f5fc3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5191df1e90a2c053b58232056d69d211313f4083","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        \"\"\"Include orphaned instances in usage.\"\"\""},{"line_number":538,"context_line":"        for orphan in orphans:"},{"line_number":539,"context_line":"            uuid \u003d orphan[\u0027uuid\u0027]"},{"line_number":540,"context_line":"            memory_mb \u003d orphan[\u0027memory_mb\u0027]"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"            LOG.warn(_(\"Detected running orphan instance: %(uuid)s (consuming \""},{"line_number":543,"context_line":"                       \"%(memory_mb)s MB memory)\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FkLU%3D","line":540,"in_reply_to":"AAAAPn%2F%2FrTI%3D","updated":"2013-06-27 17:29:36.000000000","message":"Done","commit_id":"627d15bddb603c34d96e42f9b0cb13ad6e5f5fc3"}]}