)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"5261804b6c179bf0e1987d4f84468f757c3dc846","unresolved":false,"context_lines":[{"line_number":6489,"context_line":""},{"line_number":6490,"context_line":"            # External boot disks are hard-coded to use the Flat backend,"},{"line_number":6491,"context_line":"            # and therefore always live in the instance directory"},{"line_number":6492,"context_line":"            for disk in policy.external_boot():"},{"line_number":6493,"context_line":"                disk.create()"},{"line_number":6494,"context_line":""},{"line_number":6495,"context_line":"            if not is_shared_block_storage and is_block_migration:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_656d4032","line":6492,"updated":"2016-12-22 06:27:02.000000000","message":"Did you consider a case of move all such code out of the driver into special storagepolicy methods?","commit_id":"7cc447beb1effe14e96682a9f25e9b38f430bd18"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"d8bc606ea5057cee82ba8b67aba6482f19728134","unresolved":false,"context_lines":[{"line_number":6510,"context_line":"                                              all_disks)"},{"line_number":6511,"context_line":"                all_disks \u003d itertools.chain(all_disks, policy.ephemerals())"},{"line_number":6512,"context_line":"                for disk in all_disks:"},{"line_number":6513,"context_line":"                    disk.create()"},{"line_number":6514,"context_line":""},{"line_number":6515,"context_line":"                config_disk \u003d policy.config_disk()"},{"line_number":6516,"context_line":"                if (config_disk is not None and"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_2c74f79a","line":6513,"updated":"2016-12-30 16:10:35.000000000","message":"IIANM this will create empty formatted ephemeral disks for raw backend. I.e. we\u0027ll get a new filesystem in such disks. I\u0027m not sure if this works with live block migration. And anyway this is not that we wanted.","commit_id":"7cc447beb1effe14e96682a9f25e9b38f430bd18"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"eee1624ec0695a74249e327956b38bfedcedc2f5","unresolved":false,"context_lines":[{"line_number":6512,"context_line":"                for disk in all_disks:"},{"line_number":6513,"context_line":"                    disk.create()"},{"line_number":6514,"context_line":""},{"line_number":6515,"context_line":"                config_disk \u003d policy.config_disk()"},{"line_number":6516,"context_line":"                if (config_disk is not None and"},{"line_number":6517,"context_line":"                        CONF.config_drive_format \u003d\u003d \u0027iso9660\u0027):"},{"line_number":6518,"context_line":"                    # NOTE(pkoniszewski): Due to a bug in libvirt iso config"},{"line_number":6519,"context_line":"                    # drive needs to be copied to destination prior to"},{"line_number":6520,"context_line":"                    # migration when instance path is not shared and block"}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_a003a475","line":6517,"range":{"start_line":6515,"start_character":0,"end_line":6517,"end_character":63},"updated":"2016-12-21 21:57:39.000000000","message":"How vfat config drive will be migrated? As i understand currently it is created in _create_images_and_backing and then its data is copied by libvirt during block migration.","commit_id":"7cc447beb1effe14e96682a9f25e9b38f430bd18"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"fb4c265fc0691344e207d65c37dda2d269834d2d","unresolved":false,"context_lines":[{"line_number":7014,"context_line":"            on_completion \u003d lambda process: \\"},{"line_number":7015,"context_line":"                self.job_tracker.remove_job(instance, process.pid)"},{"line_number":7016,"context_line":""},{"line_number":7017,"context_line":"            for info in disk_info:"},{"line_number":7018,"context_line":"                # assume inst_base \u003d\u003d dirname(info[\u0027path\u0027])"},{"line_number":7019,"context_line":"                img_path \u003d info[\u0027path\u0027]"},{"line_number":7020,"context_line":"                fname \u003d os.path.basename(img_path)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da4df55a_00a47055","line":7017,"updated":"2016-12-21 22:02:32.000000000","message":"This is the last loop over certain instance disks via disk_info. Is it possible to use storagepolicy here?","commit_id":"7cc447beb1effe14e96682a9f25e9b38f430bd18"}]}