)]}'
{"nova/api/openstack/compute/baremetal_nodes.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"eb63ff508396ea531986ee1fa026294cd659ce8d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # the client, but it\u0027s not even used so it doesn\u0027t really matter. The"},{"line_number":63,"context_line":"    # ironic client wrapper in the virt driver actually uses a hard-coded"},{"line_number":64,"context_line":"    # microversion via the os_ironic_api_version kwarg."},{"line_number":65,"context_line":"    icli \u003d ironic_client.get_client(\u00271\u0027, **kwargs)"},{"line_number":66,"context_line":"    return icli"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_189e1ab8","line":65,"range":{"start_line":65,"start_character":36,"end_line":65,"end_character":39},"updated":"2016-07-25 23:30:33.000000000","message":"Why should we pass a string \u00271\u0027 instead of an integer 1 here?\nThe default value was an integer, and the tests are checking an integer..","commit_id":"c659cd5d32b17b506f59b0ff88418ff031796561"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0856edc68218572876c16dbbde49397ffb581312","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # the client, but it\u0027s not even used so it doesn\u0027t really matter. The"},{"line_number":63,"context_line":"    # ironic client wrapper in the virt driver actually uses a hard-coded"},{"line_number":64,"context_line":"    # microversion via the os_ironic_api_version kwarg."},{"line_number":65,"context_line":"    icli \u003d ironic_client.get_client(\u00271\u0027, **kwargs)"},{"line_number":66,"context_line":"    return icli"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_db0577c2","line":65,"range":{"start_line":65,"start_character":36,"end_line":65,"end_character":39},"in_reply_to":"dada55a8_189e1ab8","updated":"2016-07-26 14:25:39.000000000","message":"I used \u00271\u0027 since that\u0027s what the actual python-ironicclient code says to use:\n\nhttp://git.openstack.org/cgit/openstack/python-ironicclient/tree/ironicclient/client.py?h\u003d1.1.0#n58\n\nHowever, it\u0027s not even used, so I could pass \u0027kenichi\u0027 in here and it would be fine.\n\nI can change to an integer if it bothers anyone though.","commit_id":"c659cd5d32b17b506f59b0ff88418ff031796561"}]}