)]}'
{"nova/api/openstack/placement/manage.py":[{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"2da30580acb2910b821f2ee44e6cfc77d46e12d8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            command_object \u003d fn()"},{"line_number":123,"context_line":"            actions \u003d methods_of(command_object)"},{"line_number":124,"context_line":"            print(\" \".join([k for (k, v) in actions]))"},{"line_number":125,"context_line":"        return(0)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    fn \u003d cfg.CONF.category.action_fn"},{"line_number":128,"context_line":"    fn_args \u003d [arg.decode(\u0027utf-8\u0027) for arg in cfg.CONF.category.action_args]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_af107fac","line":125,"updated":"2016-07-15 07:06:06.000000000","message":"nit: why with parens?","commit_id":"e7559111d879428d7c117d67791b520d9ba8490f"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"2a9559a6487bdc276f0def5ed685eb881649b7eb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            command_object \u003d fn()"},{"line_number":123,"context_line":"            actions \u003d methods_of(command_object)"},{"line_number":124,"context_line":"            print(\" \".join([k for (k, v) in actions]))"},{"line_number":125,"context_line":"        return(0)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    fn \u003d cfg.CONF.category.action_fn"},{"line_number":128,"context_line":"    fn_args \u003d [arg.decode(\u0027utf-8\u0027) for arg in cfg.CONF.category.action_args]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_366f1d94","line":125,"in_reply_to":"1aa78d24_af107fac","updated":"2016-07-15 19:29:56.000000000","message":"Just copied the code from nova-manage. The new version is based on cliff and does not have these quirks","commit_id":"e7559111d879428d7c117d67791b520d9ba8490f"}],"nova/db/placement/models.py":[{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"2da30580acb2910b821f2ee44e6cfc77d46e12d8","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue, nullable\u003dFalse)"},{"line_number":45,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse)"},{"line_number":46,"context_line":"    name \u003d Column(Unicode(200), nullable\u003dTrue)"},{"line_number":47,"context_line":"    generation \u003d Column(Integer, default\u003d0)"},{"line_number":48,"context_line":"    can_host \u003d Column(Integer, default\u003d0)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_cf27cb61","line":46,"updated":"2016-07-15 07:06:06.000000000","message":"Do we really need 3-values logic for name?\nTo pick empty name resource provider:\nif name is None or name \u003d\u003d \u0027\u0027.","commit_id":"e7559111d879428d7c117d67791b520d9ba8490f"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"ec1b53cac958dc5231479604fdebf6b14d15d698","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue, nullable\u003dFalse)"},{"line_number":45,"context_line":"    uuid \u003d Column(String(36), nullable\u003dFalse)"},{"line_number":46,"context_line":"    name \u003d Column(Unicode(200), nullable\u003dTrue)"},{"line_number":47,"context_line":"    generation \u003d Column(Integer, default\u003d0)"},{"line_number":48,"context_line":"    can_host \u003d Column(Integer, default\u003d0)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fad55976_165819fa","line":46,"in_reply_to":"1aa78d24_cf27cb61","updated":"2016-07-15 19:29:27.000000000","message":"Andrey, this DB schema is meant to be the exact copy of what we have now in the API DB in nova. Apparently, name is considered to be an optional property of a resource provider instance.\n\nI think, we could easily avoid the problem you are referring to just be using:\n\n  if not name:\n     ...","commit_id":"e7559111d879428d7c117d67791b520d9ba8490f"}]}