)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8abb5c4dc76ce521ad8ae78114fcff61195783a5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Stop using mox in method ShelveComputeManagerTestCase._shelve_offload"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partially implements: blueprint remove-mox-newton"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I08f86e9fb89c069af6ad751c04538adaaf24892f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_6b5bf9f6","line":11,"range":{"start_line":11,"start_character":43,"end_line":11,"end_character":49},"updated":"2016-08-10 10:57:25.000000000","message":"s/newton/ocata","commit_id":"160adeb5ebd3e9df9755a3266028e8a74cfa626f"}],"nova/tests/unit/compute/test_shelve.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8abb5c4dc76ce521ad8ae78114fcff61195783a5","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                instance)"},{"line_number":202,"context_line":"        mock_update_resource_tracker.assert_called_once_with(self.context,"},{"line_number":203,"context_line":"                                                             instance)"},{"line_number":204,"context_line":"        if clean_shutdown:"},{"line_number":205,"context_line":"            mock_power_off.assert_called_once_with(instance,"},{"line_number":206,"context_line":"                                          CONF.shutdown_timeout,"},{"line_number":207,"context_line":"                                          self.compute.SHUTDOWN_RETRY_INTERVAL)"},{"line_number":208,"context_line":"        else:"},{"line_number":209,"context_line":"            mock_power_off.assert_called_once_with(instance, 0, 0)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_shelve_offload(self):"},{"line_number":212,"context_line":"        self._shelve_offload()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_8b7aad75","line":209,"range":{"start_line":204,"start_character":0,"end_line":209,"end_character":66},"updated":"2016-08-10 10:57:25.000000000","message":"Instead of adding logic to this function, can you move these two calls into the calling functions (test_shelve_offload, test_shelve_offload_forced_shutdown). This will make the difference between the two clearer, IMO.","commit_id":"160adeb5ebd3e9df9755a3266028e8a74cfa626f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e3ffeb2d1e66736319e20e33e670539188b03edb","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                instance)"},{"line_number":202,"context_line":"        mock_update_resource_tracker.assert_called_once_with(self.context,"},{"line_number":203,"context_line":"                                                             instance)"},{"line_number":204,"context_line":"        if clean_shutdown:"},{"line_number":205,"context_line":"            mock_power_off.assert_called_once_with(instance,"},{"line_number":206,"context_line":"                                          CONF.shutdown_timeout,"},{"line_number":207,"context_line":"                                          self.compute.SHUTDOWN_RETRY_INTERVAL)"},{"line_number":208,"context_line":"        else:"},{"line_number":209,"context_line":"            mock_power_off.assert_called_once_with(instance, 0, 0)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_shelve_offload(self):"},{"line_number":212,"context_line":"        self._shelve_offload()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_91eeb1b2","line":209,"range":{"start_line":204,"start_character":0,"end_line":209,"end_character":66},"updated":"2016-09-23 14:23:50.000000000","message":"Instead of adding logic to this function, can you move these two calls into the calling functions (test_shelve_offload, test_shelve_offload_forced_shutdown). This will make the difference between the two clearer, IMO.","commit_id":"cfa189ed75163053bbff1e42edd7fc7ca5aeec25"},{"author":{"_account_id":22582,"name":"Duong Ha-Quang","email":"quangduongha@gmail.com","username":"duonghq"},"change_message_id":"7cdb9ad28486c109d91529b1231710e5c832eea4","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                instance)"},{"line_number":202,"context_line":"        mock_update_resource_tracker.assert_called_once_with(self.context,"},{"line_number":203,"context_line":"                                                             instance)"},{"line_number":204,"context_line":"        if clean_shutdown:"},{"line_number":205,"context_line":"            mock_power_off.assert_called_once_with(instance,"},{"line_number":206,"context_line":"                                          CONF.shutdown_timeout,"},{"line_number":207,"context_line":"                                          self.compute.SHUTDOWN_RETRY_INTERVAL)"},{"line_number":208,"context_line":"        else:"},{"line_number":209,"context_line":"            mock_power_off.assert_called_once_with(instance, 0, 0)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def test_shelve_offload(self):"},{"line_number":212,"context_line":"        self._shelve_offload()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5da102_6c6c439d","line":209,"range":{"start_line":204,"start_character":0,"end_line":209,"end_character":66},"in_reply_to":"5a8bc5a2_91eeb1b2","updated":"2016-10-26 08:55:49.000000000","message":"Done","commit_id":"cfa189ed75163053bbff1e42edd7fc7ca5aeec25"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e7d715a315d806b9cbdab019de9f53b80d5d3f5a","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        # prepare expect call lists"},{"line_number":208,"context_line":"        mock_notify_instance_usage_call_list \u003d ["},{"line_number":209,"context_line":"            mock.call(self.context, instance, \u0027shelve_offload.start\u0027),"},{"line_number":210,"context_line":"            mock.call(self.context, instance, \u0027shelve_offload.end\u0027)]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        mock_notify_instance_usage.assert_has_calls("},{"line_number":213,"context_line":"            mock_notify_instance_usage_call_list)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a3905b3_67ba600c","line":210,"updated":"2017-01-20 09:48:12.000000000","message":"We are loosing something in not asserting the absolute order of these operations. Although its possible in mock, I remember it making my eyes bleed. Lets go with this.","commit_id":"9a85f1551406c0d7d1647726e7dfbf01a5e23322"}]}