)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"18c870c84ec9da0407c434d5c41d599621c928c5","unresolved":false,"context_lines":[{"line_number":440,"context_line":"               help\u003d\u0027Mount options passed to the NFS client. See section \u0027"},{"line_number":441,"context_line":"                    \u0027of the nfs man page for details\u0027),"},{"line_number":442,"context_line":"    cfg.StrOpt(\u0027nfs_local_symbolic_base\u0027,"},{"line_number":443,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt_link\u0027),"},{"line_number":444,"context_line":"               help\u003d\u0027Directory where the NFS volume is linked in local \u0027"},{"line_number":445,"context_line":"                    \u0027compute node\u0027),"},{"line_number":446,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_2a1c4dc0","line":443,"updated":"2016-07-20 11:32:10.000000000","message":"Could you, please, clarify what this default value mean?\nIn bug description I see /dev/mapper/ directory and it\u0027s hard-coded in several places.","commit_id":"80099727300e78ac1d37eca1abc769e5f8d67398"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"7ea2d482c572e4571a2a09f5217c8c8a954b0aad","unresolved":false,"context_lines":[{"line_number":440,"context_line":"               help\u003d\u0027Mount options passed to the NFS client. See section \u0027"},{"line_number":441,"context_line":"                    \u0027of the nfs man page for details\u0027),"},{"line_number":442,"context_line":"    cfg.StrOpt(\u0027nfs_local_symbolic_base\u0027,"},{"line_number":443,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt_link\u0027),"},{"line_number":444,"context_line":"               help\u003d\u0027Directory where the NFS volume is linked in local \u0027"},{"line_number":445,"context_line":"                    \u0027compute node\u0027),"},{"line_number":446,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_34d01d1f","line":443,"in_reply_to":"dada55a8_2a1c4dc0","updated":"2016-07-20 18:09:10.000000000","message":"Concur. mnt_link isn\u0027t very descriptive.","commit_id":"80099727300e78ac1d37eca1abc769e5f8d67398"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"372415a7081495048acb3eafe14a8264a520b97f","unresolved":false,"context_lines":[{"line_number":440,"context_line":"               help\u003d\u0027Mount options passed to the NFS client. See section \u0027"},{"line_number":441,"context_line":"                    \u0027of the nfs man page for details\u0027),"},{"line_number":442,"context_line":"    cfg.StrOpt(\u0027nfs_local_symbolic_base\u0027,"},{"line_number":443,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt_link\u0027),"},{"line_number":444,"context_line":"               help\u003d\u0027Directory where the NFS volume is linked in local \u0027"},{"line_number":445,"context_line":"                    \u0027compute node\u0027),"},{"line_number":446,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_012ae2da","line":443,"in_reply_to":"dada55a8_2a1c4dc0","updated":"2016-07-21 06:26:53.000000000","message":"Hi Andrey,\n\nCurrently when using NFS as volume backend, Nova maps the NFS folder to local in the mount path /opt/stack/nova/mnt/[hash]/. \n\nIn this patch, I created a folder in local machine, its default value is /opt/stack/nova/mnt_symbolic/[hash]. The symbolic link refer to real file in mount_path is saved here.","commit_id":"80099727300e78ac1d37eca1abc769e5f8d67398"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"372415a7081495048acb3eafe14a8264a520b97f","unresolved":false,"context_lines":[{"line_number":440,"context_line":"               help\u003d\u0027Mount options passed to the NFS client. See section \u0027"},{"line_number":441,"context_line":"                    \u0027of the nfs man page for details\u0027),"},{"line_number":442,"context_line":"    cfg.StrOpt(\u0027nfs_local_symbolic_base\u0027,"},{"line_number":443,"context_line":"               default\u003dpaths.state_path_def(\u0027mnt_link\u0027),"},{"line_number":444,"context_line":"               help\u003d\u0027Directory where the NFS volume is linked in local \u0027"},{"line_number":445,"context_line":"                    \u0027compute node\u0027),"},{"line_number":446,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_c1828ac7","line":443,"in_reply_to":"dada55a8_34d01d1f","updated":"2016-07-21 06:26:53.000000000","message":"I update it to mnt_symbolic, but still not sure it is good.","commit_id":"80099727300e78ac1d37eca1abc769e5f8d67398"}],"nova/virt/libvirt/volume/nfs.py":[{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"7ea2d482c572e4571a2a09f5217c8c8a954b0aad","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            utils.execute(\u0027unlink\u0027, symbolic_path)"},{"line_number":92,"context_line":"        except processutils.ProcessExecutionError as exc:"},{"line_number":93,"context_line":"            LOG.exception(_LE(\"Couldn\u0027t unlink the NFS share %s\"),"},{"line_number":94,"context_line":"                          symbolic_path)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _ensure_mounted(self, connection_info):"},{"line_number":97,"context_line":"        \"\"\"@type connection_info: dict"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_340e5d3b","line":94,"updated":"2016-07-20 18:09:10.000000000","message":"Wouldn\u0027t it be better to unlink prior to unmounting the volume?","commit_id":"80099727300e78ac1d37eca1abc769e5f8d67398"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"372415a7081495048acb3eafe14a8264a520b97f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            utils.execute(\u0027unlink\u0027, symbolic_path)"},{"line_number":92,"context_line":"        except processutils.ProcessExecutionError as exc:"},{"line_number":93,"context_line":"            LOG.exception(_LE(\"Couldn\u0027t unlink the NFS share %s\"),"},{"line_number":94,"context_line":"                          symbolic_path)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _ensure_mounted(self, connection_info):"},{"line_number":97,"context_line":"        \"\"\"@type connection_info: dict"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_a15cb67d","line":94,"in_reply_to":"dada55a8_340e5d3b","updated":"2016-07-21 06:26:53.000000000","message":"Done","commit_id":"80099727300e78ac1d37eca1abc769e5f8d67398"}]}