)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"6c3bd9def80dda97866f2d07ba8efe6383dfaacb","unresolved":false,"context_lines":[{"line_number":5216,"context_line":"            LOG.exception(_LE(\u0027Live migration failed.\u0027), instance\u003dinstance)"},{"line_number":5217,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":5218,"context_line":"                self._set_migration_status(migration, \u0027error\u0027)"},{"line_number":5219,"context_line":"                self._set_instance_obj_error_state(context, instance)"},{"line_number":5220,"context_line":""},{"line_number":5221,"context_line":"    @wrap_exception()"},{"line_number":5222,"context_line":"    @wrap_instance_event(prefix\u003d\u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_d72fec85","line":5219,"updated":"2016-10-14 06:25:51.000000000","message":"I\u0027m not sure this is the way that this issue should be fixed. This try-except block covers too many exceptions. It will basically put all instances into ERROR state even when libvirt throws exception prior to migration. ERROR state would indicate that operator needs to take an action in order to recover such VM, but in such case there is nothing to do.\n\nThere we really should put instance into ACTIVE state rather than ERROR. As long as live migration does not succeed we don\u0027t want to put instance into ERROR state as it continues to operate in the normal way. The only place that we should worry about is post_live_migration_at_destination. If something bad happens there operator needs to take an action, because it is too late for any rollback and very likely nova itself can\u0027t do anything about it.","commit_id":"cb01fc9d0df20287b4e5bdc1f0c63aecb54de8c1"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"b3b17d382e807008157edc64db3c9f019caa5a80","unresolved":false,"context_lines":[{"line_number":5216,"context_line":"            LOG.exception(_LE(\u0027Live migration failed.\u0027), instance\u003dinstance)"},{"line_number":5217,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":5218,"context_line":"                self._set_migration_status(migration, \u0027error\u0027)"},{"line_number":5219,"context_line":"                self._set_instance_obj_error_state(context, instance)"},{"line_number":5220,"context_line":""},{"line_number":5221,"context_line":"    @wrap_exception()"},{"line_number":5222,"context_line":"    @wrap_instance_event(prefix\u003d\u0027compute\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a3c09a3_b8dcb619","line":5219,"in_reply_to":"fa6399be_d72fec85","updated":"2017-01-13 01:12:09.000000000","message":"Hi Pawel!\nI feel you are right, its better keep the VM in Active state as we do the same when migration got aborted or cancelled. We should call rollback_live_migration to clear the task state from \u0027migrating\u0027 to none.","commit_id":"cb01fc9d0df20287b4e5bdc1f0c63aecb54de8c1"}]}