)]}'
{"nova/tests/unit/objects/test_instance.py":[{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"e608d912028eaa7889c3bc5a537fe6f2af6254bb","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        @mock.patch.object(db, \u0027instance_get_by_uuid\u0027)"},{"line_number":401,"context_line":"        @mock.patch.object(db, \u0027instance_update_and_get_original\u0027)"},{"line_number":402,"context_line":"        @mock.patch.object(db, \u0027instance_info_cache_update\u0027)"},{"line_number":403,"context_line":"        @mock.patch.object(cells_api_mock,"},{"line_number":404,"context_line":"                           \u0027instance_update_at_top\u0027)"},{"line_number":405,"context_line":"        @mock.patch.object(cells_api_mock,"},{"line_number":406,"context_line":"                           \u0027instance_update_from_api\u0027)"},{"line_number":407,"context_line":"        @mock.patch.object(cells_rpcapi, \u0027CellsAPI\u0027,"},{"line_number":408,"context_line":"                           use_mock_anything\u003dTrue)"},{"line_number":409,"context_line":"        @mock.patch.object(notifications, \u0027send_update\u0027)"},{"line_number":410,"context_line":"        def _do_test(mock_send, mock_cells,"},{"line_number":411,"context_line":"                     mock_update_from_api, mock_update_at_top,"},{"line_number":412,"context_line":"                     mock_cache_update, mock_get_orig, mock_get_uuid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_eb866b15","line":409,"range":{"start_line":403,"start_character":0,"end_line":409,"end_character":56},"updated":"2016-10-17 20:26:11.000000000","message":"These don\u0027t need to be wrapped, they each fit on one line.\n\n        @mock.patch.object(cells_api_mock,\u0027instance_update_at_top\u0027)\n        @mock.patch.object(cells_api_mock, \u0027instance_update_from_api\u0027)\n        @mock.patch.object(cells_rpcapi, \u0027CellsAPI\u0027, use_mock_anything\u003dTrue)","commit_id":"7e7e68d0ba5ae214a4c6fb2215f7999208493299"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"f8633b15b785082e4810f87c5d621d9a2081720a","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        @mock.patch.object(db, \u0027instance_get_by_uuid\u0027)"},{"line_number":401,"context_line":"        @mock.patch.object(db, \u0027instance_update_and_get_original\u0027)"},{"line_number":402,"context_line":"        @mock.patch.object(db, \u0027instance_info_cache_update\u0027)"},{"line_number":403,"context_line":"        @mock.patch.object(cells_api_mock,"},{"line_number":404,"context_line":"                           \u0027instance_update_at_top\u0027)"},{"line_number":405,"context_line":"        @mock.patch.object(cells_api_mock,"},{"line_number":406,"context_line":"                           \u0027instance_update_from_api\u0027)"},{"line_number":407,"context_line":"        @mock.patch.object(cells_rpcapi, \u0027CellsAPI\u0027,"},{"line_number":408,"context_line":"                           use_mock_anything\u003dTrue)"},{"line_number":409,"context_line":"        @mock.patch.object(notifications, \u0027send_update\u0027)"},{"line_number":410,"context_line":"        def _do_test(mock_send, mock_cells,"},{"line_number":411,"context_line":"                     mock_update_from_api, mock_update_at_top,"},{"line_number":412,"context_line":"                     mock_cache_update, mock_get_orig, mock_get_uuid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_92f7db8b","line":409,"range":{"start_line":403,"start_character":0,"end_line":409,"end_character":56},"in_reply_to":"fa6399be_32628fae","updated":"2016-10-18 01:04:07.000000000","message":"Which line is over the pep8 limit? It looks to me like the longest line is only 76 characters long.\n\n    \u003e\u003e\u003e len(\"        @mock.patch.object(cells_rpcapi, \u0027CellsAPI\u0027, use_mock_anything\u003dTrue)\")\n    76\n\nHere\u0027s a diff on top of yours showing pep8 passing:\n\n  http://paste.openstack.org/show/586076/","commit_id":"7e7e68d0ba5ae214a4c6fb2215f7999208493299"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"073c0b7ac979dce011a22953e21015242b7df291","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        @mock.patch.object(db, \u0027instance_get_by_uuid\u0027)"},{"line_number":401,"context_line":"        @mock.patch.object(db, \u0027instance_update_and_get_original\u0027)"},{"line_number":402,"context_line":"        @mock.patch.object(db, \u0027instance_info_cache_update\u0027)"},{"line_number":403,"context_line":"        @mock.patch.object(cells_api_mock,"},{"line_number":404,"context_line":"                           \u0027instance_update_at_top\u0027)"},{"line_number":405,"context_line":"        @mock.patch.object(cells_api_mock,"},{"line_number":406,"context_line":"                           \u0027instance_update_from_api\u0027)"},{"line_number":407,"context_line":"        @mock.patch.object(cells_rpcapi, \u0027CellsAPI\u0027,"},{"line_number":408,"context_line":"                           use_mock_anything\u003dTrue)"},{"line_number":409,"context_line":"        @mock.patch.object(notifications, \u0027send_update\u0027)"},{"line_number":410,"context_line":"        def _do_test(mock_send, mock_cells,"},{"line_number":411,"context_line":"                     mock_update_from_api, mock_update_at_top,"},{"line_number":412,"context_line":"                     mock_cache_update, mock_get_orig, mock_get_uuid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_32628fae","line":409,"range":{"start_line":403,"start_character":0,"end_line":409,"end_character":56},"in_reply_to":"fa6399be_eb866b15","updated":"2016-10-18 00:51:56.000000000","message":"pep8 will fail because of over 80 char in one line.","commit_id":"7e7e68d0ba5ae214a4c6fb2215f7999208493299"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"50580dae4b7baac5c660a4ce10e18d5f35b6c11d","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                mock_update_at_top.assert_called_once_with(self.context,"},{"line_number":450,"context_line":"                        test.MatchType(objects.Instance))"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"            _do_test()"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def test_save(self):"},{"line_number":455,"context_line":"        self._save_test_helper(None, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_05e2b6d5","line":452,"range":{"start_line":452,"start_character":0,"end_line":452,"end_character":22},"updated":"2017-01-13 08:45:55.000000000","message":"opps. it does not call anything. move it on proper indentation.","commit_id":"7e7e68d0ba5ae214a4c6fb2215f7999208493299"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"b417205dfb4ae52fa155fed3d4bf7cdb018524f0","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                mock_update_at_top.assert_called_once_with(self.context,"},{"line_number":450,"context_line":"                        test.MatchType(objects.Instance))"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"            _do_test()"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def test_save(self):"},{"line_number":455,"context_line":"        self._save_test_helper(None, {})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_8a8515d0","line":452,"range":{"start_line":452,"start_character":0,"end_line":452,"end_character":22},"in_reply_to":"7a3c09a3_05e2b6d5","updated":"2017-01-18 04:29:29.000000000","message":"Done :(","commit_id":"7e7e68d0ba5ae214a4c6fb2215f7999208493299"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"a43002c9cc20eff52bb85e2c9a61c5acc4dc5ca4","unresolved":false,"context_lines":[{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        expected_updates \u003d dict(vm_state\u003d\u0027meow\u0027, task_state\u003d\u0027wuff\u0027,"},{"line_number":384,"context_line":"                                user_data\u003d\u0027new\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        new_ref \u003d dict(old_ref, host\u003d\u0027newhost\u0027, **expected_updates)"},{"line_number":387,"context_line":"        exp_vm_state \u003d save_kwargs.get(\u0027expected_vm_state\u0027)"},{"line_number":388,"context_line":"        exp_task_state \u003d save_kwargs.get(\u0027expected_task_state\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_b33ad296","side":"PARENT","line":385,"updated":"2017-01-20 08:20:25.000000000","message":"unrelated change","commit_id":"3f700b5a5a498ba08e77378d34f059c3fa6845d8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f741d63f1814f06988ca7d139ff1eb5bb2963e4b","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _save_test_helper(self, cell_type, save_kwargs):"},{"line_number":372,"context_line":"        \"\"\"Common code for testing save() for cells/non-cells.\"\"\""},{"line_number":373,"context_line":"        cells_api_mock \u003d mock.MagicMock(spec\u003dcells_rpcapi.CellsAPI)"},{"line_number":374,"context_line":"        if cell_type:"},{"line_number":375,"context_line":"            self.flags(enable\u003dTrue, cell_type\u003dcell_type, group\u003d\u0027cells\u0027)"},{"line_number":376,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_7e195579","line":373,"range":{"start_line":373,"start_character":8,"end_line":373,"end_character":67},"updated":"2017-02-27 16:04:35.000000000","message":"Why is it necessary to mock the entire object, given that we are already mocking the affected methods below?","commit_id":"e333e52c703a55e7eb200e22bc6c24c452ec129f"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"b2a0d9d3bd8fd2a757804dab1656db36285923ce","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _save_test_helper(self, cell_type, save_kwargs):"},{"line_number":372,"context_line":"        \"\"\"Common code for testing save() for cells/non-cells.\"\"\""},{"line_number":373,"context_line":"        cells_api_mock \u003d mock.MagicMock(spec\u003dcells_rpcapi.CellsAPI)"},{"line_number":374,"context_line":"        if cell_type:"},{"line_number":375,"context_line":"            self.flags(enable\u003dTrue, cell_type\u003dcell_type, group\u003d\u0027cells\u0027)"},{"line_number":376,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_47199321","line":373,"range":{"start_line":373,"start_character":8,"end_line":373,"end_character":67},"in_reply_to":"da36d5c6_7e195579","updated":"2017-03-03 03:09:38.000000000","message":"I have just converted from old mox code in L403 to this mock.\nOtherwise, we did moxed init() method of cells_rpcapi to return the mocked object in L421","commit_id":"e333e52c703a55e7eb200e22bc6c24c452ec129f"}]}