)]}'
{"nova/conf/xenserver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b4a2742d9527cef84b144270a913c9bb80dbd2e6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"XenServer options are used when the compute_driver is set to use"},{"line_number":30,"context_line":"XenServer (compute_driver\u003dxenapi.XenAPIDriver)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Must specify connection_url, connection_username (optionally),"},{"line_number":33,"context_line":"and connection_password to use compute_driver\u003dxenapi.XenAPIDriver."},{"line_number":34,"context_line":"\"\"\")"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_2342f310","line":32,"range":{"start_line":32,"start_character":29,"end_line":32,"end_character":61},"updated":"2016-08-09 17:00:02.000000000","message":"I would drop this bit.","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"2710bd7d2710c44743f87d54c10ebb3f57992d48","unresolved":false,"context_lines":[{"line_number":29,"context_line":"XenServer options are used when the compute_driver is set to use"},{"line_number":30,"context_line":"XenServer (compute_driver\u003dxenapi.XenAPIDriver)."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Must specify connection_url, connection_username (optionally),"},{"line_number":33,"context_line":"and connection_password to use compute_driver\u003dxenapi.XenAPIDriver."},{"line_number":34,"context_line":"\"\"\")"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_bf5b8b2d","line":32,"range":{"start_line":32,"start_character":29,"end_line":32,"end_character":61},"in_reply_to":"9ad45d7e_2342f310","updated":"2016-08-09 20:41:23.000000000","message":"Done","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b4a2742d9527cef84b144270a913c9bb80dbd2e6","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Possible values:"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"   * Any string that represents a URL. The connection_url is"},{"line_number":325,"context_line":"     generally the management network IP address of the XenServer."},{"line_number":326,"context_line":"   * By default this option is not set."},{"line_number":327,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_03108fa7","line":324,"range":{"start_line":324,"start_character":0,"end_line":324,"end_character":3},"updated":"2016-08-09 17:00:02.000000000","message":"Nit: we shouldn\u0027t have this indent here, ideally.","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"2710bd7d2710c44743f87d54c10ebb3f57992d48","unresolved":false,"context_lines":[{"line_number":321,"context_line":""},{"line_number":322,"context_line":"Possible values:"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"   * Any string that represents a URL. The connection_url is"},{"line_number":325,"context_line":"     generally the management network IP address of the XenServer."},{"line_number":326,"context_line":"   * By default this option is not set."},{"line_number":327,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_5f4d2f6b","line":324,"range":{"start_line":324,"start_character":0,"end_line":324,"end_character":3},"in_reply_to":"9ad45d7e_03108fa7","updated":"2016-08-09 20:41:23.000000000","message":"Done","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b4a2742d9527cef84b144270a913c9bb80dbd2e6","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"   * Any string that represents a URL. The connection_url is"},{"line_number":325,"context_line":"     generally the management network IP address of the XenServer."},{"line_number":326,"context_line":"   * By default this option is not set."},{"line_number":327,"context_line":"\"\"\"),"},{"line_number":328,"context_line":"    cfg.StrOpt(\u0027connection_username\u0027,"},{"line_number":329,"context_line":"               default\u003d\u0027root\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_c3ecb72b","line":326,"range":{"start_line":326,"start_character":0,"end_line":326,"end_character":39},"updated":"2016-08-09 17:00:02.000000000","message":"Not sure we need to say this.\n\nBut you should repeat what you say in line33, this is a required option if you chose the XenServer driver.","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"2710bd7d2710c44743f87d54c10ebb3f57992d48","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"   * Any string that represents a URL. The connection_url is"},{"line_number":325,"context_line":"     generally the management network IP address of the XenServer."},{"line_number":326,"context_line":"   * By default this option is not set."},{"line_number":327,"context_line":"\"\"\"),"},{"line_number":328,"context_line":"    cfg.StrOpt(\u0027connection_username\u0027,"},{"line_number":329,"context_line":"               default\u003d\u0027root\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_7f78f38f","line":326,"range":{"start_line":326,"start_character":0,"end_line":326,"end_character":39},"in_reply_to":"9ad45d7e_c3ecb72b","updated":"2016-08-09 20:41:23.000000000","message":"Done","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b4a2742d9527cef84b144270a913c9bb80dbd2e6","unresolved":false,"context_lines":[{"line_number":332,"context_line":"               secret\u003dTrue,"},{"line_number":333,"context_line":"               help\u003d\u0027Password for connection to XenServer/Xen Cloud Platform\u0027),"},{"line_number":334,"context_line":"    cfg.FloatOpt(\u0027vhd_coalesce_poll_interval\u0027,"},{"line_number":335,"context_line":"                 default\u003d5.0,"},{"line_number":336,"context_line":"                 help\u003d\"\"\""},{"line_number":337,"context_line":"The interval used for polling of coalescing vhds."},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_436e0797","line":335,"updated":"2016-08-09 17:00:02.000000000","message":"min\u003d0 should be added here.","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"2710bd7d2710c44743f87d54c10ebb3f57992d48","unresolved":false,"context_lines":[{"line_number":332,"context_line":"               secret\u003dTrue,"},{"line_number":333,"context_line":"               help\u003d\u0027Password for connection to XenServer/Xen Cloud Platform\u0027),"},{"line_number":334,"context_line":"    cfg.FloatOpt(\u0027vhd_coalesce_poll_interval\u0027,"},{"line_number":335,"context_line":"                 default\u003d5.0,"},{"line_number":336,"context_line":"                 help\u003d\"\"\""},{"line_number":337,"context_line":"The interval used for polling of coalescing vhds."},{"line_number":338,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_ffab43d4","line":335,"in_reply_to":"9ad45d7e_436e0797","updated":"2016-08-09 20:41:23.000000000","message":"Done","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b4a2742d9527cef84b144270a913c9bb80dbd2e6","unresolved":false,"context_lines":[{"line_number":375,"context_line":"\"\"\"),"},{"line_number":376,"context_line":"    cfg.StrOpt(\u0027sr_base_path\u0027,"},{"line_number":377,"context_line":"               default\u003d\u0027/var/run/sr-mount\u0027,"},{"line_number":378,"context_line":"               help\u003d\u0027Base path to the storage repository\u0027),"},{"line_number":379,"context_line":"    cfg.StrOpt(\u0027target_host\u0027,"},{"line_number":380,"context_line":"               help\u003d\"\"\""},{"line_number":381,"context_line":"The iSCSI Target Host."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_e388db24","line":378,"updated":"2016-08-09 17:00:02.000000000","message":"I think we should note that this directory is about the directory on the XenServer host.","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"2710bd7d2710c44743f87d54c10ebb3f57992d48","unresolved":false,"context_lines":[{"line_number":375,"context_line":"\"\"\"),"},{"line_number":376,"context_line":"    cfg.StrOpt(\u0027sr_base_path\u0027,"},{"line_number":377,"context_line":"               default\u003d\u0027/var/run/sr-mount\u0027,"},{"line_number":378,"context_line":"               help\u003d\u0027Base path to the storage repository\u0027),"},{"line_number":379,"context_line":"    cfg.StrOpt(\u0027target_host\u0027,"},{"line_number":380,"context_line":"               help\u003d\"\"\""},{"line_number":381,"context_line":"The iSCSI Target Host."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_7f3bd39c","line":378,"in_reply_to":"9ad45d7e_e388db24","updated":"2016-08-09 20:41:23.000000000","message":"Done","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b4a2742d9527cef84b144270a913c9bb80dbd2e6","unresolved":false,"context_lines":[{"line_number":387,"context_line":"Possible values:"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"   * Any string that represents hostname/ip of Target."},{"line_number":390,"context_line":"   * By default this option is not set."},{"line_number":391,"context_line":"\"\"\"),"},{"line_number":392,"context_line":"    cfg.StrOpt(\u0027target_port\u0027,"},{"line_number":393,"context_line":"               default\u003d\u00273260\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_c307977f","line":390,"range":{"start_line":390,"start_character":5,"end_line":390,"end_character":39},"updated":"2016-08-09 17:00:02.000000000","message":"What is the default behaviour here? I don\u0027t think you have to set it, its a bit confusing. I would just drop this line.","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"2710bd7d2710c44743f87d54c10ebb3f57992d48","unresolved":false,"context_lines":[{"line_number":387,"context_line":"Possible values:"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"   * Any string that represents hostname/ip of Target."},{"line_number":390,"context_line":"   * By default this option is not set."},{"line_number":391,"context_line":"\"\"\"),"},{"line_number":392,"context_line":"    cfg.StrOpt(\u0027target_port\u0027,"},{"line_number":393,"context_line":"               default\u003d\u00273260\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_9f5fa7e4","line":390,"range":{"start_line":390,"start_character":5,"end_line":390,"end_character":39},"in_reply_to":"9ad45d7e_c307977f","updated":"2016-08-09 20:41:23.000000000","message":"Done","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b4a2742d9527cef84b144270a913c9bb80dbd2e6","unresolved":false,"context_lines":[{"line_number":389,"context_line":"   * Any string that represents hostname/ip of Target."},{"line_number":390,"context_line":"   * By default this option is not set."},{"line_number":391,"context_line":"\"\"\"),"},{"line_number":392,"context_line":"    cfg.StrOpt(\u0027target_port\u0027,"},{"line_number":393,"context_line":"               default\u003d\u00273260\u0027,"},{"line_number":394,"context_line":"               help\u003d\"\"\""},{"line_number":395,"context_line":"The iSCSI Target Port."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_03eb6fb1","line":392,"range":{"start_line":392,"start_character":8,"end_line":392,"end_character":14},"updated":"2016-08-09 17:00:02.000000000","message":"It should be a PortOpt","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"2710bd7d2710c44743f87d54c10ebb3f57992d48","unresolved":false,"context_lines":[{"line_number":389,"context_line":"   * Any string that represents hostname/ip of Target."},{"line_number":390,"context_line":"   * By default this option is not set."},{"line_number":391,"context_line":"\"\"\"),"},{"line_number":392,"context_line":"    cfg.StrOpt(\u0027target_port\u0027,"},{"line_number":393,"context_line":"               default\u003d\u00273260\u0027,"},{"line_number":394,"context_line":"               help\u003d\"\"\""},{"line_number":395,"context_line":"The iSCSI Target Port."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_7f0913dd","line":392,"range":{"start_line":392,"start_character":8,"end_line":392,"end_character":14},"in_reply_to":"9ad45d7e_03eb6fb1","updated":"2016-08-09 20:41:23.000000000","message":"Done","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"3cc7159fa47cd920b0d64e8561c8554caa475f62","unresolved":false,"context_lines":[{"line_number":389,"context_line":"   * Any string that represents hostname/ip of Target."},{"line_number":390,"context_line":"   * By default this option is not set."},{"line_number":391,"context_line":"\"\"\"),"},{"line_number":392,"context_line":"    cfg.StrOpt(\u0027target_port\u0027,"},{"line_number":393,"context_line":"               default\u003d\u00273260\u0027,"},{"line_number":394,"context_line":"               help\u003d\"\"\""},{"line_number":395,"context_line":"The iSCSI Target Port."}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_86f25204","line":392,"range":{"start_line":392,"start_character":8,"end_line":392,"end_character":14},"in_reply_to":"9ad45d7e_03eb6fb1","updated":"2016-08-11 16:00:31.000000000","message":"If I change this to PortOpt some test cases are failing since they are expecting a string and I gave default value an integer. So in this patch I\u0027\u0027ll add a TODO and will do that change in a separate patch.","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b4a2742d9527cef84b144270a913c9bb80dbd2e6","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"Related options:"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"   * ``CONF.flat_injected`` (Must be False)"},{"line_number":427,"context_line":"   * ``CONF.xenserver.check_host`` (Must be False)"},{"line_number":428,"context_line":"   * ``CONF.default_ephemeral_format`` (Must be unset or \u0027ext3\u0027)"},{"line_number":429,"context_line":"   * Joining host aggregates (will error if attempted)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_e3129bb3","line":426,"range":{"start_line":426,"start_character":0,"end_line":426,"end_character":3},"updated":"2016-08-09 17:00:02.000000000","message":"Nit: we should remove this indent here, as with all the above things.","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"2710bd7d2710c44743f87d54c10ebb3f57992d48","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"Related options:"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"   * ``CONF.flat_injected`` (Must be False)"},{"line_number":427,"context_line":"   * ``CONF.xenserver.check_host`` (Must be False)"},{"line_number":428,"context_line":"   * ``CONF.default_ephemeral_format`` (Must be unset or \u0027ext3\u0027)"},{"line_number":429,"context_line":"   * Joining host aggregates (will error if attempted)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_bf138b0c","line":426,"range":{"start_line":426,"start_character":0,"end_line":426,"end_character":3},"in_reply_to":"9ad45d7e_e3129bb3","updated":"2016-08-09 20:41:23.000000000","message":"Done","commit_id":"6a5d53ff9cf2fe6846a314328b7545fa631fdb06"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6b38e6b3700474f0015f36fd74e578d52b639409","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"xenapi_opts \u003d ["},{"line_number":308,"context_line":"    cfg.StrOpt(\u0027connection_url\u0027,"},{"line_number":309,"context_line":"               help\u003d\"\"\""},{"line_number":310,"context_line":"URL for connection to XenServer/Xen Cloud Platform. A special value"},{"line_number":311,"context_line":"of unix://local can be used to connect to the local unix socket."}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_c60241b4","line":308,"updated":"2016-08-02 21:02:33.000000000","message":"Just a thought, https://github.com/openstack/nova/blob/a0c5fbb2b5b66f28dcad6b40d7f2011afee5dde0/nova/virt/xenapi/driver.py#L76 checks if URL is empty and raise an exception. Can we add regex here to make sure this string is not empty.","commit_id":"d9082a15d180d28e23bad91c2c6a7a56f0043b56"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"ab940fe8ab83f4f7de4052dff4c4fdea19283fa0","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"xenapi_opts \u003d ["},{"line_number":308,"context_line":"    cfg.StrOpt(\u0027connection_url\u0027,"},{"line_number":309,"context_line":"               help\u003d\"\"\""},{"line_number":310,"context_line":"URL for connection to XenServer/Xen Cloud Platform. A special value"},{"line_number":311,"context_line":"of unix://local can be used to connect to the local unix socket."}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_02f3740b","line":308,"in_reply_to":"bacf61ea_c60241b4","updated":"2016-08-03 16:31:18.000000000","message":"I am not quite sure to add regex here, because the default value of this option itself is None. This option must be set if xenserver is enabled. If xen is not enabled this option can be empty. So I added in the group help text that this option must be set if you enable xenserver.","commit_id":"d9082a15d180d28e23bad91c2c6a7a56f0043b56"},{"author":{"_account_id":2506,"name":"devdatta-kulkarni","email":"kulkarni.devdatta@gmail.com","username":"devdatta-kulkarni"},"change_message_id":"df0ad6e6d88cb9fd7a53373769a228b1db52f981","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"xenapi_opts \u003d ["},{"line_number":308,"context_line":"    cfg.StrOpt(\u0027connection_url\u0027,"},{"line_number":309,"context_line":"               help\u003d\"\"\""},{"line_number":310,"context_line":"URL for connection to XenServer/Xen Cloud Platform. A special value"},{"line_number":311,"context_line":"of unix://local can be used to connect to the local unix socket."}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_c7123c58","line":308,"in_reply_to":"bacf61ea_c60241b4","updated":"2016-08-02 21:48:18.000000000","message":"I think that can be done in a separate patch.","commit_id":"d9082a15d180d28e23bad91c2c6a7a56f0043b56"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"7c60bea7df147710988f3a3183933c9fdd684e52","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"xenapi_opts \u003d ["},{"line_number":308,"context_line":"    cfg.StrOpt(\u0027connection_url\u0027,"},{"line_number":309,"context_line":"               help\u003d\"\"\""},{"line_number":310,"context_line":"URL for connection to XenServer/Xen Cloud Platform. A special value"},{"line_number":311,"context_line":"of unix://local can be used to connect to the local unix socket."}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_273b589e","line":308,"in_reply_to":"bacf61ea_c7123c58","updated":"2016-08-02 21:55:37.000000000","message":"It could be, so either add TODO or leave the header flag to make sure of that.","commit_id":"d9082a15d180d28e23bad91c2c6a7a56f0043b56"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3eab73f91aa4a5570850344ecf069708323aa3f6","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"Possible values:"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"   * Any string that represents a URL. The connection_url is"},{"line_number":316,"context_line":"     generally the management network IP address of the XenServer."},{"line_number":317,"context_line":"   * By default this option is not set."},{"line_number":318,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_be8b961d","line":315,"range":{"start_line":315,"start_character":0,"end_line":315,"end_character":3},"updated":"2016-08-09 17:14:47.000000000","message":"Nit: we should remove these gaps","commit_id":"d9082a15d180d28e23bad91c2c6a7a56f0043b56"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6b38e6b3700474f0015f36fd74e578d52b639409","unresolved":false,"context_lines":[{"line_number":320,"context_line":"               default\u003d\u0027root\u0027,"},{"line_number":321,"context_line":"               help\u003d\u0027Username for connection to XenServer/Xen Cloud Platform\u0027),"},{"line_number":322,"context_line":"    cfg.StrOpt(\u0027connection_password\u0027,"},{"line_number":323,"context_line":"               secret\u003dTrue,"},{"line_number":324,"context_line":"               help\u003d\u0027Password for connection to XenServer/Xen Cloud Platform\u0027),"},{"line_number":325,"context_line":"    cfg.FloatOpt(\u0027vhd_coalesce_poll_interval\u0027,"},{"line_number":326,"context_line":"                 default\u003d5.0,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_c619a124","line":323,"updated":"2016-08-02 21:02:33.000000000","message":"Same thing. Add regex to check its not \u0027None\u0027","commit_id":"d9082a15d180d28e23bad91c2c6a7a56f0043b56"},{"author":{"_account_id":21111,"name":"STEW TY","email":"punsoca@gmail.com","username":"stewie925"},"change_message_id":"6935b4676cb9f167396769bc6e7e9fb402833123","unresolved":false,"context_lines":[{"line_number":290,"context_line":"* `independent_compute`"},{"line_number":291,"context_line":"\"\"\"),"},{"line_number":292,"context_line":"    cfg.IntOpt(\u0027vhd_coalesce_max_attempts\u0027,"},{"line_number":293,"context_line":"               min\u003d0,"},{"line_number":294,"context_line":"               default\u003d20,"},{"line_number":295,"context_line":"               help\u003d\"\"\""},{"line_number":296,"context_line":"Max number of times to poll for VHD to coalesce."}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_fc7b1626","line":293,"range":{"start_line":293,"start_character":0,"end_line":293,"end_character":21},"updated":"2016-08-10 18:24:51.000000000","message":"Nit:  \"min\u003d\" should be below the \"default\u003d\" line.","commit_id":"a8689b884b74dcdaa9976d89a0196fe2be2eb4d0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fa5c420fe122f3b8e8f5ef41cccb6ce8cea72c53","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"xenapi_opts \u003d ["},{"line_number":244,"context_line":"    cfg.StrOpt(\u0027connection_url\u0027,"},{"line_number":245,"context_line":"               help\u003d\"\"\""},{"line_number":246,"context_line":"URL for connection to XenServer/Xen Cloud Platform. A special value"},{"line_number":247,"context_line":"of unix://local can be used to connect to the local unix socket."}],"source_content_type":"text/x-python","patch_set":10,"id":"9ad45d7e_069f3860","line":244,"updated":"2016-08-12 17:25:55.000000000","message":"Nit: this could be URIOpt","commit_id":"0047a76ee805059fbaf1c3d68b8146c8af0feacc"}]}