)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"7c41bfd1c98466150b81ca6ac98e85697762de82","unresolved":false,"context_lines":[{"line_number":6244,"context_line":"                # Migration is all done"},{"line_number":6245,"context_line":"                LOG.info(_LI(\"Migration operation has completed\"),"},{"line_number":6246,"context_line":"                         instance\u003dinstance)"},{"line_number":6247,"context_line":"                if conductor_orchestration:"},{"line_number":6248,"context_line":"                    post_method(context, instance, migrate_data)"},{"line_number":6249,"context_line":"                else:"},{"line_number":6250,"context_line":"                    post_method(context, instance, dest, block_migration,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_dc31a8a3","line":6247,"updated":"2016-07-21 18:34:45.000000000","message":"I don\u0027 think we need such condition there. This code should be cleaned up so that post_method and recover_method would not need to take dest and block_migration parameters anymore. Such cleanup is safe as both calls are internal, not over RPC.\n\nIf you don\u0027t want cleanup we can simplify this anyway and check once whether conductor_orchestration is True and build kwargs basing on this if condition. So that you will pass empty **kwargs or **kwargs containing destination host. But in such case I\u0027d like to see this patch depending on https://review.openstack.org/#/c/295315/. Let\u0027s stop playing with block_migration parameter.","commit_id":"a4f620c6fc22b6c2856fc244ad035ec2b1c8eb5b"}]}