)]}'
{"nova/netconf.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7d984e6095e814ab34a56769420f1ff5d0252e89","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        try:"},{"line_number":50,"context_line":"            addresses \u003d utils.get_my_ipv4_addresses()[0]"},{"line_number":51,"context_line":"            if not addresses:"},{"line_number":52,"context_line":"                my_ip \u003d addresses[0]"},{"line_number":53,"context_line":"        except exception.NovaException:"},{"line_number":54,"context_line":"            pass"},{"line_number":55,"context_line":"    LOG.debug(\"_get_my_ip : %s\", my_ip)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FrV8%3D","line":52,"updated":"2013-06-25 13:49:56.000000000","message":"Isn\u0027t the logic here backwards? If addresses equates to false, it\u0027s probably not a good idea to expect it has an element...","commit_id":"baf5469fa8076a73b233985b65b7e0004d4ca8f5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7d984e6095e814ab34a56769420f1ff5d0252e89","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        except exception.NovaException:"},{"line_number":54,"context_line":"            pass"},{"line_number":55,"context_line":"    LOG.debug(\"_get_my_ip : %s\", my_ip)"},{"line_number":56,"context_line":"    return my_ip"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"netconf_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FrVI%3D","line":56,"updated":"2013-06-25 13:49:56.000000000","message":"You added tests for the utility function, but not for this one to ensure all the possible outcomes are correct (which would have caught the above issue).","commit_id":"baf5469fa8076a73b233985b65b7e0004d4ca8f5"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"e386d801f4920800dc4a10170759bcb6913e8f76","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        except exception.NovaException:"},{"line_number":54,"context_line":"            pass"},{"line_number":55,"context_line":"    LOG.debug(\"_get_my_ip : %s\", my_ip)"},{"line_number":56,"context_line":"    return my_ip"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"netconf_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fpfo%3D","line":56,"in_reply_to":"AAAAPn%2F%2FrVI%3D","updated":"2013-06-26 00:22:07.000000000","message":"next patch is far simpler. please take a peek.","commit_id":"baf5469fa8076a73b233985b65b7e0004d4ca8f5"}],"nova/utils.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"40d7824eb43acce4046815606e43c383f7a02882","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    \"\"\""},{"line_number":327,"context_line":"    r \u003d re.compile(r\u0027inet\\s*\\w*\\S*:\\s*(\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3})\u0027)"},{"line_number":328,"context_line":"    try:"},{"line_number":329,"context_line":"        out \u003d execute(\u0027ifconfig\u0027)"},{"line_number":330,"context_line":"        return [m.group(1) for m in r.finditer(out[0])"},{"line_number":331,"context_line":"                if m.group(1) !\u003d \u0027127.0.0.1\u0027]"},{"line_number":332,"context_line":"    except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FrS8%3D","line":329,"updated":"2013-06-25 13:53:16.000000000","message":"would it not be better to use \u0027ip addr\u0027?\ni think that the ifconfig format may differ between various distributions (i may be wrong here)","commit_id":"baf5469fa8076a73b233985b65b7e0004d4ca8f5"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"e386d801f4920800dc4a10170759bcb6913e8f76","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    \"\"\""},{"line_number":327,"context_line":"    r \u003d re.compile(r\u0027inet\\s*\\w*\\S*:\\s*(\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3})\u0027)"},{"line_number":328,"context_line":"    try:"},{"line_number":329,"context_line":"        out \u003d execute(\u0027ifconfig\u0027)"},{"line_number":330,"context_line":"        return [m.group(1) for m in r.finditer(out[0])"},{"line_number":331,"context_line":"                if m.group(1) !\u003d \u0027127.0.0.1\u0027]"},{"line_number":332,"context_line":"    except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fpfc%3D","line":329,"in_reply_to":"AAAAPn%2F%2Fqt8%3D","updated":"2013-06-26 00:22:07.000000000","message":"right, still switched to ip addr/route","commit_id":"baf5469fa8076a73b233985b65b7e0004d4ca8f5"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"e386d801f4920800dc4a10170759bcb6913e8f76","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    \"\"\""},{"line_number":327,"context_line":"    r \u003d re.compile(r\u0027inet\\s*\\w*\\S*:\\s*(\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3})\u0027)"},{"line_number":328,"context_line":"    try:"},{"line_number":329,"context_line":"        out \u003d execute(\u0027ifconfig\u0027)"},{"line_number":330,"context_line":"        return [m.group(1) for m in r.finditer(out[0])"},{"line_number":331,"context_line":"                if m.group(1) !\u003d \u0027127.0.0.1\u0027]"},{"line_number":332,"context_line":"    except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fpfg%3D","line":329,"in_reply_to":"AAAAPn%2F%2FrS8%3D","updated":"2013-06-26 00:22:07.000000000","message":"Done","commit_id":"baf5469fa8076a73b233985b65b7e0004d4ca8f5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4a8c41b413d04a7997fa4f473a87dabf089a57f3","unresolved":false,"context_lines":[{"line_number":326,"context_line":"    \"\"\""},{"line_number":327,"context_line":"    r \u003d re.compile(r\u0027inet\\s*\\w*\\S*:\\s*(\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3})\u0027)"},{"line_number":328,"context_line":"    try:"},{"line_number":329,"context_line":"        out \u003d execute(\u0027ifconfig\u0027)"},{"line_number":330,"context_line":"        return [m.group(1) for m in r.finditer(out[0])"},{"line_number":331,"context_line":"                if m.group(1) !\u003d \u0027127.0.0.1\u0027]"},{"line_number":332,"context_line":"    except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fqt8%3D","line":329,"in_reply_to":"AAAAPn%2F%2FrS8%3D","updated":"2013-06-25 16:42:22.000000000","message":"I don\u0027t think ifconfig output will differ between distros, but using ip is better for reasons I detailed previously (i.e. interfaces with multiple addresses).","commit_id":"baf5469fa8076a73b233985b65b7e0004d4ca8f5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"94bfec0ce460d450efd1a2d836cd50173c81f932","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                    try:"},{"line_number":342,"context_line":"                        return _get_ipv4_address_for_interface(iface)"},{"line_number":343,"context_line":"                    except exception.NovaException:"},{"line_number":344,"context_line":"                        pass"},{"line_number":345,"context_line":"    except Exception as ex:"},{"line_number":346,"context_line":"        LOG.error(_(\"Couldn\u0027t get IPv4 : %(ex)s\") % {\u0027ex\u0027: ex})"},{"line_number":347,"context_line":"    return \u0027127.0.0.1\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fpdg%3D","line":344,"updated":"2013-06-26 01:00:16.000000000","message":"The nesting here is way too deep, IMHO, and the use of variables like r, r2, m, etc make it hard to follow. I\u0027d really like to see this broken up a little more so that it\u0027s not so tightly packed.","commit_id":"18a7803933030216f95d5b60117ba9f4812df2dd"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"5ff4f34ad0916af19c1b8ae0e77f3c4696882628","unresolved":false,"context_lines":[{"line_number":341,"context_line":"                    try:"},{"line_number":342,"context_line":"                        return _get_ipv4_address_for_interface(iface)"},{"line_number":343,"context_line":"                    except exception.NovaException:"},{"line_number":344,"context_line":"                        pass"},{"line_number":345,"context_line":"    except Exception as ex:"},{"line_number":346,"context_line":"        LOG.error(_(\"Couldn\u0027t get IPv4 : %(ex)s\") % {\u0027ex\u0027: ex})"},{"line_number":347,"context_line":"    return \u0027127.0.0.1\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FpWo%3D","line":344,"in_reply_to":"AAAAPn%2F%2Fpdg%3D","updated":"2013-06-26 01:36:39.000000000","message":"Done","commit_id":"18a7803933030216f95d5b60117ba9f4812df2dd"}]}