)]}'
{"nova/notifications/objects/instance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8dd6b36d1a382e18671eeb55bcddce48540a4aff","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        \u0027memory_mb\u0027: (\u0027flavor\u0027, \u0027memory_mb\u0027),"},{"line_number":173,"context_line":"        \u0027vcpus\u0027: (\u0027flavor\u0027, \u0027vcpus\u0027),"},{"line_number":174,"context_line":"        \u0027root_gb\u0027: (\u0027flavor\u0027, \u0027root_gb\u0027),"},{"line_number":175,"context_line":"        \u0027ephemeral_gb\u0027: (\u0027flavor\u0027, \u0027ephemeral_gb\u0027),"},{"line_number":176,"context_line":"    }"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_db838c01","line":175,"updated":"2016-08-05 17:13:46.000000000","message":"I can\u0027t really look at this and see that it will work. Can\u0027t we have a test for this? Should be trivial, right?","commit_id":"1c0f3e5a3b8da3d8127c1cbfbd495ebdceda4d59"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"93903c25ebf84c0f8b9c8ec2455f08e2ae983f63","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        \u0027memory_mb\u0027: (\u0027flavor\u0027, \u0027memory_mb\u0027),"},{"line_number":173,"context_line":"        \u0027vcpus\u0027: (\u0027flavor\u0027, \u0027vcpus\u0027),"},{"line_number":174,"context_line":"        \u0027root_gb\u0027: (\u0027flavor\u0027, \u0027root_gb\u0027),"},{"line_number":175,"context_line":"        \u0027ephemeral_gb\u0027: (\u0027flavor\u0027, \u0027ephemeral_gb\u0027),"},{"line_number":176,"context_line":"    }"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_ac914049","line":175,"in_reply_to":"bacf61ea_7119df21","updated":"2016-08-05 18:27:26.000000000","message":"This doesn\u0027t validate that we\u0027re getting the values from the right place though.","commit_id":"1c0f3e5a3b8da3d8127c1cbfbd495ebdceda4d59"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb8c5e630d9e0531cea2878f56a40568389869e7","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        \u0027memory_mb\u0027: (\u0027flavor\u0027, \u0027memory_mb\u0027),"},{"line_number":173,"context_line":"        \u0027vcpus\u0027: (\u0027flavor\u0027, \u0027vcpus\u0027),"},{"line_number":174,"context_line":"        \u0027root_gb\u0027: (\u0027flavor\u0027, \u0027root_gb\u0027),"},{"line_number":175,"context_line":"        \u0027ephemeral_gb\u0027: (\u0027flavor\u0027, \u0027ephemeral_gb\u0027),"},{"line_number":176,"context_line":"    }"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_7119df21","line":175,"in_reply_to":"bacf61ea_db838c01","updated":"2016-08-05 17:55:46.000000000","message":"I think it\u0027s tested by:\n\nhttps://github.com/openstack/nova/blob/master/nova/tests/functional/notification_sample_tests/test_instance.py\n\nWhich uses like:\n\nhttps://github.com/openstack/nova/blob/master/doc/notification_samples/instance-update.json#L46","commit_id":"1c0f3e5a3b8da3d8127c1cbfbd495ebdceda4d59"}],"nova/tests/unit/notifications/objects/test_notification.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b3b501bd43d5ebb5cb3533e3f201aa2927a5174e","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        payload \u003d mock_emit.call_args_list[0][1][\u0027payload\u0027][\u0027nova_object.data\u0027]"},{"line_number":363,"context_line":"        flavor_payload \u003d payload[\u0027flavor\u0027][\u0027nova_object.data\u0027]"},{"line_number":364,"context_line":"        data \u003d {k: flavor_payload[k] for k in test_keys}"},{"line_number":365,"context_line":"        self.assertEqual(flavor_values, data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_0c24cc0a","line":365,"updated":"2016-08-05 18:30:14.000000000","message":"This test fails on the old code and passes with the change to the instance notification in this patch.","commit_id":"ec56270a8fcdac548e27dbf2b0e682689535c42e"}]}
