)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6b7e27498bdd1a62e86dbafc11f71c7ededfee6d","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        return self._cached_libvirt_type"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    @property"},{"line_number":369,"context_line":"    def working_uri(self):"},{"line_number":370,"context_line":"        return self._cached_libvirt_uri"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXIQ%3D","line":369,"updated":"2013-07-03 10:16:09.000000000","message":"s/working_uri/hypervisor_uri/","commit_id":"33472321c75ddee1dbba520d0840049ef1f88b3b"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6b7e27498bdd1a62e86dbafc11f71c7ededfee6d","unresolved":false,"context_lines":[{"line_number":646,"context_line":"    @staticmethod"},{"line_number":647,"context_line":"    def uri():"},{"line_number":648,"context_line":"        if CONF.libvirt_type \u003d\u003d \u0027auto\u0027:"},{"line_number":649,"context_line":"            uri \u003d CONF.libvirt_uri or None"},{"line_number":650,"context_line":"        elif CONF.libvirt_type \u003d\u003d \u0027uml\u0027:"},{"line_number":651,"context_line":"            uri \u003d CONF.libvirt_uri or \u0027uml:///system\u0027"},{"line_number":652,"context_line":"        elif CONF.libvirt_type \u003d\u003d \u0027xen\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXFw%3D","line":649,"updated":"2013-07-03 10:16:09.000000000","message":"This should not be in this patch - the type\u003dauto is something that is only introduced in the later patch you submitted.","commit_id":"33472321c75ddee1dbba520d0840049ef1f88b3b"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6eaf57fcfd69a64da971eb5f63cd5c0ddffe91cf","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        hypervisor_type \u003d CONF.libvirt_type"},{"line_number":114,"context_line":"        if hypervisor_type \u003d\u003d \u0027auto\u0027:"},{"line_number":115,"context_line":"            hypervisor_type \u003d libvirt_utils.autodetect_hypervisor_type()"},{"line_number":116,"context_line":"            hypervisor_type \u003d hypervisor_type.lower()"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        driver_name \u003d libvirt_utils.pick_disk_driver_name(self.is_block_dev,"},{"line_number":119,"context_line":"                                                          hypervisor_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FqOU%3D","line":116,"updated":"2013-06-25 19:33:20.000000000","message":"This is dubious. In the same way that LibvirtBaseVIFDriver gets given a \u0027get_connection\u0027 method to its constructor, the Image class should be too. That way it can access the connection object already open by the driver.","commit_id":"5013ec54d664f68ff5b3dbb43c90324776904d6a"}],"nova/virt/libvirt/utils.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6eaf57fcfd69a64da971eb5f63cd5c0ddffe91cf","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    res \u003d conn.getURI()"},{"line_number":197,"context_line":"    conn.close()"},{"line_number":198,"context_line":"    return res"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def create_image(disk_format, path, size):"},{"line_number":202,"context_line":"    \"\"\"Create a disk image"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FqOs%3D","line":199,"updated":"2013-06-25 19:33:20.000000000","message":"This method is really dubious. All code should be refering to the hypervisor type and/or connection set on the driver instance.","commit_id":"5013ec54d664f68ff5b3dbb43c90324776904d6a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6eaf57fcfd69a64da971eb5f63cd5c0ddffe91cf","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        execute(*lvremove, attempts\u003d3, run_as_root\u003dTrue)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"def pick_disk_driver_name(is_block_dev\u003dFalse, hypervisor_type\u003dNone):"},{"line_number":408,"context_line":"    \"\"\"Pick the libvirt primary backend driver name"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    If the hypervisor supports multiple backend drivers, then the name"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FqOA%3D","line":407,"updated":"2013-06-25 19:33:20.000000000","message":"Setting this to default to None will result in silent bugs. Make this parameter compulsory so any incorrect usage causes a stack trace.","commit_id":"5013ec54d664f68ff5b3dbb43c90324776904d6a"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6b7e27498bdd1a62e86dbafc11f71c7ededfee6d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from nova import utils"},{"line_number":33,"context_line":"from nova.virt import images"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"libvirt \u003d None"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"libvirt_opts \u003d ["},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027libvirt_snapshot_compression\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXHw%3D","line":35,"updated":"2013-07-03 10:16:09.000000000","message":"Why ?  This doesn\u0027t appear to be used anywhere","commit_id":"33472321c75ddee1dbba520d0840049ef1f88b3b"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"6b7e27498bdd1a62e86dbafc11f71c7ededfee6d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.get_connection \u003d get_connection"},{"line_number":80,"context_line":"        self.libvirt_version \u003d None"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        self._cached_libvirt_type \u003d CONF.libvirt_type"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @property"},{"line_number":85,"context_line":"    def hypervisor_type(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXHM%3D","line":82,"updated":"2013-07-03 10:16:09.000000000","message":"Huh ? This change was supposed to be removing use of CONF.libvirt_type ? You didn\u0027t have this in the previous version of this patch.","commit_id":"33472321c75ddee1dbba520d0840049ef1f88b3b"}]}