)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"c92822bd4e9f31abf87e107c1a2f9da96e9c6e15","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"        LOG.debug(_(\"Allocating IP information in the background.\"),"},{"line_number":1160,"context_line":"                  instance\u003dinstance)"},{"line_number":1161,"context_line":"        retries \u003d CONF.network_allocate_retries"},{"line_number":1162,"context_line":"        attempts \u003d retries \u003e 1 and retries + 1 or 1"},{"line_number":1163,"context_line":"        retry_time \u003d 1"},{"line_number":1164,"context_line":"        for attempt in range(1, attempts + 1):"},{"line_number":1165,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FnLA%3D","line":1162,"updated":"2013-06-26 19:15:23.000000000","message":"Might want to raise an error if retries \u003c 0 since it makes no sense. (rather than silently change it)\n\nThen you can just do:\nattempts \u003d max(1, retries)","commit_id":"44827015ef69d5c1c242d210615a83f3495f604b"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"07d9b9fdcfedb7ec057d8e7fe0fc3c33083e49ef","unresolved":false,"context_lines":[{"line_number":1159,"context_line":"        LOG.debug(_(\"Allocating IP information in the background.\"),"},{"line_number":1160,"context_line":"                  instance\u003dinstance)"},{"line_number":1161,"context_line":"        retries \u003d CONF.network_allocate_retries"},{"line_number":1162,"context_line":"        attempts \u003d retries \u003e 1 and retries + 1 or 1"},{"line_number":1163,"context_line":"        retry_time \u003d 1"},{"line_number":1164,"context_line":"        for attempt in range(1, attempts + 1):"},{"line_number":1165,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FnEY%3D","line":1162,"in_reply_to":"AAAAPn%2F%2FnLA%3D","updated":"2013-06-26 19:37:04.000000000","message":"I wish there were a way to do it on startup.. :-/   I think maybe a warning would be more appropriate here.. ?","commit_id":"44827015ef69d5c1c242d210615a83f3495f604b"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"c92822bd4e9f31abf87e107c1a2f9da96e9c6e15","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"                log_info \u003d {\u0027attempt\u0027: attempt,"},{"line_number":1178,"context_line":"                            \u0027attempts\u0027: attempts}"},{"line_number":1179,"context_line":"                if attempt \u003d\u003d attempts:"},{"line_number":1180,"context_line":"                    LOG.exception(_(\u0027Instance failed network setup \u0027"},{"line_number":1181,"context_line":"                                    \u0027after %d attempt(s)\u0027),"},{"line_number":1182,"context_line":"                                  log_info)"},{"line_number":1183,"context_line":"                    raise exc_info[0], exc_info[1], exc_info[2]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FnKg%3D","line":1180,"updated":"2013-06-26 19:15:23.000000000","message":"You might need some excutils.save_and_reraise_exception() goodness here.  The logging call could potentially switch the greenthread.","commit_id":"44827015ef69d5c1c242d210615a83f3495f604b"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"07d9b9fdcfedb7ec057d8e7fe0fc3c33083e49ef","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"                log_info \u003d {\u0027attempt\u0027: attempt,"},{"line_number":1178,"context_line":"                            \u0027attempts\u0027: attempts}"},{"line_number":1179,"context_line":"                if attempt \u003d\u003d attempts:"},{"line_number":1180,"context_line":"                    LOG.exception(_(\u0027Instance failed network setup \u0027"},{"line_number":1181,"context_line":"                                    \u0027after %d attempt(s)\u0027),"},{"line_number":1182,"context_line":"                                  log_info)"},{"line_number":1183,"context_line":"                    raise exc_info[0], exc_info[1], exc_info[2]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FnE4%3D","line":1180,"in_reply_to":"AAAAPn%2F%2FnKg%3D","updated":"2013-06-26 19:37:04.000000000","message":"It\u0027s saved above in \u0027exc_info\u0027 and re-raised below properly.  I couldn\u0027t use the nice excutils method because I only want to re-raise conditionally.","commit_id":"44827015ef69d5c1c242d210615a83f3495f604b"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"8a604692b2fff6eb61a4276818c305229e559eaf","unresolved":false,"context_lines":[{"line_number":1179,"context_line":"                if attempt \u003d\u003d attempts:"},{"line_number":1180,"context_line":"                    LOG.exception(_(\u0027Instance failed network setup \u0027"},{"line_number":1181,"context_line":"                                    \u0027after %d attempt(s)\u0027),"},{"line_number":1182,"context_line":"                                  log_info)"},{"line_number":1183,"context_line":"                    raise exc_info[0], exc_info[1], exc_info[2]"},{"line_number":1184,"context_line":"                LOG.warn(_(\u0027Instance failed network setup \u0027"},{"line_number":1185,"context_line":"                           \u0027(attempt %(attempt)d of %(attempts)d)\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FnRA%3D","line":1182,"updated":"2013-06-26 18:26:01.000000000","message":"I don\u0027t think this will work because the format string isn\u0027t using a named parameter.","commit_id":"44827015ef69d5c1c242d210615a83f3495f604b"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"07d9b9fdcfedb7ec057d8e7fe0fc3c33083e49ef","unresolved":false,"context_lines":[{"line_number":1179,"context_line":"                if attempt \u003d\u003d attempts:"},{"line_number":1180,"context_line":"                    LOG.exception(_(\u0027Instance failed network setup \u0027"},{"line_number":1181,"context_line":"                                    \u0027after %d attempt(s)\u0027),"},{"line_number":1182,"context_line":"                                  log_info)"},{"line_number":1183,"context_line":"                    raise exc_info[0], exc_info[1], exc_info[2]"},{"line_number":1184,"context_line":"                LOG.warn(_(\u0027Instance failed network setup \u0027"},{"line_number":1185,"context_line":"                           \u0027(attempt %(attempt)d of %(attempts)d)\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FnEs%3D","line":1182,"in_reply_to":"AAAAPn%2F%2FnRA%3D","updated":"2013-06-26 19:37:04.000000000","message":"Oops... yeah, that\u0027s my bad.","commit_id":"44827015ef69d5c1c242d210615a83f3495f604b"}]}