)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"c546d45d469b0488c931c134e918f96943af33cd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: Modify the console type of os_commandline for AArch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For AArch64, the default console is \"ttyAMA0\", which is different"},{"line_number":10,"context_line":"from X86_64. Also modify the test case to support it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1604677"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_ea5fbfe2","line":10,"updated":"2016-07-20 16:52:50.000000000","message":"Missing test case. Either add or correct commit message.","commit_id":"3f06411b9cc8f0cb740d1f9978c06124a83b675c"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"23d5054272e5f7c8c89ae29942f59e4c5d0fa80b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: Modify the console type of os_commandline for AArch64"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For AArch64, the default console is \"ttyAMA0\", which is different"},{"line_number":10,"context_line":"from X86_64. Also modify the test case to support it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1604677"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_d58cf6db","line":10,"in_reply_to":"dada55a8_ea5fbfe2","updated":"2016-07-21 12:12:04.000000000","message":"Hi Joel,\n   Thanks~ I have modified the commit message","commit_id":"3f06411b9cc8f0cb740d1f9978c06124a83b675c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd500ca691726dbe20519f9f1905ce55451196a2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Closes-Bug: #1604677"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I95a221a188d1d2c9aee910db5eb6750ff7b71dd4"},{"line_number":15,"context_line":"Signed-off-by: Kevin Zhao \u003ckevin.zhao@linaro.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa6399be_e79f615d","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":49},"updated":"2016-10-11 16:47:39.000000000","message":"kill this - not needed due to the CCLA","commit_id":"8666290a9faa066d10fc48802fe144948d3c6e8c"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"d6e472131eb8809e36959c14ed3ee472ea1a717e","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# Guest config console string"},{"line_number":142,"context_line":"CONSOLE \u003d \"console\u003dtty0 console\u003dttyS0\""},{"line_number":143,"context_line":"CONSOLE_AARCH64 \u003d \"console\u003dttyAMA0\""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"GuestNumaConfig \u003d collections.namedtuple("},{"line_number":146,"context_line":"    \u0027GuestNumaConfig\u0027, [\u0027cpuset\u0027, \u0027cputune\u0027, \u0027numaconfig\u0027, \u0027numatune\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_edc9af5a","line":143,"updated":"2016-07-20 11:42:33.000000000","message":"This looks broken to me. ttyAMA0 only replaces the ttyS0. So you should still have the second tty0 there afaik, as there\u0027s no aarch64 specific code in console configuration later .","commit_id":"4e182b6dfc6ba91540b91cb1d8faa7c719836cf7"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"c5f1cc62098c0ec9850d576d3b52c11ebae664ff","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# Guest config console string"},{"line_number":142,"context_line":"CONSOLE \u003d \"console\u003dtty0 console\u003dttyS0\""},{"line_number":143,"context_line":"CONSOLE_AARCH64 \u003d \"console\u003dttyAMA0\""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"GuestNumaConfig \u003d collections.namedtuple("},{"line_number":146,"context_line":"    \u0027GuestNumaConfig\u0027, [\u0027cpuset\u0027, \u0027cputune\u0027, \u0027numaconfig\u0027, \u0027numatune\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_f0cfc326","line":143,"in_reply_to":"dada55a8_edc9af5a","updated":"2016-07-20 13:22:40.000000000","message":"Thanks Daniel,\n    I have modify here and rechecked~Those works","commit_id":"4e182b6dfc6ba91540b91cb1d8faa7c719836cf7"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"d6e472131eb8809e36959c14ed3ee472ea1a717e","unresolved":false,"context_lines":[{"line_number":3969,"context_line":"            if virt_type \u003d\u003d \"xen\":"},{"line_number":3970,"context_line":"                guest.os_cmdline \u003d \"ro root\u003d%s\" % root_device_name"},{"line_number":3971,"context_line":"            else:"},{"line_number":3972,"context_line":"                if arch.AARCH64:"},{"line_number":3973,"context_line":"                    guest.os_cmdline \u003d (\"root\u003d%s %s\" % (root_device_name, CONSOLE_AARCH64))"},{"line_number":3974,"context_line":"                else:"},{"line_number":3975,"context_line":"                    guest.os_cmdline \u003d (\"root\u003d%s %s\" % (root_device_name, CONSOLE))"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_6dc13f54","line":3972,"updated":"2016-07-20 11:42:33.000000000","message":"Err  \u0027arch.AARCH64\u0027 is just a constant which always exists. It says nothing about whether this *guest* is running aarc64\nYou need\n\n        guestarch \u003d libvirt_utils.get_arch(image_meta)\n        if guestarch \u003d\u003d arch.AARCH64:\n              ...","commit_id":"4e182b6dfc6ba91540b91cb1d8faa7c719836cf7"},{"author":{"_account_id":22076,"name":"Kevin Zhao","email":"kevin.zhao@linaro.org","username":"KevinZhao"},"change_message_id":"c5f1cc62098c0ec9850d576d3b52c11ebae664ff","unresolved":false,"context_lines":[{"line_number":3969,"context_line":"            if virt_type \u003d\u003d \"xen\":"},{"line_number":3970,"context_line":"                guest.os_cmdline \u003d \"ro root\u003d%s\" % root_device_name"},{"line_number":3971,"context_line":"            else:"},{"line_number":3972,"context_line":"                if arch.AARCH64:"},{"line_number":3973,"context_line":"                    guest.os_cmdline \u003d (\"root\u003d%s %s\" % (root_device_name, CONSOLE_AARCH64))"},{"line_number":3974,"context_line":"                else:"},{"line_number":3975,"context_line":"                    guest.os_cmdline \u003d (\"root\u003d%s %s\" % (root_device_name, CONSOLE))"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_b0f0ab68","line":3972,"in_reply_to":"dada55a8_6dc13f54","updated":"2016-07-20 13:22:40.000000000","message":"OK I\u0027ve modified","commit_id":"4e182b6dfc6ba91540b91cb1d8faa7c719836cf7"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0b0fa2635a374fe5fefef187b5b6e8311b4ebe08","unresolved":false,"context_lines":[{"line_number":4331,"context_line":"            if guestarch \u003d\u003d arch.AARCH64:"},{"line_number":4332,"context_line":"                guest.os_cmdline \u003d CONSOLE_AARCH64"},{"line_number":4333,"context_line":"            else:"},{"line_number":4334,"context_line":"                guest.os_cmdline \u003d CONSOLE"},{"line_number":4335,"context_line":"        elif virt_type \u003d\u003d \"uml\":"},{"line_number":4336,"context_line":"            guest.os_kernel \u003d \"/usr/bin/linux\""},{"line_number":4337,"context_line":"            guest.os_root \u003d root_device_name"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_46e37533","line":4334,"updated":"2016-07-20 13:41:21.000000000","message":"This is not required. LXC doens\u0027t boot a real kernel, so this console arg will have no effect. In fact even the existing code is wrong - we should not set CONSOLE at all, even on x86","commit_id":"f42e3289c6bca308dbeb49867792653f956e1d41"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd500ca691726dbe20519f9f1905ce55451196a2","unresolved":false,"context_lines":[{"line_number":139,"context_line":"DISABLE_REASON_UNDEFINED \u003d None"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"# Guest config console string"},{"line_number":142,"context_line":"CONSOLE \u003d \"console\u003dtty0 console\u003dttyS0\""},{"line_number":143,"context_line":"CONSOLE_AARCH64 \u003d \"console\u003dtty0 console\u003dttyAMA0\""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"GuestNumaConfig \u003d collections.namedtuple("}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_07745533","line":142,"range":{"start_line":142,"start_character":0,"end_line":142,"end_character":7},"updated":"2016-10-11 16:47:39.000000000","message":"Could you rename this CONSOLE_DEFAULT or similar, and perhaps document why they\u0027re different in the comments?","commit_id":"8666290a9faa066d10fc48802fe144948d3c6e8c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f76c945cffaf5ae846721a4df6cad0a8863f54d5","unresolved":false,"context_lines":[{"line_number":3936,"context_line":"            else:"},{"line_number":3937,"context_line":"                guestarch \u003d libvirt_utils.get_arch(image_meta)"},{"line_number":3938,"context_line":"                if guestarch \u003d\u003d arch.AARCH64:"},{"line_number":3939,"context_line":"                    guest.os_cmdline \u003d (\"root\u003d%s %s\" % (root_device_name,"},{"line_number":3940,"context_line":"                                                        CONSOLE_AARCH64))"},{"line_number":3941,"context_line":"                else:"},{"line_number":3942,"context_line":"                    guest.os_cmdline \u003d (\"root\u003d%s %s\" % (root_device_name,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_988115fe","line":3939,"updated":"2016-10-14 13:33:06.000000000","message":"Micro nit: would be nice to to repeat this string, and just do console \u003d CONSOLE or CONSOLE_AARCH64","commit_id":"8666290a9faa066d10fc48802fe144948d3c6e8c"}]}