)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9925abb7c2018d47a3e1edeebcbcc73fdf3c2ac4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     dineshbhor \u003cdinesh.bhor@nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-20 18:14:23 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use DDT to reduce test data duplication"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DDT can ease up error tracing and autogenerates tests on"},{"line_number":10,"context_line":"basis of different input data. It automatically generates"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_aedd3672","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":27},"updated":"2016-07-25 05:57:44.000000000","message":"code?","commit_id":"051802fae72370d8784ad81d2d579ad82debfbd9"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"94d988c1793caa5d20b37852fa0747232d0ff195","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     dineshbhor \u003cdinesh.bhor@nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-20 18:14:23 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use DDT to reduce test data duplication"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DDT can ease up error tracing and autogenerates tests on"},{"line_number":10,"context_line":"basis of different input data. It automatically generates"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_9997d5ea","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":27},"in_reply_to":"dada55a8_aedd3672","updated":"2016-07-25 10:54:10.000000000","message":"Done","commit_id":"051802fae72370d8784ad81d2d579ad82debfbd9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4f738494b13ad32fca6262c72de5af1ea3a9dbec","unresolved":false,"context_lines":[{"line_number":9,"context_line":"DDT can ease up error tracing and autogenerates tests on"},{"line_number":10,"context_line":"basis of different input data. It automatically generates"},{"line_number":11,"context_line":"tests:"},{"line_number":12,"context_line":"\ttest_create_invalid_create_aggregate_data_1"},{"line_number":13,"context_line":"\ttest_create_invalid_create_aggregate_data_2"},{"line_number":14,"context_line":"\ttest_create_invalid_create_aggregate_data_3"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_0e2f223f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"updated":"2016-07-25 06:09:34.000000000","message":"Are these tabulators?","commit_id":"051802fae72370d8784ad81d2d579ad82debfbd9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"be3382198e3971f572096eecd7a03463d5499823","unresolved":false,"context_lines":[{"line_number":9,"context_line":"DDT can ease up error tracing and autogenerates tests on"},{"line_number":10,"context_line":"basis of different input data. It automatically generates"},{"line_number":11,"context_line":"tests:"},{"line_number":12,"context_line":"\ttest_create_invalid_create_aggregate_data_1"},{"line_number":13,"context_line":"\ttest_create_invalid_create_aggregate_data_2"},{"line_number":14,"context_line":"\ttest_create_invalid_create_aggregate_data_3"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_8e9789ea","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"in_reply_to":"dada55a8_0e2f223f","updated":"2016-07-25 10:38:53.000000000","message":"+1 on killing those.","commit_id":"051802fae72370d8784ad81d2d579ad82debfbd9"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"94d988c1793caa5d20b37852fa0747232d0ff195","unresolved":false,"context_lines":[{"line_number":9,"context_line":"DDT can ease up error tracing and autogenerates tests on"},{"line_number":10,"context_line":"basis of different input data. It automatically generates"},{"line_number":11,"context_line":"tests:"},{"line_number":12,"context_line":"\ttest_create_invalid_create_aggregate_data_1"},{"line_number":13,"context_line":"\ttest_create_invalid_create_aggregate_data_2"},{"line_number":14,"context_line":"\ttest_create_invalid_create_aggregate_data_3"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_b99459e8","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"in_reply_to":"dada55a8_0e2f223f","updated":"2016-07-25 10:54:10.000000000","message":"Done","commit_id":"051802fae72370d8784ad81d2d579ad82debfbd9"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"94d988c1793caa5d20b37852fa0747232d0ff195","unresolved":false,"context_lines":[{"line_number":9,"context_line":"DDT can ease up error tracing and autogenerates tests on"},{"line_number":10,"context_line":"basis of different input data. It automatically generates"},{"line_number":11,"context_line":"tests:"},{"line_number":12,"context_line":"\ttest_create_invalid_create_aggregate_data_1"},{"line_number":13,"context_line":"\ttest_create_invalid_create_aggregate_data_2"},{"line_number":14,"context_line":"\ttest_create_invalid_create_aggregate_data_3"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_59f71d59","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"in_reply_to":"dada55a8_8e9789ea","updated":"2016-07-25 10:54:10.000000000","message":"Done","commit_id":"051802fae72370d8784ad81d2d579ad82debfbd9"}],"nova/tests/unit/api/openstack/compute/test_aggregates.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4f738494b13ad32fca6262c72de5af1ea3a9dbec","unresolved":false,"context_lines":[{"line_number":178,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"x\" * 256},"},{"line_number":179,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"  nova1  \"},"},{"line_number":180,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"\"},"},{"line_number":181,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"nova1\", \"foo\": \"bar\"})"},{"line_number":182,"context_line":"    def test_create_invalid_create_aggregate_data(self, value):"},{"line_number":183,"context_line":"        self.assertRaises(self.bad_request, self.controller.create,"},{"line_number":184,"context_line":"                          self.req, body\u003d{\"aggregate\": value})"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_cefeaaad","line":181,"updated":"2016-07-25 06:09:34.000000000","message":"I feel that we lose the descriptive name of each individual test case we had. By reading the original test case names I could easily see what negative use cases are actually tested. Here I can only guess that the some of the data is about creating too long names while others is about missing data. Can we somehow get back the descriptive case names?","commit_id":"051802fae72370d8784ad81d2d579ad82debfbd9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"be3382198e3971f572096eecd7a03463d5499823","unresolved":false,"context_lines":[{"line_number":178,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"x\" * 256},"},{"line_number":179,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"  nova1  \"},"},{"line_number":180,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"\"},"},{"line_number":181,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"nova1\", \"foo\": \"bar\"})"},{"line_number":182,"context_line":"    def test_create_invalid_create_aggregate_data(self, value):"},{"line_number":183,"context_line":"        self.assertRaises(self.bad_request, self.controller.create,"},{"line_number":184,"context_line":"                          self.req, body\u003d{\"aggregate\": value})"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_4e2ab191","line":181,"in_reply_to":"dada55a8_05d1bccd","updated":"2016-07-25 10:38:53.000000000","message":"Its not quite the same, you loose the test result descriptions.\n\nIf the data were simple, the test names would get generated nicely.\n\nIt feels like ddt should add some what to name each data set, maybe optionally take kwargs, when it generates the correct names?","commit_id":"051802fae72370d8784ad81d2d579ad82debfbd9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"7adab99efb9480e36b70618130b7e8febfe1d2fc","unresolved":false,"context_lines":[{"line_number":178,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"x\" * 256},"},{"line_number":179,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"  nova1  \"},"},{"line_number":180,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"\"},"},{"line_number":181,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"nova1\", \"foo\": \"bar\"})"},{"line_number":182,"context_line":"    def test_create_invalid_create_aggregate_data(self, value):"},{"line_number":183,"context_line":"        self.assertRaises(self.bad_request, self.controller.create,"},{"line_number":184,"context_line":"                          self.req, body\u003d{\"aggregate\": value})"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_794941d0","line":181,"in_reply_to":"dada55a8_4e2ab191","updated":"2016-07-25 10:49:37.000000000","message":"I don\u0027t think that\u0027s really a reason to block use of DDT today. Its merely a nice-to-have enhancement that\u0027d improve its usability a little, not having pretty test names isn\u0027t a show stopper in the meantime.","commit_id":"051802fae72370d8784ad81d2d579ad82debfbd9"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"051f9009216274415dffd11d5cc5c65d0e84a0b9","unresolved":false,"context_lines":[{"line_number":178,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"x\" * 256},"},{"line_number":179,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"  nova1  \"},"},{"line_number":180,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"\"},"},{"line_number":181,"context_line":"              {\"name\": \"test\", \"availability_zone\": \"nova1\", \"foo\": \"bar\"})"},{"line_number":182,"context_line":"    def test_create_invalid_create_aggregate_data(self, value):"},{"line_number":183,"context_line":"        self.assertRaises(self.bad_request, self.controller.create,"},{"line_number":184,"context_line":"                          self.req, body\u003d{\"aggregate\": value})"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_05d1bccd","line":181,"in_reply_to":"dada55a8_cefeaaad","updated":"2016-07-25 09:12:10.000000000","message":"If you want a description of what\u0027s being tested just add a python comment for each line","commit_id":"051802fae72370d8784ad81d2d579ad82debfbd9"}]}
