)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"58478885d87e3bc9a2f5528d14b892972bc07689","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If the command \u0027nova list --name \u003csome_pattern\u003e\u0027 is invoked"},{"line_number":10,"context_line":"with an incorrect value of the pattern, the nova-api makes"},{"line_number":11,"context_line":"a request to database and returns Http 500 error. Seems"},{"line_number":12,"context_line":"it\u0027s not convinient."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This fix examinates the pattern. If it isn\u0027t correct,"},{"line_number":15,"context_line":"the nova-api returns error 400 with a prompt of a bad regex."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_2c1a897d","line":12,"range":{"start_line":12,"start_character":9,"end_line":12,"end_character":19},"updated":"2016-07-20 21:52:33.000000000","message":"typo: convinient -\u003e convenient","commit_id":"732b35041666afebdc0bc370246522874e0baebb"},{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"58478885d87e3bc9a2f5528d14b892972bc07689","unresolved":false,"context_lines":[{"line_number":11,"context_line":"a request to database and returns Http 500 error. Seems"},{"line_number":12,"context_line":"it\u0027s not convinient."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This fix examinates the pattern. If it isn\u0027t correct,"},{"line_number":15,"context_line":"the nova-api returns error 400 with a prompt of a bad regex."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iad63c668d09ec6a82ace29700fb4949c1acfbe1c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_4c3eddda","line":14,"range":{"start_line":14,"start_character":9,"end_line":14,"end_character":19},"updated":"2016-07-20 21:52:33.000000000","message":"Incorrect word?","commit_id":"732b35041666afebdc0bc370246522874e0baebb"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"658b54c79b1142ba0fad7ec509e3c5150bf590b7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"it\u0027s not convenient."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This fix checks the pattern. If it isn\u0027t correct,"},{"line_number":17,"context_line":"the nova-api returns error 400 with a prompt of a bad regex."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Iad63c668d09ec6a82ace29700fb4949c1acfbe1c"},{"line_number":20,"context_line":"Closes-Bug: #1603728"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bacf61ea_a7115254","line":17,"updated":"2016-08-01 17:18:13.000000000","message":"nice!","commit_id":"d01695886f3fb6ec1ffe4204e7f4bc72737992cf"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"aa9e037cd5ef914c6aa2cd5db5555f3f3f9691c9","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            try:"},{"line_number":268,"context_line":"                re.compile(search_opts[\u0027name\u0027])"},{"line_number":269,"context_line":"            except re.error:"},{"line_number":270,"context_line":"                msg \u003d _(\"The regex for \u0027--name\u0027 option is incorrect\")"},{"line_number":271,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        if api_version_request.is_supported(req, min_version\u003d\u00272.26\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_e6866e15","line":270,"range":{"start_line":270,"start_character":24,"end_line":270,"end_character":68},"updated":"2016-07-22 13:35:51.000000000","message":"The solution looks good to me. Just one nit,\nthis solution solves the problem of various nova apis like\n\u0027stop\u0027, \u0027lock\u0027, \u0027rescue\u0027, \u0027start\u0027 if you pass invalid regex to it because they calls nova list internally to get that particular server.\n\nYou get following errors:\n\nCommand: \nnova start +\n\nError:\nThe regex for \u0027--name\u0027 option is incorrect (HTTP 400) (Request-ID: req-ed4254c9-6e31-44ed-bc73-91d1facaf8ee)\nERROR (CommandError): Unable to start the specified server(s).\n\nCommand:\nnova rescue +\n\nError:\nERROR (BadRequest): The regex for \u0027--name\u0027 option is incorrect (HTTP 400) (Request-ID: req-a37d28dc-0fad-4131-a149-d2c2fde1a4ef)\n\nBut there is no such option \u0027--name\u0027 for these apis.\n\nSo IMO the error message should be generic so that it will fit for all these cases and will give proper error message to user.\nSomething like \"The regex for server name is incorrect\" would be nice.","commit_id":"7c913b955db0594777cb31699ecbf7bae7dc579b"}]}