)]}'
{"nova/api/openstack/compute/limits.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3d198356b979a5344dd0f6e6e25e09fd5150cd6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def index(self, req):"},{"line_number":43,"context_line":"        return self._index(req)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @wsgi.Controller.api_version(_get_filter_result_version())  # noqa"},{"line_number":46,"context_line":"    @extensions.expected_errors(())"},{"line_number":47,"context_line":"    def index(self, req):"},{"line_number":48,"context_line":"        return self._index(req, filter_result\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_e4499c32","line":45,"range":{"start_line":45,"start_character":33,"end_line":45,"end_character":61},"updated":"2016-07-21 06:49:46.000000000","message":"or just 2.36 as we are going with this for proxy API deprecation.","commit_id":"958f4d69ebed712587ce462956aa8f2932d454ed"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"823456634ca748bf70c58c856e350a86541986f3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def index(self, req):"},{"line_number":43,"context_line":"        return self._index(req)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @wsgi.Controller.api_version(_get_filter_result_version())  # noqa"},{"line_number":46,"context_line":"    @extensions.expected_errors(())"},{"line_number":47,"context_line":"    def index(self, req):"},{"line_number":48,"context_line":"        return self._index(req, filter_result\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_50c0abe0","line":45,"range":{"start_line":45,"start_character":33,"end_line":45,"end_character":59},"updated":"2016-07-23 16:56:30.000000000","message":"as this 2.36 already fixed, should we directly hard coding it?","commit_id":"71bc8825cf749213c3df3939f7e536ed846a93b8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d95ddb156fb3133eefd74d3404f596dfade26fa1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"ALIAS \u003d \u0027limits\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def _get_filter_result_version():"},{"line_number":31,"context_line":"    filter_result_version \u003d api_version_request.APIVersionRequest("},{"line_number":32,"context_line":"        MAX_PROXY_API_SUPPORT_VERSION)"},{"line_number":33,"context_line":"    filter_result_version.ver_minor \u003d filter_result_version.ver_minor + 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_1e4c4f6f","line":30,"updated":"2016-07-25 21:17:32.000000000","message":"A code comment in here about what this is for would be nice for posterity.","commit_id":"0b1c4981adc1b9713b8819e514b717c487c604c1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"02a5265be1f5d707292713792306913740f44d13","unresolved":false,"context_lines":[{"line_number":27,"context_line":"ALIAS \u003d \u0027limits\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def _get_filter_result_version():"},{"line_number":31,"context_line":"    filter_result_version \u003d api_version_request.APIVersionRequest("},{"line_number":32,"context_line":"        MAX_PROXY_API_SUPPORT_VERSION)"},{"line_number":33,"context_line":"    filter_result_version.ver_minor \u003d filter_result_version.ver_minor + 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_93a2e4fa","line":30,"in_reply_to":"dada55a8_1e4c4f6f","updated":"2016-07-26 05:36:05.000000000","message":"yea, will add comment.","commit_id":"0b1c4981adc1b9713b8819e514b717c487c604c1"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"1576d62e115a8a076c6d8a827154d9d062df6a97","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":"    filter_result_version \u003d api_version_request.APIVersionRequest("},{"line_number":37,"context_line":"        MAX_PROXY_API_SUPPORT_VERSION)"},{"line_number":38,"context_line":"    filter_result_version.ver_minor \u003d filter_result_version.ver_minor + 1"},{"line_number":39,"context_line":"    return filter_result_version.get_string()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_56c215ea","line":38,"updated":"2016-07-26 08:37:10.000000000","message":"nit: +\u003d 1","commit_id":"62d57e57e301d60d21129c94a8da92683494440e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7dd21319f8f40183e47a583afea7d577547a89c7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    filter_result_version \u003d api_version_request.APIVersionRequest("},{"line_number":37,"context_line":"        MAX_PROXY_API_SUPPORT_VERSION)"},{"line_number":38,"context_line":"    filter_result_version.ver_minor \u003d filter_result_version.ver_minor + 1"},{"line_number":39,"context_line":"    return filter_result_version.get_string()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class LimitsController(wsgi.Controller):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_9083ec55","line":39,"updated":"2016-07-26 10:32:49.000000000","message":"Hmm, it does make we wonder more about my comment here:\nhttps://review.openstack.org/#/c/333825/13/nova/api/openstack/compute/quota_sets.py@48","commit_id":"62d57e57e301d60d21129c94a8da92683494440e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"836bb2d08fea0e821a819db81fd6d78d60277324","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    filter_result_version \u003d api_version_request.APIVersionRequest("},{"line_number":37,"context_line":"        MAX_PROXY_API_SUPPORT_VERSION)"},{"line_number":38,"context_line":"    filter_result_version.ver_minor \u003d filter_result_version.ver_minor + 1"},{"line_number":39,"context_line":"    return filter_result_version.get_string()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class LimitsController(wsgi.Controller):"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_9be94dba","line":39,"in_reply_to":"dada55a8_9083ec55","updated":"2016-07-26 10:51:43.000000000","message":"Sounds like its best for alex to move the API version in a tidy up, as such, I am happy.","commit_id":"62d57e57e301d60d21129c94a8da92683494440e"}],"nova/api/openstack/compute/views/limits.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d95ddb156fb3133eefd74d3404f596dfade26fa1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import six"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"FILTERED_LIMITS \u003d [\u0027floating_ips\u0027, \u0027security_groups\u0027, \u0027security_group_rules\u0027]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ViewBuilder(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_fe8b3b66","line":19,"updated":"2016-07-25 21:17:32.000000000","message":"Code comment would be good for why these are in here (I know why, but posterity).\n\nI also think \u0027networks\u0027 would be in this list, but it\u0027s based on config, see:\n\nhttps://review.openstack.org/#/c/346996/","commit_id":"0b1c4981adc1b9713b8819e514b717c487c604c1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"02a5265be1f5d707292713792306913740f44d13","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import six"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"FILTERED_LIMITS \u003d [\u0027floating_ips\u0027, \u0027security_groups\u0027, \u0027security_group_rules\u0027]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ViewBuilder(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_53006c01","line":19,"in_reply_to":"dada55a8_fe8b3b66","updated":"2016-07-26 05:36:05.000000000","message":"there is filter in the line 66, it depends on the \u0027self.limit_names\u0027. So the networks isn\u0027t in the response in the past","commit_id":"0b1c4981adc1b9713b8819e514b717c487c604c1"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"30b69512b21dcfb7fa542d240897e09cb7722916","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def build(self, absolute_limits, filter_result\u003dFalse):"},{"line_number":45,"context_line":"        absolute_limits \u003d self._build_absolute_limits("},{"line_number":46,"context_line":"            absolute_limits, filter_result\u003dfilter_result)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        output \u003d {"},{"line_number":49,"context_line":"            \"limits\": {"}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_d0fba479","line":46,"updated":"2016-07-26 10:38:43.000000000","message":"Nit: I wonder if just passing the req down here would be simpler?","commit_id":"62d57e57e301d60d21129c94a8da92683494440e"}]}