)]}'
{"nova/api/openstack/compute/plugins/v3/admin_actions.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9511424267e448fc39a4e0ae3f37cc5aac5bb825","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                exception.UnableToMigrateToSelf,"},{"line_number":295,"context_line":"                exception.DestinationHypervisorTooOld) as ex:"},{"line_number":296,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dex.format_message())"},{"line_number":297,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":298,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":299,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F6OA%3D","line":297,"updated":"2013-07-19 11:42:05.000000000","message":"do we loose too much information here? It feels like we really need to know the live migration target hosts for the failure. Want to make sure we\u0027ve still got them.","commit_id":"8f3f4ca758616a282ec4b2268ed13f7e492a6216"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d48473e2adc137f1fa5d291b058cd5fc92b56e60","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                exception.UnableToMigrateToSelf,"},{"line_number":295,"context_line":"                exception.DestinationHypervisorTooOld) as ex:"},{"line_number":296,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dex.format_message())"},{"line_number":297,"context_line":"        except exception.InstanceNotFound as e:"},{"line_number":298,"context_line":"            raise exc.HTTPNotFound(explanation\u003de.format_message())"},{"line_number":299,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F2Ro%3D","line":297,"in_reply_to":"AAAAQn%2F%2F6OA%3D","updated":"2013-07-22 07:10:10.000000000","message":"The message of InstanceNotFound will include the target hosts. So we won\u0027t loose the information. But after I recheck code, I missing some exception catching at here. I will update","commit_id":"8f3f4ca758616a282ec4b2268ed13f7e492a6216"}],"nova/tests/api/openstack/compute/plugins/v3/test_admin_actions.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9511424267e448fc39a4e0ae3f37cc5aac5bb825","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                        task_state, expected_task_state):"},{"line_number":396,"context_line":"            return None"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        fake_exc \u003d exception.UnableToMigrateToSelf(self.UUID, host\u003d\u0027host\u0027)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        def fake_migrate_server(self, context, instance,"},{"line_number":401,"context_line":"                scheduler_hint, live, rebuild, flavor,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F6Og%3D","line":398,"updated":"2013-07-19 11:42:05.000000000","message":"why is this pulled out?","commit_id":"8f3f4ca758616a282ec4b2268ed13f7e492a6216"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d48473e2adc137f1fa5d291b058cd5fc92b56e60","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                        task_state, expected_task_state):"},{"line_number":396,"context_line":"            return None"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        fake_exc \u003d exception.UnableToMigrateToSelf(self.UUID, host\u003d\u0027host\u0027)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        def fake_migrate_server(self, context, instance,"},{"line_number":401,"context_line":"                scheduler_hint, live, rebuild, flavor,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F2Rg%3D","line":398,"in_reply_to":"AAAAQn%2F%2F6Og%3D","updated":"2013-07-22 07:10:10.000000000","message":"Because the \u0027self.UUID\u0027, The UUID was member of AdminActionsTest, not the member of ComputeTaskAPI.","commit_id":"8f3f4ca758616a282ec4b2268ed13f7e492a6216"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"9511424267e448fc39a4e0ae3f37cc5aac5bb825","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        response \u003d request.get_response(self.app)"},{"line_number":614,"context_line":"        self.assertEqual(response.status_int, 409)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    def test_create_backup_with_not_existed_instance(self):"},{"line_number":617,"context_line":"        body \u003d {"},{"line_number":618,"context_line":"            \u0027create_backup\u0027: {"},{"line_number":619,"context_line":"                \u0027name\u0027: \u0027Backup 1\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F6OY%3D","line":616,"updated":"2013-07-19 11:42:05.000000000","message":"probably should be: test_create_backup_with_nonexisting_instance","commit_id":"8f3f4ca758616a282ec4b2268ed13f7e492a6216"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d48473e2adc137f1fa5d291b058cd5fc92b56e60","unresolved":false,"context_lines":[{"line_number":613,"context_line":"        response \u003d request.get_response(self.app)"},{"line_number":614,"context_line":"        self.assertEqual(response.status_int, 409)"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    def test_create_backup_with_not_existed_instance(self):"},{"line_number":617,"context_line":"        body \u003d {"},{"line_number":618,"context_line":"            \u0027create_backup\u0027: {"},{"line_number":619,"context_line":"                \u0027name\u0027: \u0027Backup 1\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2F2RY%3D","line":616,"in_reply_to":"AAAAQn%2F%2F6OY%3D","updated":"2013-07-22 07:10:10.000000000","message":"Done, thanks","commit_id":"8f3f4ca758616a282ec4b2268ed13f7e492a6216"}]}