)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9355775f3e7c84e59bce0cc5b29213a7a14b3688","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Error updating resources for some node"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1602057"},{"line_number":10,"context_line":"Partial-Bug: #1602057"},{"line_number":11,"context_line":"Related-Bug: #1602057"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I12c9c1ae6ca27727e8742060647dbe7017cded08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_db42ae3d","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":21},"updated":"2016-07-26 07:58:11.000000000","message":"These lines are unnecessary.\nThey should be removed.","commit_id":"13de23450491e2b22ebf72c2f2d19039ef5a4b5c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"62e24b1d3ac413475d5226b9db79d6510885c481","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix Error updating resources for some node"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1602057"},{"line_number":10,"context_line":"Partial-Bug: #1602057"},{"line_number":11,"context_line":"Related-Bug: #1602057"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I12c9c1ae6ca27727e8742060647dbe7017cded08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a95cdbc_554eb996","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":21},"updated":"2016-10-06 16:41:34.000000000","message":"We don\u0027t need these.","commit_id":"aa0725c2f428ca5847f7b3a986c5e15bd7dd4089"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1e0cf256a55b899f0dc55873bd9a00b0c2058ddc","unresolved":false,"context_lines":[{"line_number":12060,"context_line":"            root_device_name\u003d\u0027/dev/vdd\u0027)"},{"line_number":12061,"context_line":"        ]"},{"line_number":12062,"context_line":"        mock_get.return_value \u003d instances + ["},{"line_number":12063,"context_line":"            objects.Instance(uuid\u003duuids.newinstance,"},{"line_number":12064,"context_line":"                             root_device_name\u003d\u0027/dev/vda\u0027)]"},{"line_number":12065,"context_line":""},{"line_number":12066,"context_line":"        # NOTE(danms): We need to have found bdms for our instances,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_cbbce508","line":12063,"range":{"start_line":12063,"start_character":34,"end_line":12063,"end_character":51},"updated":"2016-10-06 18:43:29.000000000","message":"This is cheating a bit as this isn\u0027t in instance_domains or fake_disks above.","commit_id":"a0bc3e91f8439a23b9bd28b2c7b49399b69d10e0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8d9874bae171721ec83cecdb383c7f55cf95917d","unresolved":false,"context_lines":[{"line_number":12060,"context_line":"            root_device_name\u003d\u0027/dev/vdd\u0027)"},{"line_number":12061,"context_line":"        ]"},{"line_number":12062,"context_line":"        mock_get.return_value \u003d instances + ["},{"line_number":12063,"context_line":"            objects.Instance(uuid\u003duuids.newinstance,"},{"line_number":12064,"context_line":"                             root_device_name\u003d\u0027/dev/vda\u0027)]"},{"line_number":12065,"context_line":""},{"line_number":12066,"context_line":"        # NOTE(danms): We need to have found bdms for our instances,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_d7c9df5a","line":12063,"range":{"start_line":12063,"start_character":34,"end_line":12063,"end_character":51},"in_reply_to":"1a95cdbc_2e67174e","updated":"2016-10-06 21:31:10.000000000","message":"You\u0027re right, I confused instance_domains and instance_uuids in the runtime code. I was going for ensuring \"can I still call the _get_instance_disk_info() if I don\u0027t run the bit inside the inner if\". But, I didn\u0027t mean to skip that instance entirely which I\u0027m doing here.\n\nI spent a lot of time trying to make minimal change and keep this test working, but...oops.","commit_id":"a0bc3e91f8439a23b9bd28b2c7b49399b69d10e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e5857b228bc36af2f2df1eaed1b0b620c77e7958","unresolved":false,"context_lines":[{"line_number":12060,"context_line":"            root_device_name\u003d\u0027/dev/vdd\u0027)"},{"line_number":12061,"context_line":"        ]"},{"line_number":12062,"context_line":"        mock_get.return_value \u003d instances + ["},{"line_number":12063,"context_line":"            objects.Instance(uuid\u003duuids.newinstance,"},{"line_number":12064,"context_line":"                             root_device_name\u003d\u0027/dev/vda\u0027)]"},{"line_number":12065,"context_line":""},{"line_number":12066,"context_line":"        # NOTE(danms): We need to have found bdms for our instances,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_2e67174e","line":12063,"range":{"start_line":12063,"start_character":34,"end_line":12063,"end_character":51},"in_reply_to":"1a95cdbc_cbbce508","updated":"2016-10-06 18:59:37.000000000","message":"And because of this, this condition is false in the code:\n\nif guest.uuid in local_instances\n\nSo you don\u0027t get to the part that fails with the KeyError, so it\u0027s not demonstrating the bug.","commit_id":"a0bc3e91f8439a23b9bd28b2c7b49399b69d10e0"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6b09a04b83a01cec7098e619b0ae8ff3a44e5b64","unresolved":false,"context_lines":[{"line_number":6889,"context_line":"                xml \u003d guest.get_xml_desc()"},{"line_number":6890,"context_line":""},{"line_number":6891,"context_line":"                block_device_info \u003d None"},{"line_number":6892,"context_line":"                if guest.uuid in local_instances \\"},{"line_number":6893,"context_line":"                        and (bdms and guest.uuid in bdms):"},{"line_number":6894,"context_line":"                    # Get block device info for instance"},{"line_number":6895,"context_line":"                    block_device_info \u003d driver.get_block_device_info("}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_064b29b1","line":6892,"updated":"2016-10-06 17:33:45.000000000","message":"Consider:\nif guest.uuid in local_instances:\n    if bdms and guest.uuid not in bdms:\n        LOG.debug(\"something informative...\")\n        continue\n\nThe unit tests needs to be tweaked","commit_id":"aa0725c2f428ca5847f7b3a986c5e15bd7dd4089"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1e0cf256a55b899f0dc55873bd9a00b0c2058ddc","unresolved":false,"context_lines":[{"line_number":6711,"context_line":"          * \u0027disk_size\u0027: physical disk size (int)"},{"line_number":6712,"context_line":"          * \u0027over_committed_disk_size\u0027: virt_disk_size - disk_size or 0"},{"line_number":6713,"context_line":"        \"\"\""},{"line_number":6714,"context_line":"        block_device_mapping \u003d driver.block_device_info_get_mapping("},{"line_number":6715,"context_line":"            block_device_info)"},{"line_number":6716,"context_line":""},{"line_number":6717,"context_line":"        volume_devices \u003d set()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_775e5577","line":6714,"updated":"2016-10-06 18:43:29.000000000","message":"So we\u0027ll get an empty list here which is fine.","commit_id":"a0bc3e91f8439a23b9bd28b2c7b49399b69d10e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1e0cf256a55b899f0dc55873bd9a00b0c2058ddc","unresolved":false,"context_lines":[{"line_number":6754,"context_line":"                LOG.debug(\u0027skipping disk because it looks like a volume\u0027, path)"},{"line_number":6755,"context_line":"                continue"},{"line_number":6756,"context_line":""},{"line_number":6757,"context_line":"            if target in volume_devices:"},{"line_number":6758,"context_line":"                LOG.debug(\u0027skipping disk %(path)s (%(target)s) as it is a \u0027"},{"line_number":6759,"context_line":"                          \u0027volume\u0027, {\u0027path\u0027: path, \u0027target\u0027: target})"},{"line_number":6760,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_77ec958f","line":6757,"updated":"2016-10-06 18:43:29.000000000","message":"And we won\u0027t have anything in volume_devices so we won\u0027t be able to do this check...so does that break anything here?\n\nThis was added in:\n\nhttps://github.com/openstack/nova/commit/e71081b856b06513cc1e56a9adb2a619967f0eae\n\nSo I guess there is a risk of an issue but it doesn\u0027t look like that would impact a server create flow.","commit_id":"a0bc3e91f8439a23b9bd28b2c7b49399b69d10e0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8d9874bae171721ec83cecdb383c7f55cf95917d","unresolved":false,"context_lines":[{"line_number":6754,"context_line":"                LOG.debug(\u0027skipping disk because it looks like a volume\u0027, path)"},{"line_number":6755,"context_line":"                continue"},{"line_number":6756,"context_line":""},{"line_number":6757,"context_line":"            if target in volume_devices:"},{"line_number":6758,"context_line":"                LOG.debug(\u0027skipping disk %(path)s (%(target)s) as it is a \u0027"},{"line_number":6759,"context_line":"                          \u0027volume\u0027, {\u0027path\u0027: path, \u0027target\u0027: target})"},{"line_number":6760,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_57806fc0","line":6757,"in_reply_to":"1a95cdbc_77ec958f","updated":"2016-10-06 21:31:10.000000000","message":"This is a periodic, so no. I actually wanted to make more change to the original loop because we really should ignore instances with no bdms instead of kinda falling through the way we do. Maybe I\u0027ll just do that.","commit_id":"a0bc3e91f8439a23b9bd28b2c7b49399b69d10e0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f9bf3274adc5162b083558def42909dcc1bd3517","unresolved":false,"context_lines":[{"line_number":6853,"context_line":"                xml \u003d guest.get_xml_desc()"},{"line_number":6854,"context_line":""},{"line_number":6855,"context_line":"                block_device_info \u003d None"},{"line_number":6856,"context_line":"                if guest.uuid in local_instances \\"},{"line_number":6857,"context_line":"                        and (bdms and guest.uuid in bdms):"},{"line_number":6858,"context_line":"                    # Get block device info for instance"},{"line_number":6859,"context_line":"                    block_device_info \u003d driver.get_block_device_info("}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_dbf546ed","line":6856,"updated":"2016-10-09 09:00:13.000000000","message":"consider:\nif (guest.uuid in local_instances and\n    guest.uuid in bdms):\n\nBlockDeviceMappingList should return an empty list if there are no values.","commit_id":"66246c4c9b6f766f40ee922c38c46f35bb02ae70"}]}