)]}'
{"nova/tests/unit/test_context.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"0138e2fe4ae8267a0aefefd0036948e280437678","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.assertEqual(None, values2[\u0027user_domain\u0027])"},{"line_number":185,"context_line":"        self.assertEqual(111, values2[\u0027user_id\u0027])"},{"line_number":186,"context_line":"        self.assertEqual(\u0027111 222 - - -\u0027, values2[\u0027user_identity\u0027])"},{"line_number":187,"context_line":"        self.assertEqual(None, values2[\u0027user_name\u0027])"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_convert_from_dict_then_to_dict(self):"},{"line_number":190,"context_line":"        values \u003d {\u0027user\u0027: \u0027111\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_4bd048c9","line":187,"updated":"2016-07-21 20:35:33.000000000","message":"1. Any reason you chose to replace this one with a bunch of assertEqual() calls, when on lines 214-215 you used a loop over items()?\n\n2. Did you consider using assertDictContainsSubset()?","commit_id":"b23b8ce082f77eb78e93b74ba3df986acc3f98ff"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"68b9475a96127843659293099a2a6126fc2ae68d","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.assertEqual(None, values2[\u0027user_domain\u0027])"},{"line_number":185,"context_line":"        self.assertEqual(111, values2[\u0027user_id\u0027])"},{"line_number":186,"context_line":"        self.assertEqual(\u0027111 222 - - -\u0027, values2[\u0027user_identity\u0027])"},{"line_number":187,"context_line":"        self.assertEqual(None, values2[\u0027user_name\u0027])"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_convert_from_dict_then_to_dict(self):"},{"line_number":190,"context_line":"        values \u003d {\u0027user\u0027: \u0027111\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_74f4e386","line":187,"in_reply_to":"dada55a8_251ffc5b","updated":"2016-07-22 15:33:59.000000000","message":"Heh.  Figures.  I suspect testtools has a matcher that will accomplish the same task, but *shrug*.","commit_id":"b23b8ce082f77eb78e93b74ba3df986acc3f98ff"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"5d6976a12471298e7b1c4d548d1f062d54327db6","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.assertEqual(None, values2[\u0027user_domain\u0027])"},{"line_number":185,"context_line":"        self.assertEqual(111, values2[\u0027user_id\u0027])"},{"line_number":186,"context_line":"        self.assertEqual(\u0027111 222 - - -\u0027, values2[\u0027user_identity\u0027])"},{"line_number":187,"context_line":"        self.assertEqual(None, values2[\u0027user_name\u0027])"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_convert_from_dict_then_to_dict(self):"},{"line_number":190,"context_line":"        values \u003d {\u0027user\u0027: \u0027111\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_ba9aeb11","line":187,"in_reply_to":"dada55a8_4bd048c9","updated":"2016-07-21 23:23:25.000000000","message":"1. In the other case I had a dictionary already. In this one the only reason that we created the dict was to assertEqual so this seemed more appropriate. \n\n2. I hadn\u0027t heard of that.","commit_id":"b23b8ce082f77eb78e93b74ba3df986acc3f98ff"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"0939c01632a3bae4dcbc686cc90871589dc573e1","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self.assertEqual(None, values2[\u0027user_domain\u0027])"},{"line_number":185,"context_line":"        self.assertEqual(111, values2[\u0027user_id\u0027])"},{"line_number":186,"context_line":"        self.assertEqual(\u0027111 222 - - -\u0027, values2[\u0027user_identity\u0027])"},{"line_number":187,"context_line":"        self.assertEqual(None, values2[\u0027user_name\u0027])"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_convert_from_dict_then_to_dict(self):"},{"line_number":190,"context_line":"        values \u003d {\u0027user\u0027: \u0027111\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_251ffc5b","line":187,"in_reply_to":"dada55a8_ba9aeb11","updated":"2016-07-21 23:33:50.000000000","message":"2. assertdictcontainssubset is marked as deprecated in 3.2 https://docs.python.org/2.7/library/unittest.html#unittest.TestCase.assertDictContainsSubset","commit_id":"b23b8ce082f77eb78e93b74ba3df986acc3f98ff"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"32018ec8aefc77ca4638d376386bc2c4477099a3","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        request_id \u003d \u0027req-679033b7-1755-4929-bf85-eb3bfaef7e0b\u0027"},{"line_number":160,"context_line":"        ctx \u003d context.RequestContext("},{"line_number":161,"context_line":"            111, 222, request_id\u003drequest_id,"},{"line_number":162,"context_line":"            timestamp\u003d\u00272015-03-02T22:31:56.641629\u0027)"},{"line_number":163,"context_line":"        values2 \u003d ctx.to_dict()"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        self.assertIsNone(values2[\u0027auth_token\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_228ae0bf","line":162,"updated":"2016-07-25 16:26:32.000000000","message":"suggest also pull out the timestamp into a variable like request_id.","commit_id":"9f99f6c212c38f8ae26c6aeee4b4521cbf9207a4"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"32018ec8aefc77ca4638d376386bc2c4477099a3","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        self.assertIsNone(values2[\u0027auth_token\u0027])"},{"line_number":166,"context_line":"        self.assertIsNone(values2[\u0027domain\u0027])"},{"line_number":167,"context_line":"        self.assertEqual(False, values2[\u0027instance_lock_checked\u0027])"},{"line_number":168,"context_line":"        self.assertEqual(False, values2[\u0027is_admin\u0027])"},{"line_number":169,"context_line":"        self.assertEqual(222, values2[\u0027project_id\u0027])"},{"line_number":170,"context_line":"        self.assertIsNone(values2[\u0027project_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_a2c7f010","line":167,"updated":"2016-07-25 16:26:32.000000000","message":"The \"assertEqual(False\"s should use assertIs since comparing to a singleton.","commit_id":"9f99f6c212c38f8ae26c6aeee4b4521cbf9207a4"}]}