)]}'
{"nova/virt/xenapi/volume_utils.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1fcd152238f93d73003820c3848066db7097d6a1","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    target_port \u003d _get_target_port(target_portal)"},{"line_number":235,"context_line":"    target_iqn \u003d connection_data[\u0027target_iqn\u0027]"},{"line_number":236,"context_line":"    LOG.debug(\u0027(vol_id,number,host,port,iqn): (%s,%s,%s,%s)\u0027,"},{"line_number":237,"context_line":"              volume_id, target_host, target_port, target_iqn)"},{"line_number":238,"context_line":"    if (volume_id is None or"},{"line_number":239,"context_line":"        target_host is None or"},{"line_number":240,"context_line":"        target_iqn is None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FnwY%3D","line":237,"updated":"2013-06-26 15:31:01.000000000","message":"so I think we normally go for dicts now, to help translators, but I guess thats not valid here.","commit_id":"465a84c012f3cd4845d9bbd64d97da6253446144"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c56a64b084bc39114a7d5cf0cd8727e06bb5d29f","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    target_port \u003d _get_target_port(target_portal)"},{"line_number":235,"context_line":"    target_iqn \u003d connection_data[\u0027target_iqn\u0027]"},{"line_number":236,"context_line":"    LOG.debug(\u0027(vol_id,number,host,port,iqn): (%s,%s,%s,%s)\u0027,"},{"line_number":237,"context_line":"              volume_id, target_host, target_port, target_iqn)"},{"line_number":238,"context_line":"    if (volume_id is None or"},{"line_number":239,"context_line":"        target_host is None or"},{"line_number":240,"context_line":"        target_iqn is None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fnvo%3D","line":237,"in_reply_to":"AAAAPn%2F%2FnwY%3D","updated":"2013-06-26 15:34:13.000000000","message":"Use named params in this case.","commit_id":"465a84c012f3cd4845d9bbd64d97da6253446144"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3f36949f2eaa80eff43214fc146f7f4435d486f6","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    LOG.debug("},{"line_number":237,"context_line":"        \u0027(vol_id,host,port,iqn): \u0027"},{"line_number":238,"context_line":"        \u0027(%(vol_id)s,%(host)s,%(port)s,%(iqn)s)\u0027,"},{"line_number":239,"context_line":"        dict("},{"line_number":240,"context_line":"            vol_id\u003dvolume_id,"},{"line_number":241,"context_line":"            host\u003dtarget_host,"},{"line_number":242,"context_line":"            port\u003dtarget_port,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fnqo%3D","line":239,"updated":"2013-06-26 15:58:27.000000000","message":"use {} instead of dict()\nfor more details read Doug\u0027s post \nhttp://doughellmann.com/2012/11/the-performance-impact-of-using-dict-instead-of-in-cpython-2-7-2.html","commit_id":"fa0d9333148095b5441ac845f71e61efa07ae27b"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"ad3a14e1254b897ed147f0d04bb6d5175b3442fa","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    LOG.debug("},{"line_number":237,"context_line":"        \u0027(vol_id,host,port,iqn): \u0027"},{"line_number":238,"context_line":"        \u0027(%(vol_id)s,%(host)s,%(port)s,%(iqn)s)\u0027,"},{"line_number":239,"context_line":"        dict("},{"line_number":240,"context_line":"            vol_id\u003dvolume_id,"},{"line_number":241,"context_line":"            host\u003dtarget_host,"},{"line_number":242,"context_line":"            port\u003dtarget_port,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fnjg%3D","line":239,"in_reply_to":"AAAAPn%2F%2Fnqo%3D","updated":"2013-06-26 16:41:30.000000000","message":"Performance tuning aside, I\u0027d prefer you populated the dict outside of the log statement. This looks a little messy, IMO","commit_id":"fa0d9333148095b5441ac845f71e61efa07ae27b"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"003a81d18fb1fa15f2c053321b9617d5ced71ca2","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        \"port\": target_port,"},{"line_number":241,"context_line":"        \"iqn\": target_iqn"},{"line_number":242,"context_line":"    }"},{"line_number":243,"context_line":"    LOG.debug(\u0027(vol_id,host,port,iqn): \u0027"},{"line_number":244,"context_line":"              \u0027(%(vol_id)s,%(host)s,%(port)s,%(iqn)s)\u0027, log_params)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    if (volume_id is None or"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2Fjn8%3D","line":243,"updated":"2013-06-27 20:26:25.000000000","message":"The string should be wrapped w/ _() for i18n.","commit_id":"68583e6423e49ad62abd0ca32bd78288bc0f0d5a"}]}