)]}'
{"api-ref/source/parameters.yaml":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"1ea5034685ae20f96b82a23abdb46cffdeb021ba","unresolved":false,"context_lines":[{"line_number":1089,"context_line":"  type: object"},{"line_number":1090,"context_line":"block_migration:"},{"line_number":1091,"context_line":"  description: |"},{"line_number":1092,"context_line":"    Set to ``auto`` by default which means nova will decide the value of"},{"line_number":1093,"context_line":"    block_migration during live-migration."},{"line_number":1094,"context_line":"  in: body"},{"line_number":1095,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_ef9b51c7","line":1092,"range":{"start_line":1092,"start_character":20,"end_line":1092,"end_character":30},"updated":"2016-07-26 15:35:24.000000000","message":"check implementation please: https://github.com/openstack/nova/blob/caeb8ecb85cede691622c1c90c3957dc3e7d3496/nova/api/openstack/compute/migrate_server.py#L77-L88 this param is not defaulted to auto in API, it was just allowed to pass auto","commit_id":"034a9c7e7a76c62c49c36ce8ad8df511efb822f7"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"0e2241e70b5955409befebd69a4e04fb1813e9c9","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"  in: body"},{"line_number":1095,"context_line":"  required: true"},{"line_number":1096,"context_line":"  type: string"},{"line_number":1097,"context_line":"  min_version: 2.25"},{"line_number":1098,"context_line":"boot_index:"},{"line_number":1099,"context_line":"  description: |"},{"line_number":1100,"context_line":"    Defines the order in which a hypervisor tries devices when it attempts to boot"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dada55a8_d2b24c93","line":1097,"range":{"start_line":1097,"start_character":2,"end_line":1097,"end_character":19},"updated":"2016-07-27 11:17:15.000000000","message":"imo, it\u0027s not valid setting min_version here, block_migration param was before 2.25 either, but it could accept only boolean values before 2.25.","commit_id":"9b49c5de93a23918e7c368f50b5cfdb77ea79cc2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fd730ea00ab7e5abb60796b34472a85928f2febf","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"  in: body"},{"line_number":1095,"context_line":"  required: true"},{"line_number":1096,"context_line":"  type: string"},{"line_number":1097,"context_line":"  min_version: 2.25"},{"line_number":1098,"context_line":"boot_index:"},{"line_number":1099,"context_line":"  description: |"},{"line_number":1100,"context_line":"    Defines the order in which a hypervisor tries devices when it attempts to boot"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bacf61ea_6dc50a3c","line":1097,"range":{"start_line":1097,"start_character":2,"end_line":1097,"end_character":19},"in_reply_to":"dada55a8_15a96e24","updated":"2016-08-03 15:02:47.000000000","message":"+1 what Artom said, lets try have two entries for the old and the new thing.","commit_id":"9b49c5de93a23918e7c368f50b5cfdb77ea79cc2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"87220d66988e609ba77ee23515e1a0d2d911a5a3","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"  in: body"},{"line_number":1095,"context_line":"  required: true"},{"line_number":1096,"context_line":"  type: string"},{"line_number":1097,"context_line":"  min_version: 2.25"},{"line_number":1098,"context_line":"boot_index:"},{"line_number":1099,"context_line":"  description: |"},{"line_number":1100,"context_line":"    Defines the order in which a hypervisor tries devices when it attempts to boot"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dada55a8_15a96e24","line":1097,"range":{"start_line":1097,"start_character":2,"end_line":1097,"end_character":19},"in_reply_to":"dada55a8_d2b24c93","updated":"2016-07-27 11:40:52.000000000","message":"I think we could do two block_migration params here, one boolean max_version 2.24, one string min_version 2.25. Assuming it passes tests and nothing complains about duplicate params, it\u0027d be my prefered solution FWIW.\n\nIn novaclient, I added the tag key to the --block-device argument in 2.32, so I had two --block-device arguments, each with a different help text, wrapped in a versioned utils.args [1] I know it\u0027s a completely different context, but the bigger logic seems appropriate enough.\n\nAlso, I specifically got a -1 on that review [2] telling me to not just put in the description \u0027tag is a new key in version 2.32\u0027, so I think the same applies here, don\u0027t just mention in the description that it\u0027s string since 2.25.\n\n[1] https://review.openstack.org/#/c/299222/20/novaclient/v2/shell.py@442\n[2] https://review.openstack.org/#/c/299222/10/novaclient/v2/shell.py@503","commit_id":"9b49c5de93a23918e7c368f50b5cfdb77ea79cc2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"885618374830b19eb46d8e15d26779fcc74b4301","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"  in: body"},{"line_number":1096,"context_line":"  required: true"},{"line_number":1097,"context_line":"  type: boolean"},{"line_number":1098,"context_line":"  max_version: 2.24"},{"line_number":1099,"context_line":"block_migration:"},{"line_number":1100,"context_line":"  description: |"},{"line_number":1101,"context_line":"    Migrates local disks by using block migration. Set to ``auto`` which means"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ad45d7e_6e08622e","line":1098,"updated":"2016-08-09 13:04:28.000000000","message":"This doesn\u0027t even show up:\n\nhttp://docs-draft.openstack.org/52/345652/3/check/gate-nova-api-ref/248a1de//api-ref/build/html/?expanded\u003dlive-migrate-server-os-migratelive-action-detail#id115","commit_id":"bf74d00f192d5c63e26a8757c4d222b0890d372d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"129d971b06727ca256cf24c20c2306f5feaacd95","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"  in: body"},{"line_number":1096,"context_line":"  required: true"},{"line_number":1097,"context_line":"  type: boolean"},{"line_number":1098,"context_line":"  max_version: 2.24"},{"line_number":1099,"context_line":"block_migration:"},{"line_number":1100,"context_line":"  description: |"},{"line_number":1101,"context_line":"    Migrates local disks by using block migration. Set to ``auto`` which means"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ad45d7e_ddf8d9c5","line":1098,"in_reply_to":"9ad45d7e_6e08622e","updated":"2016-08-10 15:15:29.000000000","message":"+1 I added comments on how to fix that.","commit_id":"bf74d00f192d5c63e26a8757c4d222b0890d372d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"129d971b06727ca256cf24c20c2306f5feaacd95","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"  required: true"},{"line_number":1097,"context_line":"  type: boolean"},{"line_number":1098,"context_line":"  max_version: 2.24"},{"line_number":1099,"context_line":"block_migration:"},{"line_number":1100,"context_line":"  description: |"},{"line_number":1101,"context_line":"    Migrates local disks by using block migration. Set to ``auto`` which means"},{"line_number":1102,"context_line":"    nova will decide the value of block_migration during live-migration."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ad45d7e_fd74bd68","line":1099,"range":{"start_line":1099,"start_character":0,"end_line":1099,"end_character":15},"updated":"2016-08-10 15:15:29.000000000","message":"This should be block_migration_2_25 I think.","commit_id":"bf74d00f192d5c63e26a8757c4d222b0890d372d"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"304a6e2b360e980160bdeef99b4a2b3265c87361","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"block_migration:"},{"line_number":1100,"context_line":"  description: |"},{"line_number":1101,"context_line":"    Migrates local disks by using block migration. Set to ``auto`` which means"},{"line_number":1102,"context_line":"    nova will decide the value of block_migration during live-migration."},{"line_number":1103,"context_line":"  in: body"},{"line_number":1104,"context_line":"  required: true"},{"line_number":1105,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ad45d7e_5ebf1ed0","line":1102,"range":{"start_line":1102,"start_character":14,"end_line":1102,"end_character":49},"updated":"2016-08-09 07:01:03.000000000","message":"Maybe worth better explain about this decided by whether the dest and source on the shared storage.","commit_id":"bf74d00f192d5c63e26a8757c4d222b0890d372d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bc421d5b3ed3fe2ce50328e39564aa581a556dfb","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"block_migration:"},{"line_number":1100,"context_line":"  description: |"},{"line_number":1101,"context_line":"    Migrates local disks by using block migration. Set to ``auto`` which means"},{"line_number":1102,"context_line":"    nova will decide the value of block_migration during live-migration."},{"line_number":1103,"context_line":"  in: body"},{"line_number":1104,"context_line":"  required: true"},{"line_number":1105,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9ad45d7e_3d4815cc","line":1102,"range":{"start_line":1102,"start_character":14,"end_line":1102,"end_character":49},"in_reply_to":"9ad45d7e_5ebf1ed0","updated":"2016-08-10 15:20:21.000000000","message":"+1 we should describe that it depends if the instance\u0027s disks need to be moved or not to the destination.\n\nWe also don\u0027t mention that true and false are also supported, at least I assume they are? See here:\nhttps://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/migrate_server.py#n82","commit_id":"bf74d00f192d5c63e26a8757c4d222b0890d372d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ef213ce28b778525873d6c87f4f4c1fe7d4731da","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"  max_version: 2.24"},{"line_number":1099,"context_line":"block_migration_2_25:"},{"line_number":1100,"context_line":"  description: |"},{"line_number":1101,"context_line":"    Migrates local disks by using block migration. Set to ``auto`` which means"},{"line_number":1102,"context_line":"    nova will decide the value of block_migration during live-migration. Nova service"},{"line_number":1103,"context_line":"    on destination host checks if it is possible to execute live migration and then"},{"line_number":1104,"context_line":"    calls back to the source host. Ephemeral drives are copied over the network in"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_e3bdf002","line":1101,"range":{"start_line":1101,"start_character":51,"end_line":1101,"end_character":66},"updated":"2016-08-18 10:37:17.000000000","message":"As previous patch, we need to describe the True and False are still supported, should you care about ensuring if block migration is happening or not.\n\nSee here:\nhttps://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/migrate_server.py#n82\n\nNote its not really a string as the param is True, False and \"auto\", Not \"True\", \"False\" and \"auto\", but I may be wrong.","commit_id":"87474c6b819ebae71d44739e06195b786567fb5c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ef213ce28b778525873d6c87f4f4c1fe7d4731da","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"    nova will decide the value of block_migration during live-migration. Nova service"},{"line_number":1103,"context_line":"    on destination host checks if it is possible to execute live migration and then"},{"line_number":1104,"context_line":"    calls back to the source host. Ephemeral drives are copied over the network in"},{"line_number":1105,"context_line":"    block migration. Access to shared storage is not required. Block migration is"},{"line_number":1106,"context_line":"    incompatible with read-only devices such as config drive."},{"line_number":1107,"context_line":"  in: body"},{"line_number":1108,"context_line":"  required: true"},{"line_number":1109,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_239ee8b8","line":1106,"range":{"start_line":1105,"start_character":63,"end_line":1106,"end_character":61},"updated":"2016-08-18 10:37:17.000000000","message":"That is not true for all drivers. It is a libvirt bug that may now be fixed.","commit_id":"87474c6b819ebae71d44739e06195b786567fb5c"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b949033776279a29a1eff77cff0997886b0dd3df","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"    Migrates local disks by using block migration. Set to ``auto`` which means"},{"line_number":1102,"context_line":"    nova will detect whether source and destination hosts on shared storage. if they are"},{"line_number":1103,"context_line":"    on shared storage, the live-migration won\u0027t be block migration. Otherwise the block"},{"line_number":1104,"context_line":"    migration will be executed. When set to ``True``, the scheduler will choose a host"},{"line_number":1105,"context_line":"    which is not on the shared storage with original host. When set to ``False``, the"},{"line_number":1106,"context_line":"    scheduler will choose a host which is on shared storage with original host."},{"line_number":1107,"context_line":"  in: body"},{"line_number":1108,"context_line":"  required: true"},{"line_number":1109,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1ac06dbe_0b5c8f7b","line":1106,"range":{"start_line":1104,"start_character":31,"end_line":1106,"end_character":79},"updated":"2016-08-24 09:15:45.000000000","message":"this is not the behaviour currently. Set to True means the request will failed when the host is on the shared stroage(whatever the host is specified by user or select by scheduler). Set to False means the request will failed when the host isn\u0027t on the shared storage.\n\nThis should be same with the description at line 1092","commit_id":"31f4dfa620789962536d7373228e158cdeb6eba2"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"0ad535a1748796559ee46d1d88fc25ebbafcb3c5","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"    Migrates local disks by using block migration. Set to ``auto`` which means"},{"line_number":1102,"context_line":"    nova will detect whether source and destination hosts on shared storage. if they are"},{"line_number":1103,"context_line":"    on shared storage, the live-migration won\u0027t be block migration. Otherwise the block"},{"line_number":1104,"context_line":"    migration will be executed. When set to ``True``, the scheduler will choose a host"},{"line_number":1105,"context_line":"    which is not on the shared storage with original host. When set to ``False``, the"},{"line_number":1106,"context_line":"    scheduler will choose a host which is on shared storage with original host."},{"line_number":1107,"context_line":"  in: body"},{"line_number":1108,"context_line":"  required: true"},{"line_number":1109,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1ac06dbe_2cfeb238","line":1106,"range":{"start_line":1104,"start_character":31,"end_line":1106,"end_character":79},"in_reply_to":"1ac06dbe_0b5c8f7b","updated":"2016-08-24 13:46:55.000000000","message":"Done","commit_id":"31f4dfa620789962536d7373228e158cdeb6eba2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9726e51b9294068be955004505daf69524db3800","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"    Migrates local disks by using block migration. Set to ``auto`` which means"},{"line_number":1102,"context_line":"    nova will detect whether source and destination hosts on shared storage. if they are"},{"line_number":1103,"context_line":"    on shared storage, the live-migration won\u0027t be block migration. Otherwise the block"},{"line_number":1104,"context_line":"    migration will be executed. Set to ``True``, means tha request will fail when the"},{"line_number":1105,"context_line":"    source or destination host uses shared storage. Set to ``False`` means the request"},{"line_number":1106,"context_line":"    will fail when the source and destination hosts are not on the shared storage."},{"line_number":1107,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fa7ab95a_be114b54","line":1104,"range":{"start_line":1104,"start_character":55,"end_line":1104,"end_character":58},"updated":"2016-08-30 11:34:18.000000000","message":"s/tha/the/","commit_id":"c08bfabda2140c848535bae7cb2c3ca7da944cd3"}],"api-ref/source/servers-admin-action.inc":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"0e2241e70b5955409befebd69a4e04fb1813e9c9","unresolved":false,"context_lines":[{"line_number":146,"context_line":"is not suitable to do migration, the scheduler tries up to"},{"line_number":147,"context_line":"``migrate_max_retries`` rescheduling attempts."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Starting from API version 2.25, the ``block_migration`` parameter is set to"},{"line_number":150,"context_line":"``auto`` so that nova can decide value of block_migration during live"},{"line_number":151,"context_line":"migration."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Policy defaults enable only users with the administrative role to"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"dada55a8_1280648a","line":150,"range":{"start_line":149,"start_character":66,"end_line":150,"end_character":8},"updated":"2016-07-27 11:17:15.000000000","message":"I\u0027d rephrase it to \u0027could be set to ``auto``\u0027","commit_id":"9b49c5de93a23918e7c368f50b5cfdb77ea79cc2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"129d971b06727ca256cf24c20c2306f5feaacd95","unresolved":false,"context_lines":[{"line_number":174,"context_line":"  - server_id: server_id"},{"line_number":175,"context_line":"  - host: host_migration"},{"line_number":176,"context_line":"  - block_migration: block_migration"},{"line_number":177,"context_line":"  - disk_over_commit: disk_over_commit"},{"line_number":178,"context_line":"  - force: force_live_migrate"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"**Example Live-Migrate Server (os-migrateLive Action): JSON request**"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"9ad45d7e_1d51d1d8","line":177,"updated":"2016-08-10 15:15:29.000000000","message":"So I think we need two entries here:\n\n- disk_over_commit: disk_over_commit\n- disk_over_commit: disk_over_commit_2.25\n\nOr something like that?","commit_id":"bf74d00f192d5c63e26a8757c4d222b0890d372d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"129d971b06727ca256cf24c20c2306f5feaacd95","unresolved":false,"context_lines":[{"line_number":180,"context_line":"**Example Live-Migrate Server (os-migrateLive Action): JSON request**"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":".. literalinclude:: ../../doc/api_samples/os-migrate-server/live-migrate-server.json"},{"line_number":183,"context_line":"   :language: javascript"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"Response"},{"line_number":186,"context_line":"--------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"9ad45d7e_fd6afdb1","line":183,"updated":"2016-08-10 15:15:29.000000000","message":"Lets add the additional sample file here if you want, linking to this:\nhttps://git.openstack.org/cgit/openstack/nova/tree/doc/api_samples/os-migrate-server/v2.30/live-migrate-server.json","commit_id":"bf74d00f192d5c63e26a8757c4d222b0890d372d"}],"doc/api_samples/os-migrate-server/live-migrate-server.json":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"aebbd8ff0c7336f17cd58a91eb6636467dbe1294","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"os-migrateLive\": {"},{"line_number":3,"context_line":"        \"host\": \"01c0cadef72d47e28a672a76060d492c\","},{"line_number":4,"context_line":"        \"block_migration\": \"auto\","},{"line_number":5,"context_line":"        \"disk_over_commit\": false"},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"dada55a8_8c00fa67","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":34},"updated":"2016-07-26 09:18:36.000000000","message":"I can find the samples for API version 2.25 in doc/api_samples/os-migrate-server/v2.25.\nSo IMO, it is not necessary to change it.","commit_id":"034a9c7e7a76c62c49c36ce8ad8df511efb822f7"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"0c6c1f9ba920d58bdebac010a38fc89c95741613","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"os-migrateLive\": {"},{"line_number":3,"context_line":"        \"host\": \"01c0cadef72d47e28a672a76060d492c\","},{"line_number":4,"context_line":"        \"block_migration\": \"auto\","},{"line_number":5,"context_line":"        \"disk_over_commit\": false"},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":1,"id":"dada55a8_e90511c2","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":34},"in_reply_to":"dada55a8_8c00fa67","updated":"2016-07-26 15:02:45.000000000","message":"in servers-admin-actions.inc we are referring todoc/api_samples/os-migrate-server/live-migrate-server.json. https://github.com/openstack/nova/blob/master/api-ref/source/servers-admin-action.inc#L183\nHence, made changes here.","commit_id":"034a9c7e7a76c62c49c36ce8ad8df511efb822f7"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ceb5fb0ed7f295a27d711aa1cb0345a797dddd25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"os-migrateLive\": {"},{"line_number":3,"context_line":"        \"host\": \"01c0cadef72d47e28a672a76060d492c\","},{"line_number":4,"context_line":"        \"block_migration\": \"auto\","},{"line_number":5,"context_line":"        \"disk_over_commit\": false"},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"bacf61ea_ad51e964","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":34},"updated":"2016-07-28 04:43:34.000000000","message":"For example, in os-hypervisors.inc, the sample in version directory is used.\n\nhttps://github.com/openstack/nova/blob/bdb46ccc9c89f023719570ebb47300c9bdbe635d/api-ref/source/os-hypervisors.inc#L107\n\nSo servers-admin-action.inc should be modified instead of this file.","commit_id":"9b49c5de93a23918e7c368f50b5cfdb77ea79cc2"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"7f9b32bab398a27d5884ce765589731c016c7601","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"os-migrateLive\": {"},{"line_number":3,"context_line":"        \"host\": \"01c0cadef72d47e28a672a76060d492c\","},{"line_number":4,"context_line":"        \"block_migration\": \"auto\","},{"line_number":5,"context_line":"        \"disk_over_commit\": false"},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":2,"id":"bacf61ea_5798c16a","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":34},"in_reply_to":"bacf61ea_ad51e964","updated":"2016-08-02 18:50:27.000000000","message":"ok. the samples for API version 2.25 is not same as required JSON request as we have introduced \"force\" param as a part of 2.30. Hence, I made change todoc/api_samples/os-migrate-server/live-migrate-server.json. Please let me know if you have better suggestion.","commit_id":"9b49c5de93a23918e7c368f50b5cfdb77ea79cc2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"129d971b06727ca256cf24c20c2306f5feaacd95","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"os-migrateLive\": {"},{"line_number":3,"context_line":"        \"host\": \"01c0cadef72d47e28a672a76060d492c\","},{"line_number":4,"context_line":"        \"block_migration\": \"auto\","},{"line_number":5,"context_line":"        \"disk_over_commit\": false"},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"9ad45d7e_dd39f9d8","line":4,"updated":"2016-08-10 15:15:29.000000000","message":"We can\u0027t make this change. These should only be updated by the unit tests generating the value. This can never be generated.\n\nCan\u0027t we just use this one?https://git.openstack.org/cgit/openstack/nova/tree/doc/api_samples/os-migrate-server/v2.30/live-migrate-server.json","commit_id":"bf74d00f192d5c63e26a8757c4d222b0890d372d"}]}