)]}'
{"nova/console/websocketproxy.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"68bccd983148871386a6d8065f6888a8a8555b41","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                    try:"},{"line_number":94,"context_line":"                        cookie.load(hcookie_part)"},{"line_number":95,"context_line":"                    except Cookie.CookieError:"},{"line_number":96,"context_line":"                        LOG.debug(\u0027Malformed cookie: \"%s\"\u0027, hcookie_part,"},{"line_number":97,"context_line":"                                  exc_info\u003dTrue)"},{"line_number":98,"context_line":"                    else:"},{"line_number":99,"context_line":"                        if \u0027token\u0027 in cookie:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_efec8394","line":96,"updated":"2016-08-02 17:51:09.000000000","message":"Isn\u0027t this something we should warn an operator about? Based on the bug description this happens if something is wrong with the configuration. If it only goes to debug logs, there is a very low chance anybody notices that.","commit_id":"1ed6d7c374e9d07363731218ca1f34f991299aaf"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"091174d6e16ce26d7aa3887d9b1482d30722d47e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                    try:"},{"line_number":94,"context_line":"                        cookie.load(hcookie_part)"},{"line_number":95,"context_line":"                    except Cookie.CookieError:"},{"line_number":96,"context_line":"                        LOG.warn(\u0027Malformed cookie: \"%s\"\u0027, hcookie_part,"},{"line_number":97,"context_line":"                                  exc_info\u003dTrue)"},{"line_number":98,"context_line":"                    else:"},{"line_number":99,"context_line":"                        if \u0027token\u0027 in cookie:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_804c9577","line":96,"updated":"2016-08-03 10:04:53.000000000","message":"nit: let\u0027s use LOG.warning() instead of LOG.warn(), wrap the string into _LW() to allow for translations and skip the exc_info as it\u0027s more like information for developers rather than for operators\n\nI believe thats the best practices based on http://codesearch.openstack.org/?q\u003dLOG.warn\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"ad899f5fe37c9dc94986e7dcf6d126a025f3dd9c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cef9f87270d76f28cd46546e3ea6bc74f2c298e7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                        cookie.load(hcookie_part)"},{"line_number":96,"context_line":"                    except Cookie.CookieError:"},{"line_number":97,"context_line":"                        LOG.warning(_LW(\u0027Malformed cookie: \"%s\"\u0027),"},{"line_number":98,"context_line":"                                    hcookie_part)"},{"line_number":99,"context_line":"                    else:"},{"line_number":100,"context_line":"                        if \u0027token\u0027 in cookie:"},{"line_number":101,"context_line":"                            token \u003d cookie[\u0027token\u0027].value"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_6bf8717d","line":98,"range":{"start_line":98,"start_character":36,"end_line":98,"end_character":48},"updated":"2016-09-09 22:07:44.000000000","message":"Should we be logging cookie data? I thought it could contain sensitive data?","commit_id":"ec45e866e561593bd031d51afe6e2a796f551ae8"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"65fbab8b2962bf69aebcb94532faec6ce9b349fc","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                        cookie.load(hcookie_part)"},{"line_number":96,"context_line":"                    except Cookie.CookieError:"},{"line_number":97,"context_line":"                        LOG.warning(_LW(\u0027Malformed cookie: \"%s\"\u0027),"},{"line_number":98,"context_line":"                                    hcookie_part)"},{"line_number":99,"context_line":"                    else:"},{"line_number":100,"context_line":"                        if \u0027token\u0027 in cookie:"},{"line_number":101,"context_line":"                            token \u003d cookie[\u0027token\u0027].value"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_30e04296","line":98,"range":{"start_line":98,"start_character":36,"end_line":98,"end_character":48},"in_reply_to":"9a89bdaa_6bf8717d","updated":"2016-09-21 14:33:08.000000000","message":"I was thinking that malformed cookies are not interesting from point of leaks, but I agree with you that even malformed cookie can contain secure data, i will remove that from here.","commit_id":"ec45e866e561593bd031d51afe6e2a796f551ae8"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"82290043c712b684913450162035661e89153563","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    try:"},{"line_number":95,"context_line":"                        cookie.load(hcookie_part)"},{"line_number":96,"context_line":"                    except Cookie.CookieError:"},{"line_number":97,"context_line":"                        LOG.warning(_LW(\u0027Found malformed cookie\u0027))"},{"line_number":98,"context_line":"                    else:"},{"line_number":99,"context_line":"                        if \u0027token\u0027 in cookie:"},{"line_number":100,"context_line":"                            token \u003d cookie[\u0027token\u0027].value"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_376af181","line":97,"updated":"2016-09-21 15:57:53.000000000","message":"It would be nice to have a comment here explaining that the cookie data is not logged because it may be security sensitive.","commit_id":"dc2d666b99d5dd1ef40fc7f69bd6ade71539f525"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dc0ee61b69bb2245c3036e131971aac55dcaec36","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                    except Cookie.CookieError:"},{"line_number":97,"context_line":"                        # NOTE(stgleb): Do not print out cookie content"},{"line_number":98,"context_line":"                        # for security reasons."},{"line_number":99,"context_line":"                        LOG.warning(_LW(\u0027Found malformed cookie\u0027))"},{"line_number":100,"context_line":"                    else:"},{"line_number":101,"context_line":"                        if \u0027token\u0027 in cookie:"},{"line_number":102,"context_line":"                            token \u003d cookie[\u0027token\u0027].value"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_f5408a36","line":99,"updated":"2016-09-26 08:07:24.000000000","message":"It feels like we should add more context here, but I guess we already log request-id by default, etc.","commit_id":"6b3b7296b997d83bf272abc78581c6afb5d4131e"}]}