)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b09169cb15c3b6682ce60dda166883743831526a","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                          instance\u003dinstance)"},{"line_number":820,"context_line":"                raise loopingcall.LoopingCallDone()"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"            if data[\u0027tries\u0027] \u003e\u003d CONF.ironic.api_max_retries + 1:"},{"line_number":823,"context_line":"                msg \u003d (_(\"Error destroying the instance on node %(node)s. \""},{"line_number":824,"context_line":"                         \"Provision state still \u0027%(state)s\u0027.\")"},{"line_number":825,"context_line":"                       % {\u0027state\u0027: node.provision_state,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_d3777700","line":822,"updated":"2016-07-25 05:32:48.000000000","message":"This change looks good.\n\nBut about \u0027api_max_retries\u0027, \"if set to 0, only try once, no retries.\" in nova/conf/ironic.py.\nBut in this case, if \u0027api_max_retries\u0027 is 0, it seems one retry occurs.","commit_id":"2f7e45bcbf76405a2febfb80e935e7185c1d5a41"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b13380a3b974e8fbdbc876a6d8ca85bd4a5812b0","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                          instance\u003dinstance)"},{"line_number":820,"context_line":"                raise loopingcall.LoopingCallDone()"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"            if data[\u0027tries\u0027] \u003e\u003d CONF.ironic.api_max_retries + 1:"},{"line_number":823,"context_line":"                msg \u003d (_(\"Error destroying the instance on node %(node)s. \""},{"line_number":824,"context_line":"                         \"Provision state still \u0027%(state)s\u0027.\")"},{"line_number":825,"context_line":"                       % {\u0027state\u0027: node.provision_state,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_54b9a414","line":822,"in_reply_to":"dada55a8_d3777700","updated":"2016-07-25 11:03:02.000000000","message":"data[\u0027tries\u0027] should be 0 at that point, so looks fine?","commit_id":"2f7e45bcbf76405a2febfb80e935e7185c1d5a41"}]}