)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"20fcf1976d0f3aee30378835aeb565eb5d4f5108","unresolved":false,"context_lines":[{"line_number":11,"context_line":"bind a port to a host where the existing fixed_ips are not compatible."},{"line_number":12,"context_line":"This should just abort the build immediately. In the future, when"},{"line_number":13,"context_line":"generic resource pools are available for scheduling, Nova will be able"},{"line_number":14,"context_line":"to schedule to avoid this problem and this will be obsolete."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I68a0d5e3b3ea025629cbaa220c5a6043d69b0bc9"},{"line_number":17,"context_line":"Depends-On: I636ef272202ec7ea8fc0adbfd86ca3eb07e316ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_52e62117","line":14,"updated":"2016-08-02 14:11:35.000000000","message":"As an aside, if you pass the same port into two build requests started at the same time, what happens. I need to go think about that.\n\nI like this extra protection, even when we have the scheduler in place. You can do things like force a specific host, so its a good protection for that case.","commit_id":"f123d83912e736e974fcdbed43fdb704627def6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21a00a93b4659c864ad50c870454aeaf58e84d36","unresolved":false,"context_lines":[{"line_number":11,"context_line":"bind a port to a host where the existing fixed_ips are not compatible."},{"line_number":12,"context_line":"This should just abort the build immediately. In the future, when"},{"line_number":13,"context_line":"generic resource pools are available for scheduling, Nova will be able"},{"line_number":14,"context_line":"to schedule to avoid this problem and this will be obsolete."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I68a0d5e3b3ea025629cbaa220c5a6043d69b0bc9"},{"line_number":17,"context_line":"Depends-On: I636ef272202ec7ea8fc0adbfd86ca3eb07e316ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_de617a13","line":14,"in_reply_to":"bacf61ea_52e62117","updated":"2016-08-02 15:16:25.000000000","message":"@John, that\u0027s not valid because there can only be one device_id set on the port, so the last one in fails:\n\nhttps://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1466","commit_id":"f123d83912e736e974fcdbed43fdb704627def6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21a00a93b4659c864ad50c870454aeaf58e84d36","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to schedule to avoid this problem and this will be obsolete."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I68a0d5e3b3ea025629cbaa220c5a6043d69b0bc9"},{"line_number":17,"context_line":"Depends-On: I636ef272202ec7ea8fc0adbfd86ca3eb07e316ba"},{"line_number":18,"context_line":"Partially-Implements: blueprint neutron-routed-networks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_fe01de6b","line":17,"updated":"2016-08-02 15:16:25.000000000","message":"We should update this to whatever g-r change raises the minimum required version of neutronclient to pull this in (which isn\u0027t released yet). Note the final release for client libs is 9/2. Might want to propose a release or ask armax to do that next week.","commit_id":"f123d83912e736e974fcdbed43fdb704627def6d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"783740f7ff9e5eac8e7d8aa2101d44870d42fdbe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to schedule to avoid this problem and this will be obsolete."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I68a0d5e3b3ea025629cbaa220c5a6043d69b0bc9"},{"line_number":17,"context_line":"Depends-On: I636ef272202ec7ea8fc0adbfd86ca3eb07e316ba"},{"line_number":18,"context_line":"Partially-Implements: blueprint neutron-routed-networks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_36530a6d","line":17,"in_reply_to":"bacf61ea_54228202","updated":"2016-08-10 19:57:44.000000000","message":"5.1.0 of the client is released [1].\n\n[1] https://review.openstack.org/#/c/351967/","commit_id":"f123d83912e736e974fcdbed43fdb704627def6d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ee067263fdedbe8c2419aab35836eaf70d08113c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to schedule to avoid this problem and this will be obsolete."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I68a0d5e3b3ea025629cbaa220c5a6043d69b0bc9"},{"line_number":17,"context_line":"Depends-On: I636ef272202ec7ea8fc0adbfd86ca3eb07e316ba"},{"line_number":18,"context_line":"Partially-Implements: blueprint neutron-routed-networks"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_54228202","line":17,"in_reply_to":"bacf61ea_fe01de6b","updated":"2016-08-02 17:31:07.000000000","message":"I\u0027ll follow up on this.","commit_id":"f123d83912e736e974fcdbed43fdb704627def6d"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"717a8d9958656864efde396955cf43547ef851ab","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                            \u0027in use on network %(network)s.\u0027),"},{"line_number":312,"context_line":"                        {\u0027mac\u0027: mac_address, \u0027network\u0027: network_id},"},{"line_number":313,"context_line":"                        instance\u003dinstance)"},{"line_number":314,"context_line":"            raise exception.PortInUse(port_id\u003dmac_address)"},{"line_number":315,"context_line":"        except neutron_client_exc.HostNotCompatibleWithFixedIpsClient:"},{"line_number":316,"context_line":"            network_id \u003d port_req_body[\u0027port\u0027].get(\u0027network_id\u0027)"},{"line_number":317,"context_line":"            LOG.warning(_LW(\u0027Neutron error: Tried to bind a port with \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_1c58a589","line":314,"range":{"start_line":314,"start_character":38,"end_line":314,"end_character":57},"updated":"2016-08-10 21:03:34.000000000","message":"Aside: port_id\u003dmac_address looks strange to me.","commit_id":"f123d83912e736e974fcdbed43fdb704627def6d"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"dfd9f8046bc94eca79bd48d6c31511876be56d87","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                            \u0027fixed_ips to a host in the wrong segment on \u0027"},{"line_number":319,"context_line":"                            \u0027network %(network)s.\u0027),"},{"line_number":320,"context_line":"                        {\u0027network\u0027: network_id}, instance\u003dinstance)"},{"line_number":321,"context_line":"            raise exception.VirtualInterfaceCreateException()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    @staticmethod"},{"line_number":324,"context_line":"    def _populate_mac_address(instance, port_req_body, available_macs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_d25cd1f2","line":321,"range":{"start_line":321,"start_character":28,"end_line":321,"end_character":59},"updated":"2016-08-02 14:09:28.000000000","message":"Maybe go for a new specific exception here, its not really a VIF create fail here.","commit_id":"f123d83912e736e974fcdbed43fdb704627def6d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1471ac252b1c24918bb2fb69b2ad15a525a8319f","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                            \u0027fixed_ips to a host in the wrong segment on \u0027"},{"line_number":319,"context_line":"                            \u0027network %(network)s.\u0027),"},{"line_number":320,"context_line":"                        {\u0027network\u0027: network_id}, instance\u003dinstance)"},{"line_number":321,"context_line":"            raise exception.VirtualInterfaceCreateException()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    @staticmethod"},{"line_number":324,"context_line":"    def _populate_mac_address(instance, port_req_body, available_macs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_bc64f9b8","line":321,"range":{"start_line":321,"start_character":28,"end_line":321,"end_character":59},"in_reply_to":"bacf61ea_34e70eae","updated":"2016-08-10 20:36:19.000000000","message":"https://github.com/openstack/nova/blob/1934116aad195fb5ce0c20b63ea32b1432c1a502/nova/compute/manager.py#L1941-L1950","commit_id":"f123d83912e736e974fcdbed43fdb704627def6d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ee067263fdedbe8c2419aab35836eaf70d08113c","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                            \u0027fixed_ips to a host in the wrong segment on \u0027"},{"line_number":319,"context_line":"                            \u0027network %(network)s.\u0027),"},{"line_number":320,"context_line":"                        {\u0027network\u0027: network_id}, instance\u003dinstance)"},{"line_number":321,"context_line":"            raise exception.VirtualInterfaceCreateException()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    @staticmethod"},{"line_number":324,"context_line":"    def _populate_mac_address(instance, port_req_body, available_macs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_34e70eae","line":321,"range":{"start_line":321,"start_character":28,"end_line":321,"end_character":59},"in_reply_to":"bacf61ea_b902e007","updated":"2016-08-02 17:31:07.000000000","message":"I\u0027ll admit that I did this on purpose hoping you guys would suggest exactly what I should do here. Thanks! I\u0027ll fix this up.","commit_id":"f123d83912e736e974fcdbed43fdb704627def6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"21a00a93b4659c864ad50c870454aeaf58e84d36","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                            \u0027fixed_ips to a host in the wrong segment on \u0027"},{"line_number":319,"context_line":"                            \u0027network %(network)s.\u0027),"},{"line_number":320,"context_line":"                        {\u0027network\u0027: network_id}, instance\u003dinstance)"},{"line_number":321,"context_line":"            raise exception.VirtualInterfaceCreateException()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    @staticmethod"},{"line_number":324,"context_line":"    def _populate_mac_address(instance, port_req_body, available_macs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_b902e007","line":321,"range":{"start_line":321,"start_character":28,"end_line":321,"end_character":59},"in_reply_to":"bacf61ea_d25cd1f2","updated":"2016-08-02 15:16:25.000000000","message":"Yeah, agree, that\u0027s what I did for UnableToAutoAllocateNetwork here:\n\nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1941-L1950\n\nMaybe like an InvalidPortBinding exception or something.","commit_id":"f123d83912e736e974fcdbed43fdb704627def6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"65772337d661ff7dfe62e85db06dd2ff7b1c64c3","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                        {\u0027mac\u0027: mac_address, \u0027network\u0027: network_id},"},{"line_number":371,"context_line":"                        instance\u003dinstance)"},{"line_number":372,"context_line":"            raise exception.PortInUse(port_id\u003dmac_address)"},{"line_number":373,"context_line":"        except neutron_client_exc.HostNotCompatibleWithFixedIpsClient:"},{"line_number":374,"context_line":"            network_id \u003d port_req_body[\u0027port\u0027].get(\u0027network_id\u0027)"},{"line_number":375,"context_line":"            LOG.warning(_LW(\u0027Neutron error: Tried to bind a port with \u0027"},{"line_number":376,"context_line":"                            \u0027fixed_ips to a host in the wrong segment on \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_fd1a676d","line":373,"updated":"2016-08-15 14:08:54.000000000","message":"This relies on python-neutronclient\u003e\u003d5.1.0 in global-requirements. I know there is a dependency from this change to the upper-constraints bump, but this will fail on anything \u003c5.1.0, so we need to make it dependent on the g-r bump.","commit_id":"9d6914a510c57f3c6c8eed6d7f1ae22d21f6e0ec"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7da7c93db9ae9a356a870c551d325ccc76c3668d","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                        {\u0027mac\u0027: mac_address, \u0027network\u0027: network_id},"},{"line_number":371,"context_line":"                        instance\u003dinstance)"},{"line_number":372,"context_line":"            raise exception.PortInUse(port_id\u003dmac_address)"},{"line_number":373,"context_line":"        except neutron_client_exc.HostNotCompatibleWithFixedIpsClient:"},{"line_number":374,"context_line":"            network_id \u003d port_req_body[\u0027port\u0027].get(\u0027network_id\u0027)"},{"line_number":375,"context_line":"            LOG.warning(_LW(\u0027Neutron error: Tried to bind a port with \u0027"},{"line_number":376,"context_line":"                            \u0027fixed_ips to a host in the wrong segment on \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_5203a573","line":373,"in_reply_to":"3ac371cc_fd1a676d","updated":"2016-08-15 14:50:18.000000000","message":"Yeah, the g-r bump wasn\u0027t available at the time and I wasn\u0027t sure how the g-r patch would be updated. I\u0027ll put a WIP on this until the g-r patch is up for review.","commit_id":"9d6914a510c57f3c6c8eed6d7f1ae22d21f6e0ec"}]}