)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"5d0c6476f2d509ca6bb7ead5e894351ac27a1978","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As suggested in John Garbutt in I7e1986c5f11356060cc9db12605b1322c39e79c0,"},{"line_number":10,"context_line":"move the quota config options into a config group of their own."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie06a370868f01fb9a1cc246a77d7823fac83e70e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad45d7e_8d02dc6d","line":11,"updated":"2016-08-10 00:05:34.000000000","message":"Add blueprint \"Implements: blueprint centralize-config-options-newton\" for linking.","commit_id":"7c0a61b6af2bc825cf1da4121ed2353103f8fac7"}],"nova/conf/quota.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b625cc6e55f73a153e9d69fe5cd890e9033b687","unresolved":false,"context_lines":[{"line_number":261,"context_line":"\"\"\"),"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"# TODO(pumaranikar): Add a new config to select between the db_driver and"},{"line_number":264,"context_line":"# the no_op driver using stevedoor."},{"line_number":265,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":266,"context_line":"               default\u003d\u0027nova.quota.DbQuotaDriver\u0027,"},{"line_number":267,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5da102_d5d30b5e","line":264,"range":{"start_line":264,"start_character":32,"end_line":264,"end_character":35},"updated":"2016-11-04 11:19:21.000000000","message":"this was correct first time around :)","commit_id":"d281663ad51f624ddd50ef595f59537706bb8ea1"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a77d4c8ae91286eac4028e7fdc40518546a508b5","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"quota_group \u003d cfg.OptGroup("},{"line_number":21,"context_line":"    \u0027quota\u0027,"},{"line_number":22,"context_line":"    title\u003d\u0027Quota Options\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"quota_opts \u003d ["},{"line_number":25,"context_line":"    cfg.IntOpt(\u0027instances\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_4fe82711","line":22,"updated":"2016-12-13 13:07:03.000000000","message":"should have a description here, I believe.","commit_id":"f016e1d1a21ff23cea7043c22289ee5bfdf1b021"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6ec9e80f83f7bb7a72e95b4924497d8df0871d54","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"quota_group \u003d cfg.OptGroup("},{"line_number":21,"context_line":"    \u0027quota\u0027,"},{"line_number":22,"context_line":"    title\u003d\u0027Quota Options\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"quota_opts \u003d ["},{"line_number":25,"context_line":"    cfg.IntOpt(\u0027instances\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_1759d95a","line":22,"in_reply_to":"1a6eadb0_4fe82711","updated":"2016-12-13 17:15:20.000000000","message":"Done","commit_id":"f016e1d1a21ff23cea7043c22289ee5bfdf1b021"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f23df188d1fbe105abc875a255db0be2dbbd6df4","unresolved":false,"context_lines":[{"line_number":270,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":271,"context_line":"               deprecated_since\u003d\u002714.0.0\u0027,"},{"line_number":272,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":273,"context_line":"               deprecated_name\u003d\u0027quota_driver\u0027,"},{"line_number":274,"context_line":"               help\u003d\"\"\""},{"line_number":275,"context_line":"Provides abstraction for quota checks. Users can configure a specific"},{"line_number":276,"context_line":"driver to use for quota checks."}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_80870dd6","line":273,"updated":"2017-01-04 15:44:26.000000000","message":"Nit: we generally haven\u0027t been moving deprecated configs. But I don\u0027t want to block on that.","commit_id":"cd8222dc5416ee520d49dd15fcfa11a220fc2696"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e320639c58a1a9886f2582980c211de2c475ed5e","unresolved":false,"context_lines":[{"line_number":64,"context_line":" * 51200 (default) or any positive integer."},{"line_number":65,"context_line":" * -1 : treated as unlimited."},{"line_number":66,"context_line":"\"\"\"),"},{"line_number":67,"context_line":"    cfg.IntOpt(\u0027floating_ips\u0027,"},{"line_number":68,"context_line":"               min\u003d-1,"},{"line_number":69,"context_line":"               default\u003d10,"},{"line_number":70,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":71,"context_line":"               deprecated_name\u003d\u0027quota_floating_ips\u0027,"},{"line_number":72,"context_line":"               help\u003d\"\"\""},{"line_number":73,"context_line":"The number of floating IPs allowed per project. Floating IPs are not allocated"},{"line_number":74,"context_line":"to instances by default. Users need to select them from the pool configured by"},{"line_number":75,"context_line":"the OpenStack administrator to attach to their instances."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":" * 10 (default) or any positive integer."},{"line_number":80,"context_line":" * -1 : treated as unlimited."},{"line_number":81,"context_line":"\"\"\"),"},{"line_number":82,"context_line":"    cfg.IntOpt(\u0027fixed_ips\u0027,"},{"line_number":83,"context_line":"               min\u003d-1,"},{"line_number":84,"context_line":"               default\u003d-1,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_1ef998c7","line":81,"range":{"start_line":67,"start_character":0,"end_line":81,"end_character":5},"updated":"2017-01-05 12:12:36.000000000","message":"This is a nova-network only option and should be deprecated - not moved. See comments here https://review.openstack.org/#/c/415707/3/nova/tests/unit/test_quota.py","commit_id":"de0eff47f2cfa271735bb754637f979659a2d91a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5eae979aa296d04fd1da4e7c562858263cf06c25","unresolved":false,"context_lines":[{"line_number":64,"context_line":" * 51200 (default) or any positive integer."},{"line_number":65,"context_line":" * -1 : treated as unlimited."},{"line_number":66,"context_line":"\"\"\"),"},{"line_number":67,"context_line":"    cfg.IntOpt(\u0027floating_ips\u0027,"},{"line_number":68,"context_line":"               min\u003d-1,"},{"line_number":69,"context_line":"               default\u003d10,"},{"line_number":70,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":71,"context_line":"               deprecated_name\u003d\u0027quota_floating_ips\u0027,"},{"line_number":72,"context_line":"               help\u003d\"\"\""},{"line_number":73,"context_line":"The number of floating IPs allowed per project. Floating IPs are not allocated"},{"line_number":74,"context_line":"to instances by default. Users need to select them from the pool configured by"},{"line_number":75,"context_line":"the OpenStack administrator to attach to their instances."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Possible values:"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":" * 10 (default) or any positive integer."},{"line_number":80,"context_line":" * -1 : treated as unlimited."},{"line_number":81,"context_line":"\"\"\"),"},{"line_number":82,"context_line":"    cfg.IntOpt(\u0027fixed_ips\u0027,"},{"line_number":83,"context_line":"               min\u003d-1,"},{"line_number":84,"context_line":"               default\u003d-1,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_64e02797","line":81,"range":{"start_line":67,"start_character":0,"end_line":81,"end_character":5},"in_reply_to":"ba5201f7_1ef998c7","updated":"2017-01-06 14:41:22.000000000","message":"Well there are a few, but we will need to keep them for a good while. Lets leave this as it is.","commit_id":"de0eff47f2cfa271735bb754637f979659a2d91a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e320639c58a1a9886f2582980c211de2c475ed5e","unresolved":false,"context_lines":[{"line_number":263,"context_line":" * 0 (default) or any positive integer representing number of seconds."},{"line_number":264,"context_line":"\"\"\"),"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"# TODO(pumaranikar): Add a new config to select between the db_driver and"},{"line_number":267,"context_line":"# the no_op driver using stevedore."},{"line_number":268,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":269,"context_line":"               default\u003d\u0027nova.quota.DbQuotaDriver\u0027,"},{"line_number":270,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":271,"context_line":"               deprecated_since\u003d\u002714.0.0\u0027,"},{"line_number":272,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":273,"context_line":"               deprecated_name\u003d\u0027quota_driver\u0027,"},{"line_number":274,"context_line":"               help\u003d\"\"\""},{"line_number":275,"context_line":"Provides abstraction for quota checks. Users can configure a specific"},{"line_number":276,"context_line":"driver to use for quota checks."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"Possible values:"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":" * nova.quota.DbQuotaDriver (default) or any string representing fully"},{"line_number":281,"context_line":"   qualified class name."},{"line_number":282,"context_line":"\"\"\"),"},{"line_number":283,"context_line":"    ]"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_3e19fc22","line":282,"range":{"start_line":266,"start_character":0,"end_line":282,"end_character":5},"updated":"2017-01-05 12:12:36.000000000","message":"John was correct - we shouldn\u0027t move this. Seeing as we need to get two +2\u0027s again, could you unmove this before I re +2","commit_id":"de0eff47f2cfa271735bb754637f979659a2d91a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5eae979aa296d04fd1da4e7c562858263cf06c25","unresolved":false,"context_lines":[{"line_number":263,"context_line":" * 0 (default) or any positive integer representing number of seconds."},{"line_number":264,"context_line":"\"\"\"),"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"# TODO(pumaranikar): Add a new config to select between the db_driver and"},{"line_number":267,"context_line":"# the no_op driver using stevedore."},{"line_number":268,"context_line":"    cfg.StrOpt(\u0027driver\u0027,"},{"line_number":269,"context_line":"               default\u003d\u0027nova.quota.DbQuotaDriver\u0027,"},{"line_number":270,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":271,"context_line":"               deprecated_since\u003d\u002714.0.0\u0027,"},{"line_number":272,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":273,"context_line":"               deprecated_name\u003d\u0027quota_driver\u0027,"},{"line_number":274,"context_line":"               help\u003d\"\"\""},{"line_number":275,"context_line":"Provides abstraction for quota checks. Users can configure a specific"},{"line_number":276,"context_line":"driver to use for quota checks."},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"Possible values:"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":" * nova.quota.DbQuotaDriver (default) or any string representing fully"},{"line_number":281,"context_line":"   qualified class name."},{"line_number":282,"context_line":"\"\"\"),"},{"line_number":283,"context_line":"    ]"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_e4ea5773","line":282,"range":{"start_line":266,"start_character":0,"end_line":282,"end_character":5},"in_reply_to":"ba5201f7_3e19fc22","updated":"2017-01-06 14:41:22.000000000","message":"We are now thinking of keeping it for other reasons.","commit_id":"de0eff47f2cfa271735bb754637f979659a2d91a"}],"nova/quota.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a77d4c8ae91286eac4028e7fdc40518546a508b5","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"    def default(self):"},{"line_number":1062,"context_line":"        \"\"\"Return the default value of the quota.\"\"\""},{"line_number":1063,"context_line":""},{"line_number":1064,"context_line":"        # NOTE(mikal): special case for quota_networks, which is an API"},{"line_number":1065,"context_line":"        # flag and not a quota flag"},{"line_number":1066,"context_line":"        if self.flag \u003d\u003d \u0027quota_networks\u0027:"},{"line_number":1067,"context_line":"            return CONF[self.flag]"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"        return CONF.quota[self.flag] if self.flag else -1"},{"line_number":1070,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_6f6a4382","line":1067,"range":{"start_line":1064,"start_character":0,"end_line":1067,"end_character":34},"updated":"2016-12-13 13:07:03.000000000","message":"Should it be a quota flag? I guess we can do that later, and its deprecated for removal anyways, I think.","commit_id":"f016e1d1a21ff23cea7043c22289ee5bfdf1b021"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6ec9e80f83f7bb7a72e95b4924497d8df0871d54","unresolved":false,"context_lines":[{"line_number":1061,"context_line":"    def default(self):"},{"line_number":1062,"context_line":"        \"\"\"Return the default value of the quota.\"\"\""},{"line_number":1063,"context_line":""},{"line_number":1064,"context_line":"        # NOTE(mikal): special case for quota_networks, which is an API"},{"line_number":1065,"context_line":"        # flag and not a quota flag"},{"line_number":1066,"context_line":"        if self.flag \u003d\u003d \u0027quota_networks\u0027:"},{"line_number":1067,"context_line":"            return CONF[self.flag]"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"        return CONF.quota[self.flag] if self.flag else -1"},{"line_number":1070,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_37041516","line":1067,"range":{"start_line":1064,"start_character":0,"end_line":1067,"end_character":34},"in_reply_to":"1a6eadb0_6f6a4382","updated":"2016-12-13 17:15:20.000000000","message":"Ok, leaving it as it is in this patch.","commit_id":"f016e1d1a21ff23cea7043c22289ee5bfdf1b021"}],"releasenotes/notes/quota-config-group-8028127074d43c48.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1b625cc6e55f73a153e9d69fe5cd890e9033b687","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Most quota options have been moved into their own"},{"line_number":4,"context_line":"    configuration group. The exception is quota_networks"},{"line_number":5,"context_line":"    as it is an API flag not a quota flag."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba5da102_556e1b97","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":42},"updated":"2016-11-04 11:19:21.000000000","message":"You\u0027re going to need to list the config options that have changed here. See releasenotes/notes/add-pci-config-to-pci-group-5648cc0f307f24f8.yaml for an example.\n\nAlso, as a nit, any chance you could rename this as \u0027add-quota-config-to-quota-group-xxx\u0027 purely for consistency\u0027s sake?","commit_id":"d281663ad51f624ddd50ef595f59537706bb8ea1"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6e201b491387936db72c59ec2723d6686c1e9673","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Most quota options have been moved into their own"},{"line_number":4,"context_line":"    configuration group. The exception is quota_networks"},{"line_number":5,"context_line":"    as it is an API flag not a quota flag."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a6eadb0_25fed06b","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":42},"in_reply_to":"ba5da102_556e1b97","updated":"2016-12-12 21:12:45.000000000","message":"Agree with Stephen, all deprecated items should be listed here.","commit_id":"d281663ad51f624ddd50ef595f59537706bb8ea1"}]}