)]}'
{"nova/conf/xenserver.py":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"2303b386d1d8407b61acb39a61f492c5348f8357","unresolved":false,"context_lines":[{"line_number":378,"context_line":"instances do not go to running state within this sepcified wait"},{"line_number":379,"context_line":"time, the launch expires."},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"Possible Values:"},{"line_number":382,"context_line":"    * A valid positive integer representing time in seconds"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"Related Options:"},{"line_number":385,"context_line":"    * None"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_c13741ae","line":382,"range":{"start_line":381,"start_character":0,"end_line":382,"end_character":59},"updated":"2016-07-26 16:20:15.000000000","message":"Add min\u003d0 and drop this section","commit_id":"1202f8b8201afea8c25653f545372183425c1dd7"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"2303b386d1d8407b61acb39a61f492c5348f8357","unresolved":false,"context_lines":[{"line_number":381,"context_line":"Possible Values:"},{"line_number":382,"context_line":"    * A valid positive integer representing time in seconds"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"Related Options:"},{"line_number":385,"context_line":"    * None"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"\"\"\")),"},{"line_number":388,"context_line":"    cfg.StrOpt(\u0027vif_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_e1cb65a2","line":385,"range":{"start_line":384,"start_character":0,"end_line":385,"end_character":10},"updated":"2016-07-26 16:20:15.000000000","message":"Drop this section","commit_id":"1202f8b8201afea8c25653f545372183425c1dd7"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"2303b386d1d8407b61acb39a61f492c5348f8357","unresolved":false,"context_lines":[{"line_number":407,"context_line":"Possible values:"},{"line_number":408,"context_line":"    * A valid VIF driver to use for XenServer"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"Related Options:"},{"line_number":411,"context_line":"    * None."},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"\"\"\")),"},{"line_number":414,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_013e798a","line":411,"range":{"start_line":410,"start_character":0,"end_line":411,"end_character":11},"updated":"2016-07-26 16:20:15.000000000","message":"Drop","commit_id":"1202f8b8201afea8c25653f545372183425c1dd7"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"2303b386d1d8407b61acb39a61f492c5348f8357","unresolved":false,"context_lines":[{"line_number":427,"context_line":"Possible Values:"},{"line_number":428,"context_line":"    * A valid driver to handle image uploading"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Related Options:"},{"line_number":431,"context_line":"    * None"},{"line_number":432,"context_line":"\"\"\")),"},{"line_number":433,"context_line":"]"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_2149fd31","line":431,"range":{"start_line":430,"start_character":0,"end_line":431,"end_character":10},"updated":"2016-07-26 16:20:15.000000000","message":"Ditto","commit_id":"1202f8b8201afea8c25653f545372183425c1dd7"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"6a76d78f88bed5ca83e3a77d2cb80f328054bae3","unresolved":false,"context_lines":[{"line_number":377,"context_line":"time is involved until the instance(s) can become available and"},{"line_number":378,"context_line":"\u0027running\u0027. This wait time is defined by running_timeout. If the"},{"line_number":379,"context_line":"instances do not go to running state within this sepcified wait"},{"line_number":380,"context_line":"time, the launch expires."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"\"\"\")),"},{"line_number":383,"context_line":"    cfg.StrOpt(\u0027vif_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_e65ff20c","line":380,"updated":"2016-07-26 19:02:04.000000000","message":"What happens when this timer expire? instance is set to error state? I think its worth mentioning that behavior here.","commit_id":"1882afc54bd3d4512f871248b316658cf69908e2"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"1a0f7a78eb586e6a3668ed7291c463e48057f1e0","unresolved":false,"context_lines":[{"line_number":377,"context_line":"time is involved until the instance(s) can become available and"},{"line_number":378,"context_line":"\u0027running\u0027. This wait time is defined by running_timeout. If the"},{"line_number":379,"context_line":"instances do not go to running state within this sepcified wait"},{"line_number":380,"context_line":"time, the launch expires."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"\"\"\")),"},{"line_number":383,"context_line":"    cfg.StrOpt(\u0027vif_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_a9de6b6a","line":380,"in_reply_to":"dada55a8_e65ff20c","updated":"2016-07-26 19:22:17.000000000","message":"Done","commit_id":"1882afc54bd3d4512f871248b316658cf69908e2"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"ae4a09970d42cf6d4dfecf54da2015919d008689","unresolved":false,"context_lines":[{"line_number":366,"context_line":"               help\u003d(\"\"\""},{"line_number":367,"context_line":"Wait time for instances to go to running state."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"Provide an integer value representing time in seconds to set the"},{"line_number":370,"context_line":"wait time for an instance to go to running state."},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"When a request to create an instance is received by nova-api and"},{"line_number":373,"context_line":"communicated to nova-compute, the creation of the instance occurs"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a506f282","line":370,"range":{"start_line":369,"start_character":25,"end_line":370,"end_character":9},"updated":"2016-08-03 16:55:50.000000000","message":"nit: this seems a bit wordy, \"time\" is used twice. I\u0027d change it to:\n\n\"Provide an integer value to set the wait time in seconds for an instance to go to running state\"","commit_id":"8c05a19d8ccb723b1d8e009168fd3845c4e008e3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eebacd07e531d69751fa497f256bf6d1934fc046","unresolved":false,"context_lines":[{"line_number":513,"context_line":"    cfg.IntOpt(\u0027running_timeout\u0027,"},{"line_number":514,"context_line":"               default\u003d60,"},{"line_number":515,"context_line":"               min\u003d0,"},{"line_number":516,"context_line":"               help\u003d(\"\"\""},{"line_number":517,"context_line":"Wait time for instances to go to running state."},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"Provide an integer value representing time in seconds to set the"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_beec362a","line":516,"range":{"start_line":516,"start_character":20,"end_line":516,"end_character":21},"updated":"2016-08-09 17:14:27.000000000","message":"Nit: why do we have this here?","commit_id":"c06c6c1170e0a270e8513a6c4efcdc47ddb804e0"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"2248db70ef67c98c25c1790f68054b17f807578b","unresolved":false,"context_lines":[{"line_number":513,"context_line":"    cfg.IntOpt(\u0027running_timeout\u0027,"},{"line_number":514,"context_line":"               default\u003d60,"},{"line_number":515,"context_line":"               min\u003d0,"},{"line_number":516,"context_line":"               help\u003d(\"\"\""},{"line_number":517,"context_line":"Wait time for instances to go to running state."},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"Provide an integer value representing time in seconds to set the"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_99634cdc","line":516,"range":{"start_line":516,"start_character":20,"end_line":516,"end_character":21},"in_reply_to":"9ad45d7e_beec362a","updated":"2016-08-09 17:30:25.000000000","message":"Thanks John.\nI was intending to add the internationalization using i18n (as in Glance) and realized that we do not do it in Nova.  That\u0027s the reason the parenthesis were included by me. \nWill remove it and submit another patch set.","commit_id":"c06c6c1170e0a270e8513a6c4efcdc47ddb804e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eebacd07e531d69751fa497f256bf6d1934fc046","unresolved":false,"context_lines":[{"line_number":529,"context_line":"instances do not go to running state within this sepcified wait"},{"line_number":530,"context_line":"time, the launch expires and the instance(s) are set to \u0027error\u0027"},{"line_number":531,"context_line":"state."},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"\"\"\")),"},{"line_number":534,"context_line":"    cfg.StrOpt(\u0027vif_driver\u0027,"},{"line_number":535,"context_line":"               default\u003d\u0027nova.virt.xenapi.vif.XenAPIBridgeDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_fecd0eb8","line":532,"updated":"2016-08-09 17:14:27.000000000","message":"Nit: don\u0027t need the trailing space.","commit_id":"c06c6c1170e0a270e8513a6c4efcdc47ddb804e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eebacd07e531d69751fa497f256bf6d1934fc046","unresolved":false,"context_lines":[{"line_number":533,"context_line":"\"\"\")),"},{"line_number":534,"context_line":"    cfg.StrOpt(\u0027vif_driver\u0027,"},{"line_number":535,"context_line":"               default\u003d\u0027nova.virt.xenapi.vif.XenAPIBridgeDriver\u0027,"},{"line_number":536,"context_line":"               help\u003d(\"\"\""},{"line_number":537,"context_line":"The XenAPI VIF driver using XenServer Network APIs."},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"Provide a string value representing the VIF XenAPI bridge driver to"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_5ec53a8c","line":536,"range":{"start_line":536,"start_character":20,"end_line":536,"end_character":21},"updated":"2016-08-09 17:14:27.000000000","message":"As above.","commit_id":"c06c6c1170e0a270e8513a6c4efcdc47ddb804e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eebacd07e531d69751fa497f256bf6d1934fc046","unresolved":false,"context_lines":[{"line_number":551,"context_line":"XenServer."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"Possible values:"},{"line_number":554,"context_line":"    * A valid VIF driver to use for XenServer"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"\"\"\")),"},{"line_number":557,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_1e42a210","line":554,"range":{"start_line":554,"start_character":0,"end_line":554,"end_character":4},"updated":"2016-08-09 17:14:27.000000000","message":"We don\u0027t want the space here","commit_id":"c06c6c1170e0a270e8513a6c4efcdc47ddb804e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eebacd07e531d69751fa497f256bf6d1934fc046","unresolved":false,"context_lines":[{"line_number":551,"context_line":"XenServer."},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"Possible values:"},{"line_number":554,"context_line":"    * A valid VIF driver to use for XenServer"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"\"\"\")),"},{"line_number":557,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_5efa5abe","line":554,"range":{"start_line":554,"start_character":6,"end_line":554,"end_character":45},"updated":"2016-08-09 17:14:27.000000000","message":"What are the valid VIF drivers, please list them out here.\n\nXenAPIOpenVswitchDriver is the only other one here.","commit_id":"c06c6c1170e0a270e8513a6c4efcdc47ddb804e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eebacd07e531d69751fa497f256bf6d1934fc046","unresolved":false,"context_lines":[{"line_number":554,"context_line":"    * A valid VIF driver to use for XenServer"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"\"\"\")),"},{"line_number":557,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"},{"line_number":558,"context_line":"                default\u003d\u0027nova.virt.xenapi.image.glance.GlanceStore\u0027,"},{"line_number":559,"context_line":"               help\u003d(\"\"\""},{"line_number":560,"context_line":"Dom0 plugin driver used to handle image uploads."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_9e5692d0","line":557,"updated":"2016-08-09 17:14:27.000000000","message":"We should add a TODO to make this into a stevedore plugin.","commit_id":"c06c6c1170e0a270e8513a6c4efcdc47ddb804e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eebacd07e531d69751fa497f256bf6d1934fc046","unresolved":false,"context_lines":[{"line_number":556,"context_line":"\"\"\")),"},{"line_number":557,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"},{"line_number":558,"context_line":"                default\u003d\u0027nova.virt.xenapi.image.glance.GlanceStore\u0027,"},{"line_number":559,"context_line":"               help\u003d(\"\"\""},{"line_number":560,"context_line":"Dom0 plugin driver used to handle image uploads."},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"Provide a string value representing a plugin driver required to"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_de376aae","line":559,"range":{"start_line":559,"start_character":20,"end_line":559,"end_character":21},"updated":"2016-08-09 17:14:27.000000000","message":"as above, lets drop this, and the extra space at the end.","commit_id":"c06c6c1170e0a270e8513a6c4efcdc47ddb804e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"eebacd07e531d69751fa497f256bf6d1934fc046","unresolved":false,"context_lines":[{"line_number":568,"context_line":"GlanceStore."},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"Possible Values:"},{"line_number":571,"context_line":"    * A valid driver to handle image uploading"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"\"\"\")),"},{"line_number":574,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_5e4c1a42","line":571,"updated":"2016-08-09 17:14:27.000000000","message":"What are the possible other values here?\n\nBittorrentStore and VdiThroughDevStore are the other ones I think.","commit_id":"c06c6c1170e0a270e8513a6c4efcdc47ddb804e0"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3b8971ae4892b6061a7355cf0313209568c6bc67","unresolved":false,"context_lines":[{"line_number":454,"context_line":"xenapi_vmops_opts \u003d ["},{"line_number":455,"context_line":"    cfg.IntOpt(\u0027running_timeout\u0027,"},{"line_number":456,"context_line":"               default\u003d60,"},{"line_number":457,"context_line":"               min\u003d0,"},{"line_number":458,"context_line":"               help\u003d(\"\"\""},{"line_number":459,"context_line":"Wait time for instances to go to running state."},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_0e9b4073","line":457,"range":{"start_line":457,"start_character":19,"end_line":457,"end_character":20},"updated":"2016-09-12 12:39:13.000000000","message":"I think that previous message \"positive integer\" (which was a natural cause to put 0 here) mislead us a bit.\n\nWon\u0027t it break the stack if the timeout is set to 0? This would cause instances to instantly go to error state, no matter what.\n\nAlso the question is if we want to be fool-proof that much.","commit_id":"052791e17fa767f4c9793a7911a3166b3c2767e9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"f330c351b4887ea479401e860b865f042f5a9c1a","unresolved":false,"context_lines":[{"line_number":454,"context_line":"xenapi_vmops_opts \u003d ["},{"line_number":455,"context_line":"    cfg.IntOpt(\u0027running_timeout\u0027,"},{"line_number":456,"context_line":"               default\u003d60,"},{"line_number":457,"context_line":"               min\u003d0,"},{"line_number":458,"context_line":"               help\u003d(\"\"\""},{"line_number":459,"context_line":"Wait time for instances to go to running state."},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_c6bbd4e3","line":457,"range":{"start_line":457,"start_character":19,"end_line":457,"end_character":20},"in_reply_to":"9a89bdaa_0e9b4073","updated":"2016-09-26 12:54:00.000000000","message":"https://github.com/openstack/nova/blob/master/nova/virt/xenapi/vmops.py#L814\n\nIt is safe to assume that min\u003d0 is ok here.","commit_id":"052791e17fa767f4c9793a7911a3166b3c2767e9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3b8971ae4892b6061a7355cf0313209568c6bc67","unresolved":false,"context_lines":[{"line_number":493,"context_line":"XenServer."},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"Possible values:"},{"line_number":496,"context_line":"    * A valid VIF driver to use for XenServer"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"\"\"\")),"},{"line_number":499,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_eeb9bc2f","line":496,"range":{"start_line":496,"start_character":0,"end_line":496,"end_character":4},"updated":"2016-09-12 12:39:13.000000000","message":"Nit - indentation is excessive. `* ` is enough and is used in most patches.","commit_id":"052791e17fa767f4c9793a7911a3166b3c2767e9"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"3b8971ae4892b6061a7355cf0313209568c6bc67","unresolved":false,"context_lines":[{"line_number":510,"context_line":"GlanceStore."},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"Possible Values:"},{"line_number":513,"context_line":"    * A valid driver to handle image uploading"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"\"\"\")),"},{"line_number":516,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a89bdaa_6eb04cde","line":513,"range":{"start_line":513,"start_character":0,"end_line":513,"end_character":4},"updated":"2016-09-12 12:39:13.000000000","message":"ditto","commit_id":"052791e17fa767f4c9793a7911a3166b3c2767e9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4a2a5fb13ad542a85190852c62fc25088cfdb7ca","unresolved":false,"context_lines":[{"line_number":453,"context_line":""},{"line_number":454,"context_line":"xenapi_vmops_opts \u003d ["},{"line_number":455,"context_line":"    cfg.IntOpt(\u0027running_timeout\u0027,"},{"line_number":456,"context_line":"               default\u003d60,"},{"line_number":457,"context_line":"               min\u003d0,"},{"line_number":458,"context_line":"               help\u003d(\"\"\""},{"line_number":459,"context_line":"Wait time for instances to go to running state."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Provide an integer value representing time in seconds to set the"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_89c9d35b","line":458,"range":{"start_line":456,"start_character":0,"end_line":458,"end_character":24},"updated":"2016-10-14 09:09:39.000000000","message":"nit: Could you take the opportunity to fix the formatting for at least this section? (the rest can be fixed later:\n\n    xenapi_vmops_opts \u003d [\n        cfg.IntOpt(\u0027running_timeout\u0027,\n            default\u003d60,\n            min\u003d0,\n            ...\n\ni.e. four-space hanging indents. This is what most of the files are moving towards now","commit_id":"857d505c457c39e39ceef07fedba7ec7fe6c6e84"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4a2a5fb13ad542a85190852c62fc25088cfdb7ca","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    cfg.IntOpt(\u0027running_timeout\u0027,"},{"line_number":456,"context_line":"               default\u003d60,"},{"line_number":457,"context_line":"               min\u003d0,"},{"line_number":458,"context_line":"               help\u003d(\"\"\""},{"line_number":459,"context_line":"Wait time for instances to go to running state."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Provide an integer value representing time in seconds to set the"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a98d1f4_4d6dbe31","line":458,"range":{"start_line":458,"start_character":20,"end_line":458,"end_character":21},"updated":"2016-10-14 09:09:39.000000000","message":"nit: you don\u0027t need these brackets","commit_id":"857d505c457c39e39ceef07fedba7ec7fe6c6e84"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"7e9967e50558e0dfad5ee7a31065a4108db18017","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    cfg.IntOpt(\u0027running_timeout\u0027,"},{"line_number":456,"context_line":"               default\u003d60,"},{"line_number":457,"context_line":"               min\u003d0,"},{"line_number":458,"context_line":"               help\u003d(\"\"\""},{"line_number":459,"context_line":"Wait time for instances to go to running state."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Provide an integer value representing time in seconds to set the"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6895a0_7fe4e73a","line":458,"range":{"start_line":458,"start_character":20,"end_line":458,"end_character":21},"in_reply_to":"3a98d1f4_4d6dbe31","updated":"2016-10-20 19:31:46.000000000","message":"Done","commit_id":"857d505c457c39e39ceef07fedba7ec7fe6c6e84"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"7e9967e50558e0dfad5ee7a31065a4108db18017","unresolved":false,"context_lines":[{"line_number":453,"context_line":""},{"line_number":454,"context_line":"xenapi_vmops_opts \u003d ["},{"line_number":455,"context_line":"    cfg.IntOpt(\u0027running_timeout\u0027,"},{"line_number":456,"context_line":"               default\u003d60,"},{"line_number":457,"context_line":"               min\u003d0,"},{"line_number":458,"context_line":"               help\u003d(\"\"\""},{"line_number":459,"context_line":"Wait time for instances to go to running state."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"Provide an integer value representing time in seconds to set the"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6895a0_9fcffbb2","line":458,"range":{"start_line":456,"start_character":0,"end_line":458,"end_character":24},"in_reply_to":"fa6399be_89c9d35b","updated":"2016-10-20 19:31:46.000000000","message":"Done.\nApologies for the delay on this patch.","commit_id":"857d505c457c39e39ceef07fedba7ec7fe6c6e84"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"697f2d6695b79f2851b1343276dff9134f886b2c","unresolved":false,"context_lines":[{"line_number":493,"context_line":""},{"line_number":494,"context_line":"Possible values:"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"* A valid VIF driver to use for XenServer"},{"line_number":497,"context_line":"\"\"\")),"},{"line_number":498,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"},{"line_number":499,"context_line":"               default\u003d\u0027nova.virt.xenapi.image.glance.GlanceStore\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_d5129d08","line":496,"updated":"2016-10-13 16:56:42.000000000","message":"What are the know good values here? could we a choices list for those?","commit_id":"857d505c457c39e39ceef07fedba7ec7fe6c6e84"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"7e9967e50558e0dfad5ee7a31065a4108db18017","unresolved":false,"context_lines":[{"line_number":493,"context_line":""},{"line_number":494,"context_line":"Possible values:"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"* A valid VIF driver to use for XenServer"},{"line_number":497,"context_line":"\"\"\")),"},{"line_number":498,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"},{"line_number":499,"context_line":"               default\u003d\u0027nova.virt.xenapi.image.glance.GlanceStore\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6895a0_5f3483dd","line":496,"in_reply_to":"fa6399be_d5129d08","updated":"2016-10-20 19:31:46.000000000","message":"Thanks John.\nNot sure if we can have choices here. This directly refers to the ``XenAPIBridgeDriver`` in nova/virt/xenapi/vif.py written for use to create networks via the XenAPI. Also not sure why this is configurable.\nPlease correct me if I am wrong. \nI will go ahead and remove the possible values section.","commit_id":"857d505c457c39e39ceef07fedba7ec7fe6c6e84"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"697f2d6695b79f2851b1343276dff9134f886b2c","unresolved":false,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"Possible Values:"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"* A valid driver to handle image uploading"},{"line_number":514,"context_line":"\"\"\")),"},{"line_number":515,"context_line":"]"},{"line_number":516,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa6399be_55ff6da9","line":513,"updated":"2016-10-13 16:56:42.000000000","message":"As above, what are the known good values here?","commit_id":"857d505c457c39e39ceef07fedba7ec7fe6c6e84"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"7e9967e50558e0dfad5ee7a31065a4108db18017","unresolved":false,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"Possible Values:"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"* A valid driver to handle image uploading"},{"line_number":514,"context_line":"\"\"\")),"},{"line_number":515,"context_line":"]"},{"line_number":516,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da6895a0_df56d305","line":513,"in_reply_to":"fa6399be_55ff6da9","updated":"2016-10-20 19:31:46.000000000","message":"Similar situation as above.","commit_id":"857d505c457c39e39ceef07fedba7ec7fe6c6e84"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d2c4d65a9b00317aad9c6746af3209dba501af0d","unresolved":false,"context_lines":[{"line_number":454,"context_line":"xenapi_vmops_opts \u003d ["},{"line_number":455,"context_line":"    cfg.IntOpt(\u0027running_timeout\u0027,"},{"line_number":456,"context_line":"        default\u003d60,"},{"line_number":457,"context_line":"        min\u003d0,"},{"line_number":458,"context_line":"        help\u003d\"\"\""},{"line_number":459,"context_line":"Wait time for instances to go to running state."},{"line_number":460,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_8ca5b4b6","line":457,"updated":"2016-11-16 16:17:21.000000000","message":"hehe, the min is important here, otherwise the math at https://github.com/openstack/nova/blob/952af645834033ba916cd9024839f9e9266c1baa/nova/virt/xenapi/vmops.py#L814-L814 allows negative values, which could have the result to never time out :)","commit_id":"a290526db8223a11a2ce7d1b8e66b48c59bbb53e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d2c4d65a9b00317aad9c6746af3209dba501af0d","unresolved":false,"context_lines":[{"line_number":468,"context_line":"nova-schedule and the launch is triggered, a certain amount of wait"},{"line_number":469,"context_line":"time is involved until the instance(s) can become available and"},{"line_number":470,"context_line":"\u0027running\u0027. This wait time is defined by running_timeout. If the"},{"line_number":471,"context_line":"instances do not go to running state within this sepcified wait"},{"line_number":472,"context_line":"time, the launch expires and the instance(s) are set to \u0027error\u0027"},{"line_number":473,"context_line":"state."},{"line_number":474,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_2caf4082","line":471,"range":{"start_line":471,"start_character":49,"end_line":471,"end_character":58},"updated":"2016-11-16 16:17:21.000000000","message":"typo: s/sepcified/specified","commit_id":"a290526db8223a11a2ce7d1b8e66b48c59bbb53e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a60a812cce8af5e5f7e2bb2e4ac13dcce40f6905","unresolved":false,"context_lines":[{"line_number":472,"context_line":"time, the launch expires and the instance(s) are set to \u0027error\u0027"},{"line_number":473,"context_line":"state."},{"line_number":474,"context_line":"\"\"\"),"},{"line_number":475,"context_line":"    cfg.StrOpt(\u0027vif_driver\u0027,"},{"line_number":476,"context_line":"        default\u003d\u0027nova.virt.xenapi.vif.XenAPIBridgeDriver\u0027,"},{"line_number":477,"context_line":"        help\u003d\"\"\""},{"line_number":478,"context_line":"The XenAPI VIF driver using XenServer Network APIs."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"Provide a string value representing the VIF XenAPI bridge driver to"},{"line_number":481,"context_line":"use for bridging."},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"Xen configuration uses bridging within the backend domain to allow"},{"line_number":484,"context_line":"all VMs to appear on the network as individual hosts. Bridge"},{"line_number":485,"context_line":"interfaces are used to create a XenServer VLAN network in which"},{"line_number":486,"context_line":"the VIFs for the VM instances are plugged. If no VIF bridge driver"},{"line_number":487,"context_line":"is plugged, the bridge is not made available. This configuration"},{"line_number":488,"context_line":"option takes in a value for the VIF driver."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"NOTE:"},{"line_number":491,"context_line":"The XenAPIBridgeDriver should be used for running OVS or Bridge in"},{"line_number":492,"context_line":"XenServer."},{"line_number":493,"context_line":"\"\"\"),"},{"line_number":494,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"},{"line_number":495,"context_line":"        default\u003d\u0027nova.virt.xenapi.image.glance.GlanceStore\u0027,"},{"line_number":496,"context_line":"        help\u003d\"\"\""},{"line_number":497,"context_line":"Dom0 plugin driver used to handle image uploads."},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"Provide a string value representing a plugin driver required to"},{"line_number":500,"context_line":"handle the image uploading to GlanceStore."},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"Images, and snapshots from XenServer need to be uploaded to the data"},{"line_number":503,"context_line":"store for use. image_upload_handler takes in a value for the Dom0"},{"line_number":504,"context_line":"plugin driver. This driver is then called to uplaod images to the"},{"line_number":505,"context_line":"GlanceStore."},{"line_number":506,"context_line":"\"\"\"),"},{"line_number":507,"context_line":"]"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"xenapi_volume_utils_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"da6895a0_d30319b7","line":506,"range":{"start_line":475,"start_character":0,"end_line":506,"end_character":5},"updated":"2016-10-21 10:11:37.000000000","message":"If these are not really configurable then, should we just deprecate instead?","commit_id":"a290526db8223a11a2ce7d1b8e66b48c59bbb53e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"202d1de480482c80c54859fb6b1433c4abf43018","unresolved":false,"context_lines":[{"line_number":472,"context_line":"time, the launch expires and the instance(s) are set to \u0027error\u0027"},{"line_number":473,"context_line":"state."},{"line_number":474,"context_line":"\"\"\"),"},{"line_number":475,"context_line":"    cfg.StrOpt(\u0027vif_driver\u0027,"},{"line_number":476,"context_line":"        default\u003d\u0027nova.virt.xenapi.vif.XenAPIBridgeDriver\u0027,"},{"line_number":477,"context_line":"        help\u003d\"\"\""},{"line_number":478,"context_line":"The XenAPI VIF driver using XenServer Network APIs."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"Provide a string value representing the VIF XenAPI bridge driver to"},{"line_number":481,"context_line":"use for bridging."},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"Xen configuration uses bridging within the backend domain to allow"},{"line_number":484,"context_line":"all VMs to appear on the network as individual hosts. Bridge"},{"line_number":485,"context_line":"interfaces are used to create a XenServer VLAN network in which"},{"line_number":486,"context_line":"the VIFs for the VM instances are plugged. If no VIF bridge driver"},{"line_number":487,"context_line":"is plugged, the bridge is not made available. This configuration"},{"line_number":488,"context_line":"option takes in a value for the VIF driver."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"NOTE:"},{"line_number":491,"context_line":"The XenAPIBridgeDriver should be used for running OVS or Bridge in"},{"line_number":492,"context_line":"XenServer."},{"line_number":493,"context_line":"\"\"\"),"},{"line_number":494,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"},{"line_number":495,"context_line":"        default\u003d\u0027nova.virt.xenapi.image.glance.GlanceStore\u0027,"},{"line_number":496,"context_line":"        help\u003d\"\"\""},{"line_number":497,"context_line":"Dom0 plugin driver used to handle image uploads."},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"Provide a string value representing a plugin driver required to"},{"line_number":500,"context_line":"handle the image uploading to GlanceStore."},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"Images, and snapshots from XenServer need to be uploaded to the data"},{"line_number":503,"context_line":"store for use. image_upload_handler takes in a value for the Dom0"},{"line_number":504,"context_line":"plugin driver. This driver is then called to uplaod images to the"},{"line_number":505,"context_line":"GlanceStore."},{"line_number":506,"context_line":"\"\"\"),"},{"line_number":507,"context_line":"]"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"xenapi_volume_utils_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_925a0929","line":506,"range":{"start_line":475,"start_character":0,"end_line":506,"end_character":5},"in_reply_to":"7a77a97e_9936cd50","updated":"2016-11-17 09:12:30.000000000","message":"@sarafraj: yep, makes sense to separate that.","commit_id":"a290526db8223a11a2ce7d1b8e66b48c59bbb53e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"ca7b7a0cb91f2da8f3e1059ff904645b9993a2f2","unresolved":false,"context_lines":[{"line_number":472,"context_line":"time, the launch expires and the instance(s) are set to \u0027error\u0027"},{"line_number":473,"context_line":"state."},{"line_number":474,"context_line":"\"\"\"),"},{"line_number":475,"context_line":"    cfg.StrOpt(\u0027vif_driver\u0027,"},{"line_number":476,"context_line":"        default\u003d\u0027nova.virt.xenapi.vif.XenAPIBridgeDriver\u0027,"},{"line_number":477,"context_line":"        help\u003d\"\"\""},{"line_number":478,"context_line":"The XenAPI VIF driver using XenServer Network APIs."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"Provide a string value representing the VIF XenAPI bridge driver to"},{"line_number":481,"context_line":"use for bridging."},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"Xen configuration uses bridging within the backend domain to allow"},{"line_number":484,"context_line":"all VMs to appear on the network as individual hosts. Bridge"},{"line_number":485,"context_line":"interfaces are used to create a XenServer VLAN network in which"},{"line_number":486,"context_line":"the VIFs for the VM instances are plugged. If no VIF bridge driver"},{"line_number":487,"context_line":"is plugged, the bridge is not made available. This configuration"},{"line_number":488,"context_line":"option takes in a value for the VIF driver."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"NOTE:"},{"line_number":491,"context_line":"The XenAPIBridgeDriver should be used for running OVS or Bridge in"},{"line_number":492,"context_line":"XenServer."},{"line_number":493,"context_line":"\"\"\"),"},{"line_number":494,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"},{"line_number":495,"context_line":"        default\u003d\u0027nova.virt.xenapi.image.glance.GlanceStore\u0027,"},{"line_number":496,"context_line":"        help\u003d\"\"\""},{"line_number":497,"context_line":"Dom0 plugin driver used to handle image uploads."},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"Provide a string value representing a plugin driver required to"},{"line_number":500,"context_line":"handle the image uploading to GlanceStore."},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"Images, and snapshots from XenServer need to be uploaded to the data"},{"line_number":503,"context_line":"store for use. image_upload_handler takes in a value for the Dom0"},{"line_number":504,"context_line":"plugin driver. This driver is then called to uplaod images to the"},{"line_number":505,"context_line":"GlanceStore."},{"line_number":506,"context_line":"\"\"\"),"},{"line_number":507,"context_line":"]"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"xenapi_volume_utils_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5da102_df82d693","line":506,"range":{"start_line":475,"start_character":0,"end_line":506,"end_character":5},"in_reply_to":"ba5da102_bffe0236","updated":"2016-11-01 11:00:25.000000000","message":"My bad, did not read the comments to previous patches. Please ignore this msg :)","commit_id":"a290526db8223a11a2ce7d1b8e66b48c59bbb53e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d2c4d65a9b00317aad9c6746af3209dba501af0d","unresolved":false,"context_lines":[{"line_number":472,"context_line":"time, the launch expires and the instance(s) are set to \u0027error\u0027"},{"line_number":473,"context_line":"state."},{"line_number":474,"context_line":"\"\"\"),"},{"line_number":475,"context_line":"    cfg.StrOpt(\u0027vif_driver\u0027,"},{"line_number":476,"context_line":"        default\u003d\u0027nova.virt.xenapi.vif.XenAPIBridgeDriver\u0027,"},{"line_number":477,"context_line":"        help\u003d\"\"\""},{"line_number":478,"context_line":"The XenAPI VIF driver using XenServer Network APIs."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"Provide a string value representing the VIF XenAPI bridge driver to"},{"line_number":481,"context_line":"use for bridging."},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"Xen configuration uses bridging within the backend domain to allow"},{"line_number":484,"context_line":"all VMs to appear on the network as individual hosts. Bridge"},{"line_number":485,"context_line":"interfaces are used to create a XenServer VLAN network in which"},{"line_number":486,"context_line":"the VIFs for the VM instances are plugged. If no VIF bridge driver"},{"line_number":487,"context_line":"is plugged, the bridge is not made available. This configuration"},{"line_number":488,"context_line":"option takes in a value for the VIF driver."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"NOTE:"},{"line_number":491,"context_line":"The XenAPIBridgeDriver should be used for running OVS or Bridge in"},{"line_number":492,"context_line":"XenServer."},{"line_number":493,"context_line":"\"\"\"),"},{"line_number":494,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"},{"line_number":495,"context_line":"        default\u003d\u0027nova.virt.xenapi.image.glance.GlanceStore\u0027,"},{"line_number":496,"context_line":"        help\u003d\"\"\""},{"line_number":497,"context_line":"Dom0 plugin driver used to handle image uploads."},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"Provide a string value representing a plugin driver required to"},{"line_number":500,"context_line":"handle the image uploading to GlanceStore."},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"Images, and snapshots from XenServer need to be uploaded to the data"},{"line_number":503,"context_line":"store for use. image_upload_handler takes in a value for the Dom0"},{"line_number":504,"context_line":"plugin driver. This driver is then called to uplaod images to the"},{"line_number":505,"context_line":"GlanceStore."},{"line_number":506,"context_line":"\"\"\"),"},{"line_number":507,"context_line":"]"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"xenapi_volume_utils_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_3fe4c439","line":506,"range":{"start_line":475,"start_character":0,"end_line":506,"end_character":5},"in_reply_to":"ba5da102_df82d693","updated":"2016-11-16 16:17:21.000000000","message":"In ps 4, John Garbutt mentioned this:\n\n    \u003e We should add a TODO to make this into a \n    \u003e stevedore plugin.\n\nI think this comment is still valid, but I wouldn\u0027t block it because of this.","commit_id":"a290526db8223a11a2ce7d1b8e66b48c59bbb53e"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"c34c95f50c187b94810506c72a693a52c6337c14","unresolved":false,"context_lines":[{"line_number":472,"context_line":"time, the launch expires and the instance(s) are set to \u0027error\u0027"},{"line_number":473,"context_line":"state."},{"line_number":474,"context_line":"\"\"\"),"},{"line_number":475,"context_line":"    cfg.StrOpt(\u0027vif_driver\u0027,"},{"line_number":476,"context_line":"        default\u003d\u0027nova.virt.xenapi.vif.XenAPIBridgeDriver\u0027,"},{"line_number":477,"context_line":"        help\u003d\"\"\""},{"line_number":478,"context_line":"The XenAPI VIF driver using XenServer Network APIs."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"Provide a string value representing the VIF XenAPI bridge driver to"},{"line_number":481,"context_line":"use for bridging."},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"Xen configuration uses bridging within the backend domain to allow"},{"line_number":484,"context_line":"all VMs to appear on the network as individual hosts. Bridge"},{"line_number":485,"context_line":"interfaces are used to create a XenServer VLAN network in which"},{"line_number":486,"context_line":"the VIFs for the VM instances are plugged. If no VIF bridge driver"},{"line_number":487,"context_line":"is plugged, the bridge is not made available. This configuration"},{"line_number":488,"context_line":"option takes in a value for the VIF driver."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"NOTE:"},{"line_number":491,"context_line":"The XenAPIBridgeDriver should be used for running OVS or Bridge in"},{"line_number":492,"context_line":"XenServer."},{"line_number":493,"context_line":"\"\"\"),"},{"line_number":494,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"},{"line_number":495,"context_line":"        default\u003d\u0027nova.virt.xenapi.image.glance.GlanceStore\u0027,"},{"line_number":496,"context_line":"        help\u003d\"\"\""},{"line_number":497,"context_line":"Dom0 plugin driver used to handle image uploads."},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"Provide a string value representing a plugin driver required to"},{"line_number":500,"context_line":"handle the image uploading to GlanceStore."},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"Images, and snapshots from XenServer need to be uploaded to the data"},{"line_number":503,"context_line":"store for use. image_upload_handler takes in a value for the Dom0"},{"line_number":504,"context_line":"plugin driver. This driver is then called to uplaod images to the"},{"line_number":505,"context_line":"GlanceStore."},{"line_number":506,"context_line":"\"\"\"),"},{"line_number":507,"context_line":"]"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"xenapi_volume_utils_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5da102_bffe0236","line":506,"range":{"start_line":475,"start_character":0,"end_line":506,"end_character":5},"in_reply_to":"da6895a0_d30319b7","updated":"2016-11-01 10:58:46.000000000","message":"Are these not? If so, maybe let\u0027s add todo to deprecate these and do so in a follow-up patch.","commit_id":"a290526db8223a11a2ce7d1b8e66b48c59bbb53e"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"56fadc4154ebf2651b231559d86cac1c741cb640","unresolved":false,"context_lines":[{"line_number":472,"context_line":"time, the launch expires and the instance(s) are set to \u0027error\u0027"},{"line_number":473,"context_line":"state."},{"line_number":474,"context_line":"\"\"\"),"},{"line_number":475,"context_line":"    cfg.StrOpt(\u0027vif_driver\u0027,"},{"line_number":476,"context_line":"        default\u003d\u0027nova.virt.xenapi.vif.XenAPIBridgeDriver\u0027,"},{"line_number":477,"context_line":"        help\u003d\"\"\""},{"line_number":478,"context_line":"The XenAPI VIF driver using XenServer Network APIs."},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"Provide a string value representing the VIF XenAPI bridge driver to"},{"line_number":481,"context_line":"use for bridging."},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"Xen configuration uses bridging within the backend domain to allow"},{"line_number":484,"context_line":"all VMs to appear on the network as individual hosts. Bridge"},{"line_number":485,"context_line":"interfaces are used to create a XenServer VLAN network in which"},{"line_number":486,"context_line":"the VIFs for the VM instances are plugged. If no VIF bridge driver"},{"line_number":487,"context_line":"is plugged, the bridge is not made available. This configuration"},{"line_number":488,"context_line":"option takes in a value for the VIF driver."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"NOTE:"},{"line_number":491,"context_line":"The XenAPIBridgeDriver should be used for running OVS or Bridge in"},{"line_number":492,"context_line":"XenServer."},{"line_number":493,"context_line":"\"\"\"),"},{"line_number":494,"context_line":"    cfg.StrOpt(\u0027image_upload_handler\u0027,"},{"line_number":495,"context_line":"        default\u003d\u0027nova.virt.xenapi.image.glance.GlanceStore\u0027,"},{"line_number":496,"context_line":"        help\u003d\"\"\""},{"line_number":497,"context_line":"Dom0 plugin driver used to handle image uploads."},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"Provide a string value representing a plugin driver required to"},{"line_number":500,"context_line":"handle the image uploading to GlanceStore."},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"Images, and snapshots from XenServer need to be uploaded to the data"},{"line_number":503,"context_line":"store for use. image_upload_handler takes in a value for the Dom0"},{"line_number":504,"context_line":"plugin driver. This driver is then called to uplaod images to the"},{"line_number":505,"context_line":"GlanceStore."},{"line_number":506,"context_line":"\"\"\"),"},{"line_number":507,"context_line":"]"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"xenapi_volume_utils_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_9936cd50","line":506,"range":{"start_line":475,"start_character":0,"end_line":506,"end_character":5},"in_reply_to":"da6895a0_d30319b7","updated":"2016-11-16 19:06:42.000000000","message":"I think that should be in a follow on patch","commit_id":"a290526db8223a11a2ce7d1b8e66b48c59bbb53e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1fb7d28a6cbfe6340cc0fcdc75e3c930ac111a70","unresolved":false,"context_lines":[{"line_number":545,"context_line":"state."},{"line_number":546,"context_line":"\"\"\"),"},{"line_number":547,"context_line":"    cfg.StrOpt(\u0027vif_driver\u0027,"},{"line_number":548,"context_line":"        default\u003d\u0027nova.virt.xenapi.vif.XenAPIBridgeDriver\u0027,"},{"line_number":549,"context_line":"        help\u003d\"\"\""},{"line_number":550,"context_line":"The XenAPI VIF driver using XenServer Network APIs."},{"line_number":551,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1a6eadb0_36ce165b","line":548,"updated":"2016-12-12 15:30:07.000000000","message":"Nit: we should really add choices here, or stevedore, but thats true for all of these.","commit_id":"fbbcd31cbd510b4cc8ea6579a52ca146fb869281"}]}