)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1bec8c441b4490f688e9798589917847c5457c92","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        # NOTE(sbauza): Make sure we persist the new flavor in case we had"},{"line_number":272,"context_line":"        # a successful scheduler call if and only if nothing bad happened"},{"line_number":273,"context_line":"        if request_spec.obj_what_changed():"},{"line_number":274,"context_line":"            request_spec.save()"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def _set_vm_state_and_notify(self, context, instance_uuid, method, updates,"},{"line_number":277,"context_line":"                                 ex, request_spec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_952d9148","line":274,"updated":"2016-07-26 13:39:22.000000000","message":"So this means we have some \"broken\" request_specs for existing instances? I guess its impossible to fix those, so lets ignore that?\n\nI also can\u0027t remember what alaski said about updating the request_spec, but I think this makes sense.","commit_id":"9b5fdb968ed3511330fc30df92513ad837d17097"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6fcf6828bfe29d2360bba37e0acc26a140ee99ee","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        # NOTE(sbauza): Make sure we persist the new flavor in case we had"},{"line_number":272,"context_line":"        # a successful scheduler call if and only if nothing bad happened"},{"line_number":273,"context_line":"        if request_spec.obj_what_changed():"},{"line_number":274,"context_line":"            request_spec.save()"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    def _set_vm_state_and_notify(self, context, instance_uuid, method, updates,"},{"line_number":277,"context_line":"                                 ex, request_spec):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_553b18d1","line":274,"in_reply_to":"dada55a8_952d9148","updated":"2016-07-26 13:49:16.000000000","message":"So, I think the basic consensus we had is to say some fields can be updated, and some would be kept the same from the original.\n\nHere, I think we briefly discussed at PDX that the nested flavor from the RequestSpec object should respect the last asked instance type from the user. That said, the problem is when to persist that change, so that we don\u0027t update the Spec in case the resize is wedged, that\u0027s why I\u0027m only saving here.","commit_id":"9b5fdb968ed3511330fc30df92513ad837d17097"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"557a9bfbd656b996398e35634d55d31e7439d8a9","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                context, instance.uuid, image,"},{"line_number":224,"context_line":"                flavor, instance.numa_topology, instance.pci_requests,"},{"line_number":225,"context_line":"                filter_properties, None, instance.availability_zone)"},{"line_number":226,"context_line":"        else:"},{"line_number":227,"context_line":"            # NOTE(sbauza): Resizes means new flavor, so we need to update the"},{"line_number":228,"context_line":"            # original RequestSpec object for make sure the scheduler verifies"},{"line_number":229,"context_line":"            # the right one and not the original flavor"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5131cda1","line":226,"updated":"2016-07-28 14:09:55.000000000","message":"A slightly cleaner fix would be to remove this \u0027else:\u0027 and simply update the request_spec with the new flavor in all cases. But this works too.","commit_id":"74ab427d4796d8a386f84a15cc49188c2a60f8f1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0165920b63c096e20f32f517d0afb20fc3f53884","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                context, instance.uuid, image,"},{"line_number":224,"context_line":"                flavor, instance.numa_topology, instance.pci_requests,"},{"line_number":225,"context_line":"                filter_properties, None, instance.availability_zone)"},{"line_number":226,"context_line":"        else:"},{"line_number":227,"context_line":"            # NOTE(sbauza): Resizes means new flavor, so we need to update the"},{"line_number":228,"context_line":"            # original RequestSpec object for make sure the scheduler verifies"},{"line_number":229,"context_line":"            # the right one and not the original flavor"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_815e2274","line":226,"in_reply_to":"bacf61ea_5131cda1","updated":"2016-07-29 10:49:13.000000000","message":"Not really, because I plan to remove in Ocata the single if statement because all the instances should then have a related RequestSpec (even if the instances are quite old) so it would only leave the else: statement.","commit_id":"74ab427d4796d8a386f84a15cc49188c2a60f8f1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"230d9ab4bc4223d869a9ad1ad862449bda5dd933","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                filter_properties, None, instance.availability_zone)"},{"line_number":226,"context_line":"        else:"},{"line_number":227,"context_line":"            # NOTE(sbauza): Resizes means new flavor, so we need to update the"},{"line_number":228,"context_line":"            # original RequestSpec object for make sure the scheduler verifies"},{"line_number":229,"context_line":"            # the right one and not the original flavor"},{"line_number":230,"context_line":"            request_spec.flavor \u003d flavor"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b82709c9","line":228,"range":{"start_line":228,"start_character":42,"end_line":228,"end_character":45},"updated":"2016-07-29 15:40:32.000000000","message":"s/for/to/","commit_id":"74ab427d4796d8a386f84a15cc49188c2a60f8f1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"230d9ab4bc4223d869a9ad1ad862449bda5dd933","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            # NOTE(sbauza): Resizes means new flavor, so we need to update the"},{"line_number":228,"context_line":"            # original RequestSpec object for make sure the scheduler verifies"},{"line_number":229,"context_line":"            # the right one and not the original flavor"},{"line_number":230,"context_line":"            request_spec.flavor \u003d flavor"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        task \u003d self._build_cold_migrate_task(context, instance, flavor,"},{"line_number":233,"context_line":"                                             request_spec,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_fb497b61","line":230,"updated":"2016-07-29 15:40:32.000000000","message":"And if we\u0027re not doing a resize but a cold migrate, this is fine because the flavor isn\u0027t actually changing.","commit_id":"74ab427d4796d8a386f84a15cc49188c2a60f8f1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bcde071e23d8985b57ec842d0d671ba7c9105c2f","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            # NOTE(sbauza): Resizes means new flavor, so we need to update the"},{"line_number":228,"context_line":"            # original RequestSpec object for make sure the scheduler verifies"},{"line_number":229,"context_line":"            # the right one and not the original flavor"},{"line_number":230,"context_line":"            request_spec.flavor \u003d flavor"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        task \u003d self._build_cold_migrate_task(context, instance, flavor,"},{"line_number":233,"context_line":"                                             request_spec,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9e1f8d07","line":230,"in_reply_to":"bacf61ea_fb497b61","updated":"2016-07-29 15:53:43.000000000","message":"Well, the real problem is that we would pick a destination based on wrong assumption even if we would actually resize the instance (because the RPC call to the wrong compute would include the right target flavor). It\u0027s just that we make a wrong decision here, which could lead to an unnecessary reschedule later on resize claim.","commit_id":"74ab427d4796d8a386f84a15cc49188c2a60f8f1"}]}