)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"42cafd6188762841af6c5a345379127ab8f00cde","unresolved":false,"context_lines":[{"line_number":5312,"context_line":"        elif isinstance(migrate_data, migrate_data_obj.XenapiLiveMigrateData):"},{"line_number":5313,"context_line":"            is_shared_block_storage \u003d not migrate_data.block_migration"},{"line_number":5314,"context_line":"            is_shared_instance_path \u003d not migrate_data.block_migration"},{"line_number":5315,"context_line":"        elif isinstance(migrate_data, migrate_data_obj.HyperVLiveMigrateData):"},{"line_number":5316,"context_line":"            is_shared_instance_path \u003d migrate_data.is_shared_instance_path"},{"line_number":5317,"context_line":"            is_shared_block_storage \u003d migrate_data.is_shared_instance_path"},{"line_number":5318,"context_line":""},{"line_number":5319,"context_line":"        # No instance booting at source host, but instance dir"},{"line_number":5320,"context_line":"        # must be deleted for preparing next block migration"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_1adfe5d9","line":5317,"range":{"start_line":5315,"start_character":0,"end_line":5317,"end_character":74},"updated":"2016-08-01 13:03:23.000000000","message":"I can\u0027t find, where you start filling this field for HyperV, so this will fail.","commit_id":"5e569b9eaba6fea51df20d6492ee370019cfb02e"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"94406f984af45fdd8e8d1caaec92b970a3efb34c","unresolved":false,"context_lines":[{"line_number":5312,"context_line":"        elif isinstance(migrate_data, migrate_data_obj.XenapiLiveMigrateData):"},{"line_number":5313,"context_line":"            is_shared_block_storage \u003d not migrate_data.block_migration"},{"line_number":5314,"context_line":"            is_shared_instance_path \u003d not migrate_data.block_migration"},{"line_number":5315,"context_line":"        elif isinstance(migrate_data, migrate_data_obj.HyperVLiveMigrateData):"},{"line_number":5316,"context_line":"            is_shared_instance_path \u003d migrate_data.is_shared_instance_path"},{"line_number":5317,"context_line":"            is_shared_block_storage \u003d migrate_data.is_shared_instance_path"},{"line_number":5318,"context_line":""},{"line_number":5319,"context_line":"        # No instance booting at source host, but instance dir"},{"line_number":5320,"context_line":"        # must be deleted for preparing next block migration"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_b587995f","line":5317,"range":{"start_line":5315,"start_character":0,"end_line":5317,"end_character":74},"in_reply_to":"bacf61ea_1adfe5d9","updated":"2016-08-02 10:39:41.000000000","message":"This was part of a bigger change, I wanted to have the changes within the driver separated, thinking that this will ease the merging of this change but I\u0027ve missed this out. For some reason, I thought that those fields will just default to None.\n\nThose fields are set here: https://review.openstack.org/#/c/335114/5\n\nAnyway, I think you\u0027re right, this should be moved to the above mentioned change.","commit_id":"5e569b9eaba6fea51df20d6492ee370019cfb02e"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"a2ef463fc424e08604e6e608ba3f06ef42652a05","unresolved":false,"context_lines":[{"line_number":5312,"context_line":"        elif isinstance(migrate_data, migrate_data_obj.XenapiLiveMigrateData):"},{"line_number":5313,"context_line":"            is_shared_block_storage \u003d not migrate_data.block_migration"},{"line_number":5314,"context_line":"            is_shared_instance_path \u003d not migrate_data.block_migration"},{"line_number":5315,"context_line":"        elif isinstance(migrate_data, migrate_data_obj.HyperVLiveMigrateData):"},{"line_number":5316,"context_line":"            is_shared_instance_path \u003d migrate_data.is_shared_instance_path"},{"line_number":5317,"context_line":"            is_shared_block_storage \u003d migrate_data.is_shared_instance_path"},{"line_number":5318,"context_line":""},{"line_number":5319,"context_line":"        # No instance booting at source host, but instance dir"},{"line_number":5320,"context_line":"        # must be deleted for preparing next block migration"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_f3b58ed0","line":5317,"range":{"start_line":5315,"start_character":0,"end_line":5317,"end_character":74},"in_reply_to":"bacf61ea_b587995f","updated":"2016-08-08 15:15:17.000000000","message":"The CI passed. The reason is that some of the methods involved in the live migration process do not return the migrate data object, which at some point is lost.\n\nThis happens on the Hyper-V driver side, but it\u0027s addressed by the change that I\u0027ve mentioned.","commit_id":"5e569b9eaba6fea51df20d6492ee370019cfb02e"}],"nova/objects/migrate_data.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"42cafd6188762841af6c5a345379127ab8f00cde","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"@obj_base.NovaObjectRegistry.register"},{"line_number":269,"context_line":"class HyperVLiveMigrateData(LiveMigrateData):"},{"line_number":270,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_5a203df7","line":269,"range":{"start_line":269,"start_character":6,"end_line":269,"end_character":27},"updated":"2016-08-01 13:03:23.000000000","message":"you also need to implement obj_make_compatible","commit_id":"5e569b9eaba6fea51df20d6492ee370019cfb02e"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"94406f984af45fdd8e8d1caaec92b970a3efb34c","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"@obj_base.NovaObjectRegistry.register"},{"line_number":269,"context_line":"class HyperVLiveMigrateData(LiveMigrateData):"},{"line_number":270,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_952ed5a2","line":269,"range":{"start_line":269,"start_character":6,"end_line":269,"end_character":27},"in_reply_to":"bacf61ea_5a203df7","updated":"2016-08-02 10:39:41.000000000","message":"Done","commit_id":"5e569b9eaba6fea51df20d6492ee370019cfb02e"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"42cafd6188762841af6c5a345379127ab8f00cde","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"@obj_base.NovaObjectRegistry.register"},{"line_number":269,"context_line":"class HyperVLiveMigrateData(LiveMigrateData):"},{"line_number":270,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    fields \u003d {"},{"line_number":273,"context_line":"        \u0027is_shared_instance_path\u0027: fields.BooleanField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_7a18a1d3","line":270,"range":{"start_line":270,"start_character":4,"end_line":270,"end_character":19},"updated":"2016-08-01 13:03:23.000000000","message":"please document version as it\u0027s done on classes above.","commit_id":"5e569b9eaba6fea51df20d6492ee370019cfb02e"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"94406f984af45fdd8e8d1caaec92b970a3efb34c","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"@obj_base.NovaObjectRegistry.register"},{"line_number":269,"context_line":"class HyperVLiveMigrateData(LiveMigrateData):"},{"line_number":270,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    fields \u003d {"},{"line_number":273,"context_line":"        \u0027is_shared_instance_path\u0027: fields.BooleanField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ee9ae260","line":270,"range":{"start_line":270,"start_character":4,"end_line":270,"end_character":19},"in_reply_to":"bacf61ea_7a18a1d3","updated":"2016-08-02 10:39:41.000000000","message":"Done","commit_id":"5e569b9eaba6fea51df20d6492ee370019cfb02e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81dbc0ca3910bae141a19dd2a05718118f5a5037","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            if \u0027is_shared_instance_path\u0027 in primitive:"},{"line_number":282,"context_line":"                del primitive[\u0027is_shared_instance_path\u0027]"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def to_legacy_dict(self, pre_migration_result\u003dFalse):"},{"line_number":285,"context_line":"        legacy \u003d {}"},{"line_number":286,"context_line":"        if self.obj_attr_is_set(\u0027is_shared_instance_path\u0027):"},{"line_number":287,"context_line":"            legacy[\u0027is_shared_instance_path\u0027] \u003d self.is_shared_instance_path"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_12049b7c","line":284,"updated":"2016-08-19 16:39:39.000000000","message":"You need to call super\u0027s version here.","commit_id":"3b0263b2bcbbf570980d6df0c3430cfc13b81887"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"81dbc0ca3910bae141a19dd2a05718118f5a5037","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        return legacy"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    def from_legacy_dict(self, legacy):"},{"line_number":292,"context_line":"        if \u0027is_shared_instance_path\u0027 in legacy:"},{"line_number":293,"context_line":"            self.is_shared_instance_path \u003d legacy[\u0027is_shared_instance_path\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_72f50f82","line":291,"updated":"2016-08-19 16:39:39.000000000","message":"Also here.","commit_id":"3b0263b2bcbbf570980d6df0c3430cfc13b81887"}]}