)]}'
{"nova/tests/live_migration/hooks/run_tests.sh":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"eeb8c65163222c6b99d24c58c8ac185bc6505187","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#configure_and_start_cinder"},{"line_number":59,"context_line":"#run_tempest \"Ceph nova\u0026glance\u0026cinder test\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"echo \u00275. test serial console live migration\u0027"},{"line_number":62,"context_line":"# https://bugs.launchpad.net/nova/+bug/1455252"},{"line_number":63,"context_line":"serial_console_setup"},{"line_number":64,"context_line":"serial_console_configure_tempest"},{"line_number":65,"context_line":"run_tempest  \"serial console tests\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"bacf61ea_b5006a67","line":65,"range":{"start_line":61,"start_character":0,"end_line":65,"end_character":35},"updated":"2016-08-01 13:15:09.000000000","message":"I\u0027d move it up, as it\u0027s kind of simple scenario, that doesn\u0027t require ceph or nfs, right? So please put it as a second run.","commit_id":"6948b356bc5a81ae391a23f017b682fa709219fe"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"5c8de061a44b2b93c75513c4700e2fe2f31351ce","unresolved":false,"context_lines":[{"line_number":58,"context_line":"#configure_and_start_cinder"},{"line_number":59,"context_line":"#run_tempest \"Ceph nova\u0026glance\u0026cinder test\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"echo \u00275. test serial console live migration\u0027"},{"line_number":62,"context_line":"# https://bugs.launchpad.net/nova/+bug/1455252"},{"line_number":63,"context_line":"serial_console_setup"},{"line_number":64,"context_line":"serial_console_configure_tempest"},{"line_number":65,"context_line":"run_tempest  \"serial console tests\""}],"source_content_type":"text/x-sh","patch_set":7,"id":"bacf61ea_8a18a4d4","line":65,"range":{"start_line":61,"start_character":0,"end_line":65,"end_character":35},"in_reply_to":"bacf61ea_b5006a67","updated":"2016-08-01 13:50:31.000000000","message":"@Timofey: Yep, it\u0027s a pretty trivial scenario. I\u0027m going to move it to step 2 in ps8.","commit_id":"6948b356bc5a81ae391a23f017b682fa709219fe"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"a982c36d34f3fc16aebd437c26a788f3f18746b8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#echo \u00274. test with Ceph for volumes and root + ephemeral disk\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"#configure_and_start_cinder"},{"line_number":65,"context_line":"#run_tempest \"Ceph nova\u0026glance\u0026cinder test\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"9ad45d7e_9fb2abe3","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":43},"updated":"2016-08-11 10:15:45.000000000","message":"is it not related change?","commit_id":"82da83e86e5c4f9065d5046650468e49bff4a777"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"5fe1702e6d23d104b9c942c7187015827921d89e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#echo \u00274. test with Ceph for volumes and root + ephemeral disk\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"#configure_and_start_cinder"},{"line_number":65,"context_line":"#run_tempest \"Ceph nova\u0026glance\u0026cinder test\""}],"source_content_type":"text/x-sh","patch_set":13,"id":"9ad45d7e_016779e9","line":65,"range":{"start_line":65,"start_character":0,"end_line":65,"end_character":43},"in_reply_to":"9ad45d7e_9fb2abe3","updated":"2016-08-11 13:07:11.000000000","message":"@Timofey: There\u0027s a new line added by mistake. The contents in line 57+65 are equal. I can remove the new line if you like.","commit_id":"82da83e86e5c4f9065d5046650468e49bff4a777"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"26a5aa24831b794f3c9c40efcef33aa361bb70af","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# https://bugs.launchpad.net/nova/+bug/1455252"},{"line_number":36,"context_line":"serial_console_setup"},{"line_number":37,"context_line":"serial_console_configure_tempest"},{"line_number":38,"context_line":"run_tempest  \"serial console tests\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"echo \u00273. NFS testing is skipped due to setup failures with Ubuntu 16.04\u0027"},{"line_number":41,"context_line":"#echo \u00273. test with NFS for root + ephemeral disks\u0027"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9ad45d7e_d6704adf","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":35},"updated":"2016-08-12 10:04:02.000000000","message":"you need to pass regex here, I think one I\u0027ve used on line 32 would be ok.","commit_id":"622fe3e8a900cfab0a4927a2f3b56d4cc69aa112"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ed02a134e71e299add8eaaaf346122ceaf080115","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# https://bugs.launchpad.net/nova/+bug/1455252"},{"line_number":36,"context_line":"serial_console_setup"},{"line_number":37,"context_line":"serial_console_configure_tempest"},{"line_number":38,"context_line":"run_tempest  \"serial console tests\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"echo \u00273. NFS testing is skipped due to setup failures with Ubuntu 16.04\u0027"},{"line_number":41,"context_line":"#echo \u00273. test with NFS for root + ephemeral disks\u0027"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9ad45d7e_d39fb763","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":35},"in_reply_to":"9ad45d7e_d6704adf","updated":"2016-08-12 11:04:59.000000000","message":"Done","commit_id":"622fe3e8a900cfab0a4927a2f3b56d4cc69aa112"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"d44947ef5c65d811ba594fc5a9ea0a1a2ebe69c9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"run_tempest \"block migration test\" \"^.*test_live_migration(?!.*(test_volume_backed_live_migration))\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"#all tests bellow this line use shared storage, need to update tempest.conf"},{"line_number":35,"context_line":"echo \u0027disabling block_migration in tempest\u0027"},{"line_number":36,"context_line":"$ANSIBLE primary --sudo -f 5 -i \"$WORKSPACE/inventory\" -m ini_file -a \"dest\u003d$BASE/new/tempest/etc/tempest.conf section\u003dcompute-feature-enabled option\u003dblock_migration_for_live_migration value\u003dFalse\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"echo \u00272. NFS testing is skipped due to setup failures with Ubuntu 16.04\u0027"},{"line_number":39,"context_line":"#echo \u00272. test with NFS for root + ephemeral disks\u0027"}],"source_content_type":"text/x-sh","patch_set":33,"id":"5a74a57a_8ec4e15f","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":197},"updated":"2016-11-24 11:17:38.000000000","message":"This command disables block-migration in the tempest, so it expects shared storage to be set on the environment. Reordering this and new serial console lines should help","commit_id":"d9a7acdc888a8aae9dd0d8887737655db9898639"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"925337a6e9e53afe6900488b4814450de7d6315a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"echo \u0027NOTE: test_volume_backed_live_migration is skipped due to https://bugs.launchpad.net/nova/+bug/1524898\u0027"},{"line_number":32,"context_line":"run_tempest \"block migration test\" \"^.*test_live_migration(?!.*(test_volume_backed_live_migration))\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"echo \u00272. test serial console live migration\u0027"},{"line_number":35,"context_line":"# Example issue we want to avoid https://bugs.launchpad.net/nova/+bug/1455252"},{"line_number":36,"context_line":"serial_console_setup"},{"line_number":37,"context_line":"serial_console_configure_tempest"}],"source_content_type":"text/x-sh","patch_set":39,"id":"3a71b18c_7dd6e028","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":44},"updated":"2016-12-06 13:25:57.000000000","message":"So the open question is: can we skip this step when this is a grenade job and branch is stable/newton(?)? Does it sound like a good way forward?","commit_id":"d00f2df48b431fa1be5fa958f9e6836fd9f81141"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a3de5d811a77ed6e4735e260e789d894270bcc89","unresolved":false,"context_lines":[{"line_number":31,"context_line":"echo \u0027NOTE: test_volume_backed_live_migration is skipped due to https://bugs.launchpad.net/nova/+bug/1524898\u0027"},{"line_number":32,"context_line":"run_tempest \"block migration test\" \"^.*test_live_migration(?!.*(test_volume_backed_live_migration))\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"echo \u00272. test serial console live migration\u0027"},{"line_number":35,"context_line":"# Example issue we want to avoid https://bugs.launchpad.net/nova/+bug/1455252"},{"line_number":36,"context_line":"serial_console_setup"},{"line_number":37,"context_line":"serial_console_configure_tempest"}],"source_content_type":"text/x-sh","patch_set":39,"id":"3a71b18c_25a52746","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":44},"in_reply_to":"3a71b18c_7dd6e028","updated":"2016-12-06 16:56:46.000000000","message":"Yep, https://review.openstack.org/#/c/407532/2 did research a way to have a flag. We have to skip this as long as stable/newton is the latest stable release. When stable/ocata is released, we can/have to remove the skip in grenade.","commit_id":"d00f2df48b431fa1be5fa958f9e6836fd9f81141"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"4f31aba5a3a8639dfe4204a3806befa9e9f3bb40","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    serial_console_setup"},{"line_number":45,"context_line":"    serial_console_configure_tempest"},{"line_number":46,"context_line":"    run_tempest  \"serial console tests\" \"^.*test_live_migration\""},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"#all tests bellow this line use shared storage, need to update tempest.conf"},{"line_number":50,"context_line":"echo \u0027disabling block_migration in tempest\u0027"}],"source_content_type":"text/x-sh","patch_set":41,"id":"ba5201f7_e0db7919","line":47,"updated":"2017-01-11 12:40:57.000000000","message":"Shouldn\u0027t nova tear down serial console configuration here before moving forward to the next test?","commit_id":"54cc9437ba06c5abee0092d4df9426129e785ce9"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ab323f7bbda2e2688578b520ab9fe9d087c5396d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    serial_console_setup"},{"line_number":45,"context_line":"    serial_console_configure_tempest"},{"line_number":46,"context_line":"    run_tempest  \"serial console tests\" \"^.*test_live_migration\""},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"#all tests bellow this line use shared storage, need to update tempest.conf"},{"line_number":50,"context_line":"echo \u0027disabling block_migration in tempest\u0027"}],"source_content_type":"text/x-sh","patch_set":41,"id":"ba5201f7_b359c95d","line":47,"in_reply_to":"ba5201f7_e0db7919","updated":"2017-01-11 13:00:37.000000000","message":"@Pawel: Valid point. I\u0027ll add a \"serial_console_teardown\" function in ps42.","commit_id":"54cc9437ba06c5abee0092d4df9426129e785ce9"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"2c344843ed3ac1ede8f5c798a80ea61e6e196670","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    log_hook \"Skipped due to missing backports to Newton for bug 1455252\""},{"line_number":38,"context_line":"    # TODO(markus_z): This conditional has to be removed if one of these"},{"line_number":39,"context_line":"    # cases happens:"},{"line_number":40,"context_line":"    # 1) stable/ocata is created and master is open for Pike"},{"line_number":41,"context_line":"    # 2) the backports to stable/newton are merged:"},{"line_number":42,"context_line":"    #    https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton+topic:%22bug+1455252%22"},{"line_number":43,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":43,"id":"fa31d9ce_7d7851f9","line":40,"updated":"2017-02-17 09:24:37.000000000","message":"stable/ocata happened. Which means this conditional isn\u0027t necessary anymore. I\u0027ll remove that in ps44.","commit_id":"b237e5ebfabdfc593c1e83c801bb78c7196f25fd"}],"nova/tests/live_migration/hooks/serial_console.sh":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"eb40fce77139712a50c8c09cd970bfb21ee6a51c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function log_sc {"},{"line_number":4,"context_line":"    echo \u0027HOOK: serial console: $1\u0027"},{"line_number":5,"context_line":"}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"function serial_console_setup {"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bacf61ea_bc9499e8","line":4,"updated":"2016-07-27 15:05:57.000000000","message":"That\u0027s just to see my echos better in the console log as long as this is a WIP.","commit_id":"22a5edc44dfde946eea0a31a8ebd3f7ce6aaa9c5"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"577056701a397f64cb1e8eb358a298f39d4baf6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function log_sc {"},{"line_number":4,"context_line":"    echo \"HOOK: serial console: $1\""},{"line_number":5,"context_line":"}"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"9ad45d7e_bbe3ba32","line":3,"updated":"2016-08-09 12:40:57.000000000","message":"I\u0027d move that to utils.sh.","commit_id":"cb758cec1d962459e49e170a1b75eb50c29673f3"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"083d4fb29486bdade938266ba6ed8fe7dfb9dce5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function log_sc {"},{"line_number":4,"context_line":"    echo \"HOOK: serial console: $1\""},{"line_number":5,"context_line":"}"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-sh","patch_set":12,"id":"9ad45d7e_315b6b30","line":3,"in_reply_to":"9ad45d7e_bbe3ba32","updated":"2016-08-09 13:07:15.000000000","message":"OK. Will then just be made generic and renamed.","commit_id":"cb758cec1d962459e49e170a1b75eb50c29673f3"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"577056701a397f64cb1e8eb358a298f39d4baf6a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"function serial_console_setup {"},{"line_number":8,"context_line":"    log_sc \u0027check compute processes before restart\u0027"},{"line_number":9,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep compute\""},{"line_number":10,"context_line":"    log_sc \u0027stoping all n-cpu process\u0027"},{"line_number":11,"context_line":"    stop \u0027all\u0027 \u0027n-cpu\u0027"},{"line_number":12,"context_line":"    log_sc \u0027check processes after compute stop\u0027"},{"line_number":13,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep compute\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    log_sc \u0027configuring the nodes for serial console support...\u0027"},{"line_number":16,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m ini_file -a  \"dest\u003d${NOVA_CONF} section\u003dserial_console option\u003denabled value\u003dTrue\""}],"source_content_type":"text/x-sh","patch_set":12,"id":"9ad45d7e_9ba4f6a6","line":13,"range":{"start_line":8,"start_character":3,"end_line":13,"end_character":90},"updated":"2016-08-09 12:40:57.000000000","message":"it looks like kind of pattern, so maybe also wrap it in function, and move to utils?","commit_id":"cb758cec1d962459e49e170a1b75eb50c29673f3"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"083d4fb29486bdade938266ba6ed8fe7dfb9dce5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"function serial_console_setup {"},{"line_number":8,"context_line":"    log_sc \u0027check compute processes before restart\u0027"},{"line_number":9,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep compute\""},{"line_number":10,"context_line":"    log_sc \u0027stoping all n-cpu process\u0027"},{"line_number":11,"context_line":"    stop \u0027all\u0027 \u0027n-cpu\u0027"},{"line_number":12,"context_line":"    log_sc \u0027check processes after compute stop\u0027"},{"line_number":13,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep compute\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    log_sc \u0027configuring the nodes for serial console support...\u0027"},{"line_number":16,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m ini_file -a  \"dest\u003d${NOVA_CONF} section\u003dserial_console option\u003denabled value\u003dTrue\""}],"source_content_type":"text/x-sh","patch_set":12,"id":"9ad45d7e_31808b46","line":13,"range":{"start_line":8,"start_character":3,"end_line":13,"end_character":90},"in_reply_to":"9ad45d7e_9ba4f6a6","updated":"2016-08-09 13:07:15.000000000","message":"yep, you\u0027re right, that\u0027s a pattern. Will be moved in ps13.","commit_id":"cb758cec1d962459e49e170a1b75eb50c29673f3"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"577056701a397f64cb1e8eb358a298f39d4baf6a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    # https://github.com/openstack/nova/blob/e6deb676cdeb630add92663cc59f0680e38ce2a5/nova/compute/manager.py#L4562-L4562"},{"line_number":21,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m ini_file -a  \"dest\u003d${NOVA_CONF} section\u003dserial_console option\u003dbase_url value\u003dws://${SERVICE_HOST}:6083/\""},{"line_number":22,"context_line":"    log_sc \u0027configured serial_console.base_url\u003dservice_host in nova.conf\u0027"},{"line_number":23,"context_line":"    # TODO(markus_z) I don\u0027t know if `proxyclient_address\u003d$HOST_IP` is needed"},{"line_number":24,"context_line":"    # I *assume* it is needed for the consoleauth. This is also used for"},{"line_number":25,"context_line":"    # the domain XML:"},{"line_number":26,"context_line":"    # https://github.com/openstack/nova/blob/2099ce73d87038983f01f639ddd1bc8f15b16729/nova/virt/libvirt/driver.py#L4095-L4096"},{"line_number":27,"context_line":"    # https://github.com/openstack/nova/blob/ea894733e8b9fc57df54ec1443f0c426074198e2/nova/virt/libvirt/config.py#L1620-L1623"},{"line_number":28,"context_line":"    # this gets later queried to get the console:"},{"line_number":29,"context_line":"    # https://github.com/openstack/nova/blob/2099ce73d87038983f01f639ddd1bc8f15b16729/nova/virt/libvirt/driver.py#L1065-L1066"},{"line_number":30,"context_line":"    # https://github.com/openstack/nova/blob/2099ce73d87038983f01f639ddd1bc8f15b16729/nova/virt/libvirt/driver.py#L2818-L2820"},{"line_number":31,"context_line":"    # which is used by `authorize console`:"},{"line_number":32,"context_line":"    # https://github.com/openstack/nova/blob/aa81d6c301d6549af6fe8e8a9fb55facf898f809/nova/compute/api.py#L2890-L2890"},{"line_number":33,"context_line":"    # after that the connection url is assembled and return by the REST API"},{"line_number":34,"context_line":"    # https://github.com/openstack/nova/blob/e6deb676cdeb630add92663cc59f0680e38ce2a5/nova/compute/manager.py#L4562-L4562"},{"line_number":35,"context_line":"    # https://github.com/openstack/nova/blob/aa81d6c301d6549af6fe8e8a9fb55facf898f809/nova/compute/api.py#L2893-L2893"},{"line_number":36,"context_line":"    # https://github.com/openstack/nova/blob/8d16b1f6c4ce1acf0542d6d7c59343b834d14a1d/nova/api/openstack/compute/remote_consoles.py#L142-L144"},{"line_number":37,"context_line":"    # I\u0027m leaving this here as long as it\u0027s WIP"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    log_sc \u0027starting nova-serialproxy service...\u0027"},{"line_number":40,"context_line":"    sudo -H -u $STACK_USER bash -c \"/tmp/start_process.sh n-sproxy \u0027/usr/local/bin/nova-serialproxy --config-file /etc/nova/nova.conf\u0027 \""}],"source_content_type":"text/x-sh","patch_set":12,"id":"9ad45d7e_5bdefe3f","line":37,"range":{"start_line":23,"start_character":4,"end_line":37,"end_character":47},"updated":"2016-08-09 12:40:57.000000000","message":"is it still WIP?:)","commit_id":"cb758cec1d962459e49e170a1b75eb50c29673f3"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"083d4fb29486bdade938266ba6ed8fe7dfb9dce5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    # https://github.com/openstack/nova/blob/e6deb676cdeb630add92663cc59f0680e38ce2a5/nova/compute/manager.py#L4562-L4562"},{"line_number":21,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m ini_file -a  \"dest\u003d${NOVA_CONF} section\u003dserial_console option\u003dbase_url value\u003dws://${SERVICE_HOST}:6083/\""},{"line_number":22,"context_line":"    log_sc \u0027configured serial_console.base_url\u003dservice_host in nova.conf\u0027"},{"line_number":23,"context_line":"    # TODO(markus_z) I don\u0027t know if `proxyclient_address\u003d$HOST_IP` is needed"},{"line_number":24,"context_line":"    # I *assume* it is needed for the consoleauth. This is also used for"},{"line_number":25,"context_line":"    # the domain XML:"},{"line_number":26,"context_line":"    # https://github.com/openstack/nova/blob/2099ce73d87038983f01f639ddd1bc8f15b16729/nova/virt/libvirt/driver.py#L4095-L4096"},{"line_number":27,"context_line":"    # https://github.com/openstack/nova/blob/ea894733e8b9fc57df54ec1443f0c426074198e2/nova/virt/libvirt/config.py#L1620-L1623"},{"line_number":28,"context_line":"    # this gets later queried to get the console:"},{"line_number":29,"context_line":"    # https://github.com/openstack/nova/blob/2099ce73d87038983f01f639ddd1bc8f15b16729/nova/virt/libvirt/driver.py#L1065-L1066"},{"line_number":30,"context_line":"    # https://github.com/openstack/nova/blob/2099ce73d87038983f01f639ddd1bc8f15b16729/nova/virt/libvirt/driver.py#L2818-L2820"},{"line_number":31,"context_line":"    # which is used by `authorize console`:"},{"line_number":32,"context_line":"    # https://github.com/openstack/nova/blob/aa81d6c301d6549af6fe8e8a9fb55facf898f809/nova/compute/api.py#L2890-L2890"},{"line_number":33,"context_line":"    # after that the connection url is assembled and return by the REST API"},{"line_number":34,"context_line":"    # https://github.com/openstack/nova/blob/e6deb676cdeb630add92663cc59f0680e38ce2a5/nova/compute/manager.py#L4562-L4562"},{"line_number":35,"context_line":"    # https://github.com/openstack/nova/blob/aa81d6c301d6549af6fe8e8a9fb55facf898f809/nova/compute/api.py#L2893-L2893"},{"line_number":36,"context_line":"    # https://github.com/openstack/nova/blob/8d16b1f6c4ce1acf0542d6d7c59343b834d14a1d/nova/api/openstack/compute/remote_consoles.py#L142-L144"},{"line_number":37,"context_line":"    # I\u0027m leaving this here as long as it\u0027s WIP"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    log_sc \u0027starting nova-serialproxy service...\u0027"},{"line_number":40,"context_line":"    sudo -H -u $STACK_USER bash -c \"/tmp/start_process.sh n-sproxy \u0027/usr/local/bin/nova-serialproxy --config-file /etc/nova/nova.conf\u0027 \""}],"source_content_type":"text/x-sh","patch_set":12,"id":"9ad45d7e_ce07ce1a","line":37,"range":{"start_line":23,"start_character":4,"end_line":37,"end_character":47},"in_reply_to":"9ad45d7e_5bdefe3f","updated":"2016-08-09 13:07:15.000000000","message":"whops, no, that shouldn\u0027t be there anymore. Will be removed in ps 13.","commit_id":"cb758cec1d962459e49e170a1b75eb50c29673f3"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ed02a134e71e299add8eaaaf346122ceaf080115","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        log_hook \u0027starting nova-compute on one of the subnodes\u0027"},{"line_number":25,"context_line":"        ssh $SUBNODE \"sudo -H -u $STACK_USER bash -c \u0027/tmp/start_process.sh n-cpu \\\"/usr/local/bin/nova-compute --config-file /etc/nova/nova.conf\\\" libvirtd\u0027\""},{"line_number":26,"context_line":"    done"},{"line_number":27,"context_line":"    log_hook \u0027started local nova-compute\u0027"},{"line_number":28,"context_line":"    log_hook \u0027checking processes after restart...\u0027"},{"line_number":29,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep compute\""},{"line_number":30,"context_line":"    $ANSIBLE primary --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep serialproxy\""}],"source_content_type":"text/x-sh","patch_set":14,"id":"9ad45d7e_8d29a58c","line":27,"range":{"start_line":27,"start_character":22,"end_line":27,"end_character":41},"updated":"2016-08-12 11:04:59.000000000","message":"That should be \"remote nova-computes\". Changed in ps15","commit_id":"622fe3e8a900cfab0a4927a2f3b56d4cc69aa112"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"7cb657fde3988cd3e4b4dbf991ba24f7d40373d6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"function serial_console_setup {"},{"line_number":4,"context_line":"    stop_all_nova_compute"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    log_hook \u0027configuring the nodes for serial console support...\u0027"},{"line_number":7,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m ini_file -a  \"dest\u003d${NOVA_CONF} section\u003dserial_console option\u003denabled value\u003dTrue\""},{"line_number":8,"context_line":"    log_hook \u0027configured serial_console.enabled\u003dTrue in nova.conf\u0027"},{"line_number":9,"context_line":"    # The \"[serial_console].base_url\" is used to return a URL which then"}],"source_content_type":"text/x-sh","patch_set":19,"id":"3ac371cc_e5957fe4","line":6,"updated":"2016-08-16 10:34:23.000000000","message":"Should this logs be so chatty? I think it can affect a perfomance eventually. Isn\u0027t set -o xtrace replacement for this?","commit_id":"b99a1b7ba5fb19ae96ed5b7a94b1d01af90d947e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"df78f649e4005a86dc6b0e7ff3ecb932afc9263d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"function serial_console_setup {"},{"line_number":4,"context_line":"    stop_all_nova_compute"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    log_hook \u0027configuring the nodes for serial console support...\u0027"},{"line_number":7,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m ini_file -a  \"dest\u003d${NOVA_CONF} section\u003dserial_console option\u003denabled value\u003dTrue\""},{"line_number":8,"context_line":"    log_hook \u0027configured serial_console.enabled\u003dTrue in nova.conf\u0027"},{"line_number":9,"context_line":"    # The \"[serial_console].base_url\" is used to return a URL which then"}],"source_content_type":"text/x-sh","patch_set":19,"id":"3ac371cc_8189db77","line":6,"in_reply_to":"3ac371cc_e5957fe4","updated":"2016-08-17 11:40:59.000000000","message":"@Andrey: IIUC \u0027xtrace\u0027 prints the command this script is going to execute next. With the \"log_hook\" calls I want to provide a hint *why* I\u0027m executing the next command. Indeed, it is a little chatty right now, but even if this costs a few seconds, that doesn\u0027t affect the overall test run. After this hook is merged and established for some weeks we can reduce the chattieness here.","commit_id":"b99a1b7ba5fb19ae96ed5b7a94b1d01af90d947e"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"7cb657fde3988cd3e4b4dbf991ba24f7d40373d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    stop_all_nova_compute"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    log_hook \u0027configuring the nodes for serial console support...\u0027"},{"line_number":7,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m ini_file -a  \"dest\u003d${NOVA_CONF} section\u003dserial_console option\u003denabled value\u003dTrue\""},{"line_number":8,"context_line":"    log_hook \u0027configured serial_console.enabled\u003dTrue in nova.conf\u0027"},{"line_number":9,"context_line":"    # The \"[serial_console].base_url\" is used to return a URL which then"},{"line_number":10,"context_line":"    # is used to access the nova-serialproxy to use:"}],"source_content_type":"text/x-sh","patch_set":19,"id":"3ac371cc_a5aee782","line":7,"updated":"2016-08-16 10:34:23.000000000","message":"Could it be possible to limit line length for more comfortable review? )","commit_id":"b99a1b7ba5fb19ae96ed5b7a94b1d01af90d947e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"df78f649e4005a86dc6b0e7ff3ecb932afc9263d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    stop_all_nova_compute"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    log_hook \u0027configuring the nodes for serial console support...\u0027"},{"line_number":7,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m ini_file -a  \"dest\u003d${NOVA_CONF} section\u003dserial_console option\u003denabled value\u003dTrue\""},{"line_number":8,"context_line":"    log_hook \u0027configured serial_console.enabled\u003dTrue in nova.conf\u0027"},{"line_number":9,"context_line":"    # The \"[serial_console].base_url\" is used to return a URL which then"},{"line_number":10,"context_line":"    # is used to access the nova-serialproxy to use:"}],"source_content_type":"text/x-sh","patch_set":19,"id":"3ac371cc_a6334d13","line":7,"in_reply_to":"3ac371cc_a5aee782","updated":"2016-08-17 11:40:59.000000000","message":"@Andrey: Yes, will limit the length in ps21.","commit_id":"b99a1b7ba5fb19ae96ed5b7a94b1d01af90d947e"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"7cb657fde3988cd3e4b4dbf991ba24f7d40373d6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    log_hook \u0027configured serial_console.base_url\u003dservice_host in nova.conf\u0027"},{"line_number":14,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m ini_file -a  \"dest\u003d${NOVA_CONF} section\u003dserial_console option\u003dproxyclient_address value\u003d${HOST_IP}\""},{"line_number":15,"context_line":"    log_hook \u0027configured serial_console.proxyclient_address in nova.conf\u0027"},{"line_number":16,"context_line":"    log_hook \u0027configured the nodes for serial console support...\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    log_hook \u0027starting nova-serialproxy service...\u0027"},{"line_number":19,"context_line":"    sudo -H -u $STACK_USER bash -c \"/tmp/start_process.sh n-sproxy \u0027/usr/local/bin/nova-serialproxy --config-file /etc/nova/nova.conf\u0027 \""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3ac371cc_c53a0398","line":16,"updated":"2016-08-16 10:34:23.000000000","message":"Maybe, missed nodes configuration?","commit_id":"b99a1b7ba5fb19ae96ed5b7a94b1d01af90d947e"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"2683539084cdd6231ae39658c906a223bcd55ccf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    log_hook \u0027configured serial_console.base_url\u003dservice_host in nova.conf\u0027"},{"line_number":14,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m ini_file -a  \"dest\u003d${NOVA_CONF} section\u003dserial_console option\u003dproxyclient_address value\u003d${HOST_IP}\""},{"line_number":15,"context_line":"    log_hook \u0027configured serial_console.proxyclient_address in nova.conf\u0027"},{"line_number":16,"context_line":"    log_hook \u0027configured the nodes for serial console support...\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    log_hook \u0027starting nova-serialproxy service...\u0027"},{"line_number":19,"context_line":"    sudo -H -u $STACK_USER bash -c \"/tmp/start_process.sh n-sproxy \u0027/usr/local/bin/nova-serialproxy --config-file /etc/nova/nova.conf\u0027 \""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3ac371cc_00a762bd","line":16,"in_reply_to":"3ac371cc_01ddeb6e","updated":"2016-08-18 10:22:56.000000000","message":"Sorry, I thought that \"configured\" message should be after some action. Now I see it\u0027s for block of actions.","commit_id":"b99a1b7ba5fb19ae96ed5b7a94b1d01af90d947e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"df78f649e4005a86dc6b0e7ff3ecb932afc9263d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    log_hook \u0027configured serial_console.base_url\u003dservice_host in nova.conf\u0027"},{"line_number":14,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m ini_file -a  \"dest\u003d${NOVA_CONF} section\u003dserial_console option\u003dproxyclient_address value\u003d${HOST_IP}\""},{"line_number":15,"context_line":"    log_hook \u0027configured serial_console.proxyclient_address in nova.conf\u0027"},{"line_number":16,"context_line":"    log_hook \u0027configured the nodes for serial console support...\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    log_hook \u0027starting nova-serialproxy service...\u0027"},{"line_number":19,"context_line":"    sudo -H -u $STACK_USER bash -c \"/tmp/start_process.sh n-sproxy \u0027/usr/local/bin/nova-serialproxy --config-file /etc/nova/nova.conf\u0027 \""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3ac371cc_01ddeb6e","line":16,"in_reply_to":"3ac371cc_c53a0398","updated":"2016-08-17 11:40:59.000000000","message":"@Andrey: What do you mean?","commit_id":"b99a1b7ba5fb19ae96ed5b7a94b1d01af90d947e"}],"nova/tests/live_migration/hooks/utils.sh":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"26a5aa24831b794f3c9c40efcef33aa361bb70af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function run_tempest {"},{"line_number":4,"context_line":"    local message\u003d$1"},{"line_number":5,"context_line":"    local tempest_regex\u003d$2"},{"line_number":6,"context_line":"    sudo -H -u tempest tox -eall -- --concurrency\u003d$TEMPEST_CONCURRENCY $tempest_regex"},{"line_number":7,"context_line":"    exitcode\u003d$?"},{"line_number":8,"context_line":"    if [[ $exitcode -ne 0 ]]; then"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9ad45d7e_16aca234","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":26},"updated":"2016-08-12 10:04:02.000000000","message":"take a look at this, run_tempest now accepts 2 params, 1 is a message, and the second one is a regex to filter tests, that should be run","commit_id":"622fe3e8a900cfab0a4927a2f3b56d4cc69aa112"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"ed02a134e71e299add8eaaaf346122ceaf080115","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"function run_tempest {"},{"line_number":4,"context_line":"    local message\u003d$1"},{"line_number":5,"context_line":"    local tempest_regex\u003d$2"},{"line_number":6,"context_line":"    sudo -H -u tempest tox -eall -- --concurrency\u003d$TEMPEST_CONCURRENCY $tempest_regex"},{"line_number":7,"context_line":"    exitcode\u003d$?"},{"line_number":8,"context_line":"    if [[ $exitcode -ne 0 ]]; then"}],"source_content_type":"text/x-sh","patch_set":14,"id":"9ad45d7e_b3a4c3b9","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":26},"in_reply_to":"9ad45d7e_16aca234","updated":"2016-08-12 11:04:59.000000000","message":"Done","commit_id":"622fe3e8a900cfab0a4927a2f3b56d4cc69aa112"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"7cb657fde3988cd3e4b4dbf991ba24f7d40373d6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"function stop_all_nova_compute {"},{"line_number":20,"context_line":"    log_hook \u0027stopping all n-cpu processes...\u0027"},{"line_number":21,"context_line":"    log_hook \u0027check compute processes before restart\u0027"},{"line_number":22,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep compute\""},{"line_number":23,"context_line":"    stop \u0027all\u0027 \u0027n-cpu\u0027"},{"line_number":24,"context_line":"    log_hook \u0027check processes after compute stop\u0027"},{"line_number":25,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep compute\""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3ac371cc_f33b88e9","line":22,"updated":"2016-08-16 10:34:23.000000000","message":"Do we need to remove the grep process itself from ps aux output here?","commit_id":"b99a1b7ba5fb19ae96ed5b7a94b1d01af90d947e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"df78f649e4005a86dc6b0e7ff3ecb932afc9263d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"function stop_all_nova_compute {"},{"line_number":20,"context_line":"    log_hook \u0027stopping all n-cpu processes...\u0027"},{"line_number":21,"context_line":"    log_hook \u0027check compute processes before restart\u0027"},{"line_number":22,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep compute\""},{"line_number":23,"context_line":"    stop \u0027all\u0027 \u0027n-cpu\u0027"},{"line_number":24,"context_line":"    log_hook \u0027check processes after compute stop\u0027"},{"line_number":25,"context_line":"    $ANSIBLE all --sudo -f 5 -i \"$WORKSPACE/inventory\" -m shell -a \"ps aux | grep compute\""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3ac371cc_8651f138","line":22,"in_reply_to":"3ac371cc_f33b88e9","updated":"2016-08-17 11:40:59.000000000","message":"@Andrey: No, I don\u0027t think so. This output is for humans reading the log, they understand what\u0027s happening here.","commit_id":"b99a1b7ba5fb19ae96ed5b7a94b1d01af90d947e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"2c344843ed3ac1ede8f5c798a80ea61e6e196670","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    else"},{"line_number":32,"context_line":"        return 1  # You\u0027re in the l-m job context (master -\u003e master)"},{"line_number":33,"context_line":"    fi"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"function stop_all_nova_compute {"},{"line_number":37,"context_line":"    log_hook \u0027stopping all n-cpu processes...\u0027"}],"source_content_type":"text/x-sh","patch_set":43,"id":"fa31d9ce_ddd5bdb9","line":34,"updated":"2017-02-17 09:24:37.000000000","message":"Because I don\u0027t have to differentiate anymore between the grenade job context and the master job context, I\u0027ll remove the function \u0027is_grenade_job_context\u0027 in ps44.\nI\u0027ll push an extra patch which introduces this function in general, as we probably will have that case in the future again.","commit_id":"b237e5ebfabdfc593c1e83c801bb78c7196f25fd"}]}
