)]}'
{"nova/tests/unit/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"407a7d546784d94f950e992cae53510bd9abd8d6","unresolved":false,"context_lines":[{"line_number":3573,"context_line":"        self.conn \u003d xenapi_conn.XenAPIDriver(fake.FakeVirtAPI(), False)"},{"line_number":3574,"context_line":""},{"line_number":3575,"context_line":"        def fake_aggregate_get_by_host(context, host, key\u003dNone):"},{"line_number":3576,"context_line":"            self.assertEqual(CONF.host, host)"},{"line_number":3577,"context_line":"            return [dict(test_aggregate.fake_aggregate,"},{"line_number":3578,"context_line":"                         metadetails\u003d{\"host\": \"test_host_uuid\"})]"},{"line_number":3579,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_34e6cbb4","side":"PARENT","line":3576,"range":{"start_line":3576,"start_character":12,"end_line":3576,"end_character":45},"updated":"2016-08-09 07:51:54.000000000","message":"This check is removed.\nWhy is it removed?","commit_id":"794c0f8ced710f4633f92e036e558bfc90dbf772"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"774bec74053d597d3b7fd4b377d6af16577e07b4","unresolved":false,"context_lines":[{"line_number":3573,"context_line":"        self.conn \u003d xenapi_conn.XenAPIDriver(fake.FakeVirtAPI(), False)"},{"line_number":3574,"context_line":""},{"line_number":3575,"context_line":"        def fake_aggregate_get_by_host(context, host, key\u003dNone):"},{"line_number":3576,"context_line":"            self.assertEqual(CONF.host, host)"},{"line_number":3577,"context_line":"            return [dict(test_aggregate.fake_aggregate,"},{"line_number":3578,"context_line":"                         metadetails\u003d{\"host\": \"test_host_uuid\"})]"},{"line_number":3579,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_f71acd6d","side":"PARENT","line":3576,"range":{"start_line":3576,"start_character":12,"end_line":3576,"end_character":45},"in_reply_to":"9ad45d7e_34e6cbb4","updated":"2016-09-22 13:11:25.000000000","message":"I\u0027ll add the following in the next revision:\n\n        mock_get_by_host.assert_called_once_with(\n            self.context, CONF.host, key\u003d\u0027hypervisor_pool\u0027)","commit_id":"794c0f8ced710f4633f92e036e558bfc90dbf772"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"407a7d546784d94f950e992cae53510bd9abd8d6","unresolved":false,"context_lines":[{"line_number":3587,"context_line":"        self.conn \u003d xenapi_conn.XenAPIDriver(fake.FakeVirtAPI(), False)"},{"line_number":3588,"context_line":""},{"line_number":3589,"context_line":"        def fake_aggregate_get_by_host(context, host, key\u003dNone):"},{"line_number":3590,"context_line":"            self.assertEqual(CONF.host, host)"},{"line_number":3591,"context_line":"            return [dict(test_aggregate.fake_aggregate,"},{"line_number":3592,"context_line":"                         metadetails\u003d{\"dest_other\": \"test_host_uuid\"})]"},{"line_number":3593,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_74ee838c","side":"PARENT","line":3590,"range":{"start_line":3590,"start_character":12,"end_line":3590,"end_character":45},"updated":"2016-08-09 07:51:54.000000000","message":"ditto","commit_id":"794c0f8ced710f4633f92e036e558bfc90dbf772"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"774bec74053d597d3b7fd4b377d6af16577e07b4","unresolved":false,"context_lines":[{"line_number":3587,"context_line":"        self.conn \u003d xenapi_conn.XenAPIDriver(fake.FakeVirtAPI(), False)"},{"line_number":3588,"context_line":""},{"line_number":3589,"context_line":"        def fake_aggregate_get_by_host(context, host, key\u003dNone):"},{"line_number":3590,"context_line":"            self.assertEqual(CONF.host, host)"},{"line_number":3591,"context_line":"            return [dict(test_aggregate.fake_aggregate,"},{"line_number":3592,"context_line":"                         metadetails\u003d{\"dest_other\": \"test_host_uuid\"})]"},{"line_number":3593,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_973a69cc","side":"PARENT","line":3590,"range":{"start_line":3590,"start_character":12,"end_line":3590,"end_character":45},"in_reply_to":"9ad45d7e_74ee838c","updated":"2016-09-22 13:11:25.000000000","message":"Done","commit_id":"794c0f8ced710f4633f92e036e558bfc90dbf772"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"407a7d546784d94f950e992cae53510bd9abd8d6","unresolved":false,"context_lines":[{"line_number":3580,"context_line":""},{"line_number":3581,"context_line":"        instance \u003d objects.Instance(host\u003d\u0027host\u0027)"},{"line_number":3582,"context_line":"        self.conn.check_can_live_migrate_destination("},{"line_number":3583,"context_line":"            self.context, instance, None, None)"},{"line_number":3584,"context_line":""},{"line_number":3585,"context_line":"    @mock.patch.object(objects.AggregateList, \u0027get_by_host\u0027)"},{"line_number":3586,"context_line":"    def test_check_can_live_migrate_fails(self, mock_get_by_host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_7495e3e2","line":3583,"range":{"start_line":3583,"start_character":36,"end_line":3583,"end_character":46},"updated":"2016-08-09 07:51:54.000000000","message":"These arguments are changed.\nIt is not necessary to change them.","commit_id":"26203efbcc112cc3463a03ebabea184cf6bfce1d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f98e2b718285d486024b652bbb5cbd0678cc2b72","unresolved":false,"context_lines":[{"line_number":3580,"context_line":""},{"line_number":3581,"context_line":"        instance \u003d objects.Instance(host\u003d\u0027host\u0027)"},{"line_number":3582,"context_line":"        self.conn.check_can_live_migrate_destination("},{"line_number":3583,"context_line":"            self.context, instance, None, None)"},{"line_number":3584,"context_line":""},{"line_number":3585,"context_line":"    @mock.patch.object(objects.AggregateList, \u0027get_by_host\u0027)"},{"line_number":3586,"context_line":"    def test_check_can_live_migrate_fails(self, mock_get_by_host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_e908cadb","line":3583,"range":{"start_line":3583,"start_character":36,"end_line":3583,"end_character":46},"in_reply_to":"3ac371cc_f6a0dea7","updated":"2016-08-16 04:57:58.000000000","message":"I understand it. Fair enough.","commit_id":"26203efbcc112cc3463a03ebabea184cf6bfce1d"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"e7b73a777616c2de9f8e56df3cb370fda63b56ee","unresolved":false,"context_lines":[{"line_number":3580,"context_line":""},{"line_number":3581,"context_line":"        instance \u003d objects.Instance(host\u003d\u0027host\u0027)"},{"line_number":3582,"context_line":"        self.conn.check_can_live_migrate_destination("},{"line_number":3583,"context_line":"            self.context, instance, None, None)"},{"line_number":3584,"context_line":""},{"line_number":3585,"context_line":"    @mock.patch.object(objects.AggregateList, \u0027get_by_host\u0027)"},{"line_number":3586,"context_line":"    def test_check_can_live_migrate_fails(self, mock_get_by_host):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_f6a0dea7","line":3583,"range":{"start_line":3583,"start_character":36,"end_line":3583,"end_character":46},"in_reply_to":"9ad45d7e_7495e3e2","updated":"2016-08-15 04:09:44.000000000","message":"I changed these arguments because they weren\u0027t correct.\n\nIt looks like the method signature for check_can_live_migrate_destination was changed after this test was written, but that this test wasn\u0027t updated to reflect that change.\n\n- https://review.openstack.org/#/c/14791/3/nova/virt/xenapi/driver.py\n\nBefore:\n\n    def check_can_live_migrate_destination(self, context, instance,\n                block_migration\u003dFalse, disk_over_commit\u003dFalse):\n\nAfter:\n\n    def check_can_live_migrate_destination(self, context, instance,\n                src_compute_info, dst_compute_info,\n                block_migration\u003dFalse, disk_over_commit\u003dFalse):\n\nNote that the test below this one did have valid arguments (None, None). I made this test match it.","commit_id":"26203efbcc112cc3463a03ebabea184cf6bfce1d"}]}