)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"449769be14d36b9c3dc4365bc2edab0dd9c0837b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"exception: throw a NotFound exception when we don\u0027t find the flavor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"here there were two exception we should handle separately:"},{"line_number":10,"context_line":"1. flavor Ref invalid"},{"line_number":11,"context_line":"2. flavor not found"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"but the code only raise the type 1 exception for all, this patch"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_d04f69bb","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":21},"updated":"2016-07-28 17:15:02.000000000","message":"Are you reproducing this case on the latest code?\n\nThe JSON-Schema validates the existence of FlavorRef on https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L52 and I cannot understand why we need this actually.\n\nIn addition, the corresponding test doesn\u0027t exist in this patch.","commit_id":"0af4a47e7905eaaef214beba61eeeec9cf83e549"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d09a932ffccfcb8fa25f91ef44462d29a44a2380","unresolved":false,"context_lines":[{"line_number":7,"context_line":"exception: throw a NotFound exception when we don\u0027t find the flavor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"here there were two exception we should handle separately:"},{"line_number":10,"context_line":"1. flavor Ref invalid"},{"line_number":11,"context_line":"2. flavor not found"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"but the code only raise the type 1 exception for all, this patch"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_a7f884c4","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":21},"in_reply_to":"bacf61ea_ce633a19","updated":"2016-07-29 16:49:20.000000000","message":"Yeah, nice way.\nThanks for considering.","commit_id":"0af4a47e7905eaaef214beba61eeeec9cf83e549"},{"author":{"_account_id":21918,"name":"Chen Fan","email":"fan.chen@easystack.cn","username":"chenfan"},"change_message_id":"0b09041a3893ab9dd784917ae80f7cf88ae8be4d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"exception: throw a NotFound exception when we don\u0027t find the flavor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"here there were two exception we should handle separately:"},{"line_number":10,"context_line":"1. flavor Ref invalid"},{"line_number":11,"context_line":"2. flavor not found"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"but the code only raise the type 1 exception for all, this patch"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_ce633a19","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":21},"in_reply_to":"bacf61ea_d04f69bb","updated":"2016-07-29 02:04:37.000000000","message":"oh, if the flavorRef is required, I think the try catch logic can be removed because the data[flavorRef] impossible to wrong. in additional, the msg \"Invalid flavorRef provided.\" in exception.FlavorNotFound should be removed to return the default msg with \" msg_fmt \u003d _(\"Flavor %(flavor_id)s could not be found.\")\" , it can be more readability for user. thanks","commit_id":"0af4a47e7905eaaef214beba61eeeec9cf83e549"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"48793b425bd73a125ab4392403df3b6052e21927","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chen Fan \u003cfan.chen@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-29 10:12:24 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"exception: throw a NotFound exception when we don\u0027t find the flavor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the flavorRef is required in schema check, here we don\u0027t need"},{"line_number":10,"context_line":"the try catch logic to get the flavorRef any more. remove it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_6785ec05","line":7,"updated":"2016-07-29 16:52:34.000000000","message":"The following message is good for me, but the title seems different from current implementation.\n\nHow about \"Use the message of FlavorNotFound for the clear meaning\" or something?","commit_id":"6f3adcfc52fe387e2e6f6e32861e4a6fc1c18c7f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"305c67fef874acaf49eaf034a772663c847a400c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chen Fan \u003cfan.chen@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-30 09:45:30 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Flavor: Use the message of FlavorNotFound for the clear meaning"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the flavorRef is required in schema check, here we don\u0027t need"},{"line_number":10,"context_line":"the try catch logic to get the flavorRef any more. remove it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_f7c123e5","line":7,"updated":"2016-08-02 04:13:35.000000000","message":"How about this instead?\n\n correct confusing error message about flavorRef","commit_id":"df88d5acf94ce53d54abe23ca37ac5dbf332f916"},{"author":{"_account_id":21918,"name":"Chen Fan","email":"fan.chen@easystack.cn","username":"chenfan"},"change_message_id":"c650e9b1069af73c1d246eef4a72a6a18e26f635","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chen Fan \u003cfan.chen@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-30 09:45:30 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Flavor: Use the message of FlavorNotFound for the clear meaning"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since the flavorRef is required in schema check, here we don\u0027t need"},{"line_number":10,"context_line":"the try catch logic to get the flavorRef any more. remove it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_b2a4d94a","line":7,"in_reply_to":"bacf61ea_f7c123e5","updated":"2016-08-02 05:08:40.000000000","message":"Done","commit_id":"df88d5acf94ce53d54abe23ca37ac5dbf332f916"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"305c67fef874acaf49eaf034a772663c847a400c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Since the flavorRef is required in schema check, here we don\u0027t need"},{"line_number":10,"context_line":"the try catch logic to get the flavorRef any more. remove it."},{"line_number":11,"context_line":"in additional, the Invalid Ref msg for user is not readable. use"},{"line_number":12,"context_line":"flavor not found instead."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I76be8942d59b408c7512658968cdb12733772ead"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_57b58f7b","line":12,"updated":"2016-08-02 04:13:35.000000000","message":"How about this instead?\n\n There was a try/except block that was not used anymore since the\n schema check catches invalid input. Raise a FlavorNotFound exception\n when an invalid flavor is provided.","commit_id":"df88d5acf94ce53d54abe23ca37ac5dbf332f916"},{"author":{"_account_id":21918,"name":"Chen Fan","email":"fan.chen@easystack.cn","username":"chenfan"},"change_message_id":"c650e9b1069af73c1d246eef4a72a6a18e26f635","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Since the flavorRef is required in schema check, here we don\u0027t need"},{"line_number":10,"context_line":"the try catch logic to get the flavorRef any more. remove it."},{"line_number":11,"context_line":"in additional, the Invalid Ref msg for user is not readable. use"},{"line_number":12,"context_line":"flavor not found instead."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I76be8942d59b408c7512658968cdb12733772ead"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_12668529","line":12,"in_reply_to":"bacf61ea_57b58f7b","updated":"2016-08-02 05:08:40.000000000","message":"Done","commit_id":"df88d5acf94ce53d54abe23ca37ac5dbf332f916"}]}