)]}'
{"nova/api/openstack/compute/hypervisors.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"94a0cfb3c1ba1d5e048d1a923d3e5d3dbb8d953e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"            if (api_version_request.is_supported(req, min_version\u003d\u00272.28\u0027) and"},{"line_number":72,"context_line":"                hypervisor.cpu_info):"},{"line_number":73,"context_line":"                hyp_dict[\u0027cpu_info\u0027] \u003d jsonutils.loads(hypervisor.cpu_info)"},{"line_number":74,"context_line":"            else:"},{"line_number":75,"context_line":"                hyp_dict[\u0027cpu_info\u0027] \u003d hypervisor.cpu_info"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_f6c43793","line":72,"updated":"2016-07-28 13:02:30.000000000","message":"Should this be \u0027is not None\u0027, so that {} is still handled here?","commit_id":"1ccde1d0ad955ba349f74abfb89d5c9004477f5c"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"dab678060ba0c4ab86b413211cc2969abd4037dd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                hypervisor.cpu_info):"},{"line_number":73,"context_line":"                hyp_dict[\u0027cpu_info\u0027] \u003d jsonutils.loads(hypervisor.cpu_info)"},{"line_number":74,"context_line":"            else:"},{"line_number":75,"context_line":"                hyp_dict[\u0027cpu_info\u0027] \u003d hypervisor.cpu_info"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if servers:"},{"line_number":78,"context_line":"            hyp_dict[\u0027servers\u0027] \u003d [dict(name\u003dserv[\u0027name\u0027], uuid\u003dserv[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_f003a9b6","line":75,"range":{"start_line":75,"start_character":39,"end_line":75,"end_character":58},"updated":"2016-07-28 09:47:22.000000000","message":"Shouldn\u0027t just be None now? As the if if true only when it is not None","commit_id":"1ccde1d0ad955ba349f74abfb89d5c9004477f5c"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"dea4e2de4d4f049b0d1fbb5dac6e1b04c32e55c6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                hypervisor.cpu_info):"},{"line_number":73,"context_line":"                hyp_dict[\u0027cpu_info\u0027] \u003d jsonutils.loads(hypervisor.cpu_info)"},{"line_number":74,"context_line":"            else:"},{"line_number":75,"context_line":"                hyp_dict[\u0027cpu_info\u0027] \u003d hypervisor.cpu_info"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if servers:"},{"line_number":78,"context_line":"            hyp_dict[\u0027servers\u0027] \u003d [dict(name\u003dserv[\u0027name\u0027], uuid\u003dserv[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_0a972991","line":75,"range":{"start_line":75,"start_character":39,"end_line":75,"end_character":58},"in_reply_to":"bacf61ea_5f9441e1","updated":"2016-07-28 11:02:54.000000000","message":"You\u0027re right.","commit_id":"1ccde1d0ad955ba349f74abfb89d5c9004477f5c"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"184d8731108a6fc290276dd7da2dbd0a541d71cb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                hypervisor.cpu_info):"},{"line_number":73,"context_line":"                hyp_dict[\u0027cpu_info\u0027] \u003d jsonutils.loads(hypervisor.cpu_info)"},{"line_number":74,"context_line":"            else:"},{"line_number":75,"context_line":"                hyp_dict[\u0027cpu_info\u0027] \u003d hypervisor.cpu_info"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if servers:"},{"line_number":78,"context_line":"            hyp_dict[\u0027servers\u0027] \u003d [dict(name\u003dserv[\u0027name\u0027], uuid\u003dserv[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5f9441e1","line":75,"range":{"start_line":75,"start_character":39,"end_line":75,"end_character":58},"in_reply_to":"bacf61ea_f003a9b6","updated":"2016-07-28 10:57:40.000000000","message":"no, because if the api version is , 2.28 then we need to keep the old logic of just setting the cpu_info","commit_id":"1ccde1d0ad955ba349f74abfb89d5c9004477f5c"}]}