)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4d4d4cc616169b8fdcf41b78255863c21fa1d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t set empty kernel_id and ramdisk_id to glance image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some cases, if \u0027allow_additional_properties\u0027 option is"},{"line_number":10,"context_line":"disabled in Glance, \u0027kernel_id\u0027 and \u0027ramdisk_id\u0027 are considered"},{"line_number":11,"context_line":"the usual properties and cannot have None values. So it\u0027s better"},{"line_number":12,"context_line":"always omit these props and never send them to Glance if they are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_fe86fe11","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":46},"updated":"2016-07-27 17:51:09.000000000","message":"nit: allow_additional_image_properties","commit_id":"2f2b0e954d7738c2bf49a48a708cc0ce2b19e726"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4d4d4cc616169b8fdcf41b78255863c21fa1d2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t set empty kernel_id and ramdisk_id to glance image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In some cases, if \u0027allow_additional_properties\u0027 option is"},{"line_number":10,"context_line":"disabled in Glance, \u0027kernel_id\u0027 and \u0027ramdisk_id\u0027 are considered"},{"line_number":11,"context_line":"the usual properties and cannot have None values. So it\u0027s better"},{"line_number":12,"context_line":"always omit these props and never send them to Glance if they are"},{"line_number":13,"context_line":"empty."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_be93e64e","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":8},"updated":"2016-07-27 17:51:09.000000000","message":"As noted inline, we have allow_additional_image_properties\u003dTrue but don\u0027t have /etc/glance/schema-image.json and that\u0027s where we broke down, but either will cause this bug.","commit_id":"2f2b0e954d7738c2bf49a48a708cc0ce2b19e726"}],"nova/image/glance.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ae4d4d4cc616169b8fdcf41b78255863c21fa1d2","unresolved":false,"context_lines":[{"line_number":853,"context_line":"                # in glance only string and None property values are allowed,"},{"line_number":854,"context_line":"                # v1 client accepts any values and converts them to string,"},{"line_number":855,"context_line":"                # v2 doesn\u0027t - so we have to take care of it."},{"line_number":856,"context_line":"                elif prop_value is None or isinstance("},{"line_number":857,"context_line":"                        prop_value, six.string_types):"},{"line_number":858,"context_line":"                    output[prop_name] \u003d prop_value"},{"line_number":859,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_de5dfaed","line":856,"range":{"start_line":856,"start_character":21,"end_line":856,"end_character":39},"updated":"2016-07-27 17:51:09.000000000","message":"I also worry about this case but don\u0027t have a recreate for it right now.\n\nIn our case where this was a failure, we have allow_additional_image_properties\u003dTrue in glance-api.conf since it\u0027s the default. What we didn\u0027t have deployed was /etc/glance/schema-image.json. So you could specify kernel_id but it couldn\u0027t be None, but with a full disk image, it would be None and we\u0027d blow up on the schema check.","commit_id":"2f2b0e954d7738c2bf49a48a708cc0ce2b19e726"}]}